- 22 Oct, 2020 13 commits
-
-
Hayato Ito authored
This reverts commit 974e1b68. Reason for revert: culprit CL for a build error on mac-archive-rel https://ci.chromium.org/p/chromium/builders/ci/mac-archive-rel/16425? In file included from gen/third_party/blink/renderer/bindings/modules/v8/v8_internals.cc:12: In file included from gen/third_party/blink/renderer/bindings/core/v8/v8_animation.h:11: In file included from ../../third_party/blink/renderer/core/animation/animation.h:42: In file included from ../../third_party/blink/renderer/core/animation/animation_effect.h:35: ../../third_party/blink/renderer/core/animation/animation_time_delta.h:8:10: fatal error: 'third_party/blink/renderer/core/animation/buildflags.h' file not found #include "third_party/blink/renderer/core/animation/buildflags.h" Original change's description: > Remove enable-send-tab-to-self-omnibox-sending-animation flag. > > This bug fix has been launched since M84. > > Bug: 1124205 > Change-Id: I99dd4b7edbab9443c10169144f5ecf3b115c74f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391508 > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Commit-Queue: Sophey Dong <sophey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819562} TBR=jeffreycohen@chromium.org,sophey@chromium.org Change-Id: I20af4e4dc812a4b934d435fabc4d7e1930d37a33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490965Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819642}
-
Hung Vu authored
This CL will add 2 event metrics: - LOCATION_SUGGESTION_SHOWN: counts how many times this dialog type is triggered. - NOT_ENOUGH_SPACE: counts how many times the red error text is shown. Bug: 1136234 Change-Id: Ief19e9528802340fc908085f30a27737382c977c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487829Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Hung Vu <vuhung@google.com> Cr-Commit-Position: refs/heads/master@{#819641}
-
Aaron Leventhal authored
Use DumpWithoutCrashing() to get reports for problematic content. Also, add information to the crash reports about objects that are involved, and include information about commonly problematic properties. Note: DumpWithoutCrashing() once added to AXTreeSerializer once before but was reverted due to too many reports. AX-RelNotes: n/a Bug: None Change-Id: Iac5f0ba377e03881efdb6734a954fbb9f1f3125c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480624 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic4e18011de03fff582c96c97a418a9550d203240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819639}
-
Nico Weber authored
Still on the 10.15 SDK, so still no real change here. I again locally removed libcodedirectory.dylib from the .yaml file when running the script. Tweak the instructions in the yaml file a bit. I used to copy over the whole Xcode app, which used to take a few minutes. The new process only takes seconds. Also add a word of caution that following these instructions doesn't update the locally used Xcode in itself. Bug: 1108831 Change-Id: I3b3f3d698378c347161118ba59ce49a6e23ab891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490920 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819638}
-
Thomas Lukaszewicz authored
overflow-scrollbar-combinations.html is flaking consistently on Linux Tests builders. See below for example build. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/94750 Bug: 1141206 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I5ccb03ce75a47f3a8523a1b033b67144392d1fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490850Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819637}
-
Nate Chapin authored
Change-Id: I7d0598be2359323a33915fff8c4345eeac8a2a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490546 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819636}
-
Victor Fei authored
Consider the following ax tree and ax positions representing an editable text input: ++1 kRootWebArea ++++2 kTextField editable ++++++3 kGenericContainer editable ++++++++4 kStaticText editable "Hello" ++++++++++5 kInlineTextBox "Hello" TextPosition1 anchor_id=5 anchor_role=inlineTextBox text_offset=4 annotated_text=hell<o> TextPosition2 anchor_id=2 anchor_role=textField text_offset=4 annotated_text=hell<o> The above text positions point to the same position in the text field but with different anchors. Calling AXPosition::CompareTo on these positions should return that they are equal. However, CompareTo returns the result that TextPosition1 is logically less than TextPosition2; which is incorrect. This is due to the following: On TextPosition1 anchor_id=5 anchor_role=inlineTextBox, we have the following call sequence: 1. AXPosition::CompareTo 2. AXPosition::SlowCompareTo 3. AXPositionInstance::CreateAncestorPosition 4. AXPosition::CreateParentPosition 5. IsEmbeddedObjectInParent In step 4 CreateParentPosition we call IsEmbeddedObjectInParent, but incorrectly evaluates text field's immediate child (generic container, id=3) as embedded object and returns true. This results in a position with wrong offset created in step 4 CreateParentPosition, and eventually resulting in wrong comparison in step 1 CompareTo. This CL fixes the above issue, by correctly handling text field case in IsEmbeddedObjectInParent. AX-Relnotes: Narrator cursor on Google's search input now properly follows text cursor as backspacing and left/right arrow key is pressed and correctly announcing the correct character. Bug: 1141171 Change-Id: Iba85b745d60b5c039f8b65a606bab7224bab4f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473065 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819635}
-
Allen Bauer authored
Bug: 772945 Change-Id: Id38927134e6b1ddef00ac6db1bac189ab625a483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490553 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819634}
-
Ng Zhi An authored
When converting floating-point to any integer type, the fractional part is discarded, so any value in the range (-1.0,-0.00) (exclusive) will truncate to -0.0, and so will fit in an unsigned destination type. See https://en.cppreference.com/w/cpp/language/implicit_conversion#Floating.E2.80.93integral_conversions. Change-Id: Id8a5263d486cc3cd25670da27c417c66e28fccdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488717Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819633}
-
Kartik Hegde authored
Add the DnsLatency routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied DnsLatency changes and successfully ran the DnsLatency routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=dns_latency). Change-Id: I2e00fae7f641344a20372923c4d6be8e51cc5a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345004 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#819632}
-
Kevin Marshall authored
Adds missing message ack invocations which blocked flow of FIDL messages. The issue didn't exist prior to CL 2458877, because the FIDL/Blink bridge that was in place discarded flow control signals. As a result of that CL, CastMessagePortImpl now communicates point-to-point over FIDL with no bridges in between, and therefore the lack of acknowledgements lead to stalls in message delivery. Test: Manually tested Cast Streaming. Bug: 1140743 Change-Id: I05be612c110340094725f4aeb13cfc2e8e1adeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490552 Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#819631}
-
John Lee authored
This CL increases specificity of dark mode CSS for a folder that has a drag over it to force the CSS to override other colors. Fixed: 1139798 Change-Id: I6bda5834d06e9d3a4ebd27aea468df3c44a42512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490680Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819630}
-
- 21 Oct, 2020 27 commits
-
-
Yuheng Huang authored
Currently type checking of some of the functions using tabSearch.mojom.Tab is suppressed because we are trying to dynamically add some fields to it. This CL addresses the issue by wrapping tabSearch.mojom.Tab with TabData so tabSearch.mojom.Tab can stay unmodified. Bug: 1133558,1099917 Change-Id: Ibb792f2c84350f2ab234874b251f36360076bc50 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3314641Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
-
Roman Arora authored
Bug: 1128599 Change-Id: I2d11e4b33ca9500ffeba2a8721c788b25e50f1ec Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3308643Reviewed-by:
-
Roman Arora authored
Screenshots Hover: https://drive.google.com/file/d/1xxvmhVfUMVn6gKTC5N2nNL9HrvyaPzKK/view Focus: https://drive.google.com/file/d/1AQoUfTUeKRyPhmlmb5CdnQLrvBFyQuZc/view Bug: 1128599 Change-Id: Ia856b9e25b006fd5710ce2af8ca08ae7e2596740 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3303965Reviewed-by:
-
Tom Lukaszewicz authored
Fixes break in existing tests. Bug: 1099917 Change-Id: I4b110eb133128b68994f35b4d16a9e38e49da7d3 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3304907Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819626}
-
Yuheng Huang authored
A simple scoring function gives us better search results based on match index and match count. It also enables us to control title vs hostname matching weight similar to fuzzy search. Bug: 1099917 Change-Id: Ifdc9a71f856854b77851a7b133cfb34439441d16 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3301747Reviewed-by:
-
Roman Arora authored
Depends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2441333 Bug: 1133575 Change-Id: Id13dfa24226ec87a0940328df4777ed18928877b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3303663Reviewed-by:
-
Tom Lukaszewicz authored
Matching src-public CL: https://chromium-review.googlesource.com/c/chromium/src/+/2432589 Bug: 1099917 Change-Id: I19496be097ef9714e0e46872ff6966e54e442086 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291206Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I8430ce511cc625ec06bf87402e643a4a540386af Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284870Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates search such that if an exact match search is expected an exact match algorithm is used. We will rank items for exact match as follows: 1. Rank all items that match at the beginning of the title or hostname first. 2. Rank all items that match at the beginning of a word next. 3. All remaining items with an exact match are ranked at the end. Change-Id: Icd6cd647ce3b0d39eb535998dab5e49973c24b0b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3299647Reviewed-by: -
Yuheng Huang authored
This change makes URL title fully visible when mouse over it Bug: 1099917 Change-Id: I306711584fc1ed139a9b925378f27e477ce6430c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3300861Reviewed-by:
-
Roman Arora authored
This is a reland of 218a19d8afddea116cf66cd2764fa5fb1988716a Updated TabSearchAppFocusTest that expects submit feedback footer. Please review agains the Patchset 1 for new changes. Original change's description: > TabSearch: Enable/Disable feedback button based on a config > > Bug: 1099917 > Change-Id: Ia79387286a56d411dead0018c6a22a36fbc4daac > Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288761 > Reviewed-by: Tom Lukaszewicz <tluk@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> Bug: 1099917 Change-Id: Ibe13fd00d7e00c669b7e675cda1daa6d2470605c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291234Reviewed-by:
-
Yuheng Huang authored
chunkingItemCount_ = 0 should be called when chunking is started, instead of waiting for the second getProfileTabs calls() because getProfileTabs() can be called only once. Bug: 1099917 Change-Id: Id3d0ee0c29220ccee66b8c3ffaff40db42d03f80 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3295842Reviewed-by:
-
Roman Arora authored
This reverts commit 218a19d8afddea116cf66cd2764fa5fb1988716a. Reason for revert: Has test failures Change-Id: I8c2faf5cc691c9bd041f02aeac5cbeb71f4e2e66 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291232Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#819617}
-
Roman Arora authored
Bug: 1099917 Change-Id: Ia79387286a56d411dead0018c6a22a36fbc4daac Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288761Reviewed-by:
-
Tom Lukaszewicz authored
Dom-repeat chunking used for the first render of the Tab Search UI to eliminate the need to render the full list before showing the UI to the user. This bounds the time to interactive for users with an arbitrary number of open tabs. This CL disables chunking after first load due to flickering when the tab list updates later on. Bug: 1099917 Change-Id: I2924756230ef50aea8d0623c0f2a2637623b9b22 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288859Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates fuzzy search to take option values from tab search feature parameters passed in via the WebUIDataSource. Related CL: https://crrev.com/c/2425724 Bug: 1099917 Change-Id: I04a5b52a88dc2397870f3ce615e1cd874785ac18 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3285252Reviewed-by:
-
Tom Lukaszewicz authored
This CL adds a wrapping container around the tab search list items. The height of the container is updated as the number of items to be rendered is updated. This allows the tabContents container to assert the final list height even as the items are rendered piecemeal in dom-repeat's chunking mode. This is dependent on the following: https://crrev.com/c/2417548 Bug: 1099917 Change-Id: Ib6e28cbac01f23e7f8dda918f19ff168be5989b6 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3281029Reviewed-by:
-
Roman Arora authored
Depends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2414513 Bug: 1128653 Change-Id: I7c5c978a08279dba77db0d28914af345d06d9d99 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3281181Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2424510 Bug: 1099917 Change-Id: I9a3272fb1040a002498be4dd876a579804234695 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284531Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I657e15ea2a76f8286c94a7c1471579267e5bb2a2 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284828Reviewed-by:
-
Roman Arora authored
UX audit related changes: - Search field, list item, and feedback footer height changes - Search field background color and styling changes - Component alignment related changes Dependends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2417548 Screenshot: https://drive.google.com/file/d/1ahWvFnnpFgJOJXgWqDihMZFcoE0KLzf3/view?usp=sharing Bug: 1128599 Change-Id: I231688d955cbda00c4109dd48ddb5eed77f94165 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3276513Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Ia2fcf03cae03c05ed9229812f1740488a2441ec9 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3269809Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I450254884611778547c85a6e8cf6fafa7a2b6030 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284425Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I9038a2ac5911ad01cfa3b0683c4e062146b05dd3 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272139Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I14d98855e3389320ce10a94f161cb94d283c318f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3280945Reviewed-by:
-
Yuheng Huang authored
Fuzzy search should not take match location into account Bug: 1099917 Change-Id: Ie7ca087b1b0d0375cfdeb008257a7184ac64b904 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3278048Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819604}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I26318b0c4fc054f9627a5208f4dfcbb5e5608486 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3273923Reviewed-by:
-
