- 21 Jan, 2021 40 commits
-
-
dpapad authored
- In the frontend, hardcode the pdf-viewer-update-enabled attribute. Previously present/absent based on the state of the flag. - In the backend, remove checks for base::FeatureList::IsEnabled(features::kPDFViewerUpdate) As a result of these changes --disable-features=PDFViewerUpdate no longer works, in the sense that even if specified it will show the new UI. Newly dead code (old UI) will be removed in follow up CLs. Bug: 1164004 Change-Id: I0321f2f22e1358c69f6dc5d5c2662739e0b7ead7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638992 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#845578}
-
Mike West authored
This patch wires the kV8SharedArrayBufferConstructedWithoutIsolation feature up to Blink's deprecation infrastructure, resulting in a console warning on the one hand, and a deprecation report on the other. Bug: 1168554 Change-Id: I129ef0fc85d6e57ecb5db7a8671d771556e9f375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640254 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845577}
-
Christian Dullweber authored
The histogram file has changed and the actions file does not require that exact base::Feature name. Change-Id: I2151c8e388621f5322ec831e8a0b4d89f1695b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632648Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#845576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/49b20f919abe..026ad9ac2205 2021-01-21 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-21T04:03:14). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I40a22efde79d5ad919a08ca97515c1737d33b72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845575}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611197911-ad3187e6248266adece06729ea19dc5d8f4016ce.profdata to chrome-win32-master-1611208290-cf05eaf8e0dadf6ae1b4b2e6d84e2b6985a10d51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I60732a34f81b24801f25e14ecc4241fc010e5729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641417Reviewed-by:
-
Anders Hartvoll Ruud authored
There is a plan to propagate a bit with the needed information on the Node tree, but for now let's traverse the ancestor chain to figure out if we're in a @container-dependent subtree or not. Bug: 1145970 Change-Id: I27dfb0ff2fdb3947da3b5d2f78adab729ec63dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636316 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#845573}
-
Tina Wang authored
When the enterprise only allows the users to use incognito mode, Chrome should be started up in incognito mode. Bug: 1165405 Change-Id: Ic08059527becb7ce9210f693dea2679870678247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641181 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845572}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c142940b9dd..87a055b02027 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 382f016dd3b6 to f0286e636456 (15 revisions) 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 78d95924 to dac687f4 (517 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: D3DTextureTest.TextureArrayImage* Change-Id: I4099739177d861a76b22f1e17a1869a420e7e954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641657Reviewed-by:
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: Ia0449cb26c992a3c410f0de71812185974c8ecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640234Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#845570}
-
dpapad authored
- Delete PDFExtensionTestWithParam class. - Update all subclasses to subclass PDFExtensionTest instead. - Update various tests that implement testing::WithParamInterface and no longer need to do so. After this CL, there are no tests running with PDFViewerUpdate turned off. Bug: 1164004 Change-Id: I600af550aaca8de126cf32edcfa34c05658fc816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639802 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
dpapad authored
- Replace several test cases to use PDFExtensionTest instead of PDFExtensionTestWithParam. - Always enable PDFViewerUpdate UI in PDFExtensionTest. - Disable PDFExtensionJSUpdatesDisabledTest test, which refers only to old UI (and added a TODO to decide on deleting or moving). In this CL only updating test cases that used PDFExtensionTestWithParam directly. Test cases that subclass PDFExtensionTestWithParam will be addressed in a separate CL. This is the first of many CLs aiming to remove the old pre-PDFViewerUpdate UI. Bug: 1164004 Change-Id: Ic7cd069a343885ed314ddd05e5cb8fa653df7d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638244Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845568}
-
Jinsuk Kim authored
Removes deps on TrackerFactory in ToolbarTabControllerImpl and move it to the modularized toolbar/. There are a few more classes that can also be moved: ToolbarTabControllerImplTest.java ToolbarTabControllerImpl.java top/IncognitoSwitchCoordinator.java top/IncognitoSwitchProperties.java top/IncognitoSwitchViewBinder.java top/TabSwitcherActionMenuCoordinator.java top/TabSwitcherActionMenuRenderTest.java Bug: 1127732 Change-Id: I0543ab61e80015f5c34ff58640dacff799b109ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639067Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845567}
-
Hanlin Chen authored
When merging metadata of partial results, VCD will discard duplicated tags. This cause the entry_count being larger then actual entry array. Bug: 177992869 Change-Id: Icd176dc41a5a8ad15f3bbe93ad874679e8d4ecc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639342Reviewed-by:
Jasmine Chen <lnishan@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Hanlin Chen <hanlinchen@google.com> Cr-Commit-Position: refs/heads/master@{#845566}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1557fad065c6..5fccb46378a1 2021-01-21 caseq@chromium.org Roll browser_protocol.pdl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9e07038d239a5076b90678910cb32918761f5b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641885Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I4a92f4f60ce7b98ef3bc8f35e115eab428dda298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639351 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845564}
-
sauski authored
The "last_survey_check_time" preference value associated with a survey trigger limits the rate at which contact is attempted to be made with the HaTS service to once per 24hrs. Previously the creation of a HaTS Next dialog, which immediately attempts to contact the HaTS service, did not set this value. This could result in an individual client making unlimited requests to the HaTS service. This CL adjusts logic such that this value is set on creation of a HaTS Next dialog, and is consulted earlier in attempting to show a survey. Specifically as part of the CanShowSurvey check, rather than CheckSurveyStatusAndMaybeShow. Bug: 1110888 Change-Id: I289245893ed0ff7c49afeb5b560b970df02a5416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640433Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#845563}
-
Simon Zünd authored
Design doc: https://bit.ly/devtools-trust-tokens This CL adds a new "getTrustTokens" method in the storage domain that returns the number of available Trust Tokens per issuer. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1126824 Change-Id: Ic4693dfb5f4d88b54fd0f733ce38acd36632541d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593112 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#845562}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/profiles. Bug: 1148570 Change-Id: I657d9decc3489b8883957b55fb05ff62e4143c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639149 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845561}
-
arthursonzogni authored
Move CSPEE code from the AncestorThrottle toward the NavigationRequest. Why? 1) AncestorThrottle is a NavigationThrottle. NavigationThrottle doesn't run for several URLs like about:blank. This fixes two two test case introduced recently for bug 1163174 2) CSPEE can add a 'sandbox' directive. This might modify the origin. The origin needs to be computed before running the NavigationThrottle. So this isn't possible to check CSPEE in the NavigationThrottle. Taking CSPEE into accounts for sandbox will be fixed in a follow-up. Bug: 1163174 Change-Id: I193d7821b7819339912a6ba92bdb28e8fa893256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611269 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#845560}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611187144-39ea136b6ebfd3c490dd8e8da57ed07347596a8e.profdata to chrome-mac-master-1611208290-983521cb9aa454798e29d76ad68922e8cdd2db84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7bbe12b83fdc9ac14d0e8cc1821d4504aa4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641884Reviewed-by:
-
Alice Wang authored
This CL moves SigninUtils to signin.ui target. Bug: 1163470 Change-Id: I24da246f47205e60cdbb2be66bb4527eb7c26ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640397Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/137271ffc54d..bb7660008b16 2021-01-21 timvp@google.com Vulkan: Move Flush during SyncHelper::clientWait() earlier 2021-01-21 syoussefi@chromium.org Translator: Stop allocating TIntermSequence If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1060139 Tbr: cnorthrop@google.com Test: Test: CopyOutputScalingPixelTest.ScaledCopyOfDrawnFrame/48 Change-Id: I214048bd0724c4c4e073eb9e9910bfedf7b2f2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641484Reviewed-by:
-
Hidehiko Abe authored
Supporting multi clients on crosapi, in order decouple the concept of "browser" and the lacros as the browser implementation, remove the proper noun "Lacros" from crosapi interfaces. BUG=1148448 TEST=Ran tryjob. TBR=iby@chromium.org, droger@chromium.org, emaxx@chromium.org, rjkroege@chromium.org Change-Id: Id5ba84994d6a41196abb7b837a118f1ae3492d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639422 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Side Yilmaz authored
This CL passes OTRProfileID to getAllDownloads function to support multiple off-the-record profiles. Bug: 1099577, 1060940 Change-Id: I6746b60b2eeabab1d03957cce285067275ab6908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626435Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845555}
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: I9f547f785679fcc03dde65f60b090b28c250f95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640253Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f1a39a74b67f..1557fad065c6 2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iddf3f387faaf830562880b12270edf79305744e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641656Reviewed-by:
-
Luciano Pacheco authored
Enable all integration tests to run as JS modules. I have hand selected some tests to continue to run as non-js-modules to have some coverage in case we need to flip back to it. Bug: 1133186 Change-Id: Iddb5b65bd82c62a5288e856bdd0ff5587f80ac24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641688Reviewed-by:
-
David Van Cleve authored
The structured_headers::Item constructor has a default argument that determines whether a given Item will serialize as a "byte sequence" or a "string" Structured Headers item. Elsewhere in trust_token_request_signing_helper.cc, we try explicitly to provide kStringType or kByteSequenceType to the constructor to make it clear at the callsite which of the two types each particular item has. This change is a no-op adding kStringType at a callsite to make it apparent to readers that the Item in question is string-type. Bug: None Change-Id: Id7a12f4d57ed6ecdb3ab48b3ca5468cf3b7459dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638563 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#845551}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611187144-091cd0ce23c5cf7321279c1e02f3c90b64671b48.profdata to chrome-win32-master-1611197911-ad3187e6248266adece06729ea19dc5d8f4016ce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I63443f0a7713b129efc28fbc8ded688ad5979718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641482Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0be184647794..49b20f919abe 2021-01-21 deadbeef@webrtc.org Fix race with SctpTransport destruction and usrsctp timer thread. 2021-01-20 peah@webrtc.org Allow separate dump sets for the data dumper in APM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1162424 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5bc6e013069836d57d9401c39ea4313969267d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641483Reviewed-by:
-
Manuel Rego Casasnovas authored
Like the rest of the platforms, this patch avoids setting ImeTextSpan::underline_color to black color. That way when the IME composition underline is painted it'll use the text color and not be always black. This makes the composition underline visible when you have a dark background. Bug: 1168012 Change-Id: Id4ec27ffe8e698ff41de93fc1260363f96e4aa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637495Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#845548}
-
Luciano Pacheco authored
When running as non-js-modules the <bread-crumb> has its images in-lined by grit, however when running as JS modules the <bread-crumb> is in-lined via rollup, then it runs from the path foreground/js/ instead of its actual path foreground/js/ui/ making the relative address to its images incompatible. Fix by duplicating the 2 affected images, moving them up 1 directory so the relative path is consistent. NOTE: These 2 images are the only references to "/images" inside the ui/ directory. [1] [1] - https://source.chromium.org/search?q=%22images%2F%22&sq=&ss=chromium%2Fchromium%2Fsrc:ui%2Ffile_manager%2Ffile_manager%2Fforeground%2Fjs%2Fui%2F Bug: 1133186 Change-Id: I71a10286c325e54c3adecc0f079002aeab7a0344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640006Reviewed-by:
-
Xiaodan Zhu authored
This CL implements the reordering of the desks by keyboard. When a desk thumbnail is highlighted. - Pressing Ctrl + -> will swap current desk with the right one. - Pressing Ctrl + <- will swap current desk with the left one. Bug: 1164025 Change-Id: Ibb14098073191faa4d31e9075cde275006a29edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623719Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845546}
-
Gavin Williams authored
Move the common dropdown code for sorting and choosing the default option to SelectBehavior. Add getSelectedOption(), sortOptions(), and isDefaultOption() to each settings dropdown. These functions are called from SelectBehavior. Bug: 1168346 Change-Id: I186a6e2ef18b335fdba0f81e4002f4859d27d0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638499 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845545}
-
Luciano Pacheco authored
The i18n strings in the deferred elements need the `loadTimeData` which is initialized in the background page and in the initBackgroundPagePromise_. Change the initialization for JS modules to wait the background promise before importing the deferred elements. Bug: 1133186 Change-Id: I2f82cc3ca89964900c5711652379fbcbdff17acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641785 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/821a84558bd4..3c142940b9dd 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 311a17a8feae to 762814bd9229 (7 revisions) 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 89fd1480b47e to b3e5c440d239 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I0b05fe93dd42dc6a98f308619bfa28099785b7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641481Reviewed-by:
-
Shik Chen authored
Bug: b/176879728, b/172344433 Test: Manually verify the animations Change-Id: I6bd326171812531c3d150b1531564fe4cecc38a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639613Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#845542}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96b7ec727bac..d5c88e60cff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: keishi@google.com Change-Id: I9dcdf56fe37aee5ee87dd0f0fc928b78c4c1befb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641648Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845541}
-
Bartek Nowierski authored
The names are highly confusing and misleading. These functions don't return an actual size, but an underlying capacity, which may or may not be readily available to the app. AllocationCapacity* names reflect the behavior better. Change-Id: I4c59dbf75397b31ed58c1467c019ca23057031c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636748 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845540}
-
Nikolai Artemiev authored
Allows the --form-factor flag to be used to override the form factor value from the LSB release info. BUG=b:173179861 TEST=CQ Change-Id: Ic4dd3eb52dd562d35debac3fea168f686d728e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631393 Commit-Queue: Nikolai Artemiev <nartemiev@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Nikolai Artemiev <nartemiev@google.com> Cr-Commit-Position: refs/heads/master@{#845539}
-
