GitLab

R=ojan@chromium.org
BUG=402172

Review URL: https://codereview.chromium.org/654063002

git-svn-id: svn://svn.chromium.org/blink/trunk@184383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following r183834, the FrameOwner is disconnected during frame detach.
The clearing of the FrameLoader that needs to happen for Oilpan can
consequently be moved to a more natural place and be done as part
of the other LocalFrame detach operations (rather than being a
special action of FrameOwner disconnecting.)

R=haraken
BUG=425559

Review URL: https://codereview.chromium.org/678673002

git-svn-id: svn://svn.chromium.org/blink/trunk@184382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use Object.prototype.toString.call() to get a name for the object
being tested, rather than '[object]', to make the error more readable.

BUG=374802
R=asanka@chromium.org

Review URL: https://codereview.chromium.org/667423005

git-svn-id: svn://svn.chromium.org/blink/trunk@184381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Pass multiple locales to font resolution; handles mixed-language documents which need to know device default language to resolve font fallback correctly.

Depends on https://codereview.chromium.org/670243002/.
    
BUG=422180
R=djsollen@chromium.org,bungeman@chromium.org,dominik.rottsches@intel.com,eae@chromium.org

Review URL: https://codereview.chromium.org/665223004

git-svn-id: svn://svn.chromium.org/blink/trunk@184380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Right now when the display list canvas fallback is triggered,
and the fallback canvas is GPU-acclerated, we fail to notify
the GraphicsContext that it has become
accelerated.  This causes HTMLCanvasElement::paint to use
the CPU rendering code path. This change fix the problem by
notifying the GraphicsContext of whether GPU acceleration
is use by the fallback canvas.

BUG=426169

Review URL: https://codereview.chromium.org/669993004

git-svn-id: svn://svn.chromium.org/blink/trunk@184379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Other expectations were updated after the cl, but before xp
had processed them. All are expected after https://codereview.chromium.org/656913006

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/676953004

git-svn-id: svn://svn.chromium.org/blink/trunk@184378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method is for handling redirect response. It's confusing that this
is given a name sounds like intercepting all requests.

R=mkwst
BUG=none

Review URL: https://codereview.chromium.org/673243002

git-svn-id: svn://svn.chromium.org/blink/trunk@184377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This field was previously used for ligature and kerning lookups for SVG
fonts. Since SVGTextMetrics::glyph() is no longer called we can remove the
field and collapse some related code.

BUG=242735

Review URL: https://codereview.chromium.org/665253003

git-svn-id: svn://svn.chromium.org/blink/trunk@184376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=383125

Review URL: https://codereview.chromium.org/680503004

git-svn-id: svn://svn.chromium.org/blink/trunk@184375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This uses the newly added WebScheduler interface for posting idle
tasks and checking whether main thread work should yield to let
more critical tasks run. This interface is implemented by the platform.

Design doc: https://docs.google.com/a/chromium.org/document/d/16f_RIhZa47uEK_OdtTgzWdRU0RFMTQWMpEWyWXIpXUo/edit#heading=h.srz53flt1rrp

BUG=391005

Review URL: https://codereview.chromium.org/656463004

git-svn-id: svn://svn.chromium.org/blink/trunk@184374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding a couple of tests to make sure that the right resource is loaded when srcset is inside an iframe, and that *only* the right resource is loaded.

BUG=425909

Review URL: https://codereview.chromium.org/674163002

git-svn-id: svn://svn.chromium.org/blink/trunk@184373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test case was asserting that 'get' was not a valid method for
Cache.put(). But per the fetch spec, the Request's method is
normalized during construction so 'get' becomes 'GET' and that's
valid. There's a later test case which covers this using 'HEAD', so
just remove it.

BUG=374802
R=asanka@chromium.org

Review URL: https://codereview.chromium.org/678513002

git-svn-id: svn://svn.chromium.org/blink/trunk@184372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per spec, the method signature is:

Promise<Response> put((Request or USVString) request, Response response);

So passing a string for request is perfectly valid. And thanks to the
wonders of Web IDL + JavaScript, anything else passed in other than a
Request will be coerced to a string, too.

R=asanka@chromium.org
BUG=374802

Review URL: https://codereview.chromium.org/677533002

git-svn-id: svn://svn.chromium.org/blink/trunk@184371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The refactoring in https://codereview.chromium.org/453653003 dropped the
double-lookup map insertion, but animated images (at least) can still
trigger paint-time layout invals => the map entry may get deleted while
we're building the pattern.

This CL adds back the required double-lookup idiom.

R=fs@opera.com,pdr@chromium.org,schenney@chromium.org
BUG=426757,426882

Review URL: https://codereview.chromium.org/677683003

git-svn-id: svn://svn.chromium.org/blink/trunk@184370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=403508

Review URL: https://codereview.chromium.org/659573005

git-svn-id: svn://svn.chromium.org/blink/trunk@184369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change was made by https://codereview.chromium.org/379113002
Explain the reason in a comment for readability.

R=sigbjornf
BUG=none

Review URL: https://codereview.chromium.org/675993003

git-svn-id: svn://svn.chromium.org/blink/trunk@184368 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The presence of the ::selection pseudo element should not trigger a
sub-tree style recalc from style invalidation. The same goes for the
:window-inactive pseudo class.

R=chrishtr@chromium.org,esprehn@chromium.org
BUG=425494

Review URL: https://codereview.chromium.org/669873003

git-svn-id: svn://svn.chromium.org/blink/trunk@184367 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=421404

Review URL: https://codereview.chromium.org/662603002

git-svn-id: svn://svn.chromium.org/blink/trunk@184366 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348919

Review URL: https://codereview.chromium.org/603623002

git-svn-id: svn://svn.chromium.org/blink/trunk@184365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (patchset #4 id:70001 of https://codereview.chromium.org/672383003/)

Reason for revert:
This patch seems to have broken the following two browser_tests on all platforms, as can be seen on the non-layout bots on the Blink waterfall. We won't be able to roll Blink in Chromium until this is resolved.

PushMessagingBrowserTest.RegisterFailureNoPermission
PushMessagingBrowserTest.RegisterSuccess

Example output:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/4400/steps/browser_tests/logs/RegisterSuccess

[INFO:CONSOLE(7)] "SecurityError - The scope must be under the directory of the script URL.", source: https://127.0.0.1:39935/files/push_messaging/test.html (7)
../../chrome/browser/services/gcm/push_messaging_browsertest.cc:142: Failure
Value of: register_worker_result
  Actual: "SecurityError - The scope must be under the directory of the script URL."
Expected: "ok"

Original issue's description:
> [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.
> 
> As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468
> 
> BUG=423983
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184336

TBR=falken@chromium.org,horo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423983

Review URL: https://codereview.chromium.org/672353003

git-svn-id: svn://svn.chromium.org/blink/trunk@184364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to have garbage in resulting bitmap if we abort redraw before fill commands
in SkPicture are executed.

BUG=426100,426102

Review URL: https://codereview.chromium.org/654843010

git-svn-id: svn://svn.chromium.org/blink/trunk@184363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to our object profiling in micro-benchmarks and real-world benchmarks (https://docs.google.com/a/google.com/spreadsheets/d/1EBYDfkvJ1aleIj0iSNmk0zEsq0AqVOsjEyI6XfOoLIU/edit#gid=562560234), the following objects are allocated very frequently.

- Node
- CSSValue
- RenderObject
- HTMLStackItem
- ElementRecord

Given the results, this CL introduces a dedicated heap for CSSValue and RenderObject. (Note: PartitionAlloc also has a dedicated heap for RenderObject.)

This improves various benchmarks a lot:

css/CSSPropertySetterGetter: +35%
css/ClassInvalidation: +32%
css/StyleSheetInsert: +21%
layout/floats-*: ~+20%
layout/large-table-with-*: ~+10%

BUG=420515

Review URL: https://codereview.chromium.org/667053009

git-svn-id: svn://svn.chromium.org/blink/trunk@184362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes the main thread block and wait for the parser thread when all the
script data has arrived. The goal is to ensure that the script (which can now be
compiled) will get the main thread's attention as soon as possible.

This feature is temporary: The usefulness of blocking will be evaluated with
Finch, and this option will be removed (blocking will be always enabled or never
enabled, based on which option turns out to be better).

Previous version: https://codereview.chromium.org/651163002/

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/674133002

git-svn-id: svn://svn.chromium.org/blink/trunk@184361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman
BUG=426815

Review URL: https://codereview.chromium.org/640953004

git-svn-id: svn://svn.chromium.org/blink/trunk@184360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=caseq

Review URL: https://codereview.chromium.org/675173002

git-svn-id: svn://svn.chromium.org/blink/trunk@184359 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is required for the validator to work on Windows, as otherwise
the command line exceeds the maximum length there.

R=sergeyv@chromium.org, sergeyv

Review URL: https://codereview.chromium.org/669123005

git-svn-id: svn://svn.chromium.org/blink/trunk@184358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Design doc:
https://docs.google.com/a/chromium.org/document/d/16f_RIhZa47uEK_OdtTgzWdRU0RFMTQWMpEWyWXIpXUo/edit#heading=h.srz53flt1rrp

BUG=391005

Review URL: https://codereview.chromium.org/656323005

git-svn-id: svn://svn.chromium.org/blink/trunk@184357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used to change cursor upon drag on body only, but this now doesn't
have effect since we explicitly set cursor: default in .component-root.
So set the cursor explicitly both on the event target and body (the latter
is needed so that cursor change also has effect on the glass pane).

BUG=

Review URL: https://codereview.chromium.org/658723006

git-svn-id: svn://svn.chromium.org/blink/trunk@184356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/675753002

git-svn-id: svn://svn.chromium.org/blink/trunk@184355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have many .*Policy in this file. Use a more specific name for
readability.

R=mkwst
BUG=none

Review URL: https://codereview.chromium.org/666533005

git-svn-id: svn://svn.chromium.org/blink/trunk@184352 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=309710

Review URL: https://codereview.chromium.org/652813005

git-svn-id: svn://svn.chromium.org/blink/trunk@184351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebIDL Dictionaries should access prototype chains when searching for properties. This change adds getPropertyNames to the v8 Dictionary class.

Web Animations Keyframes should make use of prototype chains when looking for CSS properties to animate. This change makes use of getPropertyNames to ensure this happens.

Review URL: https://codereview.chromium.org/661453004

git-svn-id: svn://svn.chromium.org/blink/trunk@184350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts r184277.

Reason: ASSERTS fail in debug mode because ScriptStreamer gets destroyed while
holding the mutex.

BUG=
TBR=marja@chromium.org, haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/680493002

git-svn-id: svn://svn.chromium.org/blink/trunk@184349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Switched from using dumpResourceRequestCallbacks to using direct
memoryCache APIs in internals.

BUG=426041

Review URL: https://codereview.chromium.org/675853003

git-svn-id: svn://svn.chromium.org/blink/trunk@184348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes our handling of escaped newlines in the css-syntax
tokenizer. Since we don't perform preprocessing, the logic is slightly
trickier than in the spec. The preprocessing replaces \r, \r\n, \f with
\n.

Regarding escaped newlines in strings, the spec states:
"Otherwise, if the next input code point is a newline, consume it."
In this case, we may need to consume two tokens if we have \r\n.

The other cases don't require special handling, since \r\n starts with
\r (also a newline) and in these cases the following token is just going
to be a whitespace token.

BUG=424988

Review URL: https://codereview.chromium.org/656033010

git-svn-id: svn://svn.chromium.org/blink/trunk@184347 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The line-height property has lots of special handling in the style
resolver which we want to remove at some point. When we do, it's nice to
know that this still works correctly.

R=rune@opera.com
BUG=353932

Review URL: https://codereview.chromium.org/678483005

git-svn-id: svn://svn.chromium.org/blink/trunk@184346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use dataEquivalent instead of comparing pointers. Updating the base
RenderStyle in ActiveAnimations asserts that the cached base RenderStyle
is correct by comparing RenderStyle objects. It triggered an assert when
comparing two shape-outside values represented by different objects
representing the same value.

R=esprehn@chromium.org,dstockwell@chromium.org
BUG=425473

Review URL: https://codereview.chromium.org/669093002

git-svn-id: svn://svn.chromium.org/blink/trunk@184345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik@chromium.org,aandrey@chromium.org,pfeldman@chromium.org

Review URL: https://codereview.chromium.org/649183010

git-svn-id: svn://svn.chromium.org/blink/trunk@184344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/674103002

git-svn-id: svn://svn.chromium.org/blink/trunk@184343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's not necessary to do initialization of FontBuilder separately from
StyleResolverState::setStyle. It just adds noise.

Also, use a reference for Document in FontBuilder, since its existence can
be guaranteed in all cases.

R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/671613003

git-svn-id: svn://svn.chromium.org/blink/trunk@184342 bbb929c8-8fbe-4397-9dbb-9b2b20218538