- 18 Nov, 2020 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie9fa8c667a0ff361ec6bcee145266d42885a5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547207Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#828787}
-
Frank Tang authored
Bug: 1144403 Change-Id: Ib3a78b49d328120bf51c332f61f57299933e8088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545867 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#828786}
-
Pavel Feldman authored
The value was changed without a comment from 10ms to 100ms as a part of the viz migration: https://chromium-review.googlesource.com/980823. This change is bringing it back. Change-Id: Ib7a0312cb5958108d5d7fbf222e0cf339e9f93fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546475Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#828785}
-
Nico Weber authored
It's been a CoreOption since https://reviews.llvm.org/D61945 No behavior change. Bug: none Change-Id: I32acae26fffb3b71fd9d866aead3569c7ace7287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547204 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#828784}
-
Mikel Astiz authored
model_type.h is included in many places so let's make sure it doesn't add unnecessary dependencies. Change-Id: I43f89cedb0942245742c7f041e59c325a06d612c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540686Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828783}
-
Koji Ishii authored
This patch reorders fields in |ShapeResult::RunInfo|, which reduces the size from 88 bytes to 80 bytes on x64. |RunInfo| represents a run of glyphs rendered in one font after font cascading. |ShapeResult| has a vector of |RunInfo|. Also adds an |ASSERT_SIZE|. This patch has no behavior changes. Change-Id: If635a71b6fcd861410f9e2354c6bcfd03c94dafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546394Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828782}
-
Maksim Ivanov authored
Extend the chrome.certificateProvider API's apitests to cover all currently supported algorithms and legacy hashes. This commit makes sure that regressions in rarely used algorithms are caught early, and also prepares for the introduction of the RSA-PSS algorithm support. Bug: 792204 Change-Id: Icb13cff10738141e4aea9a84df2323fcf5d5e49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545386 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828781}
-
Xianzhu Wang authored
This reverts commit c5bbd834. Reason for revert: Breaks custom scrollbar background painting (null pointer when dereferencing a Node when getting the Document). Original change's description: > Use only one way to check if we are printing or painting preview > > We had 3 ways to check printing status: > - Document::Printing()/Document::IsPaintingPreview()/Document::IsCapturingLayout() > - GraphicsContext::Printing()/GraphicsContext::IsPaintingPreview()/GraphicsContext::IsPrintingOrPrintingPreview() > - PaintInfo::IsPrinting() > > Now keep the first way only to ensure consistency and reduce chance > of errors. > > Also simplify PaintRecordBuilder constructor parameters to avoid > multiple default parameters, and let callers set some GraphicsContext > related configs directly instead of through PaintRecordBuilder > constructor. > > Change-Id: I479b98b19700c5bed077ec9ef00bd148e3b33c63 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535627 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828385} TBR=szager@chromium.org,wangxianzhu@chromium.org,mstensho@chromium.org,ckitagawa@chromium.org Change-Id: I9854b70695cf588fbc8f704c60fd211c936bd132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547424Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828780}
-
Ioana Pandele authored
TBR=jdonnelly@chromium.org Bug: 1143630 Change-Id: Ia5c565c19f1472a9a46aef32c16159d12b6e224a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547301Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#828779}
-
Elizabeth Popova authored
In this test the keyboard was expected to be shown as soon as the AddressEditor dialog is opened. This behavior was broken because due to Focus/Keyboard Navigation Changes in Android P+ initial focus is no longer assigned. The issue was fixed in [1] and now the test should pass on android-pie-arm64-rel and android-pie-x86-rel builders. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2510211 Bug: 836460, 1061208 Change-Id: I3e857b936b8736b8293f14f2f9fbc82e9bd17b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545304Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#828778}
-
Lijin Shen authored
1. Add a listener for queue to be notified of tab changes 2. dismiss all messages when tab changes Bug: 1123947 Change-Id: Ibd91c432a1dd93087127ce8c03e45d3af9f57ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538675Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#828777}
-
Omar Morsi authored
This CL extends KeyPermissionsManager to record: - The time taken to successfully migrate key permissions to chaps. - The time taken to successfully update chaps with the new ARC usage flags. Bug: 1139855 Change-Id: I78b871f520963ff6bfa907ccc598786c2a5bd9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544975Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828776}
-
Dale Curtis authored
This reverts commit 79e55e3e. Reason for revert: Fix failed to land in time. Original change's description: > Add event cache size limit to media devtools > > This adds a cache for both total number of players as well as total > number of events kept by the each individual player, in order to prevent > long-living pages from creating an otherwise unbounded number of events > and creating memory pressure. > > There is some logic for selecting which players to prune, but no logic > to do anything special for events yet. > > Events, Messages, and Errors are all subject to the same cache size > limits, but the Properties can't grow unbounded so they aren't. > > R=dalecurtis > > Bug: 1145392 > Change-Id: Iab39207276b6179b9f8828df7ced210154ab97dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517928 > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827070} TBR=dalecurtis@chromium.org,caseq@chromium.org,tkent@chromium.org,tmathmeyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145392 Change-Id: I40b2631948aadcb3643595681b222a5b6805a6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547403Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828775}
-
Dale Curtis authored
This reverts commit 82e54baf. Reason for revert: Fix not landed in time. Original change's description: > Fix ClusterFuzz NPD > > playerIDs were getting added to dead players, then removed from the > player map - when it came time to delete players, the dead players > tried to be removed again. Looks like CF was running without DCHECK > enabled, so it never hit the check for iter != players_.end(). > > Bug: 1148757 > Change-Id: I13486c59ec362b023ddbf93462d359bec7707512 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537789 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827464} TBR=dalecurtis@chromium.org,caseq@chromium.org,tmathmeyer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1148757 Change-Id: I61920a94635369846e0781ac22b072f0cd7ee4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547423Reviewed-by:
-
James Cook authored
I need to introduce it so I have a place to put some crash and metrics consent code that needs to run early in browser startup. No functional changes. Bug: 1148604 Change-Id: I9dca170b1cf9f0453e174d7cbe0a0b8652f7328b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508367Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828773}
-
Stephen McGruer authored
Import done manually as test changes and tool changes need to be in sync. Tools rolled to 62b6255 Tests imported at ebb2824 Bug: 1150380 Change-Id: I1bfc1dd19073bde99ab669da8bd2856117755a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545067Reviewed-by:
Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828772}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202011180600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vYtTShBj1xqnqgqJLKObuX6STR_IQfyEJaxLgFcIolMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ieb56f0dc69f416036d4d1debff05fd9ba8f0b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547143Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828771}
-
Peter Kasting authored
Bug: 1097283 Change-Id: Ic54679c9d4b86fbe074b77067bd1bfa8b5d388f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546842 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828770}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/55f251dffe05..01e445072921 2020-11-18 hao.x.li@intel.com Query API: Non Precise Occlusion Query If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Id11cc312c9e276f918b32b7c60394e0284a2f23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547202Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828769}
-
Nancy Wang authored
If the app is paused or blocked, announce 'Paused' or 'Blocked' for Chrome Vox, when the icon item is selected/focused from app list, shelf or searchbox. The block status has higher priority. When the app is paused and blocked, announce 'Blocked'. This CL modifies the search box result to add 'Paused' or 'Blocked' to the accessible name. BUG=1144384 Change-Id: I1388a021a169cf332b86bfd892d7ccde990fc805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545908 Commit-Queue: Nancy Wang <nancylingwang@google.com> Reviewed-by:
-
Adrienne Walker authored
This change decouples background fetch from using CacheStorageCache directly. A future follow-up patch will switch the use of CacheStorageContext to a CacheStorageControl mojom, paralleling IndexedDBControl. Background fetch all uses the GetAllMatchedEntries API, which is a combination of the existing Keys/Match APIs and returns requests and responses together. For simplicity, this API is exposed to mojo (and the renderer) as well. Bug: 1147642 Change-Id: I79f872bc9e1dbd53a4363f259b2c5d5a0c1a9389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464075Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828767}
-
Nohemi Fernandez authored
Ensure that all Google domains (including YouTube) will trigger the logic to check for GAIA cookies attached to google.com. This will enable users to automatically sign-in when Gaia cookies are removed. Bug: 1149902 Change-Id: I8e9b2c06d2c4d49c5b86cf361240315664cb31ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545506Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#828766}
-
Joon Ahn authored
Clamp this.value to this.max. If value is higher than max, paper-progress breaks for a while. For example if fullBattery resolves later than currentBattery, paper-progress will break until the currentBattery changes (which might not happen if device has the charging cable in at 100%). Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I30b3df7faf838b973a83afc9bb18543d3fb169eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542423 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828765}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d7af84645b98..fa9411e0a242 2020-11-18 acostinas@google.com Expect system-proxy in password-viewers 2020-11-18 kyleshima@chromium.org nebraska: Pass 'ignore-appid' flag to Nebraska 2020-11-18 yyanagisawa@chromium.org Use ?cros GOMA_RPC_EXTRA_PARAMS for RBE_CHROMEOS. 2020-11-17 yunghsien@google.com image test: Add new users to group gwifi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I51bf2e38d44cb52f4d467977cf736aa333c24450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547142Reviewed-by:
-
Andres Medina authored
Bug: b/132440534 Test: CQ and manual size check. Change-Id: Ie892c66dd5773e93ed154d3754add455e1f47041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518775Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#828763}
-
Ioana Pandele authored
TBR=chili@chromium.org Bug: 1149856 Change-Id: I968d6cb9eb1053e2d735908aa19c0c68214f41cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546545Reviewed-by:
-
Tomasz Tylenda authored
BUG=764795 TESTED=build Change-Id: I45723edb2defc663df4228f26fa82e543aab567c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497741Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#828761}
-
Peter Boström authored
Bug: 1106422 Change-Id: I1f5c6c786ca85714f5e2178249db051b5690df79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545683 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
kylechar authored
Replace BindToTaskRunner() to with base::BindPostTask(). The only functionality change is the base version ensures the callback is destroyed on the bound task runner, even if the callback is never invoked, so that any curried variables are destroyed on the right task runner. Bug: 1140582 Change-Id: I713f5e63a5eac63322808b75dac52693afbcdadb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536786Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#828759}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie506967775e3e0fc083b8baea327edff9bb7a57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546963Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5bf96dbd711b3b9a8735cc256839c4b192b8a7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547043Reviewed-by:
-
Ossama Mahmoud authored
While the PIN input field is focused on the lock screen, Pressing the shortcut keys Ctrl+Shift+Q twice does not sign out the user. This is fixed by invoking the default handling when ctrl is pressed. Bug: 1147599 Change-Id: I254489b88086d93da16e00987242da73f8f469d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546962Reviewed-by:
Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Cr-Commit-Position: refs/heads/master@{#828756}
-
danakj authored
This explains more what is unsafe about this mojom, and add additional comments explaining when it is okay to use this and discouraging general use. R=darin@chromium.org, dcheng@chromium.org Bug: 1144462 Change-Id: I735da27d649394f2e196d99f6b63444e370e9586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545203Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828755}
-
Michael Olbrich authored
cap.capabilities describes all capabilities of the whole physical device. It may contain V4L2_CAP_VIDEO_CAPTURE and V4L2_CAP_VIDEO_OUTPUT if multiple /dev/video* device nodes are part of the same physical device. If the V4L2_CAP_DEVICE_CAPS flag is set, then device_caps contains the capabilities of the currently opened device node. So this should be checked as well to determine if the device node is a capture device. Bug: None Change-Id: I83c0516c546121a0fac82380b72d1c8f3cb22fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537967Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#828754}
-
cfredric authored
This enables usage of the feature flag in net/ code, since services/network code can depend on net/ but not vice versa. Bug: 1143756 Change-Id: I0f78a995cb14b2acd6a12991c1b6afedad12e0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542813Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#828753}
-
Muhammad Hasan Khan authored
ArcSignInStatus has values that are only used inside ARC and are not sent over mojom interfaces. In this change we're removing all such values from the mojom interface and we'll create a local enum in ARC for referencing it in the code there. BUG=b:166322619 TEST=CQ Change-Id: I00a31e6c7f7b49d7cc0454f905539b1c494799ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542824 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828752}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_Filter=DiagnosticsApp* Change-Id: Ia61f672578543693b0107f65a91d1be033e2d081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544752Reviewed-by:
-
Matt Simmons authored
R=davidjm@chromium.org Change-Id: I86f1d5204949c6fe8d3d062f0e9840558fd85cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542807Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#828750}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d1219d7bc85c..c91cb9e0abfe 2020-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 11c6670b4a4f to 30e70cbd9850 (1 revision) 2020-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 0cb8cc8cfcb2 to 169d0c7f8a7b (4 revisions) 2020-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 04515da400d5 to bb96f79d0e15 (2 revisions) 2020-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from be6ccb9ecaf7 to b54d55122868 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I0700ba3aeaf564a173a51242c9eb6db7b4ec07cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546867Reviewed-by:
-
Peter Kotwicz authored
This reverts commit d3f64670. Reason for revert: Broke several chrome_junit_tests See https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20%28dbg%29/53156 Sample broken chrome_junit_tests: ConfirmSyncDataStateMachineDelegateTest Original change's description: > [WebLayer] Update Fragment.getActivity() implementation. > > This CL updates the bytecode modifications we perform on > Fragment.getActivity() to have it call ContextUtils.activityFromContext( > getContext()), and modifies compile_java.py to detect compilation errors > related to this change and print a message pointing you to documentation > about the bytecode modifications. > > A compilation error will now print: > ../...../PasswordEntryEditor.java:144: error: cannot find symbol > getActivity().getSupportFragmentManager(), > ^ > symbol: method getSupportFragmentManager() > location: class Activity > Expecting a FragmentActivity? See docs/.......md > > Bug: 1123216 > Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828643} TBR=twellington@chromium.org,agrieve@chromium.org,bsazonov@chromium.org,rmcelrath@chromium.org,chouinard@chromium.org Change-Id: Iee2c469e87e9067bdf7ea2c1744398c473328711 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1123216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547121Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#828748}
-
