- 11 Jan, 2017 40 commits
-
-
xianglu authored
This CL moves Shape Detection mojo interfaces to //services, which exposes them to public instead of just Blink. No new code added. Blocking: https://codereview.chromium.org/2460723003/ TBR=haraken@chromium.org (mechanical move) BUG=646083, 659139 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2620083002 Cr-Commit-Position: refs/heads/master@{#442991}
-
kbr authored
Rendering corruption is seen on this GPU, which is nearly 10 years old. Fall back to software rendering. BUG=676975 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626973002 Cr-Commit-Position: refs/heads/master@{#442990}
-
alexclarke authored
Previously background web views had timer alignment throttling applied immediately and budget based throttling after 10s. It looks like even the timer alignment throttling on it's own is causing problems for new tabs where the visibility isn't initially known. To fix this we're changing the policy so we don't do any throttling at all until the web view has been in the background for 10s and then we turn budget based throttling & alignment on. Note this patch removes fast/dom/timer-throttling-hidden-page.html because the 10s grace period means this test would be too slow. Virtual time doesn't help because Date.now() (currently) isn't overridden. There's no support for using a mock time source in layout tests. In any event there's plenty of C++ unit test coverage for this so it's not too bad to remove the layout test. BUG=649942 Review-Url: https://codereview.chromium.org/2620743002 Cr-Commit-Position: refs/heads/master@{#442989}
-
sdefresne authored
In order to roll GN c99acd65..5c18ca83 (r439377:r442253) and pick up the following changes: 4ce240b3 Associate xctest files with corresponding xctest targets. 7e5894a9 Configure xctest build settings to prevent Xcode from linking objects. 043a15dd Add functionality to find xctest files under application target. d1316080 Stop propagation of dependent configs between toolchains. 0c1dd9de GN: Fix some typos in the documentation. 67e8c60e [Refactor Xcode Objects] Allow extra attributes for native targets. 8fb7d9d9 [Refactor Xcode Objects] Enable adding per file '--help' compiler flag. 898a56b7 [Refactor Xcode Objects] Decouple file references and indexing target. a8936b7a Fix a typo in GN documentation 889ccd0f Fix a typo in gn help. 7d886382 Support for source_target_relative expansion in GN 615f8527 Fix GN bootstrap. d48f4812 [Refactor Xcode Objects] Enable navigator paths for file references. 44dbd2f1 Clean up link references in //tools/gn/README.md. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2619823002 Cr-Commit-Position: refs/heads/master@{#442988}
-
Dave Schuyler authored
Cr-Commit-Position: refs/heads/master@{#442987}
-
tonikitoo authored
Driven-by clean up past [1], where the only user of this switch was (re)moved. [1] https://codereview.chromium.org/2573283002 BUG= Review-Url: https://codereview.chromium.org/2619773003 Cr-Commit-Position: refs/heads/master@{#442986}
-
fdoray authored
The following traits are used: Priority: BACKGROUND User won't notice if this task takes an arbitrarily long time to complete. Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2610503002 Cr-Commit-Position: refs/heads/master@{#442985}
-
samans authored
The sole purpose of SurfaceReferenceBase and SequenceSurfaceReference was to be able to return the reference later on, but the same goal can be achieved using closures with much less complexity. From now on, SurfaceReferenceFactory::CreateReference returns a closure that returns the reference once its called. TBR=sadrul@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2616403003 Cr-Commit-Position: refs/heads/master@{#442984}
-
rdevlin.cronin authored
BUG=669277 Review-Url: https://codereview.chromium.org/2623033002 Cr-Commit-Position: refs/heads/master@{#442983}
-
robertogden authored
R=sclittle BUG=679424 Review-Url: https://codereview.chromium.org/2624233002 Cr-Commit-Position: refs/heads/master@{#442982}
-
boliu authored
Move getSmallestDIPWidth to ChromeContextUtil in chrome. This removes the last usage of DeviceDisplayInfo, so finally remove it. BUG=625089 Review-Url: https://codereview.chromium.org/2623653002 Cr-Commit-Position: refs/heads/master@{#442981}
-
fs authored
The former should "win" over the latter. Fixed by https://codereview.chromium.org/2478233002. TBR=pdr@chromium.org BUG=415950 Review-Url: https://codereview.chromium.org/2621153005 Cr-Commit-Position: refs/heads/master@{#442980}
-
dcastagna authored
KMS now advertises per plane buffer modifiers. This patch uses that information to make an educated choice on which modifiers to use when allocating scanout buffers for a specific crtcs. patch from issue 2576263002 at patchset 60001 (http://crrev.com/2576263002#ps60001) BUG=chrome-os-partner:56407 Review-Url: https://codereview.chromium.org/2623963002 Cr-Commit-Position: refs/heads/master@{#442979}
-
maxbogue authored
Still lost as to why it would be null, but this should stop crashes. BUG=679657,673883 Review-Url: https://codereview.chromium.org/2622223003 Cr-Commit-Position: refs/heads/master@{#442978}
-
bzanotti authored
The first one should always be the default one. Updated switch case: http://screen/PTLfmU9H7h0.png BUG=660418 Review-Url: https://codereview.chromium.org/2614973002 Cr-Commit-Position: refs/heads/master@{#442977}
-
dimu authored
Cr-Commit-Position: refs/heads/master@{#442976}
-
pdr authored
Slimming paint invalidation (--enable-slimming-paint-invalidation) moves paint invalidation to a new "pre-paint" document lifecycle stage. This patch moves prePaint under the "Update Layer Tree" timeline category, and adds a comment to move this under "Paint" for slimming paint v2 (see discussion in https://codereview.chromium.org/2623613008). BUG=679403 Review-Url: https://codereview.chromium.org/2622983002 Cr-Commit-Position: refs/heads/master@{#442975}
-
siggi authored
This implements a fallback crash handler launcher. The launcher will be instantiated in the Crashpad handler process, where it pre-computes a command line to be launched on crash. This will be triggered off the UEF, under some form of single-instance locking. BUG=678959 Review-Url: https://codereview.chromium.org/2596463002 Cr-Original-Original-Commit-Position: refs/heads/master@{#442596} Committed: https://chromium.googlesource.com/chromium/src/+/d4e43bb5146c7a59123ff5f3b6e853d8e8c29130 Review-Url: https://codereview.chromium.org/2596463002 Cr-Original-Commit-Position: refs/heads/master@{#442698} Committed: https://chromium.googlesource.com/chromium/src/+/f87fdaa12b09ff286d873e7a3ea459507d7adb83 Review-Url: https://codereview.chromium.org/2596463002 Cr-Commit-Position: refs/heads/master@{#442974}
-
zakerinasab authored
Implement color management for ImageData as described in this proposal: github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE BUG=670712 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2555213002 Cr-Commit-Position: refs/heads/master@{#442973}
-
yzshen authored
It is convenient for debugging. Although console.log() is supported by chrome directly, mojo bindings currently are loaded using gin. Therefore, console.log() is not always available and needs to be defined as a module. After we move away from gin/AMD, we should be able to get rid of this. BUG=579646 TBR=jochen@chromium.org (deferring to eugenebut) Review-Url: https://codereview.chromium.org/2618693004 Cr-Commit-Position: refs/heads/master@{#442972}
-
fdoray authored
The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2608093002 Cr-Commit-Position: refs/heads/master@{#442971}
-
dtseng authored
Previously, accessibility extensions required content scripts to access locked screen UI. With the introduction of chrome.automation, this is no longer necessary. An extension running in the signed in profile can easily access locked screen UI. We therefore can: - remove enabling an extension in the locked screen ui's profile (e.g. adding ChromeVox as a component extension). - stop injection of content scripts into the locked screen's web ui. TEST=navigate to locked screen with ChromeVox on. Verify things work. Toggle ChromeVox off and on. Verify things still work. BUG=676467,611736 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2617633004 Cr-Commit-Position: refs/heads/master@{#442970}
-
krasin authored
BUG=678915 Review-Url: https://codereview.chromium.org/2621193003 Cr-Commit-Position: refs/heads/master@{#442969}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/76a44dea3180..8fa82794ffc2 $ git log 76a44dea3..8fa82794f --date=short --no-merges --format='%ad %ae %s' 2017-01-11 tsepez Annotation deleted while retrieving it in JS BUG=679642 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2623263002 Cr-Commit-Position: refs/heads/master@{#442968}
-
sdefresne authored
gn will be modified to no longer propagate public_configs across toolchains (as this is a problem with some platforms). Refactor ios_framework_bundle template to define the configs for all the toolchains and to put the references directly (instead of having secondary toolchain get them through the dependency). BUG=675224 Review-Url: https://codereview.chromium.org/2627983002 Cr-Commit-Position: refs/heads/master@{#442967}
-
manzagop authored
The intent is to store the chrome module's information as early as possible so it's always present in the stability debug data. For information about other modules, see https://chromiumcodereview.appspot.com/2566983009/ BUG=620813 Review-Url: https://codereview.chromium.org/2622863004 Cr-Commit-Position: refs/heads/master@{#442966}
-
tfarina authored
The last usage of this method was removed by commit 451a6636: ("rlz: get rid of the call to AppendHeaderIfMissing()"). This also made possible to remove HasHeader() as AppendHeaderIfMissing() were the only client of it. With removing HasHeader() method from HttpUtil we fixed the Darin's TODO. BUG=488593 TEST=net_unittests R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2624213002 Cr-Commit-Position: refs/heads/master@{#442965}
-
skyostil authored
This flag needs to be passed to the renderer to actually disable background throttling. BUG=678745 Review-Url: https://codereview.chromium.org/2624153002 Cr-Commit-Position: refs/heads/master@{#442964}
-
carlosk authored
This CL adds some support ahead of time for the upcoming one that will partially move mixed content checks to the browser (https://crrev.com/1905033002). These changes are: - Split mixed content Blink public code into two different files to separate constants (WebMixedContentContextType) from functions (WebMixedContent). - The renderer now sends back to the browser information about the WebMixedContentContextType for navigation requests so that the browser won't need to execute Blink code (what is not acceptable). There's quite some piping involved in making this happen and some tests needed updates to avoid DCHECKs to be hit. For browser side requests it is set to match the RequestContextType used (blink::WebMixedContentContextType::Blockable to content::REQUEST_CONTEXT_TYPE_LOCATION). - Moved mixed content code that was previously made public back into MixedContentChecker where it used to be as it doesn't need to be public anymore. BUG=576270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2625633002 Cr-Commit-Position: refs/heads/master@{#442963}
-
yunchao.he authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/046d1f6..06ad9fd BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626963002 Cr-Commit-Position: refs/heads/master@{#442962}
-
clamy authored
Currently we attempt to query RenderFrameDevToolsAgentHost::IsNetworkHandlerEnabled based on the frame that is navigating. However, there may not be a RenderFrameDevToolsAgentHost for a subframe that is navigating even though there is one for the top-level frame, where the NetworkHandler is active. This prevents from properly reporting headers in subframe navigations. BUG=551000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2628593002 Cr-Commit-Position: refs/heads/master@{#442961}
-
dfalcantara authored
Problematically, new DownloadItems are created with no file name when a download first starts. This means that the DownloadHistoryItemWrapper is added to the wrong part of the FilePathsToDownloadItemsMap and can't be removed until the user re-opens Download Home, which correctly records the DownloadItem in the correct place. * Change the behavior so a download completion event also triggers the item to be added to the map -- this time with the correct file path. * Also make the FilePathsToDownloadItemsMap use a HashSet for its secondary data structure. It ends up slightly cleaner IMO. * Cleans up the StubbedProvider so that it can take in specific download percentages more easily. * Add a new test for this behavior. BUG=670583 TEST=DownloadHistoryAdapterTest* Review-Url: https://codereview.chromium.org/2626903005 Cr-Commit-Position: refs/heads/master@{#442960}
-
Jamie Madill authored
These tests were probably accidentally dropped some time ago. BUG=angleproject:1385 R=eyaich@chromium.org TBR=dtu@chromium.org, eyaich@chromium.org Review-Url: https://codereview.chromium.org/2625933003 . Cr-Commit-Position: refs/heads/master@{#442959}
-
sdefresne authored
In preparation of the removal of BrowserListIOS, implements free function to maintain explicitly the 1:N mapping from ios::ChromeBrowserState to TabModel. BUG=None Review-Url: https://codereview.chromium.org/2621083003 Cr-Commit-Position: refs/heads/master@{#442958}
-
byungchul authored
ENABLED_SCREEN_CAPTURE is not flag to enable DesktopCaptureDevice. It enables DesktopCaptureDeviceAura (if use_aura=1). Use BUILDFLAG(ENABLE_WEBRTC) instead of ENABLED_SCREEN_CAPTURE to use DesktopCaptureDevice in VidepCaptureManager. BUG=internal b/34176576 Review-Url: https://codereview.chromium.org/2625553003 Cr-Commit-Position: refs/heads/master@{#442957}
-
kylechar authored
Running mustash on device currently crashes on startup. This is because ui::Service doesn't create a TaskScheduler before Ozone DRM uses it. One option is to have ui::Service::OnStart() create a TaskScheduler. If other Mojo applications need a task scheduler they'll have to do the same. Instead, have MashRunner start a TaskRunner for each process. This fixes the crash in Ozone DRM and doesn't seem to cause any other problems. BUG=679840 Review-Url: https://codereview.chromium.org/2621153003 Cr-Commit-Position: refs/heads/master@{#442956}
-
sadrul authored
The gpu host should set up GpuPreferences correctly and send that to the gpu process so that GpuService is initialized with the desired settings. The corresponding chrome-ipc, GpuMsg_Initialize, also includes the GpuPreferences. Also includes a build fix for mac. BUG=643746, 630895 Review-Url: https://codereview.chromium.org/2627993002 Cr-Commit-Position: refs/heads/master@{#442955}
-
michaeldo authored
BUG=none Review-Url: https://codereview.chromium.org/2619483002 Cr-Commit-Position: refs/heads/master@{#442954}
-
fdoray authored
The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2604923002 Cr-Commit-Position: refs/heads/master@{#442953}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/f4faccd3b303..a5494f117086 $ git log f4faccd3b..a5494f117 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 halcanary SkTypes.h : move SkAutoMalloc into SkAutoMalloc.h 2017-01-10 brianosman Get latest ANGLE as of January 6, 2017 2017-01-10 msarett Add readPixels() tests for generator backed images Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=kjlubick@google.com Review-Url: https://codereview.chromium.org/2626073004 Cr-Commit-Position: refs/heads/master@{#442952}
-