- 12 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7f0e7d0d262a..c0ef8ccfcd8b 2021-01-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 348ba200aa29 to 3549479dc4cc (3 revisions) 2021-01-12 jonahr@google.com GL: Clean up Display code related to multithreading 2021-01-12 syoussefi@chromium.org Reland "Use is_apple instead of is_mac and is_ios everywhere" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1161513 Tbr: timvp@google.com Change-Id: I9e34c9eac5ecf17cf015d835d1ee22139ea8d91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842647}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c0b5a6bb2b2..c8e16bbe32be 2021-01-12 egdaniel@google.com Add recycled gpu resource ref counting and use it in GrVkCommandBuffer. 2021-01-12 tdenniston@google.com [svg] Implement feGaussianBlur 2021-01-12 jvanverth@google.com Fix issues with MTLPixelFormatBGR10A2Unorm on older OSes. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I96cac990a1163f9bf528de3c04ab9549d39b5ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624950Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8d7ce656. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm jsbell@chromium.org: external/wpt/service-workers/cache-storage yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ib6cf2e6dcfdceab26112360fbf4a7fb91170b103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624867Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842645}
-
Jan Krcal authored
This CL disables the FRE for profiles created through the updated profile creation flow (as the user is presented with a very similar sign-in promo in the flow). Bug: 1115056 Change-Id: Iff161d371d32fc369a26a0a2e3f99daa2b1f8fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624212 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842644}
-
Jeffrey Cohen authored
Bug: 1164076 Change-Id: I95c40a60e3d68958c5f3d0d7002534dafc332b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616865 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#842643}
-
David Black authored
Previously the pin button was 8dip from the edge of the view. The spec calls for 4dip. This CL also reduces scope of screen capture related constants.h Bug: 1165348 Change-Id: I585b332e82735ecad2dcc2707928a39a2ebbc76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624030Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#842642}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea9b5bbcb53e..e2ffb3742633 2021-01-12 tvanderlippe@chromium.org Remove Closure-related types in legacy-defs 2021-01-12 tvanderlippe@chromium.org Move String.hashCode into string-utilities 2021-01-12 tvanderlippe@chromium.org Move unescapeCssString into elements/ 2021-01-12 jacktfranklin@chromium.org Remove Set#firstValue proto method 2021-01-12 tvanderlippe@chromium.org [module.json extensions] coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b74af1acfe9a5ed67e93cb5aab2114ffeaf8943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624948Reviewed-by:
-
David Tseng authored
ChromeVox's cursors module contains a clean, clear, and simple interface to work with the ideas of positions (cursors) and ranges over the automation tree. It predates and largely motivates the creation of AXPosition/AXRange in ui/accessibility. Future changes will attempt to rebase these js classes partly or completely on top of their native counterparts. R=dmazzoni@chromium.org Test: existing (moved) tests. Change-Id: Ie27cd9ae2c2b406c8f2edcc5148dee03d7bb6281 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622053Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842640}
-
David Black authored
Problems addressed: - Selection ring was too small - Focus ring was too tight around view - Focus ring had wrong corner radius Before: http://shortn/_cqPPbTDIUI After: http://shortn/_Bvt34oqzIC Bug: 1147182, 1163739 Change-Id: I1e70ad9ffa00d0e57e32ea1f77ba5201ef79a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623707Reviewed-by:
-
Chris Davis (EDGE) authored
During early startup a call is made to GetHardwareInfoSync which queries WMI for the model, manufacturer and serial number. Querying WMI is an outbound call that can hang. I have looked at traces showing 100-500ms outbound hangs. The model and manufacturer strings can be read from the registry for windows in a known location. This isn't the case for the bios serial number, but it turns out nobody is using that anyways (at least through GetHardwareInfoSync) so I am removing it. Bug: 1164623 Change-Id: Iabb414f42f75008730440529b055d5951ce37dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619419Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a231c0ae86..e3e59aac750e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If0a15388e0958f5932e0746a9357370a9999464a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624529Reviewed-by:
-
David Black authored
It was previously assumed (at least by me) that hiding the holding space tray would result in closing of the holding space bubble. This was not actually guaranteed to be the case. This means that it was theoretically possible to keep the holding space bubble open even after detaching the holding space model and client, though I have not been able to reproduce this in the real world w/o forcing state programmatically. It's possible that a user was able to reach such a state which could result in the crash in the attached bug if interacting with the Files app chip. Bug: 1165305 Change-Id: I039072d2d07eaf741ae70d551ac7889eaee0a46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623726Reviewed-by:
-
Kevin Ellis authored
Source of the flakiness fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2621924 These tests were not actually able to run on the compositor since the keyframes where empty and thus not affecting a property that could be composited. The flakes were appearing on both the virtual and base test suites; however, only the virtual version was disabled. This patch re-enables the test in the virtual test suite. Bug: 1139023 Change-Id: I4811b7fa0850cb7346448e008f4652eda547f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622340Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#842635}
-
Norge Vizcay authored
* A new service is introduced to act as a bridge between Java and c++ password store and provide the required functionality. The service supports the following directives: - Clear all password store credentials. - Read password store credentials. - Write credential into the password store. - Edit credential from password store. More context: https://docs.google.com/document/d/1baR4V7_1myXAGRBve6tjH7M1y3b46NLSMCmvwUniTng/edit?usp=sharing&resourcekey=0-zhjniBnKxbx700x72JViMg Bug: 1164365 Change-Id: Ic343609d738524a597a724593ae5bf4d766738e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591128 Commit-Queue: Norge Vizcay <vizcay@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#842634}
-
Stefan Zager authored
Change-Id: I40207e26b973cf669b0a45b4215c486e2bcc29fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617057 Auto-Submit: Stefan Zager <szager@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#842633}
-
Yao Xiao authored
Use floc-accessible-since to bound the history query time range (in addition to 7-days-ago-from-now). floc-accessible-since represents the point in time from which history is eligible to be used when calculating a user's floc id. It will be reset to base::Time::Now() when a user clears all cookies, or when the browser restarts with "Clear on exit" enabled. When the floc-accessible-since is updated to be greater than the begin time of the history used to compute the current floc, invalidate the current floc. This could happen at the browser startup, or during a browser session when getting an explicit notification. We only invalidate the floc rather than recomputing, because we don't want the floc to change more frequently than the scheduled update rate. Bug: 1157383 Change-Id: I60708820b353ae3c30be6eb34fe0596a6080003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617622 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#842632}
-
Takumi Fujimoto authored
Media.Remoting.VideoPixelRateSupport - How big the video resolution is and whether it's supported Media.Remoting.Compatibility - Record various reasons why the media may not be compatible with remoting Bug: 1163944 Change-Id: I3c46662b71a7a860d6e63f6db3218c9c576d4305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605289Reviewed-by:
Jordan Bayles <jophba@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#842631}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c60dda78e4ab..002c03c4b6ed 2021-01-12 treehugger-gerrit@google.com Merge "Remove legacy flow event macros" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I144976791692c27e80ec030195215d3869c14119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623432Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/469db8fabd5f..3889691dd695 2021-01-12 zmin@chromium.org Disable ActionRunnerTest.testSwipe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1164657 Tbr: eseckler@google.com Change-Id: I2d7a0ceeed66aeacb5ba3c947baa38c2d57711b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624947Reviewed-by:
-
Jonah Ryan-Davis authored
Update ANGLE's active histograms to expire on Jun 30, 2021, and make sure they each have 2 owners. Bug: chromium:1165066 Change-Id: I78a421a54f74e7a24f889abf286c514da6f70b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622278Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#842628}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610452567-3155f81fa9ef93aecd596b942169049fc68cadb1.profdata to chrome-win64-master-1610463436-2052566ba20716214eb6d7caa0887c28794c37bd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia675d3f8c545df30f9247eba95d2926525db0c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622813Reviewed-by:
-
Daniel Hosseinian authored
Bug: 93619, 1148478 Change-Id: I7a7d46dcaa216731741dc9ab9fc83e0ac0598223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623724 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842626}
-
Min Qin authored
Saving canvas image from context menu goes through RenderFrameHost->LocalFrame->RenderFrameHost. This CL adds a boolean flag to indicate the download is actually from the context menu save. BUG=1113770 Change-Id: I404aaa4e11e19744be3fe4d11ac4413beed4c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616245Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842625}
-
Jérôme Lebel authored
The goal of this series of patches is to propagate the keychain reload flag that comes with the identity list update notification from GCRSSOService. This flag will be used by AuthenticationService to have a better signal when the identity list is updated by another Google app (when the flag is YES), or if the update comes from Chrome user actions. * crrev.com/i/3513584: Receive the flag from GCRSSOService notification =>crrev.com/c/2615421: Add support for the keychain reload flag * crrev.com/i/3470951: Switching FireIdentityListChanged(bool) method * crrev.com/c/2615538: FireIdentityListChanged() cleanup Bug: 1097080 Change-Id: I5763ed1127ba1fe1e8e79953bea321803c06953d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615421 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842624}
-
Clark DuVall authored
This has been stable on canary/dev and showed very good results in the beta experiment: go/isolated-splits-experiment The plan is to run beta/stable experiments in M89 with isolated splits disabled to get final numbers. Bug: 1126301 Change-Id: Ifc6ecbc893241b84db57545381d606a0adb1e963 Binary-Size: Increase is unavoidable and comes from symbols being Binary-Size: duplicated between dex files and resources moved into Binary-Size: base module. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612278 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
David Tseng authored
This change enables Chrome OS Chrome builds running on non-cros linux to work with Espeak-ng. On linux builds, dcheck always triggers an error in mojo. Consequently, in TtsService, where the service makes mojo calls on a Remote within the audio thread, a DCHECK was hit: 2021-01-11T22:46:32.666960Z FATAL chrome[2743839:2743847]: [sequence_checker.h(120)] Check failed: checker.CalledOnValidSequence(). #0 0x7f7ee68c681f base::debug::CollectStackTrace() #1 0x7f7ee665fd8a base::debug::StackTrace::StackTrace() #2 0x7f7ee665fd45 base::debug::StackTrace::StackTrace() #3 0x7f7ee66a9057 logging::LogMessage::~LogMessage() #4 0x7f7ee66a9769 logging::LogMessage::~LogMessage() #5 0x7f7ee6620c1b logging::CheckError::~CheckError() #6 0x7f7ee564e09c base::ScopedValidateSequenceChecker::ScopedValidateSequenceChecker() #7 0x7f7ee566c068 mojo::InterfaceEndpointClient::SendMessage() #8 0x7f7ee566c99f mojo::InterfaceEndpointClient::Accept() #9 0x565159b53c29 chromeos::tts::mojom::TtsEventObserverProxy::OnStart() #10 0x56515c4e3a5a chromeos::tts::TtsService::Render() #11 0x7f7ed8648f02 media::AudioOutputDeviceThreadCallback::Process() #12 0x7f7ed861fe9d media::AudioDeviceThread::ThreadMain() #13 0x7f7ee68fb1ab base::(anonymous namespace)::ThreadFunc() #14 0x7f7ea303fea7 start_thread #15 0x7f7ea2baad8f clone Fix this by queueing up already rendered audio buffers and processing them on the main thread's task runner. Test: manually on a linux chromeos build. Verify that web speech produces speech through Espeak. Change-Id: I4b1e5b0a6e72e4e571b5a26fde731acc57936894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621983Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842622}
-
Ulan Degenbaev authored
Bug: 1085129 Change-Id: I16ee23ac320300b2e408aca4b8a4873b1f1594ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624674 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Stephen McGruer authored
We are seeing regular hangs on bots when running 'wpt manifest' on Python 3, which is causing them to go red. Initial investigations have not been able to locate a root cause (other than the upgrade), so to stop the bleeding lets switch back to Python 2 for now. This is not a long-term fix, just a bandaid. WPT is going to Python 3 only in ~Feb 2021, and will start introducing breaking code changes. If we cannot resolve the issue here, we will end up stuck on old WPT tooling forever (which is very much not desirable!). Bug: 1161274 Change-Id: I7cef267d7b4f725a2069950852c75fa4fc009fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623816 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842620}
-
Martin Kreichgauer authored
The CrOS side of this isn't yet implemented, but we can just set these fields already anyway. Bug: b/165724836 Change-Id: Iee100d6f160bb3a749c913e9df7b0cdd1c4ff524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568683Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#842619}
-
Sathya Gunasekaran authored
Instead of using the default arguments of v8::ConstructorBehavior::kAllow and then immediately calling FunctionTemplate::RemovePrototype, this patch changes the FunctionTemplateInfo::New to pass in the correct value for v8::ConstructorBehavior. There is no change in observable behavior with this patch. In the future, this change will allow v8 to correctly cache only the instantiable templates (crbug.com/v8/11284) improving performance of this template cache. Bug: v8:11288 Change-Id: I0392fd83fbeeb5a0363d75742bcae9a5239ac715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616412Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#842618}
-
Josh Nohle authored
1. Only emit the receive-message metrics and logs if the callback has not already been invoked. 2. Record a fast-path-ready notification as a receive-message success. 3. Clarify receive-message histogram summaries to indicate that the metric records the result of opening the receive stream, i.e., starting to receive messages, not a result for every message receipt. 4. Add metrics and logs to track send- and receive-message OAuth token fetches. Manually verified logs and histograms. Fixed: 1164009 Change-Id: I2a064cae444ec890971db40b15c93c713e32565c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619628 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842617}
-
Nicolas Ouellet-Payeur authored
ScopedProfileKeepAlive is not meant for use with OTR profiles, so this caused a failed DCHECK() when a downloading a file in Incognito (with DestroyProfileOnBrowserClose=true). Bug: 88586 Change-Id: I1aff2cadf62ab1bd56a0b44e9154d6843f92cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622873Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#842616}
-
Charlie Reis authored
The NEW_PAGE, EXISTING_PAGE, and SAME_PAGE names are confusing because they refer to NavigationEntries rather than pages. For example, NEW_PAGE is used for same-document main frame navigations, which create a new entry but not a new page. This CL mechanically renames them to NEW_ENTRY, EXISTING_ENTRY, and SAME_ENTRY. Bug: 1164466 Change-Id: Idb0bfa4de08a69f55088b248a9b05619dd17cca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618392Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842615}
-
Gavin Williams authored
When the first option in the select is hidden, even though the option won't be shown in the dropdown list, its text still appears as the selected option in the dropdown. Moving the |noScannersText| option to after the list of scanners allows the first scanner to replace |noScannersText| as the selected value when loaded. Bug: 1059779 Change-Id: Ic06363e55d082fe758a6ae04ddbe4e7206841f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622894 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#842614}
-
Yuheng Huang authored
Add tab_search:measure_memory:before and tab_search:measure_memory:after to measure memory before/after open tab search. Add tab_search:clean_slate to benchmark tab search without any traffic. Bug: 1099917 Change-Id: I748609a91af8866c9814ff0cf2a17e92dd197d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622951Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#842613}
-
Jordan Demeulenaere authored
This CL merges multiple details into a single block, with the details separated by a line. See b/174652960#comment16 for screenshots. Bug: b/174652960 Change-Id: Ia562ec600b513a120b503c8f7ffa676124089749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611096 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#842612}
-
Yulun Wu authored
Bug: 1139478 Change-Id: I9fd0a87bcc2086e27a5c4b3b6c025c2ff4065dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623672 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842611}
-
Anastasia Helfinstein authored
Per the bug filed by our UX designer, update the preview focus ring to have a solid inner ring, and a dashed outer ring with 4dip dashes and 2dip gaps. Since Switch Access is the only application of the DASHED focus ring style currently, I modified that style directly, rather than creating another new style. Bug: 1152610 Change-Id: If61810ed594e7f388a8cbf71aaa41a44c2ed3cb6 AX-Relnotes: Dashed focus ring in Switch Access now has a different style. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622757Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#842610}
-
Owen Min authored
Bump the expire date to 2022-02-01 Bug: 1165249 Change-Id: Ifb567252ac93f21073d16019adbed1b3c9622bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622993Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81d005b6696c..767ed2f6b642 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com Change-Id: I0a20a271d883525e958b9ad30faa6f555a566609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842608}
-
