GitLab

BUG=470391

Review URL: https://codereview.chromium.org/1090033002

Cr-Commit-Position: refs/heads/master@{#325519}

Rename the OWNER file to OWNERS so that presubmit reads it.

BUG=

Review URL: https://codereview.chromium.org/1093683002

Cr-Commit-Position: refs/heads/master@{#325518}

This reverts https://codereview.chromium.org/914363002 completely.
Some of the changes have already been reverted in
https://codereview.chromium.org/1008683002.

R=dalecurtis@chromium.org
BUG=457280

Review URL: https://codereview.chromium.org/1098503002

Cr-Commit-Position: refs/heads/master@{#325517}

Review URL: https://codereview.chromium.org/1086183003

Cr-Commit-Position: refs/heads/master@{#325516}

This CL maps an  ONC property for setting per-network roam threshold.

BUG=chrome-os-partner:38681
TEST=Expanded test ONC and JSON test sets

Review URL: https://codereview.chromium.org/1087353002

Cr-Commit-Position: refs/heads/master@{#325515}

In GLX, most of the drivers can cope with both PBuffer and Surfaceless modes
for offscreen rendering. In EGL though, Intel driver only works with
Surfaceless.

This CL changes all hardware platforms to use Surfaceless by forcing a zero
size GL surface initialization. Ozone-GBM wasn't previously working because of
that but now works fine.

BUG=423481
TEST=gpu_perftests on GBM

Review URL: https://codereview.chromium.org/1086703007

Cr-Commit-Position: refs/heads/master@{#325514}

BUG=467287
R=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1095653002

Cr-Commit-Position: refs/heads/master@{#325513}

base/strings: Remove an unnecessary UTF8 check from one of the trim functions

gtest's message often use leading whitespace in a way that's visually meaningful. Some examples:

======== EXPECT_EQ(this, this+1);
my_test.cc(2048): error: Value of: this+1
  Actual: 24F8B8D4
Expected: this
Which is: 24F8B8A0
========
======== EXPECT_EQ("AA\nBB\nDD", std::string("AA\nXX\nDD"));
my_test.cc(2049): error: Value of: std::string("AA\nXX\nDD")
  Actual: "AA\nXX\nDD"
Expected: "AA\nBB\nDD"
With diff:
@@ -1,3 +1,3 @@
 AA
-BB
+XX
 DD
========

Today leading whitespaces are stripped out by the test launcher, leading to less readable test stdout on the bots (and headaches, especially, if the 'AA' value in the example above had leading whitespace itself -- which is how I noticed this).

The current whitespace trimming seems to be an accidental effect of [https://codereview.chromium.org/324893004], so it should be safe to change back.

BUG=475265

Review URL: https://codereview.chromium.org/1081493002

Cr-Commit-Position: refs/heads/master@{#325512}

create_nmf should determine the root of the SDK relative
to its own location.

The exception to this is when its run as part of the
chrome build, when it is not yet installed.  In this
case we pass --no-default-libpath and --objdump to
create_nmf to remove any use of the SDK root.

This is the second attempt at landing this change.
The first one was reverted:
https://codereview.chromium.org/737653003

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
BUG=none

Review URL: https://codereview.chromium.org/1066823003

Cr-Commit-Position: refs/heads/master@{#325511}

BUG=477556

Review URL: https://codereview.chromium.org/1081073004

Cr-Commit-Position: refs/heads/master@{#325510}

This make the API more consistent with RefCountedMemory and
other discardable memory interfaces such as SkDiscardableMemory.

Also improves readability by replacing memory->Memory() calls
with memory->data() calls.

A handy method is also added to simplify calling data() with a
reinterpret_cast. This is also consistent with RefCountedMemory.

BUG=

Review URL: https://codereview.chromium.org/1094433002

Cr-Commit-Position: refs/heads/master@{#325509}

In the FrameTree unittests, illustrate the liveness of frames in the ASCII
dumps. Update some tests so that children aren't born to dead parents.

BUG=474231

Review URL: https://codereview.chromium.org/1070553005

Cr-Commit-Position: refs/heads/master@{#325508}

1. Increasing hard-coded estimates to fix stalls in low fps YouTube videos
2. Moving video to use max duration to avoid stalls.
3. Adjusting estimates in SourceBufferRange upon future appends.

*More on hard-coded estimates*
The hard-coded video duration estimate was changed from 42ms (24fps) to 63ms (16fps). While 42ms is more common than 63ms, both are just wild guesses and 42ms was causing low framerate videos (12fps and lower) to stall by incorrectly triggering gaps in the MSE buffered range. 63ms will prevent these gaps for video as low as 8fps. To the extent that 63ms favors over-estimation, this is mitigated by the adjustments in SourceBufferRange.

*What about audio*
This CL lays the foundation for a similar change to audio's estimation. I'm splitting them up to keep the size reasonable.

Internal Google bug: b/18090240

Review URL: https://codereview.chromium.org/1018373003

Cr-Commit-Position: refs/heads/master@{#325507}

The "mojo" target depended on //ui/gl:gl transitively through a few dependencies. However when building it, libEGL etc don't get built. This works with deps but not data_deps.

BUG=477104

Review URL: https://codereview.chromium.org/1059963006

Cr-Commit-Position: refs/heads/master@{#325506}

chrome.mdns API and chrome://devices already works this way
This may trigger some Windows Firewall allerts.

BUG=349645

Review URL: https://codereview.chromium.org/1087003002

Cr-Commit-Position: refs/heads/master@{#325505}

R=jgm@google.com, rkc@chromium.org

Review URL: https://codereview.chromium.org/941593002

Cr-Commit-Position: refs/heads/master@{#325504}

TransformTree::CombineTransformsBetween is modified to compute the
combined transform between source and destination directly (without
walking the path) when the destination and all its ancestors are
flat. A unit test is added to validate the patch.

BUG=475636
TEST=passes all the unit tests along with the one added to validate the
patch. Telemetry test on poster circle page shows improvement in
performance. The draw_properties.tough_compositor:CDP_reduction percentage
improved from -287.82% to -149.36%.

Review URL: https://codereview.chromium.org/1096493002

Cr-Commit-Position: refs/heads/master@{#325503}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3cf1422..97a4012

TBR=dcheng@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/1091083002

Cr-Commit-Position: refs/heads/master@{#325502}

The corresponding desktop CL: https://codereview.chromium.org/1090753002

BUG=NONE
TEST=Building html_viewer from scratch also builds the network service.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1097503002

Cr-Commit-Position: refs/heads/master@{#325501}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bdb0bf5..9c79820

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1098463002

Cr-Commit-Position: refs/heads/master@{#325500}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/4e4d540...4e772b9

BUG=

Review URL: https://codereview.chromium.org/1087243003

Cr-Commit-Position: refs/heads/master@{#325499}

This CL moves the ownership of NavigationRequests from a map in NavigatorImpl
to the FrameTreeNode. This ensures that NavigationRequests are unique per
FrameTreeNode and are also properly deleted on destruction of the
FrameTreeNode. It also makes it easier to have PlzNavigate adapt to the
refactoring of DidStart/StopLoading happening in
https://codereview.chromium.org/1080143003/.

BUG=439423

Review URL: https://codereview.chromium.org/1080073004

Cr-Commit-Position: refs/heads/master@{#325498}

This CL adds the DBus bindings needed to be able to host BLE advertisment
objects and register those advertisements with BlueZ.

R=armansito@chromium.org, jamuraa@chromium.org
BUG=466375

Review URL: https://codereview.chromium.org/1052363005

Cr-Commit-Position: refs/heads/master@{#325497}

Reason for revert: breaks some keyboard layouts (crbug.com/473932)

BUG=473932
TBR=oshima@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/1094693002

Cr-Commit-Position: refs/heads/master@{#325496}

Standard functions for people to check if content from an origin can be
considered to have been transferred to the browser securely, as defined in
https://www.w3.org/TR/powerful-features/#is-origin-trustworthy.

BUG=362214,470142

Review URL: https://codereview.chromium.org/1049533002

Cr-Commit-Position: refs/heads/master@{#325495}

This is a regression from https://codereview.chromium.org/953233002

BUG=475939

Review URL: https://codereview.chromium.org/1078123002

Cr-Commit-Position: refs/heads/master@{#325494}

Multi-line Python regex's with inner python comments was breaking sublime
text's syntax highlighting.

BUG=NONE

Review URL: https://codereview.chromium.org/1091063002

Cr-Commit-Position: refs/heads/master@{#325493}

This patch includes the changes that enables <webview>.addContentScript/removeContentScript API  work on extensions.

This is the first patch in a series of patches:
1) Implement <webview>.addContentScript/removeContentScript API [1] (https://codereview.chromium.org/959413003)
2) Implement <webview>.addContentScript/removeContentScript API [2] (https://codereview.chromium.org/1056533002)
3) Implement <webview>.addContentScript/removeContentScript API [3] (https://codereview.chromium.org/1058113002)

TBR=asvitkine@chromium.org
BUG=461052

Review URL: https://codereview.chromium.org/959413003

Cr-Commit-Position: refs/heads/master@{#325492}

Code that interacts with device/usb often lives on the UI thread. As
with the recent migration of device/hid (issue 422540) moving ownership
of these classes to the UI thread makes calling code substancially
simplier. Blocking operations are handled internally by posting tasks
to the FILE thread and returning a result to the UI thread
asynchronously.

This change paves the way for replacing libusb with platform-specific
implementations of these classes that may have different thread usage
requirements (as is the case in the device/hid code).

BUG=427985

Review URL: https://codereview.chromium.org/980023002

Cr-Commit-Position: refs/heads/master@{#325491}

BUG=472672

Review URL: https://codereview.chromium.org/1057553003

Cr-Commit-Position: refs/heads/master@{#325490}

Whitelist the chrome history page so that it can trigger starting up the sync
engine. It gets special treatment since it's where the other devices UI lives.

BUG=476678

Review URL: https://codereview.chromium.org/1062013003

Cr-Commit-Position: refs/heads/master@{#325489}

BUG=455694

Review URL: https://codereview.chromium.org/1056213003

Cr-Commit-Position: refs/heads/master@{#325488}

The previous usage of Log required layers and components to
redefine Log classes and have them declare log instances. This was
not convenient and made base packages needlessly aware of specialized
layers.

This approach has the callers specify the group tag at every call, removing the need to get any sort if logger instance.

BUG=472152

Review URL: https://codereview.chromium.org/1080543002

Cr-Commit-Position: refs/heads/master@{#325487}

It makes it possible to tell if the GPU process is stuck waiting
for a DRM device to authenticate.

BUG=476728

Review URL: https://codereview.chromium.org/1086353003

Cr-Commit-Position: refs/heads/master@{#325486}

Review URL: https://codereview.chromium.org/1061433003

Cr-Commit-Position: refs/heads/master@{#325485}

This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.

Original CL (reverted for unrelated failure):
https://codereview.chromium.org/1043343002/

BUG=430115
TBR=michaelpg, pneubeck, mpearson@chromium.org

Review URL: https://codereview.chromium.org/1091043002

Cr-Commit-Position: refs/heads/master@{#325484}

Revert of Fix errors found in Mac gn component builds (patchset #10 id:180001 of https://codereview.chromium.org/1087873003/)

Reason for revert:
Suspected of breaking Mac GN, see https://codereview.chromium.org/1087873003

Original issue's description:
> Fix errors found in Mac gn component builds
>
> Mac gn component build fail because of missing frameworks and missing some other
> dependencies, and occasionally file list out of sync with the gyp counterpart:
> http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_dbg/builds/321/steps/compile/logs/stdio
>
> For instance, the frameworks linked in the components that sync depends on is not
> automatically linked into sync, thus revealing the issue.
>
> Committed: https://crrev.com/ae8297db22a6ca96652d42bd0cdc3deff17aba4a
> Cr-Commit-Position: refs/heads/master@{#325479}

TBR=dpranke@google.com,dpranke@chromium.org,brettw@chromium.org,avi@chromium.org,toyoshim@chromium.org,piman@chromium.org,pavely@chromium.org,dalecurtis@chromium.org,jiangj@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1089773003

Cr-Commit-Position: refs/heads/master@{#325483}

The [data_]deps of source_set dependencies aren't built.
The group target type works as I'd expect; see bug for details.

This is still a GN bug(?) workaround, but a cleaner one.

BUG=477104
TEST=Building mojo/services/html_viewer:apptest builds mojo_shell
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1053493003

Cr-Commit-Position: refs/heads/master@{#325482}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1095433005

Cr-Commit-Position: refs/heads/master@{#325481}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d352e4a..3cf1422

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/1089393003

Cr-Commit-Position: refs/heads/master@{#325480}