- 31 Oct, 2019 40 commits
-
-
Elly Fong-Jones authored
*_mac* matches (eg) common_param_traits_macros.h :) Bug: None Change-Id: Ibb573d8a98eb2ecf13b7946fe7f5616cfd07384b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893351Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#711273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46a4db6c. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I93f79df26f9980eb0917bca8d5d499dd22259647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711272}
-
Leo Zhang authored
Download LMs based on the lang of IME. There is a clenaup issue after downloading, check b/143685131 TBR=dvallet@chromium.org,shend@chromium.org TEST=it-IT,en-GB Bug: 946913 Change-Id: I2e963f294b603d264fd9577b49e1fd902f6d853a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893471Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711271}
-
Olivier Li authored
Improve comments for ExtensionWebRequestApiTest.WebRequestApiDoesNotCrashOnErrorAfterProfileDestroyed Original comments were a little incorrect. Change-Id: Icb52d1e83ae176be5b019ec9b5874e9193f72c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887430Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#711270}
-
Mohamed Heikal authored
android-binary-size trybot has been updated to fail if expectation files are changed even if they dont break the build. This cl now stops breaking build. Bug: 1011227 Change-Id: If563429a800c29c8c4e50735fe1211d9fc7ed4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890727Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711269}
-
Ulan Degenbaev authored
This fixes a stale pointer in the following scenario: 1) We have a JS object A in the young generation of V8's heap. 2) A Blink object B points to A via v8::TracedReference. 3) Incremental unified heap GC starts. 4) A V8 Scavenge happens during the unified heap GC and discovers that object A is reachable only via the v8::TracedReference. It checks whether the object can be collected using IsRootForNonTracingGC, which returns false. 5) Object A is collected by the Scavenger and object B points to a free region (i.e. it has a stale pointer to V8's heap). 6) Object B is traced and the stale pointer is reported to V8 and added to V8's marking worklist. 7) Next Scavenge crashes when it tries to update the marking worklist. Bug: 1019839 Change-Id: I6f5ae2e21273cdd3ea4150ceb0f70fe33eeb2614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893255 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711268}
-
Frank Tang authored
Roll the ICU cherry pick https://github.com/unicode-org/icu/pull/902 Bug: chromium:1014272 Change-Id: Ic16eba93942eed279fe649f708f916a0bd359f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892579Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711267}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c93b3dec290..1ce01db4f59d git log 1c93b3dec290..1ce01db4f59d --date=short --no-merges --format='%ad %ae %s' 2019-10-31 perezju@chromium.org Revert "[Telemetry] Stop doing metric computation." Created with: gclient setdep -r src/third_party/catapult@1ce01db4f59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349,chromium:1019888 Change-Id: I6e93446842c0a123ee133c4e7709f584a1b4c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893393Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711266}
-
Mike Wittman authored
Provides API support for specifying an optional user-defined key along with the metadata name. This can be used to distinguish samples based on additional state beyond just the name -- e.g. execution in service of different tabs within the same renderer process. Uploading of the key state with the samples will be implemented in a following CL. Bug: 976864 Change-Id: Ib924be48a816e65e83976c34e27efea19da61925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891112Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711265}
-
Peter E Conn authored
For CCTs (and TWAs) to have a "bring tab to front" functionality, we need an Intent provided by the client that will launch in the client's Task. The client should provide an Intent to an Activity that immediately exits. This way the Task will be brought to the foreground with the CustomTabActivity visible. There are a few cases that this method breaks down. First, the client may have another Activity on top of the Custom Tab - in this case that Activity will be brought to the foreground instead. We deem this to be acceptable as it is unlikely to happen often and still brings the user into the context of the app. (Note that this method won't be called if there is no currently running CustomTabActivity.) Another case is that the client provides an Intent that does not simply exit. There is little we can do to check for this case. Bug: 989908 Change-Id: I8dc5384b4631c7a0c895114621e4810cffb21259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849682 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711264}
-
Chris Harrelson authored
The MapToVisualRectInAncestorSpace fast-path needs a LayoutObject with LocalBorderBoxProperties set, so that it can call into GeometryMapper. If the start LayoutObject does not have one, it proceeds up the containing block chain until it finds one, and uses the FirstFragment() of the resulting LayoutObject. This is wrong in cases where there multiple fragments on the LayoutObject, because we don't know which one to choose. In such cases, fall back to the slow path. Bug: 999551 Change-Id: I887c15c3acbe41432b2ca64e5a1551f3765a5043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892058 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711263}
-
Alice Wang authored
This CL fixes tests of BookmarkPersonalizedSigninPromoTests on tablet. TBR=twellington@chromium.org Bug: 789531 Change-Id: I04a49042104bcbdf1b0add9a6a9bd88d819cb8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893259 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711262}
-
Mohamed Heikal authored
In furtherance of possibly putting a limit on additional native relocations added to the binary. A count of native relocations is now included in the metadata of the .size file. This reverts commit 936b6478. Reason for reland: this cl works on 64bit elf files. Original CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1879504 Bug: 1012373 Change-Id: I47c7fc8e73b6ad05d3ecd9dfd235f8904e9d7c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889946Reviewed-by:
-
Roman Sorokin authored
Bug: 504928 Test: run locally Change-Id: I74ffe767d95e2b47a5fbad87a4685bd31e01180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891312Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711260}
-
Koji Ishii authored
Following bot results are included. 100 101 102 103 104 111 114 109 112 115 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I0a76bfda86eb0db80b545f26ce5016832fbe8bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888243Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#711259}
-
Mehran Mahmoudi authored
This is the third part in a series of CLs for moving the AddToHomescreen component to MVC in Android. In this CL the AddToHomescreenInstaller and AddToHomescreenParams classes are added. AppBannerUiDelegateAndroid and AddToHomescreenManager classes are edited to use these new classes. Design doc: http://go/a2hs-mvc A subsequient CL will implement the coordinator and the mediator classes and remove the AppBannerUiDelegateAndroid and AddToHomescreenManager classes. Bug: 994759 Change-Id: Iaaa0b714d4aac9c3d348348a972b937bdaa246c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864568 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711258}
-
Etienne Bergeron authored
The PUA (Private Use Areas) codepoints are not assigned by unicode. They can be used with an hardcoded font to display custom made glyphs. This feature is not used in chrome and will lead to fallback fonts. based on https://chromium-review.googlesource.com/c/chromium/src/+/829378 see http://crbug.com/795225 see: https://en.wikipedia.org/wiki/Private_Use_Areas Bug: 1018378 Change-Id: I4b218336dba859eda2729bc9668d866e4ec03211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887531 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#711257}
-
Roman Sorokin authored
Bug: 396352 Test: run locally Change-Id: I210e3ae974ca0170e2cc04838c1c15628baa74bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892777Reviewed-by:
-
Gauthier Ambard authored
OmniboxWidth and OmniboxWidthBetween are moved to the egtest.mm file directly to avoid having a more complicated interface. Suggestions() uses are replaced by -addNumberOfSuggestions: additionalSuggestionsURL:. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1871888 Bug: 987646 Change-Id: I7c5136c6cce3e7a62666e2e478b6819b3aad970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887871Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#711255}
-
Arthur Hemery authored
org.chromium.chrome.browser.FeaturesAnnotationsTest.* could not be run by any bot enabling or disabling custom features. It now filters flags, only using the ones that are relevant in the test. Change-Id: Ia1628ebd038db83d5e8ebab1c1a1a391b71e8b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890414 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#711254}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/133be10311f8..5e6be1d627e9 git log 133be10311f8..5e6be1d627e9 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 sugoi@google.com Provoking vertex feature support enabled Created with: gclient setdep -r src/third_party/angle@5e6be1d627e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I6987f99e79d9a42df79c0e1a4cc80dcbbd672fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893180Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cd154b2c0ca..aae0b57ab143 Created with: gclient setdep -r src-internal@aae0b57ab143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1a7fa7f6d40742d3e4225adacbc7d0d2df7276f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893181Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711252}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9c82eb913f44..904cac856785 git log 9c82eb913f44..904cac856785 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 brianosman@google.com Use SkYUVMath in GrYUVtoRGBEffect Created with: gclient setdep -r src/third_party/skia@904cac856785 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: Id3dd4e6bb62acdc8a536f7c5c51ecdcb8593faa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893178Reviewed-by:
-
Olivier Robin authored
Bug: 987646 Tbr: eugenebut Change-Id: Id2af6bb88a61567a113b82e33eddb2645a3ee4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890039 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Mohamed Abdelhalim authored
This moves WILL_START_REQUEST and CANCELING to NavigationRequest::NavigationState. And removes INITIAL and uses navigation_handle_id instead. Bug: 916537 Change-Id: Ibe078a9d2947adb5baead6c5d499d79a7fff201f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816507Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711249}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de365955dc6a..159b417c9827 git log de365955dc6a..159b417c9827 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 jakobi@webrtc.org Keep the video send stream alive if the encoder drop frames. 2019-10-31 mbonadei@webrtc.org Add RTC_EXPORT_TEMPLATE_{DECLARE,DEFINE} macros. Created with: gclient setdep -r src/third_party/webrtc@159b417c9827 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I03861a202b35cf07aaf185a7e940a24a78f1562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893177Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fcfd69546437..b094d526c20b git log fcfd69546437..b094d526c20b --date=short --no-merges --format='%ad %ae %s' 2019-10-31 treehugger-gerrit@google.com Merge "Increase trace duration of runtime HeapprofdCtsTest." Created with: gclient setdep -r src/third_party/perfetto@b094d526c20b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idfb00c6216972eeb145e614ad483f1dd833f76e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893175Reviewed-by:
-
Xida Chen authored
The reason for the crash and the reason for the flaky layout tests are the same, we didn't check the |layout_object| in that function. Locally when I run the flaky layout tests, I can get at least 1 crash every 10 runs. With this CL, I got no crash with 20 runs for each test. Bug: 1018027, 1018596 Change-Id: Ib9113324d42950f280ef0125b34e453db1427282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883621Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711246}
-
Armando Miraglia authored
TBR=caseq@chromium.org Bug: 1020046 Change-Id: I4cac925b8de98484b030966719f71b72550f5e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893280 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711245}
-
Owen Min authored
When default search provider is disabled by the policy, user can still press the touch bar search button to enter URL in the omnibox. Add a text to the button for better UX. Bug: 1011260 Change-Id: I6d35f853336c567f260579a1ee7d54e9b640a8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891331Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711244}
-
Rohit Rao authored
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/6791abc9c696..8fbc948c8479 $ git log 6791abc9c..8fbc948c8 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 tirodkar Keyboard tutorial fix for iOS 13 iPads. 2019-10-25 tirodkar Rolling back iOS 13 fix. 2019-10-25 tirodkar Duplicate Matcher for UITextField iOS 13 fix. 2019-10-24 tirodkar Revert back UIKeyboardImpl check 2019-10-24 tirodkar Automartion Setup related Cleanups. 2019-10-24 tirodkar UIWebView deprecation. 2019-10-23 sskhandp Use variable to store sharedInstance and reuse. 2019-10-23 tirodkar Cleanup of semi-colon. 2019-10-22 tirodkar Fix rotation from UIDevice to XCUIDevice. 2019-10-22 tirodkar iOS 13 System Alert fixes. 2019-10-21 tirodkar Fix build 2019-10-21 tirodkar Internal 2019-10-16 tirodkar Fix failure. 2019-10-16 tirodkar Internal Change. 2019-10-15 tirodkar Remove UI_USER_INTERFACE_IDIOM completely. 2019-10-15 tirodkar UI_USER_INTERFACE_IDIOM/UIDevice. 2019-10-10 tirodkar iOS 13 Stepper fix. 2019-10-09 tirodkar Disambiguate name 2019-10-07 tirodkar Fix GREYWaitFunctions compilation failure. 2019-10-07 tirodkar Support description glossary in non-tactile actions 2019-10-06 sskhandp Fix some documentation. 2019-10-04 tirodkar Config Cleanup by rm'ing unused method and expanding check. 2019-09-17 tirodkar CocoaPods Setup Doc link. 2019-09-11 tirodkar Spelling fix. 2019-09-09 tirodkar Expose app to idle api. 2019-09-06 tirodkar Fix. 2019-09-06 tirodkar Remote Executor Refactor 2019-09-05 tirodkar Move automation setup to the test. 2019-09-04 tirodkar Rm unused private method interface. 2019-09-03 tirodkar Search Action Error cleanup. 2019-09-03 tirodkar Delete grey_performSearchActionWithError: 2019-08-30 sskhandp Minor formatting. 2019-08-28 tirodkar Move NestedErrorMake to the AppFramework. 2019-08-27 mobile-devx-github-bot Experiment for temporarily fixing the flakiness on visibility checker. 2019-08-27 tirodkar System Alert Cleanup. 2019-08-26 tirodkar Added App side check to System Alerts. 2019-08-26 tirodkar System Alerts Stability Update 2019-08-21 mobile-devx-github-bot Added helper method to get windows above a given window, including itself. 2019-08-21 tirodkar Remove alpha blurb. 2019-08-20 mobile-devx-github-bot GREYUIWindowProvider making the parameters nonnull and adding light weight generics. 2019-08-20 tirodkar Shake API iOS 13 fix. 2019-08-19 tirodkar Docs update. 2019-08-19 mobile-devx-github-bot Optimizing visibility checker by only drawing portions necessary for screenshots. 2019-08-19 tirodkar Project on Device bitcode fix. 2019-08-19 tirodkar Add shake device to EarlGrey.swift. Created with: roll-dep src/ios/third_party/earl_grey2/src Change-Id: I09ff68dce97ae7a4271c35d4e85ff6c0690529a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892157Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#711243}
-
Henrique Ferreiro authored
blink::WebNativeScrollBehavior is only used in //third_party/blink/renderer/core. Move it to //third_party/blink/renderer/core/page/scrolling/scroll_state_callback.h as blink::NativeScrollBehavior. Bug: 919392 Change-Id: I8dac59f7b1a778508ee7c1dbed5abdf15f0e371a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886677 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711242}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ac12db7d..287957ea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1227c76b1e8ad63d5364c192e3cdba47dafa6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893291Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711241}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib07f7d22f6b5d64e7d3e83e16c38ae304f34d7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887210Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711240}
-
Peter E Conn authored
Bug: 1890430 Change-Id: I9acbc480aab5a8ef520a0c8e5e0761eccf851cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890411 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 268984 Change-Id: I6bfa723fed79ef8d371b33a53595273237f3e3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891584Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#711238}
-
Christopher Cameron authored
A WebContentsViewCocoa can have several RenderWidgetHostViewCocoas added as subviews. Each view, when added as a subview, in the function WebContentsViewMac::CreateViewForWidget, is put behind all other subviews (in contrast to the default behavior of -[NSView addSubview], which puts the new subview in front). The analogous code in the app shim, in the function RenderWidgetHostNSViewBridge::SetParentWebContentsNSView, orders the subviews in the default way, which does not match the behavior of the browser. As a result, the NSView ordering can get messed up, resulting in un-clickable contents. This is vaguely similar to the issue in crbug.com/859834, which also involve the login page. The login page hits these sorts of bugs because RenderWidgetHostViewMacs are added to a single WebContentsViewMac at the login page. Bug: 1017446 Change-Id: I11425603b258b47e84c6e3df55ec966cf5246191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892577Reviewed-by:
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 Change-Id: I09d5fe93f6ed0620087b9360a6922ff919221e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891191Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#711236}
-
A Olsen authored
Ping does not have a particular success URL - it just redirects back to the "returnurl" on success. We can detect this if we listen for a POSTed request to the password change URL, and then for a response that redirects us to the returnurl, and not back to the password change URL again. This involves listening for redirects, not just URLs - since visiting the returnurl normally would not mean success. I have modified all such success detection attempts to listen for redirects - even when we have a success URL to listen for eg "?status=0" - it is a bit more certain to listen for a redirect *from* the password change URL *to* the success URL, instead of just listening for a visit to the success URL by itself. Bug: 930109 Change-Id: Idfd081a603ca402367de774f6253e4af9b84bbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878489Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711235}
-
Thomas Tangl authored
Sync paused: - Show text "Not signed in" instead of email - Remove "Manage your Google Account" button Signin or sync disallowed: - Remove sync info section Bug: 1020146 Change-Id: I853d52f3e586a74414b7e368e4cb73f9e617b172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893277Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#711234}
-
