- 06 Feb, 2018 7 commits
-
-
Greg Kraynov authored
Accessing destructed field is undefined behaviour. Bug: 807631 Change-Id: I88ac60b1b5ffe1a96e3f5a885527cba07d31652b Reviewed-on: https://chromium-review.googlesource.com/901882 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534547}
-
Michael Thiessen authored
The NTP omnibox doesn't work in VR because we don't support keyboard for Android Java UI elements. We also have a separate omnibox below the content window in VR, so the one on the NTP is redundant. Bug: 767988 Change-Id: I17fc2a81da20bac4b4effa279876a093c76ddad5 Reviewed-on: https://chromium-review.googlesource.com/899465Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#534546}
-
Florin Malita authored
The computed background geometry tile size may end up empty due to pixel-snapping. In that case, all derived calculations are invalid and we should not attempt to draw the background. R=schenney@chromium.org BUG=808065 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If14ea82ca158318374296184a8f44856c19dcb64 Reviewed-on: https://chromium-review.googlesource.com/902148Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#534545}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: If8ac718ae98c79b3a198342bdf6b64a8c08fd054 Reviewed-on: https://chromium-review.googlesource.com/902821 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#534544}
-
Tommy C. Li authored
Bug: 794201 Change-Id: I00e8041f87cc7ecc4846d7e8dba812a498f816c9 Reviewed-on: https://chromium-review.googlesource.com/902803Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#534543}
-
Peter Kasting authored
Also makes this error about deprecated functions into a warning. The problems with using these are not so severe they should block uploads. BUG=none TEST=none Change-Id: I94e6cc900e23d8f3371aace9386a80829906083b Reviewed-on: https://chromium-review.googlesource.com/902448Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#534542}
-
Hwanseung Lee authored
CSSSkewX and CSSSkewY was added in spec. because result of "skew(X,Y)" is different from "skewX(X) skewY(Y)". first of all, CSSSkewX was added at this CL. and CSSSkewY is going to add at next patch. https://drafts.css-houdini.org/css-typed-om-1/#cssskewx Bug: 808321 Change-Id: I9214b06047f100c88999cba796d6c803545092c0 Reviewed-on: https://chromium-review.googlesource.com/899883Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#534541}
-
- 05 Feb, 2018 33 commits
-
-
Yafei Duan authored
This UI treatment includes: - Adding interfaces in Java to check whether the current tab is showing a trusted offline page. - Showing offline badge for shared pages. - Updating the strings shown in page info box when showing shared offline pages. - When showing an untrusted page, if the user focuses on the url in the location bar, remove the text. This is based on the following patch by fgorski@: https://chromium-review.googlesource.com/c/chromium/src/+/757898 Bug: 758690 Change-Id: I5bfe553433a568486c58a1a6f61867946ae67ccf Reviewed-on: https://chromium-review.googlesource.com/896793 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534540}
-
Sidney San Martín authored
This is a reland of 22e3eede. TBR=isherman@chromium.org,shimazu@chromium.org Original change's description: > Add MacMDDownloadShelf to fieldtrial_testing_config.json > > Change-Id: I00799bf180fc94b3a8b30e0a77bdc7473cf58ca4 > Bug: 589943 > Reviewed-on: https://chromium-review.googlesource.com/887385 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532044} Bug: 589943, 806901 Change-Id: I5e96a60a73806c6e2016db806c559976ec120901 Reviewed-on: https://chromium-review.googlesource.com/899115 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534539}
-
gambard authored
This CL changes the tools menu button such as it is correctly positionned and the animation is occurring in the right direction in RTL. Bug: 807285 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9cfcd86931a22f4b34e6d8a3dfc575afd50f95de Reviewed-on: https://chromium-review.googlesource.com/899364 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534538}
-
Devlin Cronin authored
App Windows are only visible to the owning application. This was loosely and ambiguously documented (and supported). Clarify the documentation. Bug: 805528 Change-Id: Ie9108da81879d277411f09755913890a123b53ae Reviewed-on: https://chromium-review.googlesource.com/900270Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534537}
-
Saman Sami authored
Send the SurfaceIds that we want evicted to HostFrameSinkManager instead of directly to CompositorFrameSinkSupport. This will allow us to do frame eviction with enable-viz. The added method takes an array of SurfaceIds to enable evicting the main frame with all its OOPIFS in one go (will happen in a separate CL). Bug: 777881 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6839f16718e9a9b169ae26d905cdade430c53d18 Reviewed-on: https://chromium-review.googlesource.com/897892 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#534536}
-
Devlin Cronin authored
Remove ChromeAsyncExtensionFunction::GetExtensionWindowController() and ChromeExtensionFunctionDetails::GetExtensionWindowController(). Each of these were never used. Additionally, the behavior is very non- deterministic, and could return any one of a number of different windows. Instead, ExtensionFunctions should fetch the appropriate window for the call (typically, through GetSenderWebContents()), rather than by relying on getting any window the extension can access. Bug: 809194 Change-Id: I00fc417cfbe4c9161f2475f50ab77fe843677faa Reviewed-on: https://chromium-review.googlesource.com/902198Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534535}
-
Sam Clegg authored
This was broken by: https://chromium-review.googlesource.com/891900 but went unnoticed because the bots were all red anyway. Turns out we acutally compile this code with many different compilers, including the PNaCl version of clang which doesn't seem to have this attribute :( CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk BUG=177475 Change-Id: Iac06aa0ba1c63a758c666d207c2495edd3352abc Reviewed-on: https://chromium-review.googlesource.com/900314 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#534534}
-
Jungshik Shin authored
$ git log c8ca296..d888fd2 --date=short --no-merges --format='%ad %ae %s' 2018-02-05 jshin@chromium.org Update IANA tzdata to 2018c 2018-01-23 digit@google.com SmallIntFormatter: simplify implementation. In JS console: > new Date(Date.UTC(2018, 9,31, 5)).toLocaleString("en", {timeZone: 'America/Sao_Paulo'}) "10/31/2018, 2:00:00 AM" > new Date(Date.UTC(2017, 9,31, 5)).toLocaleString("en", {timeZone: 'America/Sao_Paulo'}) "10/31/2017, 3:00:00 AM" TBR=mark@chromium.org Bug: 473288,802890 Test: See the above Change-Id: I341d11a5b62bd7fa2d5473575591f50060c04870 Reviewed-on: https://chromium-review.googlesource.com/902806 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534533}
-
Bill Budge authored
- The vector of partitions may iterated on one thread, while another thread is mutating it. Use a mutex to prevent that. Bug: chromium:808427 Change-Id: I4cfee3ad9adeeba6e108f8a79dd1ddef9c418de0 Reviewed-on: https://chromium-review.googlesource.com/899778Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#534532}
-
Avi Drissman authored
This modernizes the "Hung Page" dialog. BUG=767526 Change-Id: I4831ef1d3d4db92ce92d67f5e7fce34393f0f655 Reviewed-on: https://chromium-review.googlesource.com/897896Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534531}
-
Adithya Srinivasan authored
This CL renames the enum to NodeListSearchRoot to better indicate that the value refers to where the NodeList begins searching for elements. Change-Id: I09aa6732fd52cc5a476f2ea42c0fbb3b2a7e92af Reviewed-on: https://chromium-review.googlesource.com/897883Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#534530}
-
Yuzhu Shen authored
This CL uses mojo interface custom disconnect reason to send this cancellation reason to the impl side of network::mojom::URLLoader. Why we need this change? Currently the Android WebView SafeBrowsing ResourceThrottle sets a flag in the user data of net::URLRequest to indicate the request is cancelled by SafeBrowsing, and later this cancellation reason is conveyed to the Android WebView embedder. When switching to URLLoaderThrottle, we cannot directly access net::URLRequest, so we need this application-defined reason on URLLoaderThrottle::Delegate to notify the impl side of network::mojom::URLLoader. Bug: 807399 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib4e4cc0e5e346562aef4f03f6e9bacf7da0716c5 Reviewed-on: https://chromium-review.googlesource.com/897734Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Miguel Casas-Sanchez authored
This CL uses the 2020 CGColorSpaceRef when playing back high bit depth content that is labelled as having e.g. transfer function SMPTE ST.2084 [1]. (This is Mac specific because other platforms use the shaders in [2]). [1] http://go/bt.2100 , table 4 [2] https://cs.chromium.org/chromium/src/ui/gfx/color_transform.cc?type=cs&q=SMPTEST2084&sq=package:chromium&l=617 Bug: 797347 Change-Id: I943b41a8b7372f6eb641524fac85be8da58afa11 Reviewed-on: https://chromium-review.googlesource.com/896719Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#534528}
-
spqchan authored
Show toolkit-views AutofillPopupView with --secondary-ui-md. Removed AutofillPopupBaseView FocusManager accelerator code. The code is no longer necessary since it was added for a now obsolete rAc dialog. The autofill popup will get dismissed by the web contents, which listens for the accelerators. Bug: 728182 Change-Id: I9f7816fe41279a397f5066d28d88099d50ef033e Reviewed-on: https://chromium-review.googlesource.com/889983 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#534527}
-
Scott Graham authored
Bug: 707030 Change-Id: Ia61eecb9197af4040250980d8de20978b6b5739a Reviewed-on: https://chromium-review.googlesource.com/902923Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#534526}
-
Karan Bhatia authored
This reverts commit 10c92aea. Reason for revert: Changing the approach as per discussion, don't need DNR specific host permissions any longer. Original change's description: > DNR: Introduce manifest key to specify host permissions. > > This CL introduces the "hosts" key within the "declarative_net_request" manifest > key. It is used to specify a list of match patterns. These match patterns will > then be used by DNR to evaluate whether an extension has access to a particular > request for the purpose of DNR. > > The parsing of host permissions within PermissionsParser is refactored and a new > static utility method called ParseHostPermissions is introduced on the class to > parse a list of match patterns. > > In subsequent CLs, the concept of hosts for DNR will be introduced in the > PermissionsSet class and DNR will start checking these host permissions. > > BUG=777714, 696822 > Doc=go/dnr-hosts > > Change-Id: Iee31b634ce5e45c5685ad4264219cb79b70070aa > Reviewed-on: https://chromium-review.googlesource.com/888321 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533838} TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org Change-Id: I63cb84b126de6ba02d604efb4503959e3de6cef7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 777714, 696822 Reviewed-on: https://chromium-review.googlesource.com/900162Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Miguel Casas authored
Various cleanups on GpuVideoEncodeAcceleratorFactory that I stumbled upon while adding more info to the DLOG(ERROR) in CreateVEA(). Bug: 599650 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I99bfad58b82b9e87bbf224290a27bdf15f1201b2 Reviewed-on: https://chromium-review.googlesource.com/899224 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534524}
-
spqchan authored
Add support for MitM software in Dynamic Interstitials. Testing: Unit tests in SSLErrorAssistantTest Browser tests in SSLUIDynamicInterstitialTest Bug: 790850 Change-Id: If6c174d8e207bf51d34e8dcd75ffd2c284f36e05 Reviewed-on: https://chromium-review.googlesource.com/865834 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#534523}
-
Brian Salomon authored
Skia is deprecating GrPixelConfig because it can be ambiguous. Instead clients specify 3D API (GL, VK) formats when making GrBackendTextures and then SkColorTypes when making SkSurface/SkImages. Bug: skia:6718 Bug: skia:7533 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3e7c72de549394761cbb46c60e9553b33ff6656a Reviewed-on: https://chromium-review.googlesource.com/889861 Commit-Queue: Brian Salomon <bsalomon@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534522}
-
https://chromium.googlesource.com/catapult.git/+log/b1069a4b3a67..ef4265e56abb $ git log b1069a4b3..ef4265e56 --date=short --no-merges --format='%ad %ae %s' 2018-02-01 eakuefner [Telemetry] Remove ValueCanBeAddedPredicate Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I76a18c47208a7405c541dfa4107522d0faef9c72 Reviewed-on: https://chromium-review.googlesource.com/902563 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534521}
-
Nico Weber authored
R=scottmg@chromium.org Bug: 177475 Change-Id: I830c63748878cc8af7d1b52418a45fe7f05d1734 Reviewed-on: https://chromium-review.googlesource.com/899446Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534520}
-
Mustafa Emre Acer authored
The method is duplicated by sublasses. Push it to the base class instead. An upcoming CL will use this for CaptivePortalBlockingPage as well. Change-Id: Id24993df5fa0f7a0371e01ee84bf4788a196aca6 Reviewed-on: https://chromium-review.googlesource.com/902805Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#534519}
-
Fabio Tirelo authored
Bug: 803714 Change-Id: I32c55010741eb54ea22caf57eec79e3f2c38e211 Reviewed-on: https://chromium-review.googlesource.com/902584Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534518}
-
Xiaohui Chen authored
Bug: 807015 Test: compiles with ninja -C out assistant Change-Id: I66fc1bb6b3f44027b283f224841397b1d3245fc2 Reviewed-on: https://chromium-review.googlesource.com/891995Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#534517}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/966c4db5..a58470f2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3584d25d149a89bd095aa002404ccf26ac85033a Reviewed-on: https://chromium-review.googlesource.com/902224Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534516}
-
Sergey Volk authored
What happens here is similar to crbug.com/775852 - somehow an invalid track id is passed from blink level down to media pipeline and we fail to find the demuxer stream corresponding to that track id. So instead of using map operator[], we need to use map::find and check if the stream for the given track id was actually found. BUG=806871 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibbffc74046a562585d6b404f90a9ae38a0d43050 Reviewed-on: https://chromium-review.googlesource.com/902188Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#534515}
-
David Tseng authored
The desktop role gets used as the root of the entire automation tree and should not be used elsewhere. This change adds a comment in the enums file where views authors hopefully look for the list of roles. Note that in ChromeVox, using the desktop role amounts to a no-op, since ChromeVox only checks desktop role when it asks for a AutomationNode.prototype.root. TBR=tsepez@chromium.org Bug: 787101 Change-Id: I9f1b7a7a71f69f43ebc265cf0b61d0b0bdb4249f Reviewed-on: https://chromium-review.googlesource.com/896557 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch delays the recording of the translate/clip/effect until we are confident that the operations will affect anything meaningful. This eliminates the cases of save/clip/restore for example, since it skips recording these operations. Note that it also adds an early out to BoxPainterBase when we're not painting either image or color (ie transparent). Without the early out the record which is generated has a clip due to scroll adjustment, and it's hard to say with a non-empty record whether it actually draws anything. Specifically from the bug, this eliminates the sequence - save - translate - save - clip rect - restore - restore However, there is another sequence of - save - translate - restore which isn't coming from this code which still remains. R=wangxianzhu@chromium.org, chrishtr@chromium.org Bug: 795017 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id750ead924deec5d208cc9d52b8bb873d448d3e0 Reviewed-on: https://chromium-review.googlesource.com/900264Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#534513}
-
Steven Bennetts authored
The focus selector assumes there are no hidden elements. Using restamp in the dom-if templates will ensure that is true when the config dialog is opened more than once. Bug: 804239 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c0b12e5cffff218b33e7435a0268b305275e50a Reviewed-on: https://chromium-review.googlesource.com/902439Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534512}
-
François Degros authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I341d823feeb1077a8ff1a810dcda606d1ba84b20 Reviewed-on: https://chromium-review.googlesource.com/899407Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This reverts commit bc976225. Reason for revert: <INSERT REASONING HERE> Original change's description: > [PE] Recompute overflow for tables > > A previous refactor accidentally omitted delegation to the > parent class when recomputing overflow for LayoutTable. > > Bug:807900 > > Change-Id: I68c415de59162a29b642ad697e7b8ab8dc19f530 > Reviewed-on: https://chromium-review.googlesource.com/900044 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534175} TBR=chrishtr@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807900,808876 Change-Id: I9a0b6ca4dd8ae3d80990b754b997aa9cd4beb0c5 Reviewed-on: https://chromium-review.googlesource.com/902502 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Leon Scroggins III authored
Bug: 807324 An upgrade to libpng version 1.6.34 resulted in Chromium truncating some pngs. This pngs are technically incorrect, but turning this option on allows displaying them the way we previously did. Change-Id: Ib800486cbf6e28b4df028d5264f6661eda08dc4c Reviewed-on: https://chromium-review.googlesource.com/901985Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534509}
-
Junliang Yan authored
current_cpu turn out to be ppc64 instead of ppc64le Change-Id: I045598d67b25531fafa31f3de70360188d963408 Reviewed-on: https://chromium-review.googlesource.com/899642Reviewed-by:
-
