GitLab

Whenever there are multiple non-fullscreen badges, a blue dot will show
on the top right corner of the overflow badge if the menu has not been opened
yet. Once it is opened, the blue dot will disappear. The dot reappears if
a new badge is added.

A new BadgeConsumer method markDisplayedBadgeAsRead() is added to allow for the
mediator to tell the view controller when to hide/show the dot.

Screenshot: https://drive.google.com/open?id=13TMm0r1mtm_tz55hiMWkr77R0rMEijPp

Bug: 976901
Change-Id: I220cb865e117b19520c37cea2287757b46803df9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832157
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702047}

This is needed for implementing PostTaskHere and base::CurrentThread traits.
In a follow on patch SimpleTaskExecutor will be added for blink threads.

Bug: 835323
Change-Id: Ice25d2a93fc7a6a10c0a4d4e43aa82a97462e3c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832280
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702046}

TBR=khushalsagar

Bug: 995235
Change-Id: Icd9cc8165836cf97a852869e296599f887ed9a70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835197
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702045}

This fixes a slight inaccuracy in the tooltip string describing why
a cookie was blocked for being SameSite=None but not Secure.

Bug: 856777
Change-Id: I529eaa67380045fa86fd421664c2824638b851c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832522Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702044}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3dc289df..f45ddb9b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I68f290577ebefc754542902c48fb526d7107229d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835812Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702043}

Chrome OS Account Manager has been launched to Stable channel and
enabled on ToT. Cleanup the flag in Chrome signin code.

Bug: 1009960
Test: unit_tests --gtest_filter="*ChromeSigninHelperTest*"
Change-Id: I012a6967f890febba66e1ce8e19764b46e357aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833609
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702042}

It is possible an AudioOutputDevice is created
and waiting for authorization when destruction
happens. Add a stop call to ensure it gets
cleaned up.

Bug: b/141012708
Test: Local build, before/after manual testing.
Change-Id: If454095f2d3d44d20b84a9135151248372b0a574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832727Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Brett Kilty <brettk@google.com>
Cr-Commit-Position: refs/heads/master@{#702041}

Change-Id: I93162b75b817fdf8488b33009e13775da3a890df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825620
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702040}

https://android.googlesource.com/platform/external/perfetto.git/+log/1e470360678b..3ad1e2151d99

git log 1e470360678b..3ad1e2151d99 --date=short --no-merges --format='%ad %ae %s'
2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for resize of bitvector"
2019-10-02 lalitm@google.com Merge "trace_processor: add benchmark for sparsevector Get calls"

Created with:
  gclient setdep -r src/third_party/perfetto@3ad1e2151d99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I038e5dd52eac5d6a35455c700824320616040d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702039}

Following some earlier Onion Soup refactoring,
blink::PrivacyPreferences has no usage---only a couple scary
comments in renderer_preferences.mojom warning to keep fields "in sync"
with PrivacyPreferences.

This change deletes the dead PrivacyPreferences code and the scary
comments.

R=shimazu

Bug: 869748
Change-Id: If95f5da0fe40ec6507d34b8985b8c13f5685f3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833707
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702038}

This test was assuming that the iframe load event could not fire during
appendChild, which it does on Chrome. To fix this, setup the promise
before calling appendChild, but only await on it afterwards.

Bug: None
Change-Id: Ie5ebdd7cec0fe0c276621033afaa8e8a5699dad1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833902Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702037}

This reverts commit 3f622b5a.

Reason for revert: This was an improper fix. Proper fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/1835274

Original change's description:
> Fix chrome://flags search box placeholder visibility in dark mode
> 
> Default placeholder text color in input boxes was changed to a color with
> transparency, which may cause placeholder text to be unreadable by default
> if the input box background is a dark color. This change adds explicit
> styling to the placeholder color.
> 
> Bug: 1001957
> Change-Id: I7b24ab1e01a96cc5b7caa0f22ade8ab712951fe9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799997
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#696060}

TBR=asvitkine@chromium.org,blundell@chromium.org,jeffreyca16@gmail.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1001957
Change-Id: Ia470faa1c7193dbdb2643348d7c8b421e2c1b416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835276Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702036}

This CL was partially created by
//base/android/jni_generator/jni_refactorer.py.

The conversion also required converting unit tests to use the new JNI
mocking approach provided by JniMocker.

Also removed a couple of unused methods.

Bug: 929661
Change-Id: Ic34608693e7c48313512c8ef7e48943023de2af5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833078Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702035}

While waiting for "connected" state on PC2, PC1 may sometimes have
time to transit to "completed" state. This CL accepts both event
sequences.

Due to the bug on not completing, this will only happen in plan B.
Delete the mac-specific expectations files.

Bug: 997201
Change-Id: I7aab5566c7868990d840bda9afc16516cf147425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834225
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702034}

Old implementation of GetData() encrypted keystore_decryptor_token with
current default encryption key, which is wrong for backward compatible
keystore Nigori, since it uses non-keystore key as the default
encryption key. Now we always use most recent keystore key to encrypt
keystore_decryptor_token.

The old behavior shouldn't cause any issues, since it should be
impossible to reach GetData() in commit codepath, while Nigori is in
backward compatible keystore mode. But it's still better to fix, to
avoid data corruption in case it overlaps with other bugs and to not
violate invariants.

Bug: 922900
Change-Id: Ic2455b5e1875cb18c4a9278598999dc47025bc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834081Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#702033}

The user is likely to try re-entering their passphrase, so ensure
focus stays in the input field.

Convert the Print Preview PIN settings element to use the same
approach to focus, so callers aren't depending on internal
implementation details of cr-input.

Bug: 805829
Test: See bug. sign in to account with sync passphrase, enter
  incorrect phrase, focus returns to input field. Tested with both
  Chrome OS and Linux.

Change-Id: I012f5b5368654c8b0f36b66f9fd07124d394c9a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832632Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702032}

https://chromium.googlesource.com/angle/angle.git/+log/8c3bb48f5870..f03259ad7205

git log 8c3bb48f5870..f03259ad7205 --date=short --no-merges --format='%ad %ae %s'
2019-10-02 courtneygo@google.com Vulkan: lineloop support for DrawElementsIndirect
2019-10-02 ianelliott@google.com Vulkan: Divide 3188 KHR failures into 2 known root causes + cleanup.

Created with:
  gclient setdep -r src/third_party/angle@f03259ad7205

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@google.com

Bug: None
Change-Id: I7d40b569c62dfcb74a3a32704a6d51f0849b8ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834975Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702031}

To aid debugging data loss issues.

Bug: 914092, 1008424
Change-Id: I06b91acd892970b6bba251c1893247debf61b16a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835577Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702030}

- device_last_updated is unused after https://crrev.com/c/1742158, but
  still causing prefs::kSharingSyncedDevices to update on every reboot

Bug: 1006153
Change-Id: I62e86791a58e8c5ca63ae9127895ecb4b813b1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835578
Commit-Queue: Alex Chau <alexchau@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702029}

See bug.

TBR=sky@chromium.org
NOTRY=True

Bug: 1010182
Change-Id: I7017fbb995398a4a1d43caa7acac78c72fd00612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835368Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702028}

The use seems pointless now that the class uses Mojo for IPC.

This CL prepares to Onion souping this class.

BUG=787254
R=guidou@chromium.org

Change-Id: If36a51b8ff724d6a70aecc884f296e594d3fd2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834362
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702027}

We can allow generate_jni_registration targets to appear in multiple
toolchains by moving the default_toolchain dependency into the
template.

This will eventually be needed to build bundles that include HWASAN
splits, which will employ three toolchains (32-bit, 64-bit and HWASAN)
instead of the usual two.

Bug: 916828
Change-Id: I4edb22263d6feb432034be41f2cfea5cafafc60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832713
Auto-Submit: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702026}

Filter content_unittests crashing on android_bfcache_debug fyi bot.

Bug: 1007276
Change-Id: I7510c423da49fc9821e9910b3e2b51b63017edc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835366Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702025}

https://android.googlesource.com/platform/external/perfetto.git/+log/fa5193a394a7..1e470360678b

git log fa5193a394a7..1e470360678b --date=short --no-merges --format='%ad %ae %s'
2019-10-02 eseckler@google.com base: Output a debug message if temp file creation fails

Created with:
  gclient setdep -r src/third_party/perfetto@1e470360678b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:931138
Change-Id: I7af9324c9867ec36bf5bb9355d55712ae4a06da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835696Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702024}

In the case that the element with backdrop-filter also has
opacity set to zero, there is no need to perform the backdrop
filtering operation. This also avoids degradation of the painted
output when backdrop_filter_quality is < 1 and opacity is 0,
as in crbug.com/1002225.

Bug: 1002225
Change-Id: I8334f6cc46f18eeda412cab7b885b1612c0315a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833925
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702023}

This CL prepares MediaStreamTrackMetrics to be Onion souped.

BUG=787254
R=guidou@chromium.org

Change-Id: I9c31edef1cc690afcbc08b0cde2b18faec866558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834363
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702022}

It fixes missing back button

Bug: 1000606, 1009340
Change-Id: If7839758f51f39315317cb7d8c4616ef27736295
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829199Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702021}

The current popover feature is supposed to be able to handle property
accesses (in the current scope) and show a preview of the value. This
triggers when you hover an identifier with the mouse. DevTools will then
try to find the full sequence of preceeding tokens for the property
access and send that to debug-evaluate. However for template literals,
this doesn't work properly, since a template literal is not necessarily
a single token (in CodeMirror), but for example `a${x}b` is a sequence
of three tokens. So instead of just assuming that looking at tokens is
enough here, we search for the preceeding ` when we find a template
literal and include everything in between.

This is merely a work-around for the bigger issue that we should
probably implement this feature via a dedicated parser (or ideally
reusing V8's AST) to find the correct, innermost subexpression that
forms the property access. Hence there's a TODO left in the code to
eventually address the bigger issue.

Bug: chromium:995036
Change-Id: I4191a54c7ec6ee768f213076c22d575e1ac8438b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835573Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702020}

It's the upstream CI configuration and we don't need it.

Stop ignoring .travis.yml since that's gone upstream.

Change-Id: I1c1fb6f4f7f6658082406fd3e19a4d0456d614f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835359Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702019}

This is reverting the disabling from here:
https://chromium-review.googlesource.com/c/chromium/src/+/1278543

Bug: 838549
Change-Id: Ia354b294aee539ba59d6d4aa160c38f9de7773b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637051Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702018}

This reverts commit e9e520a3.

Reason for revert: Flakiness unlikely to be caused by the test itself.

Original change's description:
> sheriff: Disable BrowserNonClientFrameViewPopupTest.HitTestPopupTopChrome.
> 
> Flaky on Linux ASAN and TSAN.
> 
> TBR=bsep
> 
> Bug: 998946
> Change-Id: Iead970e3ca6738c495a9b922c19f24294b9093e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774006
> Reviewed-by: Darren Shen <shend@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691478}

TBR=shend@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 998946
Change-Id: Id164a193c1182b71d002b66b4e8b328fddde7402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835619Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702017}

Since Settings might embed 3rd party ViewControllers, the only interface we could
expect from them in order to clean up or rubberband when swiping down to dismiss
are the AdaptivePresentationControllerDelegate instance methods. For this reason
SettingsRootTableVC now conforms to AdaptivePresentationControllerDelegate, and
any subclass can override or implement any of the these methods.

This CL also forwards all AdaptivePresentationControllerDelegate method calls into
the currently presented Settings VC.

Bug: 1006304
Change-Id: I0ff47d755e5c3e67029e210dfb94d21d700520cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832104Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702016}

The Windows VS_FIXEDFILEINFO structure includes fields to represent the
version number of a file.  Allow these to be provided as a standard
base::Version object.

Update base::FileVersionInfoWin to make use of this API update.

Drop exposure of internal VS_FIXEDFILEINFO structure, and propagate
cleanup to gpu/config to use cleaned up API.

Bug: 1008222
Change-Id: I94beaf8f8d2d3d90ebb19c3c44acacf7027903f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828219
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702015}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Id79e18139e4f6f2986b58a0ed9d290e8dbff8e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835695Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702014}

https://webrtc.googlesource.com/src.git/+log/f4e0c29ed1d7..f1e97b9ebd23

git log f4e0c29ed1d7..f1e97b9ebd23 --date=short --no-merges --format='%ad %ae %s'
2019-10-02 sprang@webrtc.org Reland "Prepares RtpSenderVideo for batch forwarding of generated packets"
2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ce9e096..1fdb019b (701829:701929)
2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 443491f4..4ce9e096 (701518:701829)

Created with:
  gclient setdep -r src/third_party/webrtc@f1e97b9ebd23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: If109a6b99f49b58eea78ebabf6199fd3b2b39ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835464Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#702013}

Filter unit_tests crashing on android_bfcache_debug fyi bot.

Bug: 1007276
Change-Id: I01720d8ed406d82e0e728ab5a8012a590676227c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835615Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702012}

If a Message Banner is being presented and the user taps on its picture/
initial letter Disc, the settings screen wouldn't be presented. This
happens because BVC is actually not the presenter VC and it can't dismiss
the Banner.

This CL uses the existent functionality for
showGoogleServicesSettingsFromViewController where BVC is used instead of
the parameter VC. This also takes us closer to not sending a VC through the
dispatcher.

It also removes a DCHECK since a presentedVC should leave that decision to
the presenterVC. This is something we currently lack and I hope to work on
this after Messages.

I didn't add an integration test since we don't have a good way to trigger
an Infobar on NTP in an integration test.

Bug: 961343
Change-Id: I85ea8047f5b55abd6e5606b4046d7dd7ad158625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834206
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702011}

TBR=hbos@chromium.org
NOTRY=true

Bug: 1010483
Change-Id: I095aedfdefe38c62cd3ba9fb8b4a49f1b7c65c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834875Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702010}

-Wpessimizing-move missed a few calls for a while. Now it finds them again,
so clean them up.

Bug: 1010458
Change-Id: I143cc6f1421f505aeb56858182860018a75051f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835672
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702009}

Bug: 981349, 956308
Change-Id: I887cd6752df75d33babfb187d8da1ad78112f4f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824088Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#702008}