- 02 Oct, 2020 16 commits
-
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I57310023f83236b42a185d5c1b401ae3a338a94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443849 Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813019}
-
Malay Keshav authored
This patch uses glClear to draw the solid color draw quad whenever possible. It also replaces the usage of color transform matrix used in the fragment shader for solid color draw quad with a precomputed color that is in the correct color space. Improves draw time of a full screen solid color quad by approximately 80% on Atlas. (From ~1.5ms to about ~0.25ms) Also adds a feature flag that is disabled by default and will be enabled in subsequent CLs. (For easy revert of feature) Bug: 1072895,1072910 Test: Manually tested on Chrome OS Change-Id: I0d0174bffa802d146bce26f985bc3150e051dc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343970 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#813018}
-
evliu authored
This CL adds a browser test for the Speech Recognition Service using the Speech On-Device API (SODA) binary and test file. Bug: 1122784 Change-Id: Ib143827f9ef1ee44c366f98752e36c4ed219d072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440311Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#813017}
-
Peter Boström authored
Used to test grt@'s hypothesis in https://crbug.com/677806. Bug: 677806 Change-Id: I1f2fa6c799fdd765f7dfbe2530f4fb5916fbb5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443976 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#813016}
-
Mustafa Camurcu authored
Uses GFX metrics to trace and report frame jankiness to UMA. Traces are done in 5 minute intervals. BUG=b:169211158 TEST=Manually tested on PlayStore and other apps and looked at results. Change-Id: I87a381193bc9d0dbd00d81386cc4c0396c9afdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430505 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Auto-Submit: Mustafa Camurcu <camurcu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813015}
-
Weilun Shi authored
Add back --inputs to the generate_expired_histograms_array script. A follow up cl will add an assertion in the _GenerateFile function to make sure that the input always keeps in sync the most updated list of metadata description. TBR=rohitrao Bug: 1133102 Change-Id: Ic4a28adf60f9a5cf9331414defedb5bd91e99d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444449 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813014}
-
Sinan Sahin authored
TBR=wychen@chromium.org Bug: 1134361 Change-Id: Id061120cc3e8003a674584613e291d3293b5107a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444134Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#813013}
-
Harald Alvestrand authored
The chromium feature is https://www.chromestatus.com/feature/5410592384876544 The intent-to-implement-and-ship thread is https://groups.google.com/a/chromium.org/g/blink-dev/c/dAeG7K7HPG8 The feature is covered by WPT tests. Bug: chromium:980879 Change-Id: Icac0d2f4b116bc775a9635c7441f6f8cbad371a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438065Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#813012}
-
Callistus authored
- Added |IsLSSEnabled| to help_app_ui.mojom. - LSS methods in receiver forward requests via message pipe. - Implement message handlers in browser_proxy. - Added browsertest to ensure LSS methods used by delegate. Bug: b/166047521 Change-Id: Iadc5fba94e79631d7b293be0e5b917f72bdc8fc8 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437560Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#813011}
-
Yao Xiao authored
The version needs to be passed around, and for a single floc computation cycle, the blocklist service is supposed validate the version from sorting-lsh output to make sure they are in sync. This is to address race conditions when a new component comes between the 2 file reads. Bug: 1062736 Change-Id: I597565902fb8e893c7481cee496411880c6839b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443495 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813010}
-
Scott Violet authored
This way the embedder can readily detect when and if a Browser or Tab has been destroyed. BUG=1134085 TEST=covered by tests Change-Id: I2e316e023d18c04d4aec6139306d1815e1ee65cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443402Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813009}
-
Felix Andrew authored
Bug: 1132914 Changes to base::Value to use absl::variant made it necessary to change the .natvis to aid in debugging. Change-Id: I1f3d99afeb28bdb5a9d132d3bb578103befc6525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436320Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813008}
-
Mihai Sardarescu authored
This CL adds a "supervised" argument to the X-Chrome-Connected header when the account that is signed in to Chrome is a child account. Design document (Google internal): https://docs.google.com/document/d/1u5PUBIeTxXiKSpqJHDiSuc9hJ2Y9_Te4ja5eJdLfZk4/edit?usp=sharing Bug: 1103228 Change-Id: Ic90021207213d926ed2dbb54b78eb4d9559a0da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431524 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813007}
-
Peter Boström authored
Auto-grouping a pinned tab would unpin it, which is likely not what the person intended. Bug: 1133147 Change-Id: I504ed6e2117c96f53840a24993fd7891d6b3c30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444269Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813006}
-
Dave Tapuska authored
Change to use gfx::Size over WebSize for WebView/WebViewClient. BUG=738465 Change-Id: Ic3470cd85b61cdbb8719aa924a138fdaf34db8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441193 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813005}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564, not having a sources assignments filter is the default. No behavior change. Bug: 1018739 Change-Id: I6e0e4aa4499d7a99908a63851b899c639543a3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443690 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813004}
-
- 01 Oct, 2020 24 commits
-
-
minch authored
- Add DeprecatedGet*LayerColor functions in a separate file to help keeping UI elements' current colors before launching dark/light mode. - Add ScopedLightModeAsDefeault to set the default color mode to light. This is done to support UI elements are light by default. E.g. Power button menu. Bug: 1133952 Change-Id: I169f13991a649a1d1aacea451a6fb8ba8001396c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440661 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813003}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/cdeac3d48653..be82703d7841 2020-10-01 jophba@chromium.org Delete unused private key der. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I451c08974d041f5e9e02f30d36f8554192c395a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813002}
-
harrisonsean authored
Added Tests: StartingCheckPutsChecksInRunningState CheckStartButtonDefaultUI ClickingCancelTakesChecksToPrevious CheckStartButtonCancelUI TimestampSetIfIssueFound SafeBrowsingEnabledReturnsSafeState SafeBrowsingSafeUI SafeBrowsingDisabledReturnsInfoState SafeBrowsingUnSafeUI SafeBrowsingManagedUI PasswordCheckSafeCheck PasswordCheckSafeUI PasswordCheckUnSafeCheck PasswordCheckUnSafeUI PasswordCheckErrorCheck PasswordCheckErrorUI OmahaRespondsUpToDate UpdateCheckUpToDateUI OmahaRespondsOutOfDateAndUpdatesInfobarTime UpdateCheckOutOfDateUI OmahaRespondsError UpdateCheckOmahaErrorUI UpdateCheckNetErrorUI UpdateCheckManagedUI UpdateCheckChannelUI Bug: 1078782 Change-Id: I61d155817bc13b96fb581fa4a77426ac56deae6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436530 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#813001}
-
Akihiro Ota authored
This change fixes a regression that was introduced by adding in-page link support for ChromeVox. The issue is that when the panel is collapsed, a scrolled_to_anchor event is fired, which was causing us to always place focus on the Panel root web area upon collapsing the menus. To fix the issue, we ignore scrolled_to_anchor events if the root of the target differs from the root of the current range. Fixed: 1133548 AX-Relnotes: N/A Change-Id: I43e99452ea27cd190bd53c62b5fb06593a5bf6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442899 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813000}
-
bttk authored
LocationBarPhone and LocationBarTablet independently implement method setUrlFocusChangePercent(float) which modified a protected LocationBarLayout field. This is one of the simplest changes that reduces the differences between Phone and Tablet LocationBar APIs. Bug: 1133482 Change-Id: I4e9379786bb20009a10be2f812c15323d2c5c1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438883 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#812999}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: 897365 Change-Id: I9ca877042531bc7d2b57fd27c390a113c63f58b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391383Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#812998}
-
Nnamdi Theodore Johnson-Kanu authored
Requirements: - https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7dc3c1fe01_5_125 Screenshot: - https://screenshot.googleplex.com/7S9tRak4yYCiP2a.png Bug: 1093185 Change-Id: I6f71cbf42be9780ea1f5341c31c9b36a2219583f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441271 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812997}
-
Kenichi Ishibashi authored
Bug: 1117369 Change-Id: I72f5277b8d7e57a648b5d14cec4318e7488f6636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440329Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812996}
-
Khushal Sagar authored
The only remaining platform is linux which doesn't ship GPU raster currently. This change switches any test code using GPU raster on linux to OOPR. R=sunnyps@chromium.org Bug:757605 Change-Id: I5c14c9d7bc423307156e3ca6b091d263036ac4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439895 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812995}
-
Findit authored
This reverts commit 6ff69d8a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 812968 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZmZjY5ZDhhNTk3M2RjNDRjMDVkZjQzZGFlYWIxNGM0YjY2ZWJlZDIM Sample Failed Build: https://ci.chromium.org/b/8867600652610457968 Sample Failed Step: compile Original change's description: > Move SODA client unit test to Chromium repo > > This CL moves the SodaClientUnitTest from the internal SODA repo to the > Chromium repo. > > Bug: 1124873 > Change-Id: Ib2dabb242f21817a117f379fb0a1b017dd5bcffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443218 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#812968} Change-Id: I654d24caca240a531da7dac1c8dc8225ef523e73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444233 Cr-Commit-Position: refs/heads/master@{#812994}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Add a mojo definition to go with the printing::AdvancedCapability which is needed to support the larger query on ChromeOS. Bug: 809738 Change-Id: I05bbc441873d6f3a88ae57a27c5abe6c7c4be47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387543 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812993}
-
Nicolás Peña Moreno authored
Bug: 1133883 Change-Id: Id4aac54f834ca7bcf017e8afbbaa4a151d8492b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441732 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812992}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29ef556aff96..ab4a49259c0e 2020-10-01 alessiob@webrtc.org GainController2::ToString updated 2020-10-01 alessiob@webrtc.org AGC2: max output noise level now part of config 2020-10-01 eshr@google.com When reconfiguring VP9 restore previous input pixel format 2020-10-01 sprang@webrtc.org Sets VP9 buffer size and speed based on highest active spatial layer. 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2cdb2cb6..3211fba0 (812617:812728) 2020-10-01 nisse@webrtc.org Delete AllowBlockingCalls and android_media_codec_common.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b8a509e0e50a75aed5a23fd0056fc1108b8774a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443774Reviewed-by:
-
Michael Crouse authored
Bug: 1089314, 1089312,1089310 Change-Id: I3cd2b0113e850e9b3795cea08a011c7060559f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441377 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#812990}
-
Haiyang Pan authored
This is a reland of f6120650 The original CL was reverted yesterday, to release the resource for the higher build request. Today the build request seems fine so reland this CL Original change's description: > luci: Increase CQ experimental percentage to 80 from 60 for pie-arm64-rel > > After the test suites adjustment in crrev.com/c/2427028, the device > usage looks in a good shape and should be able to hold more traffc: > http://shortn/_E2uBVeObl6 > > Bug: 1111436 > Change-Id: I9bfb44a96feb2bc2d49ec8335afc73324711db5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429931 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811298} Bug: 1111436 Change-Id: Iebdc89855816f214f317c0f646a301d87987bd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444190 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#812989}
-
Mingjing Zhang authored
This CL improves the jank metrics by excluding the delays caused by frames without intended updates and prevents certain outlier cases when a high jank percent is reported on a page with very low percent of dropped frames. Bug: 1133058 Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812988}
-
Findit authored
This reverts commit 3792c739. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 812962 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM3OTJjNzM5M2NjNTExMzExNzhiMThiZTViMzFlOGU3ODUxMjI1ZWUM Sample Failed Build: https://ci.chromium.org/b/8867601753821372336 Sample Failed Step: compile Original change's description: > Add additional states to FindMyDeviceController > > Fully implements the FindMyDeviceControllerImpl class. This change > also features a new state: kRingingNotAvailable. > This state is only set if the DoNotDisturb is enabled. > > Bug: 1106937 > Test: chromeos_components_unittests > Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812962} Change-Id: Ieb095886c387c2fbcb8c08aad64f10092098302b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444469 Cr-Commit-Position: refs/heads/master@{#812987}
-
Karan Bhatia authored
This reverts commit 2e1031ec. Reason for revert: Causes compile failure on linux-chromeos-dbg. Original change's description: > [CrOS PhoneHub] Add enable hotspot and locate phone controller to quick > actions UI. > > - Add enable hotspot and locate phone quick actions controllers. > - Connect the controllers to quick actions UI. > - Minor changes in fake tether controller for testing. > > BUG=1106937,1126208 > > Change-Id: I1d4ace03120a4c51fcb351b7c19f33252b3fb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428735 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812915} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org Change-Id: I431b965f354a2d63bd98e361b8ae3233ba5288e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Bug: 1126208 Bug: 1134378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444132Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812986}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30ea8e724567..110e287f7da0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128599,chromium:1130858,chromium:1132967,chromium:1134248,chromium:912681 Tbr: aaronhk@google.com,karandeepb@google.com Change-Id: I45529cbae30a1ba29492da29506e8c5f9eb66a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812985}
-
Matt Wolenetz authored
Instead of manipulating the media element's audio and video tracks directly from the SourceBuffer, this change moves that into the MediaSourceAttachmentSupplement interface. Currently, TrackBase and TrackListBase usage by HTMLMediaElement and SourceBuffer require ownership and operation by the main thread, and further require knowledge of the main-thread-owned media element for use in scheduling events on the main thread. For cross-thread MSE-in- Workers attachments, to prevent regressing BackgroundVideoOptimization, the media element will need knowledge of the worker-MSE audio and video track identifications used by the underlying media pipeline. This change supports future signalling of the media element to add or remove such audio and video tracks via new methods in MediaSourceAttachmentSupplement. Existing same-thread behavior is maintained by new implementations of these methods in the SameThreadMediaSourceAttachment. SourceBuffer is updated to understand which of the methods to use, as until track ownership and operation in worker context is supported, workarounds in SourceBuffer and the attachment will be needed. Later changes will include the cross-thread attachment implementation of the media-element track addition and removal to actually perform the signalling. This change retains the pre-existing experimental AudioVideoTracks ability of MSE in Chrome for same-thread-attachments, but prevents (with a CHECK failure, since IDL prohibits alternatives) retrieval by the app of a SourceBuffer's audioTracks or videoTracks when the MSE is in a worker context. BUG=878133 Change-Id: I209ce61915de2e4182807539013606322ece8f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427566Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812984}
-
Matt Menke authored
This potentially provides a small amount of information that help could identify a user across sites. Bug: 973801 Change-Id: Ie9e16755323a4418b2d3109ce4993bcbe0d36a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443549Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#812983}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_Bdez2rvyhe Bug: 997376, 1127110 Change-Id: I04a4a1da5bcd143ba8e653dae52dfd6df8df6419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444050 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
My Nguyen authored
https://crrev.com/c/2436969 introduces variable for clear search icon fill color, using inherit does not work because --cr-icon-button-fill-color is a variable in cr_icon_button. Specify it directly instead. Bug: 1134044 Change-Id: I48ae7bd0a28d8d1505b50759421308feeec2442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440729 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d628ffbd8f1d..b677e985297d 2020-10-01 kimstephanie@google.com Reland "Reland "Add optional enforce_fetch kwarg to fetch and refresh git cache"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ibc5845711cf9227ff8457c25f7f0681a85ab1d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441385Reviewed-by:
-
