- 14 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610636358-77f55f013156712d320ba2c348ceb07dee8d46f1.profdata to chrome-win64-master-1610647094-91dde28e2f09f28a39a8ebc52cc90535738b2c08.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98875b4999b3273b36ff360c2edf6c2ab177a895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843767}
-
Xi Han authored
The bug was caused by not resetting the text of the URL bar when an empty text is passed via setUrlBarFocus() API. Bug: 1159352 Change-Id: I6b134fd91ae96b8f956fc0ac30c77862c5ebcde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622875 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#843766}
-
Gayane Petrosyan authored
Fix by replacing the non text node position by its child text node, if possible. Otherwise, skip the word-completion logic, which assumes, the position is in text node. Bug: 1165317 Change-Id: Iafb82eb1f1f7e5b6644cc07034166e6f0344d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622987 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843765}
-
Caitlin Fischer authored
Default blocklist values shipped with Chrome 55 onward (added in bug https://crbug.com/643013) and remaining test value ed5f25a4:e is added by web_bluetooth_browsertest.cc procedurally as needed if the field trial config doesn't exist. Bug: 1126640 Change-Id: I2de2d60ade269680ccf8c2a78a77a9b4d0e5a5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627376 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#843764}
-
Kyle Horimoto authored
Includes updates to the Phone Hub onboarding flow, notification flow, and settings UI. Fixed: 1166387 Change-Id: I31f2467e765f37585a8eadd0c2a7b277536e7d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628740 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843763}
-
Jeffrey Kardatzke authored
This is being changed at the request of privacy/legal to indicate 'uniquely identify' rather than just 'identify'. BUG=1146646 TEST=Verified new string in UI Change-Id: If7716b327da1e6c16e9863f88ddca6f5f8768d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629908 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843762}
-
Kyle Horimoto authored
Additionally, add a few fixes which were needed to make tests pass now that Phone Hub is active by default: (1) Call SystemTray->SetPhoneHubManager(nullptr) when PhoneHubManagerFactory is deleted. (2) Set service to NULL while testing. (3) Do not create the service when the Profile is created; instead, Create it in UserSessionInitializer. (4) Update PhoneHubNotificationController to behave correctly when a null PhoneHubManager is passed to it. (5) Do not assume that there can only be 0 or 1 Tether networks. Though this is true in practice, there are tests which use multiple networks. Fixed: 1106937 Change-Id: I15d02e114fc81284cdad072c25c3dca24ff5bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626103 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This rolls up to WPT SHA f333959abe07e6c4cfb388f4f7a03a0a109b38a5 Importantly, it brings in https://github.com/web-platform-tests/wpt/pull/27175 which should allow us to move 'wpt manifest' calls back to Python 3. (This CL does not make that switch, it is just rolling tools). It also brings in the change that makes '--py3' the default mode for 'wpt'. Since the wptrunner bots aren't ready for that yet, I also updated testing/scripts/{run_android_wpt.py, run_wpt_tests.py} to pass --py2 to 'wpt'. Bug: 1161274, 1166741 Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0978d0685f2ef387e22e87e433d4a191e09e7597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627882Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843760}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/786a9e746bcb..18a45a67b21a 2021-01-14 vidorteg@microsoft.com [Loc] Migrate screencast panel to Localization V2 2021-01-14 morlovich@chromium.org Emulation UA-ch editing: make help button tabable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1164345 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib711d3bb84893e559a188619111099abea3c7dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630108Reviewed-by:
-
Boris Sazonov authored
Changes account_manager_facade_factory_ash.cc so that it instantiates AccountManagerFacadeImpl rather than AccountManagerFacadeAsh and removes AccountManagerFacadeAsh. This completes the unification of AccountManagerFacade implementations. Bug: 1161699 Change-Id: I173307bdc584f31af72ef4f34af5c27b71fec435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626444 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#843758}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. Change-Id: Ia4fd3f50e92674b1b16cb44488b6131e71d5d509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625826Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843757}
-
Kevin Marshall authored
Sets the fake build number in the UserAgent string to a different value. Bug: b/176552416 Bug: 1166790 Change-Id: Icb2ba63fbab785bb28f90b14c84058606abf4404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625756 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843756}
-
Mike Dougherty authored
CRWJSInjectionManager is deprecated and removing it will help to cleanup existing JavaScript feature code in preparation for new JavaScript features. Bug: 949178 Change-Id: I2b5612e00262a854157c28cd577ed0488e819530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593726Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843755}
-
Andrew Grieve authored
Bug: None Change-Id: I373e5fcde6b1e96c700ae919af1a3e08be4dac5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630069 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843754}
-
Tommy Martino authored
This adds a handful of sites to the Shared Highlighting blocklist. It also strips m. from hosts, similar to what we already do for www. Bug: 1157981 Change-Id: If907ba6bd79529e98a634918e47a21dd1f2730cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629571Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#843753}
-
Henrique Nakashima authored
This is a reland of 314cbf4c Patchset 1 is the original change. The main difference is that now the TabPersistentStore is created with the actual index that TabWindowManagerImpl assigned to the TabModelSelector, rather than the index that was "requested". Other changes are to adapt tests. Original change's description: > Create glue-layer TabModelOrchestrators > > TabModelSelectorImpl does not create or destroy TabPersistentStore > anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and > TabPersistentStore. > > Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of > passing TabPersistentStore directly. > > This is a step to break the two-way dependency between > TabModelSelectorImpl and TabPersistentStore. > > Bug: 1138561 > Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835819} Bug: 1138561,1158259 Change-Id: Iac6eaaed149e853536813cd627d28236638657de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590427 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#843752}
-
Andrey Kosyakov authored
Bug: 1154370 Change-Id: I186be83eb5b63870a435821b6d03134bfed4a9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625751 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#843751}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610625483-d2f1e02797211441cbc7cf411236f83624a240c4.profdata to chrome-win32-master-1610636358-cc0d7707c698b33d5a2e049b9e10a4117c1fdf55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4f19ff2eab83d082ac3808d9c58b407ac6811a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626532Reviewed-by:
-
Dominic Battre authored
This is an attempt to deflake AutofillServerTest.QueryAndUploadBothIncludeFieldsWithAutocompleteOff. The hypothesis is that a second lookup to the autofill server (not sure why that happens) causes a problem where some very specific network packages are expected. I believe that after this lookup the expected traffic will occur. I am relaxing the requirements a bit by dropping an EXPECT_EQ. The test will still time out if the expected network traffic does not happen. Bug: 1162474 Change-Id: If3c20d0a32152f99317618ab41f6bbc8fe940c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630047 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#843749}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a1c2dea7350..1f6ed1382f51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1166380 Tbr: davidvc@google.com,adithyas@google.com Change-Id: I2dc0d410eb0f5ec754dfdc128bc54032a9a33239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629859Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843748}
-
Andrew Xu authored
Now when copying multiple files, the shown icon is based on the extension of the last copied file, which is unexpected. This CL does the following things: (1) Implement the API to get the count of copied files for the given clipboard data (2) Show the correct icon according to the count of copied files. Bug: 1165309 Change-Id: I63222e7037fcc38683ba3c6a0be3dd080f424dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628735Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843747}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/320b6dfbe5e4..2d79f95e908d 2021-01-14 hjd@google.com Merge "ui: Remove old TODO regarding android_thread_time_in_state_event" 2021-01-14 hjd@google.com Merge "ui: Split add track logic into separate methods" 2021-01-14 rsavitski@google.com Merge "tp: trace_bounds: include the ts column of |perf_sample| table" 2021-01-14 treehugger-gerrit@google.com Merge "Update docs for adding derived events" 2021-01-14 treehugger-gerrit@google.com Merge "upkeep: Fix comments to match argument names" 2021-01-14 treehugger-gerrit@google.com Merge "upkeep: Replace find() == 0 with StartsWith" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id9fb61d4e28754e531758ed484242c46a8d2cc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629788 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Stephen Chenney authored
Identifying the cause of ForcedLayout time regression is essentially impossible given all the reasons we might do forced layouts. Add UMA/UKM for classes of layout reason to narrow down the cause of regressions. The grouping of all available reasons into a small number of reported groups is necessary to limit the size of the UKM event while avoiding aggregating multiple unrelated reasons into one number. Privacy doc covers this already: https://docs.google.com/document/d/1kRg4pBKUib-GmLkvD9ew63BP7xOF7Gi0_W0K2qdtgyw/edit?ts=5a7e060b# Fixed: 1094414 Change-Id: I040a2d4882974b9357978005cc03bf3afae01ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626416 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843745}
-
dpapad authored
Namespaces made sense in a pre-JS Module world, as a way to group related functionality together. In the context of a JS module, it no longer adds any benefit, as the client of a module can either import explicitly only what is needed, or import all exported functions with a namespace of their choice like import * as foo from './module.js'; Bug: None Change-Id: I6938c6fead73a1ef138e26183e2a880b95345a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628070 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843744}
-
Eugene Zemtsov authored
Change-Id: If0dfc3446fd697b950cb6db270fa85a52c90b63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626969Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843743}
-
Joel Riley authored
Timing issue that can happen when user performs navigation before 'start' event is received. Simplified interruption handler which was putting STS into 'inactive' state when it was not necessary. Bug: 1165284 Change-Id: Ia9818b29fcd57e0aaa5584579851ad093d9f89d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622748 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843742}
-
Sharon Yang authored
Add support for Google API Key when provided through the config file read by WebEngine. key present. Test: Manually tested. Safe Sites functionality works without another Bug: 1160130 Change-Id: I8b0fef7aa4892e130e0b6d423dc63e733e05aca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613649 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Sunggook Chue authored
It looks like OsHookType::kShortcutsMenu set was omitted in the recent refactoring of the code. OsHookType::kShortcutsMenu should be set when kShortcuts is set. Bug: 1166362 Change-Id: I04020eef8e6deb804f0dff1903b2e994f179d8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628074Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843740}
-
Jesse Doherty authored
Change-Id: Ic5d36cfc076033d7545190a5eff9ff579d01b86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629627 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843739}
-
Regan Hsu authored
This CL changes the help tooltip icon to an info tooltip icon present on the PhoneHub Notification row in OS Settings multidevice, when work profile is active Screenshot: https://screenshot.googleplex.com/ByKEpvhP8EnaL4m Fixed: 1166677 Bug: 1106937 Change-Id: I1fd28c567f16366d2f905c04185d31d3003b8d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627338 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843738}
-
Egor Pasko authored
Because it is shorter and seems to work. Bug: 1154224 Change-Id: I2e69ad5d016ef0e5a050613097645c66111da059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616158 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#843737}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I87ee1f6d2a3bdf4c05967fb62ef751120d0cbaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629517 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#843736}
-
Sky Malice authored
TBR: michaelbai@chromium.org Bug: 1161326 Change-Id: I171327653b383c05509d4d22fe7d8fb9cd855657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625757Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#843735}
-
Sophie Chang authored
Right now, this uses a random public key we generated on the server but wanted to ensure this code path is well-tested instead of waiting on the final key Bug: 1146151 Change-Id: Idf6f0580e801f4bce9e45b718be6017bc4dad813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628748Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843734}
-
Natalie Chouinard authored
The most important simplifications that were tracked by this bug have been completed (getting rid of KitKat customizations and switching to the material defaults). These lingering small TODOs can be removed. AndroidPaymentAppPreference.java: There's pros and cons to using a custom layout vs making layout changes at runtime. I generally prefer custom layouts in XML, but it's probably not worth the effort and testing to go back and change this one after the fact. storage_preferences_view.xml: The default support library empty state has smaller text, and can't be customized, so this should stay as is (UI is by design). Bug: 971791 Change-Id: Ie45ea27a39f8f4c66112152913864925f3bd5167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630067 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#843733}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c603339365fb..b7ddc5a0091b 2021-01-14 brucedawson@chromium.org Check whether goma is running when it is enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:868590 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Iac09ce5ffd5dc6b04374d5fe41b4c58959991334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629472Reviewed-by:
-
Sophie Chang authored
Just going to keep retrying until the path has been deleted. Probably better than the test crashing after the first time? Bug: 1156112 Change-Id: Ia5e7e97a09bcfe347b63b156dde558fd59009f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629673Reviewed-by:
-
Jarryd authored
* Add test case for journey 5 * Implement |add_policy_app_internal_windowed| testing action * Implement |assert_display_mode_browser_internal| testing action * Implement |assert_display_mode_standalone_internal| testing action * Add getter for WebAppProvider Bug: 1145224, 1156676, 1156708, 1156706 Change-Id: I64f2ce560a78dfb9973cca21d9e21c28dcddf40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610045 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
David Van Cleve authored
It seems like this test is pretty genuinely cross-platform flaky, so this CL moves it from conditionally disabled to disabled disabled. Tbr: chrisha@chromium.org Bug: 1158715, 1154345, 1166756 Change-Id: I9b0b71e3645ac272d907a6552ac7bcd4e8faff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626531Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843729}
-
Shuran Huang authored
Use the passed-in isolation_info to calculate the SameParty cookie context of CookieOptions. Bug: 1136102 Change-Id: I31d95d5f93c66622fbc516b1e956d0cc571ee2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615998 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#843728}
-
