- 06 Mar, 2019 40 commits
-
-
dpapad authored
- Modify js_externs_generator_test.py to add "@typedef {Object}" - Mark optional parameter as optional in bookmarks_manager_private.json - Move incorrectly placed annotation in c/b/r/bookmarks/store.js - Re-generate bookmark_manager_private.js and add a note at the top of that file, about manual edits required. Bug: 717828,717827 Change-Id: I69639a800d7aabb1bbe5e8885efce487f9414409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499778Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#637988}
-
Matt Falkenhagen authored
This can return null per issue 817691. We only recently started getting crashes for it being null for navigation preloads. It's possible this is due to r636598 which allowed extensions to intercept nav preload requests. Bug: 938639 Change-Id: I03149fa3c61234714611c272e4fa783948f2bf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504594 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#637987}
-
Ian Wells authored
Bug: 803584 Change-Id: I189c280a19e9c6a591af6b6ee0e8a37e2abb020d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490497 Auto-Submit: Ian Wells <iwells@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#637986}
-
Matt Falkenhagen authored
Part of an effort to remove EmbeddedWorkerRegistry which shouldn't be needed since mojofication. Shutdown() sent a Stop IPC on each worker when the registry is destructed, which happens only during browser shutdown or a fatal error with the service worker system. The Stop IPC is not needed since ServiceWorkerContext is also destroyed in this case, which means all hosts are destroyed and the Mojo connection to the workers are destroyed. The workers in the renderer processes detect the destroyed connection and terminate. I thought this might affect the ServiceWorker.WorkerStopped UMA, but it shouldn't because the registry is refcounted and owned by EmbeddedWorkerInstances, so it doesn't destruct until those are already destructed, so no host is alive to record the UMA. Bug: 931084 Change-Id: Id8c92f59e6602e7d95bf876858f4b771bed19636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504472Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637985}
-
Yann Dago authored
Bug: 933791 Change-Id: I987b1e0732d208c54bcfd0434408f1f0c4bad6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497334Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#637984}
-
Paul Dyson authored
App lauches are already being logged from the launcher grid and launcher suggestion chip. Launches from launcher recommendations are being missed in the UKM logging. This will fix that. Bug: 889123 Change-Id: Icbd6a966011b9cc5e50cef692cac7822d5501cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498260Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#637983}
-
Michael Martis authored
This change lets Chrome talk to the production image annotation server. It also includes a bugfix: the experiment feature is changed from constexpr to const, as suggested here: https://cs.chromium.org/chromium/src/base/feature_list.h?l=33&rcl=9d2ac606c7193521bef66585a5209fa562d209c4 Bug: 916420 Change-Id: I5fe8f87d4b8b7b8101931476d19e1aecd0d0c8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504655 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#637982}
-
Devlin Cronin authored
WebConsoleMessage::LogWebConsoleMessage() and WebLocalFrameImpl::AddMessageToConsole() used a fair amount of the same code, as both were mutating a WebConsoleMessage into a ConsoleMessage, and then logging it. Restructure this by adding a ConsoleMessage::FromWebConsoleMessage() method that can be used by both WebConsoleMessage and WebLocalFrameImpl. Bug: None Change-Id: I7a0ff42411f5e950452c86ecde7e58bb4976d7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501497 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637981}
-
Alan Cutter authored
This CL updates hosted app menu buttons to be a circle instead of a squircle. This matches the main browser app menu button highlight shape. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382151&signed_aid=8nMn1jvoQMiuwbo9hYOZnw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382152&signed_aid=dqni06i4dkv3UxZYxCF6FA==&inline=1 Bug: 918093 Change-Id: I9137331b23047570a1a7becd97ee6be6a04d0abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496399 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637980}
-
Thanh Nguyen authored
We’ve added Finch flags for Arc App Shortcuts. This CL adds unit tests to ensure the behaviour of the ranker with Finch flags: 1. Doesn’t change the scores when the flag is disabled. 2. Improves the scores when the flag is enabled. Bug: 931149 Change-Id: I4368bfbae0b1b2862f354469028c028f74cefabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501892Reviewed-by:
-
Shakti Sahu authored
1 - Changed implementation to observe individual DownloadItems rather than observing an AllDownloadItemNotifier::Observer, because AIDN generates duplicate updates to the UI. 2 - Changed this class to work with in-progress download manager. This class now depends on DownloadManagerService to get all downloads. 3 - Changed OfflineContentAggregator to a singleton for android so that it can work without a BrowserContext. 4 - TODO : This class is owned by DownloadCoreServiceImpl. Need to fix this for service manager mode. Change-Id: I5741fb0fc9eef05415ab907b23c1fb575ef2203d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1422392 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637978}
-
Yiming Zhou authored
This change adds the following additional data dependencies: 1. Directory for the certificate files Web Page Replay (WPR) needs. 2. Two JavaScript files containing scripts WPR needs to inject. Bug: 847905 Change-Id: If3473e9f554ac58590c78a6548ab28ff4966a585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504038 Commit-Queue: Yiming Zhou <uwyiming@google.com> Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#637977}
-
Shakti Sahu authored
Added a few more metrics : 1 - Image size ratio between the view and the thumbnail being shown 2 - Number of chips enabled at any time 3 - ThumbnailProvider cache hit/miss and cache size histogram 4 - ThumbnailDiskStorage cache hit/miss and cache size histogram Change-Id: I1160010808a709ea12c1e877e5e03b18fc04c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1429619 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637976}
-
Stephen Chenney authored
Remove the async callback used to re-starts commits, replacing it with a restart time passed when commits are deferred. Check if we need to restart commits within BeginMainFrame. This patch also makes it possible to re-start commits within a lifecycle update, which is important for adding signals that are discovered during paint or style update. R=vmpstr@chromium.org BUG=805798 Change-Id: I393d42adb37716a616ed24d823d657874820946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497335 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637975}
-
Victor Vasiliev authored
This involves introducing a bunch of new platform interfaces, such as: * QuicFakeEpollServer * QuicRunSystemEventLoopIteration * QUIC_TEST_DISABLED_IN_CHROME * QuicGetTestMemoryCachePath R=rch@chromium.org Change-Id: Iaafc71908337905a238ae0c7a4675c00f7676863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504455 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#637974}
-
Christian Biesinger authored
Instead, resolve it to auto (=logical height) In the future, this codepath can also be used to implement flex-basis: content. Bug: 531656 Change-Id: I57f6cb60ca32919c3efda9e32bc68f524362526a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490212 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#637973}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a272d1148d5b..f8f4140a12eb Created with: gclient setdep -r src-internal@f8f4140a12eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Id6489b13d8344d81a1e0464753f7321aad263671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504833Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637972}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/624cec68e43a..537ce575a441 git log 624cec68e43a..537ce575a441 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@537ce575a441 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I97b34f486fef0f18b3d733f150250109b7949350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637971}
-
Khushal authored
Make sure the display buffers are tagged with the correct colorspace and tag the platform surfaces used with SurfaceControl with this color space. R=ccameron@chromium.org,piman@chromium.org Bug: 889328 Change-Id: Iad159f1abe27caa26b3de0701f243cbf970ca581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504699 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637970}
-
Tina Wang authored
Add a new notification type: SEND_TAB_TO_SELF DesktopNotificaitonHandler inherits NotificationHandler and implements ReceivingUiHandler. This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/1477754 Bug: 937693 Change-Id: I96f8ee3c3de914c6742860b0f9f3650325fc8b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476103 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637969}
-
Christopher Lam authored
This CL pushes the per-row contents of expandable-app-list to being specified at the client layer, rather than branching with dom-ifs internally. Bug: 906508 Change-Id: Icc3b324a408a0a0dd2d487745eda3793e910f143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481135 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637968}
-
Stefan Zager authored
It only provided a very thin layer of functionality on top of IntersectionObserver, at the cost of another layer of WTF::BindRepeating callbacks. Convert all existing usage to use IntersectionObserver directly. Change-Id: I77c62b929dbd17e0f28966de3b9ce7f673cb8399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490405 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
Bug: 938240 Change-Id: Ia75d55ba64415fa8c77f28326afd01ca2861e9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504267Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#637966}
-
John Lee authored
This fixes a couple issues: 1) It allows us to keep the 'Next' button always enabled so that users can quickly exit the flow, 2) it clears the background when the user selects a custom background, hits 'Next', hits the browser's back button, and tries to go back to 'Default' Bug: 938235 Change-Id: I3ede7c9a99b4e0b293143188f0743c022aa07d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504127Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637965}
-
Yilong Yao authored
This was not documented well in Chromium code, but will cause a crash or LOG(FATAL) otherwise. Bug: internal b/125105834 Test: Started application that caused the crash. Change-Id: Ica50aaef287159704bc182557c0847aee8318204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498376 Commit-Queue: Yilong Yao <yilongyao@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637964}
-
rbpotter authored
If the destination updates, preserve the user's settings if the destination supports them. Otherwise, and in the case of initialization without sticky settings (e.g. kiosk public sessions), use the printer default. Bug: 936396 Change-Id: Ie07fd94afe413323c19f13948ebc1715e888e7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474437 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#637963}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/314a2f06b9ff..7e68767e2fe2 git log 314a2f06b9ff..7e68767e2fe2 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@7e68767e2fe2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2ad899cff5032ea367ca4b2128c1dc321fc370e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504432Reviewed-by:
-
Simon La Macchia authored
Problem: Currently unable to navigate the Search Engine settings menu via (Bluetooth) keyboard navigation (up/down/tab/enter keys). This is because the ListItems in the ListView (contains search engine choices) are not focusable. Solution: Make Search Engine settings options focusable, so that they can navigated and receive click events with a keyboard (up/down/tab/enter keys). Bug: 936992 Change-Id: Iee972f689bc497f4393743c0132489715946ea83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495804Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Simon La Macchia <smacchia@amazon.com> Cr-Commit-Position: refs/heads/master@{#637961}
-
Bo Liu authored
Post to UI and wait instead. Change-Id: I1f5b68b54be3cbf228b07385d2d2a39a7bd71f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504242Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637960}
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/loader with the macros of Allocator. After some analyzes, it was concluded that for the case of RawResourceClientStateChecker, SignedCertificateTimestamp, ScriptFetchOptions classes, they make sense to use DISALLOW_NEW because they have been used as a member variable with a reference type. In CachedMetadata, CachedMetadataSender, CodeCacheRequest, and ResourceResponse classes, they make sense to use USING_FAST_MALLOC because they're used with new or smart pointers. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: Ifefa6380cc70b2f2f2bddaad1885b203e95597ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503274Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637959}
-
Aleks Totic authored
NGBlockNode::PrepareForLayout calls ToLayoutNGListItem(box_)->UpdateMarkerTextIfNeeded ComputeMinMax also needs to call it to compute correct MixMax sizes. Bug: 938224 Change-Id: Iebf3183c9e7447857ebc092a29a65cbd90a720bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504155 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637958}
-
Sammie Quon authored
These are also failing on the informational trybots. Test: none Bug: 938575 Change-Id: I3d59cccf5546b5512e837a27b9829c48402d603f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504704Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#637957}
-
Weiliang Chen authored
SkImageFilter need filter origin and scale passed in and fix the bug where it wasn't passed in before. Bug: 922570 Change-Id: I24fcac2d80cc4de76eb2b72f4a24dfeec9f936b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503341Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#637956}
-
Dale Curtis authored
These are not template based, so compiling them twice just ends up with duplicate symbols that will cause linker errors. BUG=938190 TEST=local android build links. Change-Id: I0fe171e45fb24329611d09a328e38fe951cd53ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504702 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637955}
-
Wez authored
Change-Id: Ia7e7399d266530754895ec14ec6e5a3876d5a157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496324Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#637954}
-
dstockwell authored
* Add missing labels for undo/redo/expand * Don't prevent Escape from closing popups if focus is on a radio button Bug: 902646 Change-Id: I33a73f9f1a971dddc19fb0d7708aeb997ee494e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501775Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637953}
-
Ayman Almadhoun authored
This change contains the following: 1) Adds TabStripToolbarCoordinator/Mediator component. 2) Updates existing BottomTabGridCoordinator. 3) Replaces BottomTabGridSheetToolbarView with a generic BottomToolbarView. Change-Id: I7687eb7cb69ca89656a7f85e2dc993ed23b9f508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500876 Commit-Queue: Ayman Almadhoun <ayman@chromium.org> Auto-Submit: Ayman Almadhoun <ayman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#637952}
-
Donn Denman authored
When Smart Text Selection appears to be active TTS currently does not trigger on long-press. This is problematic for many reasons, not the least being that long-press is a reliable way to trigger a UX. We have supported an override switch for this suppression. This CL removes the disabling and the override switch. Now long-press will trigger TTS regardless of whether Smart Text Selection appears to be active or not. Also rename some methods used to prevent a race-condition with Smart Selection gathering the surrounding text. See issue 773330 for background on this race condition. BUG=868108 Change-Id: I3831ffc26973f019257787d3df499d7684d3c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490737Reviewed-by:
-
John Rummell authored
Update MediaDrmOriginIdManager so that when a profile is loaded it will check if any more origin IDs need to be pre-provisioned, and if so attempt to pre-provision them. This is enabled by a new base::Feature "MediaDrmPreprovisioningAtStartup". BUG=917527 TEST=new unit_tests pass Change-Id: If0e51516bd0f4d348792230c5309e89bd2b3388d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481111Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30c1365e30b1..ad22645bad55 git log 30c1365e30b1..ad22645bad55 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 primiano@google.com Merge "traceconv: Add --version" Created with: gclient setdep -r src/third_party/perfetto@ad22645bad55 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7e6366528cf6ef5ffe894bf00aef554806008d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503564Reviewed-by:
-
