- 19 Aug, 2020 40 commits
-
-
Mohamed Heikal authored
We should ensure that no new usages of the real targets can be added. Change-Id: I4999c2257f9aedef38809c4f182f419c8bed058c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357452 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#799813}
-
Tibor Goldschwendt authored
This data source allows embedding external images into WebUI pages via the URL chrome://image?<image URL>. No-try due to broken traffic annotation check. See crbug/1119509. No-Try: true Bug: 1087613 Change-Id: If7e6af0a90ce5032832eb3cc883999b5bc9ffb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352517 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799812}
-
Lucía Cantú-Miller authored
Feature added to ChromeDriver for a user to be able to use pipes to communicate with Chrome. This cl focuses and the handling, reading from pipe and writing into pipe. Bug: chromedriver:3480 Change-Id: If7affbb2dd1da96b7484352abbde0a3cf0a92f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333818 Commit-Queue: Lucía Cantú-Miller <cantumiller@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799811}
-
Bailey Berro authored
Disabling Display Alignment Assistance by default as we will launch in at a later time. Bug: 1070122 Change-Id: Ic67bc4e88ba8a6af28071bc4a167d1067586ea37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364219 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#799810}
-
spdonghao authored
Bug: 1111824 Change-Id: I4f3766703802d94a371e2b57f30af198b01e3bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344945Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799809}
-
Michael Thiessen authored
This reverts commit 7a9d7b86. Reason for revert: crbug.com/1118189 Original change's description: > Reland "Introduce CriteriaHelper#pollUiThreadNested" > > Introduce CriteriaHelper#pollUiThreadNested > This change adds an assertion that pollUiThread is not called from the > UI thread, which is equivalent to calling sleep(), and won't actually > run any UI thread tasks. > > In the few cases where polling the UI Thread from the UI thread is > necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests > the looper in order to continue running UI tasks. > > Bug: 1115220 > Change-Id: I9338a607590e8ee0a22bc32477f02867c6e37271 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357289 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798862} TBR=yfriedman@chromium.org,mthiesse@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115220 Change-Id: I7121ee7847634cee2bd6d9fc1927ce5e34d5d023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364741Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#799808}
-
Peter Kasting authored
Bug: none Change-Id: I886fafad53efed1be8bd51d9f91f7e04636fe34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364700Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799807}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe66aae8. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" fcdf8258 "Make sure Oscillator read index is in valid range." b7cd482c "Rename document policy 'unoptimized-lossless-images' to 'lossless-images-max-bpp'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I1d205d7114c0c6026c397f4da99c236e92b2c014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362636Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799806}
-
Sky Malice authored
Bug: 1108553 Change-Id: Ifa4f7d45a45ebcc8209cf0b1a83da25089a8fd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363881 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#799805}
-
Mohamed Heikal authored
We should not care about trailing whitespace in expectation files, since R8 doesn't either. Change-Id: Ief57c4c260083f662ca5b791edf7504de2e40428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363259 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799804}
-
Ben Joyce authored
See: https://bugs.chromium.org/p/chromium/issues/detail?id=946475#c48 I believe the root cause of the flake is trying to test if the server has been killed by trying to rebind to the port, although my test shows that the port can get claimed for something else by the system. Add a process.wait() to ensure server process has terminated and remove the error from checking the port status. Could do a check on PID status but system could reassign the PID, so that could lead to the same flake as before except based on PID instead of port number. Bug: 946475 Change-Id: I48911fffcab6b592ddf627e5999fc0609e0f0b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339553Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#799803}
-
Ken Rockot authored
Older android versions require additional permission (as a bug) which we do not want to request. Instead we will trap the exception and ignore the failure. Fixed: 1119435 Change-Id: I6377f4e2f910a5a8ab37af12235548420934f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364749 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799802}
-
Antonio Gomes authored
... pairing it up with content/renderer/media/OWNERS. Note that perkj@ and emircan@ were skipped intentionally because they no longer work on Chromium. BUG=787252 Change-Id: Ief10bb7a9c0d5f775ab32270877a915ee2285396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364056Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#799801}
-
Joshua Pawlicki authored
Bug: 1098935 Change-Id: I50b9730d6c63544192a93dad273ffd04ed12be67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346548 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799800}
-
Alex Moshchuk authored
This reverts commit 4dfbdf6a. Reason for revert: The EmitAccessibilityEventsOnButtonFocusHint test that's modified here is failing on Mac10.11: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/53696 Failure output: [ RUN ] All/OmniboxPopupContentsViewTest.EmitAccessibilityEventsOnButtonFocusHint/1 [26756:3843:0819/131719.560091:WARNING:notification_platform_bridge_mac.mm(572)] AlertNotificationService: XPC connection invalidated. ../../chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc:163: Failure Value of: contains(omnibox_value(), expected_value) Actual: false Expected: true Google Test trace: ../../chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc:162: Omnibox value (foo/, 2 of 3) is expected to contain "The Foo Of All Bars" Stack trace: 0 browser_tests 0x00000001072bee49 (anonymous namespace)::TestAXEventObserver::CheckOmniboxValue(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >) + 825 1 browser_tests 0x00000001072bda50 OmniboxPopupContentsViewTest_EmitAccessibilityEventsOnButtonFocusHint_Test::RunTestOnMainThread() + 640 2 browser_tests 0x000000010c21394d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 717 Original change's description: > [omnibox] Add tests for dedicated row and pedals a11y > > Added tests for keyword button, pedal button, remove suggestion button, > multiple buttons for one suggestion (tab switch and keyword button). > Cleaned up tests. > > Fixed a11y for remove suggestion button and buttons in dedicated row > (set role to be list box option and set correct accessible name). > Fixed selection event not being triggered for dedicated row buttons > (GetSecondaryButton wasn't returning buttons from dedicated row). > Fixed value changed event triggering extra time when switching selection > from button to button. > > Bug: 1104264 > Change-Id: I0c7a7a9cee0622cce2a24f6ea58c73a56ac996bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352826 > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799723} TBR=tommycli@chromium.org,bsep@chromium.org,olesiamarukhno@google.com Change-Id: I97466a40db517ef10dc138ebbea1a0d8569e0a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364961Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799799}
-
Ben Pastene authored
This reverts commit ac7726b8. Reason for revert: reverting to shed load on CQ, crbug.com/1119483 Original change's description: > [lacros] Enable linux-lacros-rel by default > > This CL enables linux-lacros-rel on CQ by default. > > Bug: 1116180 > Change-Id: I67bf89a5eefd7382bbd2886f416bc38c411213bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360496 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799123} TBR=estaab@chromium.org,liaoyuke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116180, 1119483 Change-Id: I2be0017d3af1e863ec15efaa3c3cdf1ff1764911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364140Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799798}
-
Kartik Hegde authored
This change ensures that a problem isn't returned for a routine that isn't run. BUG=chromium:956783 TEST=unit_tests --gtest_filter=SignalStrengthRoutineTest.* Change-Id: I226b632aa65aeb1a9873ce4ac6ae0380f6c3b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364033Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#799797}
-
Andrew Grieve authored
Bug: 1029357 Change-Id: I39cd0de5922bfd583edf203ec6086cbe57d7a99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363806 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799796}
-
armenk authored
When tooltiptext is changed, view controls should call NotifyAccessibilityEvent(). Combobox, Button, TextField, and ImageView controls are affected by this change. BUG=chromium:1113063 TEST=views_unittests Change-Id: Id372136e5bd49057a87e02d5382a0912773b20fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355406 Commit-Queue: Armen Keshishian <armenk@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799795}
-
Curt Clemens authored
Implement GetValidPrivateCertificate, DecryptPublicCertificate, and DownloadPublicCertificates in NearbyShareCertificateManager. Bug: b/154865267, b/154863644, b/154866542 Change-Id: Iedc9bee98956ba7585fa5ad7079d6daf9ce6612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329992 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#799794}
-
wutao authored
This is a reland of c8d093ac Original change's description: > ambient: Use different backend servers > > This patch configs the dev channel to use testing server. But users can > overwrite it with a flag. > > Bug: b/148692733 > Test: manual > Change-Id: I967281bc1421c37d9c1ff74a0815d6a6da570da3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342134 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799318} Bug: b/148692733 Change-Id: Id8140c368da44089e15ac9ded3b4faaf8f19efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364267Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799793}
-
Nick Harper authored
URLRequestStatus contained two members, an URLRequestStatus::Status and an Error. The Status field isn't used, so the whole class is now replaced with the Error enum. Change-Id: If3ea098aec3765a0f094fc576209b776c63b4c07 Bug: 651119, 490311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342281Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799792}
-
Ryan Hansberry authored
Use the new bluetooth::mojom::Adapter::SetName() to implement Nearby Connections' BluetoothAdapter::SetName(). See go/nearby-chrome-bt for more information. Bug: b:154848416, b:154845584, b:154847207 Change-Id: I3caf4b8ea5c1724bf1085b18bd4056acad21d774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340877Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#799791}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: NetworkComponents* Change-Id: I54f3ab4403acf1f758eadbf0ecba6ed52db777bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363874Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#799790}
-
Sven Zheng authored
When these tests are stable, we will move them to CI/CQ. Bug: 1102894 Change-Id: I80b7c8a64e6a176b24c87fe186b4f0b0e5ab01a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363479 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799789}
-
Abigail Klein authored
it automatically on page load. This CL is the first of two to fix a bug in which focus shifts to the webpage and automatically reads it on page load. Voiceover shifts focus to the webpage on the new tab page. We need to ensure that focus shifts to the webpage when a new page loads, and stays in the omnibox when a user opens a new tab. The fix: Do not fire AXLoadComplete when on Chrome's new tab page. An earlier fix to this bug replaced the AXLoadComplete events with AXNewDocumentLoadComplete events. Voiceover does not listen for the latter, so we remove them here. The urls for the Chrome new tab page were taken from chrome/common/url_constants.h. The browser_accessibility_manager_mac lives in content/ and does not depend on anything from chrome. For a longer explanation of this change, see this document: https://docs.google.com/document/d/19s6E0hjTyzB9XU44bdCpXNOaQ8c6nbLRnJbR1EsltL4/edit# Bug: 1049320 Change-Id: I7f1ef175b9db9c5978a5c3308291d1ba4e2b0531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356187Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#799788}
-
chrome://process-internalsAlex Moshchuk authored
After https://crrev.com/c/2304537, the site URL will no longer contain the process lock URL in the hash, so the lock URL won't be visible on chrome://process-internals. This CL adds the plumbing to show the lock URL independently from site URL, but only if the two URLs are different. This way, we'll be able to view the lock URL in cases where it matters (e.g., for hosted apps), and it won't pollute the UI in the common case where it matches the site URL. For completeness, this CL also plumbs the is-origin-keyed bit, so that all current parts of SiteInfo (foundation of a future SecurityPrincipal abstraction) are shown. The origin-keyed bit is currently only shown when opt-in origin isolation is in effect. Bug: 1105994, 1067389 Change-Id: Ife20bcefc57aecee96e24a436ae89902e0837d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364816 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799787}
-
Zentaro Kavanagh authored
Bug: 1089594 Test: manual Change-Id: I835f096589e9eb95f9cf469b43eaf36059df1f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363695Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#799786}
-
Xiaohui Chen authored
Bug: b:161846700 Change-Id: If334c314e2f281dafea7b451863195179aadd12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358036Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799785}
-
Titouan Rigoudy authored
Content settings have integer enum values, whereas the policy is boolean. We introduce a new handler that performs the translation. We check the fix through policy_test_cases.json. Bug: chromium:986744 Change-Id: Id1c7e8368405d64b1a879250c33678281d66c8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359996 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#799784}
-
Hua, Chunbo authored
Bug: 982799 Change-Id: Ibe20d74bfe6182b8464855106ca2d09f5dca087c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363462 Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799783}
-
edchin authored
It is time to remove the use of the term "session" in //ios/chrome/browser/snapshots. The identifier used to store and retrieve images from SnapshotCache is called |snapshotID|. The SnapshotCache has no concept of a Tab or WebState. It is merely a collection of images with identifiers. However, SnapshotTabHelper and SnapshotGenerator are tied to a WebState. Within those classes, the unique identifier for a WebState is called |tabID|. When those classes call SnapshotCache, they use the WebState's |tabID| as the identifier to be used in SnapshotCache. Change-Id: Ic08cd0d70b66e4d699bf06c8b5d8afc093e90255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354807 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799782}
-
Monica Basta authored
Bug: 1119412 Change-Id: Iacb441f18cda7975d2e797fe783caee181c7f98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362804Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#799781}
-
Xi Han authored
The content container which the LayoutManager is attached to has been inflated before the LayoutManager is created. Thus, passing it to the LayoutManager in its constructor, instead of init() method. This is required to support stack tab switcher in instant start. Bug: 1116449 Change-Id: I2761f51d72fdc86248934a7805c8cd27fec85bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356165 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799780}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c907b44dac7..d1a00aacb9ad 2020-08-19 tvanderlippe@chromium.org [globals] self.UI.context 2020-08-19 sigurds@chromium.org Update protocol defintions 2020-08-19 petermueller@chromium.org Add source panel icon 2020-08-19 tvanderlippe@chromium.org [globals] UI.ActionRegistry 2020-08-19 szuend@chromium.org [ts] Type-check ui/View.js with TypeScript 2020-08-19 petermarshall@chromium.org css: Align service worker status dot vertically 2020-08-19 szuend@chromium.org [ts] Type-check ui/Icon.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1058320,chromium:1119311 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9c1fddccd5c609de0698a71c963cc1ff756e5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364673Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799779}
-
adoneria authored
The tests are getting scheduled in win7 bots currently. (https://ci.chromium.org/p/chromium/builders/ci/win10-omaha-tester-rel/437) Bug: 1109373 Change-Id: I34b37c9dac4bbb301ac591523fd3b48441cf741e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363563Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#799778}
-
Mike Dougherty authored
Changes being made in crrev.com/c/2353092 are breaking these tests when using web::HttpServer. So this CL converts them to the now recommended EmbeddedTestServer. Bug: 891834 Change-Id: Ifa5b28483d8d35038c677fca6cb82608d25cfcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362976Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799777}
-
Orin Jaworski authored
This CL adds `sk, sl, sr, sv, sw, ta, te, th, tr, uk, vi, zh-TW` to the set of languages supported by Pedals. Bug: 893183 Change-Id: I5c3d5278018f4de24640357b3190681baa9cbfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364215 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799776}
-
Sahel Sharify authored
This cl adds two bits related to the "secure-payment-confirmation" payment method to events_ bitfield. It also adds this payment method to PaymentRequest.TimeToCheckout.Completed.* metric. Bug: 1113937 Change-Id: I92427cd1371ee6bac8dbeb36f81895b0a64c4234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355051Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799775}
-
Justin Cohen authored
This reverts commit ed3fbbd4. Reason for revert: Still seeing red on both 13.4 and 13.6: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25898 https://ci.chromium.org/p/chromium/builders/ci/ios14-sdk-simulator/2399 Original change's description: > [iOS] Use a simpler grey matcher for web view > > For some reason chrome_test_util::WebViewMatcher is flaky in these ones. > Could be related to the keyboard being in screen. > > The flakiness appears to be related to iOS 13.4. Maybe a recent update > to the bots or a version upgrade of earl grey. > > Using a simpler matcher seems to fix the issue. > > Fixed: 1116043, 1116734, 1114899, 1111076, 1115321, 1111258, 1115282 > Change-Id: I9172417a20d5b8e09dc47cd986256fc0a8cb46ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362892 > Reviewed-by: David Jean <djean@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799544} TBR=javierrobles@chromium.org,djean@chromium.org Change-Id: If5fe6e3906ed0b0b3a4d5ccce251e34b5829d26d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364226Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799774}
-