- 01 Sep, 2020 40 commits
-
-
Sunny Sachanandani authored
Avoid a CPU side copy to account for mismatched strides between the decoded video frame and GPU texture created for uploading the frame. GL_UNPACK_ROW_LENGTH allows specifying the stride for glTexSubImage2D, and is part of the GL_EXT_unpack_subimage extension implemented by the command buffer on the client side. Also includes a pixel test with a VP8 video with a GL incompatible stride that doesn't match the video's coded size (992 vs 962). Bug: 1077211 Change-Id: I62753234bde3b92e64089c92a59e65ae2bc1c84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386671Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#803696}
-
My Nguyen authored
Current view: http://screen/9D7MNRAdxvWVhcG Dialog view: http://screen/a6wQryUi2e2gAg8 Mock: http://go/cros-lang-settings-ux-slide#slide=25 Bug: 1113439 Change-Id: I7279be013ab91dc64dd4442b9fd07307e029b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387462Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803695}
-
K. Moon authored
Adds a skeletal Blink implementation of chrome_pdf::UrlLoader. Almost all functionality is left as NOTIMPLEMENTED(), although this change does include basic lifetime management for the blink::WebAssociatedURLLoader and related classes. Bug: 1099022 Change-Id: I6ed1e0b5e6f02cd83fef1f8664c18a33c9b0f8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387202 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803694}
-
Wei Li authored
This test showed to be flaky only on Linux bots. It should be safe to be re-enabled on Windows. Bug: 976883 Change-Id: I69d28a3b31ce31af2529a16750b5b65423b85e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387180Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#803693}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64e4b1e8e2e8..816506e1c600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9ad0664e8c5785fbb04e9f1074d75cd2f5605c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803692}
-
Ahmed Mehfooz authored
Bug: 1123454 Change-Id: I936c38b274b62d0c3f5218bc414833ee6e6a7223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384909 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Slow <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#803691}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5259b7acb72675915f0e3ceb75fe77bb9700039b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388767Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#803690}
-
Yue Li authored
Bug: None Test: None Change-Id: Id17159e58e9e6ef4f078a750372c1596b3393dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387553 Auto-Submit: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Slow <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#803689}
-
Maksim Ivanov authored
Drop the unused |pipe| argument that isn't used for anything and triggers the "bugprone-use-after-move" clang-tidy warning. Bug: 1122844 Change-Id: Ie4742b54e5cb0412e38d8629f95791f416296850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382116Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803688}
-
Fabrice de Gans-Riberi authored
Bug: 1124056 Change-Id: I9a8b654b2134591d984d8a3f5b10b0419c421621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388773Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#803687}
-
Lijin Shen authored
[Sheriff] disable StartSurfaceLayoutTest#testSwipeToDismiss_GTS & testThumbnailAspectRatio_fromTwoToPoint75 TBR=yuezhanggg@chromium.org, wychen@chromium.org Bug: 1124041 Change-Id: I29f52093d1f0b917e29f382defc65ad3cf2326cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389101Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#803686}
-
Xi Han authored
The crash is caused by mTabModelSelector is null when StaticLayout#show() is called. However, the TabModelSelector should have been created before StaticLayout is created in LayoutManager#Init(). This CL refactors the StaticLayout by passing the TabModelSelector object to its constructor, rather than a TabModelSelectorSupplier. Bug: 1123448 Change-Id: I5184b23316690313fc27684d71f0766df47b007c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385980 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#803685}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkConfigSelectTest* Change-Id: Ia621bfa974b03621c6f8e0aba8f6c9e395035d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388890 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803684}
-
Henrique Ferreiro authored
CursorThemeManager is a singleton and, because its source_set is depended upon by different targets, its static instance was not being shared. Bug: 1114812 Change-Id: Iaaa0a6fee05ff5f5504c8320072f0710d3315e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367096Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#803683}
-
phillis authored
CHECK was added to investigate crash reports related to GetShortcutInfoForApp, based on ongoing investigation, the crash is caused at line 53 for getting icon_sizes_in_px, likely due to null app. Therefore removing this CHECK. Bug: 1113276 Change-Id: I661d80cc29476e6b15fb29348928664f70cf8121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388946Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#803682}
-
Azeem Arshad authored
Creating a basic README for chromeos/network directory. See https://bit.ly/chromium-readme-tracker. Fixed: 1102454 Change-Id: I09d92b50e664447d17d6537fca16e023cdb3c098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281556 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803681}
-
Brian Sheedy authored
This is a reland of 252fed6f Changes from original CL: * Adds an additional crash signature for the renderer process Original change's description: > Add hung renderer minidump test > > Adds a test for exercising Telemetry's hung renderer detection/crashing > code. If Telemetry detects a hung renderer, it should crash the hung > renderer process and the GPU process so that we can get minidumps to > diagnose the root cause. > > Bug: 1119564 > Change-Id: Ibf72a57af6396f7e3ad32fcc16f35d5cd7d1b657 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378761 > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803200} Bug: 1119564 Change-Id: Ieda25c053a170121b4878ceb23d66c03e0b2a189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386490Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803680}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia4e0085b9fa7a51b1ecadff2255002dc277cc435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803679}
-
Matt Menke authored
This adds a couple safety DCHECKs when they're dereferenced, though isn't a huge win. It does help in cleaning up some string comparisons, though, which this CL also does. Bug: 1123179 Change-Id: I6023bebaf59c8d534c08dc386d7428b5f22ba731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387550 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#803678}
-
Yue Zhang authored
This CL adds contentDescription to the dialog_container_view in TabGridDialog. By adding this, we also fix the issue of the dialog auto-focusing on dialog toolbar back button when dialog opens. This bug is because that without a contentDescription, dialog container view will shift its focus automatically to its first "announce-able" child view which is the back button and announce that in a11y mode. After this CL, it will focus on the whole dialog and make the correct announcement instead. Bug: 1111962 Change-Id: I44e21dd5f8088e9903fa7306d56460ba2fc0feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387198 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803677}
-
Azeem Arshad authored
The tether toggle is being removed from the mobile data subpage as part of the updated eSIM UI. See go/chromeos-lte. This CL hides the instant tethering toggle when UpdatedCellularUI flag is enabled. Additional subpage changes will be made in followup CLs. Bug: 1093185 Change-Id: I7f2f01ef18a4e32893ef2289d27ad003a8a20e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380323 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803676}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ib5de66a7b7005c132d37462bcab31587ea0d9393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382317Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803675}
-
Arthur Wang authored
The ChromeJUnit4ClassRunner calls InstrumentationProcessor.applyFeatures. R=harringtond@chromium.org Bug: 1060399 Change-Id: I747f6d926636d9ff7eae78fc8905bc5efd834324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388148 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#803674}
-
Lan Wei authored
In Chromedriver's ExecutePerformActions, we put the mouse events which have a button pressed in a list of input_cancel_list in the session, so we will release any pressed buttons at the end of each test. For mouse wheel events we also generate mouse events with type of "wheel", and it does not support any pressed button, so we should not push the mouse event in the input_cancel_list. Bug: 1040611 Change-Id: I3f651a26b9137dbd8e7754d62852be64f44d5e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387546Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#803673}
-
Alison Maher authored
When determining the column block size of a new proxy fragment that is added directly after a spanning fragment, we need to know the current column block offset. Bug: 1079031 Change-Id: Ibc03d753e927da3b02399d27e986132c4f4833e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365355 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803672}
-
Oleh Lamzin authored
Reorder methods in telemetry_extension_ui_browsertest.h/.cc based on following rules: 1. Most important methods first; 2. Methods in .cc are in the same order as they are in .h. Bug: b:158566609 Change-Id: If8b3e9a1518735bbfa2e83c8703647221760dc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387023 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#803671}
-
David Bokan authored
This is part of a series of steps to decouple input from compositing. In this CL, we remove LayerTreeHostImpl from being an implementation of the cc::InputHandler interface and moves that onto ThreadedInputHandler. As part of this move, the ThreadedInputHandler is now created outside of the compositor at the point where it was previously initialized, though the lifetime remains unchanged, bound to the LayerTreeHostImpl. This also changes the LayerTreeHostImpl to no longer require that an input handler be present. For tests, this means compositing unit tests no longer need to instantiate an input handler unless they're explicitly testing input. In the long term, input tests should not be part of compositor unit tests. Change-Id: I3896b3ce8646a3749a032b1ecf1fc5337c37d184 Bug: 915926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359398 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#803670}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4953712980a2..2d5bbdc4d9de 2020-09-01 capn@google.com Assert multisample resolve has equal input and output formats 2020-09-01 jaebaek@google.com Handle OpenCL.DebugInfo.100 DebugOperation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic0012bf84aeece6154433d384a12e3b10c46bc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803669}
-
Anastasia Helfinstein authored
into the wrong input. AX-Relnotes: Fixes a Switch Access bug causing dictations to be entered Bug: 1123707 Change-Id: I7f7df36667a1af2ecb7d770f4db89fa3d7e91703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386379Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#803668}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2ac047515f09a14b7acb4ec36fd54d788d21a1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382814Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803667}
-
Brandon Wylie authored
Bug: 1119656 Change-Id: Ibf8518900f9d4866ff900b8f7f8eccf089c14c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372813 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#803666}
-
danakj authored
None of these classes are interface mocks. Rename them to be more appropriate of what they are providing. R=avi@chromium.org Bug: 866140 Change-Id: I2ca0fd49b8b1a375d2be8c2e08bb99bab554fa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388346 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803665}
-
Robert Liao authored
PermissionCombobox used ModelChanged() incorrectly to propagate a change to the SizeToLargestLabel property. The real fix updates Combobox to correctly invalidate the preferred size on such a change and updates the method name in PermissionCombobox. Fixed: 1116750 Change-Id: I5bc8f3efe292e94cbfc1c94a2a5149b8b1514da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388889 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#803664}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I2fccd171a4d970bc1cf29ec4314e63c8656fd3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382596Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803663}
-
Yue Zhang authored
Bug: 1116644 Change-Id: I2607ded4d277328067b79f5127664c7a457ba09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383092Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#803662}
-
Adam Ettenberger authored
This reverts commit 3cf58053. Reason for revert: There are 3 new performance regressions related to this change : [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1123547 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1123235 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1123254 Very likely caused AccessibilityIpcErrorBrowserTest.ResetBrowserAccessibilityManager consistently fail on android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2007 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1102 It has been verified that this test * passed with earlier revision: https://chromium-swarm.appspot.com/task?id=4e5ebf09d330cd10 * failed with this revision: https://chromium-swarm.appspot.com/task?id=4e5eb98aba040310 Original change's description: > Reland "Fix Role::kButton name invalidation when descendant text is modified" > > This is a reland of 8f92c37d > > Revert CL : > https://chromium-review.googlesource.com/c/chromium/src/+/2346996 > > Reason for revert: causing build failure: > https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547? > > Original change's description: > > Fix Role::kButton name invalidation when descendant text is modified > > > > This CL addresses a bug where Role::kButton, and possibly other roles > > that derive their name from descendant contents, were not firing > > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|. > > > > ax_object_cache_impl.cc : > > - When firing a text changed event, also fire a text changed event for > > the first ancestor that derives its name from descendant contents. > > This ensures the nodes are invalidated, send appropriate text changed > > events, and the changes are serialized to the browser process AXTree. > > > > browser_accessibility_manager_win.cc : > > - FireUiaTextContainerEvent made it possible to fire text events more > > than once for a given text provider so it has been removed. > > - Instead, populate a set |text_changed_events_| which contains the > > text providers via |GetUiaTextPatternProvider| and fire the UIA text > > events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents > > - |text_selection_changed_events_| could also potentially end up with > > the same double-event problem, so it uses GetUiaTextPatternProvider > > now as well. > > - Removing usage of std::unordered_set based on the guidance in > > base/containers/README.md. In general these sets shouldn't grow large > > enough to benefit from being unordered. > > > > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced. > > Bug: 1105262 > > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564 > > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#796464} > > Bug: 1105262 > Change-Id: Idfafd2e7f886d4d27b735d143ceaa0f33607f7c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346933 > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802730} TBR=wez@chromium.org,nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com,yangsharon@chromium.org Bug: 1105262 Change-Id: I01dfe88c964c907331c4497f7e789e2ad59e14f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388361Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803661}
-
Adrienne Walker authored
To avoid changing the meanings of long-standing metrics, this patch adds two new metrics: * appcache.UpdateJob.ExistingResourceOnlyCorrupt * appcache.UpdateJob.ExistingResourceOnlyNotCorrupt These only are emitted for corrupt or non-corrupt resources, vs the previous metrics which also emitted a "0-bucket" for the opposite. This will allow us to use these metrics more clearly in Finch. This also changes the meaning of the currently unused appcache.UpdateJob.ExistingResourceCorruptionRecovery to behave in this same way. Bug: 1033703,989611 Change-Id: Iac9575de286db19102d9586866606e31d9c0bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376571 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#803660}
-
Eugene Zemtsov authored
Bug: 1122955 Change-Id: I0d31e92fedfa8cbaf52445b1d727bb19401369c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381255Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#803659}
-
Robin Lewis authored
Bug: 1123858 Change-Id: Ide486d795a4b0c244e082e04ab3e9da02b0ff157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387621Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#803658}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I30ef2ad1444a2d21e59da4a590c8da1df4952668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382071Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#803657}
-