GitLab

        Reviewed by Tor Arne Vestbø.

        QWebElement API changes after another round of API review:

        * Fix argument names of findAll/findFirst
        * Split up toXml into innerXml and outerXml
        * Removed confusing toggleClass overload
        * Fixed casing of namespaceUri to follow QXmlStreamReader
        * Removed tagName from firstChild/nextSibling/etc.
        * Renamed append/prepend/insertAfter/insertBefore to [append|prepend][Inside|Outside]
        * Renamed wrapWith() back to wrap()
        * Made clone() const
        * Renamed remove() to takeFromDocument(), added removeFromDocument()
        * Renamed clear() to removeChildren()
        * Renamed scriptsFunctions/callScriptFunction to functions()/callFunction()
        * Renamed scriptProperty to scriptableProperty

git-svn-id: svn://svn.chromium.org/blink/trunk@42934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed: bump versions in preparation for 1.1.6 release.

        * configure.ac:

git-svn-id: svn://svn.chromium.org/blink/trunk@42933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        Leave a bit of space from the previous page when advacing a whole
        page. This matches the behavior of our scrollbar scrolling code
        and is just nicer in general.

        * webkit/webkitwebview.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Add a function for resetting the zoom factor to 1.0.
        
https://bugs.webkit.org/show_bug.cgi?id=25447


git-svn-id: svn://svn.chromium.org/blink/trunk@42931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        <rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII

        Reviewed by Adam Roben

        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):
        decode the filename before processing it as part of the image name that's passed to the client



git-svn-id: svn://svn.chromium.org/blink/trunk@42930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tor Arne Vestbø.

        Fix some qdoc warnings.

git-svn-id: svn://svn.chromium.org/blink/trunk@42929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed, build fix.

        - fix initialization order to match declaration order to fix release build

        * page/Settings.cpp:
        (WebCore::Settings::Settings):



git-svn-id: svn://svn.chromium.org/blink/trunk@42928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed: committed a few bits by mistake, remove them.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::handleEditingKeyboardEvent):

git-svn-id: svn://svn.chromium.org/blink/trunk@42927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Refactor keyboard event handling to work properly under caret
        browsing mode. Most of the code comes from the Windows port.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::):
        (WebKit::interpretKeyEvent):
        (WebKit::handleEditingKeyboardEvent):
        (WebKit::EditorClient::handleKeyboardEvent):

git-svn-id: svn://svn.chromium.org/blink/trunk@42926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Based on a patch by Alp Toker.

        Add enable-caret-browsing setting to WebKitWebView.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Justin Garcia.

        https://bugs.webkit.org/show_bug.cgi?id=16135
        [GTK] Support caret browsing

        Based on a patch by Alp Toker.

        Implement basic support for caret browsing, active only when the
        corresponding setting is enabled.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseReleaseEvent):
        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocus):
        (WebCore::clearSelectionIfNeeded):
        (WebCore::FocusController::setFocusedNode):
        * page/Frame.cpp:
        (WebCore::Frame::setFocusedNodeIfNeeded):
        (WebCore::Frame::setSelectionFromNone):
        (WebCore::Frame::respondToChangedSelection):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

git-svn-id: svn://svn.chromium.org/blink/trunk@42924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber stamped by Maciej "Henry Morgan" Stachowiak.

        Enable YARR.
        (Again.)

        * wtf/Platform.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        Tweak a loop condition to keep GCC happy,
        some GCCs seem to be having issues with this. :-/

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::breakTarget):
        * wtf/Platform.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        Disable test intermittent failing test.

        * svg/custom/filter-source-alpha.svg: Removed.
        * svg/custom/filter-source-alpha.svg-disabled: Copied from svg/custom/filter-source-alpha.svg.



git-svn-id: svn://svn.chromium.org/blink/trunk@42921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser

        Fix video-played.html layout test.

        https://bugs.webkit.org/show_bug.cgi?id=25424

        We implement playForMillisecs() which makes sure the video
        will have been playing for a minimum time.

        Note, this does not ensure a strict synchronization between the time
        asked and the media playback. But given that media playback is the
        slow part we just need to compensate for the delay involved by playback.
        (And not the other way around.)

        Moreover, we split the test in 3 in order to be more gentle which
        slower machines that may tend to timeout more easily on those tests.

        * media/video-played-collapse-expected.txt: Added.
        * media/video-played-collapse.html: Added.
        * media/video-played-expected.txt:
        * media/video-played-reset-expected.txt: Added.
        * media/video-played-reset.html: Added.
        * media/video-played.html:
        - Split tests in multiple files.
        - Makes sure we always play as much as requested by using
        playForMillisecs();
        * media/video-played.js: Added.
        (testRanges):
        (nextTest):
        (pause):
        (canplay):
        (willCreateNewRange):
        (startPlayingInNewRange):
        (startPlaying):
        (secToMilli):
        (milliToSecs):
        (playForMillisecs.callPauseIfTimeIsReached):
        (playForMillisecs):
        (videoPlayedMain):

git-svn-id: svn://svn.chromium.org/blink/trunk@42920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        Fix a compile breakage.
        <https://bugs.webkit.org/show_bug.cgi?id=25384>

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: svn://svn.chromium.org/blink/trunk@42919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        <rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash

        QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a 
        multiplier to scale from natural size to current size when a movie is opened and use that to 
        return the correct value from the naturalSize() method.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor.
        (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale.
        (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial
        size and natural size so naturalSize() accounts for non-identity movie matrix.
        (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches
        QTMovieLoadStateLoaded for the first time.



git-svn-id: svn://svn.chromium.org/blink/trunk@42918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-27  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

        The problem here is that we had a self-painting layer nested inside 
        a non-self-painting layer. We ended up ignoring the self-painting 
        layer both during painting and hit-testing. This patch corrects 
        that. 

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::hitTestLayer):

LayoutTests:

2009-04-27  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Test for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

        * fast/css/nested-layers-with-hover.html: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.checksum: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.png: Added.
        * platform/mac/fast/css/nested-layers-with-hover-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        kCFStreamSSLAllowsExpiredCertificates to true to allow expired 
        certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
        certificate chain validation. (<rdar://problem/6382059>)

        Reviewed by John Sullivan.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::makeFinalRequest):



git-svn-id: svn://svn.chromium.org/blink/trunk@42916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=22242

        Add pixel test for zoomed video with controls, with and without a transform.

        * media/video-zoom-controls.html: Added.
        * platform/mac/media/video-zoom-controls-expected.checksum: Added.
        * platform/mac/media/video-zoom-controls-expected.png: Added.
        * platform/mac/media/video-zoom-controls-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adele Peterson

        <rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well

        Fix a 'size changed' notification thrash that caused standalone video elements
        to continually resize after full page zooming, by using the movie's natual size (which is independent
        of zooming), rather than its current size (which is not).

        Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
        disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
        QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
        <rdar://problem/6822344>.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::naturalSize):

git-svn-id: svn://svn.chromium.org/blink/trunk@42914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler

        <rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
        load if movie had been previously viewed

        Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
        to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.

        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::rendererIsNeeded):

git-svn-id: svn://svn.chromium.org/blink/trunk@42913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Geoffrey Garen.

        Move more window event related code into DOMWindow.

        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        (WebCore::Document::setWindowAttributeEventListener):
        (WebCore::Document::dispatchWindowEvent):
        (WebCore::Document::dispatchLoadEvent):
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Node.cpp:
        * dom/Node.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
        (WebCore::DOMWindow::postMessageTimerFired):
        (WebCore::DOMWindow::dispatchEvent):
        (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget):
        (WebCore::DOMWindow::dispatchLoadEvent):
        (WebCore::DOMWindow::dispatchUnloadEvent):
        (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::shouldClose):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::parseMappedAttribute):



git-svn-id: svn://svn.chromium.org/blink/trunk@42912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-27  Douglas R. Davidson  <ddavidso@apple.com>

        Implement the editing mechanisms and add context menu items for
        <rdar://problem/6724106> WebViews need to implement text checking

        Reviewed by Justin Garcia.

        * editing/Editor.cpp:
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        * loader/EmptyClients.h:
        * page/ContextMenuController.cpp:
        * page/EditorClient.h:
        * page/mac/WebCoreViewFactory.h:
        * platform/ContextMenu.cpp:
        * platform/ContextMenuItem.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:

WebKit:

2009-04-27  Douglas R. Davidson  <ddavidso@apple.com>

        Add localizable strings for 
        <rdar://problem/6724106> WebViews need to implement text checking

        Reviewed by Justin Garcia.

        * English.lproj/Localizable.strings:

WebKit/mac:

2009-04-27  Douglas R. Davidson  <ddavidso@apple.com>

        Add the various switches and context menu items needed for
        <rdar://problem/6724106> WebViews need to implement text checking
        and adopt updatePanels in place of old SPI _updateGrammar.

        Reviewed by Justin Garcia.

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusReceivedFromOldClients):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::uppercaseWord):
        (WebEditorClient::lowercaseWord):
        (WebEditorClient::capitalizeWord):
        (WebEditorClient::showSubstitutionsPanel):
        (WebEditorClient::substitutionsPanelIsShowing):
        (WebEditorClient::toggleSmartInsertDelete):
        (WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
        (WebEditorClient::toggleAutomaticQuoteSubstitution):
        (WebEditorClient::isAutomaticLinkDetectionEnabled):
        (WebEditorClient::toggleAutomaticLinkDetection):
        (WebEditorClient::isAutomaticDashSubstitutionEnabled):
        (WebEditorClient::toggleAutomaticDashSubstitution):
        (WebEditorClient::isAutomaticTextReplacementEnabled):
        (WebEditorClient::toggleAutomaticTextReplacement):
        (WebEditorClient::isAutomaticSpellingCorrectionEnabled):
        (WebEditorClient::toggleAutomaticSpellingCorrection):
        (WebEditorClient::checkTextOfParagraph):
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory contextMenuItemTagShowColors]):
        (-[WebViewFactory contextMenuItemTagCorrectSpellingAutomatically]):
        (-[WebViewFactory contextMenuItemTagSubstitutionsMenu]):
        (-[WebViewFactory contextMenuItemTagShowSubstitutions:]):
        (-[WebViewFactory contextMenuItemTagSmartCopyPaste]):
        (-[WebViewFactory contextMenuItemTagSmartQuotes]):
        (-[WebViewFactory contextMenuItemTagSmartDashes]):
        (-[WebViewFactory contextMenuItemTagSmartLinks]):
        (-[WebViewFactory contextMenuItemTagTextReplacement]):
        (-[WebViewFactory contextMenuItemTagTransformationsMenu]):
        (-[WebViewFactory contextMenuItemTagMakeUpperCase]):
        (-[WebViewFactory contextMenuItemTagMakeLowerCase]):
        (-[WebViewFactory contextMenuItemTagCapitalize]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView isAutomaticQuoteSubstitutionEnabled]):
        (-[WebHTMLView setAutomaticQuoteSubstitutionEnabled:]):
        (-[WebHTMLView toggleAutomaticQuoteSubstitution:]):
        (-[WebHTMLView isAutomaticLinkDetectionEnabled]):
        (-[WebHTMLView setAutomaticLinkDetectionEnabled:]):
        (-[WebHTMLView toggleAutomaticLinkDetection:]):
        (-[WebHTMLView isAutomaticDashSubstitutionEnabled]):
        (-[WebHTMLView setAutomaticDashSubstitutionEnabled:]):
        (-[WebHTMLView toggleAutomaticDashSubstitution:]):
        (-[WebHTMLView isAutomaticTextReplacementEnabled]):
        (-[WebHTMLView setAutomaticTextReplacementEnabled:]):
        (-[WebHTMLView toggleAutomaticTextReplacement:]):
        (-[WebHTMLView isAutomaticSpellingCorrectionEnabled]):
        (-[WebHTMLView setAutomaticSpellingCorrectionEnabled:]):
        (-[WebHTMLView toggleAutomaticSpellingCorrection:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebUIDelegatePrivate.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebView setGrammarCheckingEnabled:]):
        (-[WebView isAutomaticQuoteSubstitutionEnabled]):
        (-[WebView isAutomaticLinkDetectionEnabled]):
        (-[WebView isAutomaticDashSubstitutionEnabled]):
        (-[WebView isAutomaticTextReplacementEnabled]):
        (-[WebView isAutomaticSpellingCorrectionEnabled]):
        (-[WebView setAutomaticQuoteSubstitutionEnabled:]):
        (-[WebView toggleAutomaticQuoteSubstitution:]):
        (-[WebView setAutomaticLinkDetectionEnabled:]):
        (-[WebView toggleAutomaticLinkDetection:]):
        (-[WebView setAutomaticDashSubstitutionEnabled:]):
        (-[WebView toggleAutomaticDashSubstitution:]):
        (-[WebView setAutomaticTextReplacementEnabled:]):
        (-[WebView toggleAutomaticTextReplacement:]):
        (-[WebView setAutomaticSpellingCorrectionEnabled:]):
        (-[WebView toggleAutomaticSpellingCorrection:]):
        * WebView/WebViewPrivate.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower

        Be slightly less eager in collecting after page close/navigation by increasing
        the time before collection from 0 seconds to .5 seconds.

        3% speedup on the PLT.

        * bindings/js/GCController.cpp:
        (WebCore::GCController::garbageCollectSoon):



git-svn-id: svn://svn.chromium.org/blink/trunk@42910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe and Darin Adler.

WebCore:

        * WebCore.base.exp: Added exports.
        * WebCore.xcodeproj/project.pbxproj: Added
        RuntimeApplicationChecks.{h|mm} source files to the project.
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
        Removed local checkedSafari and isSafari variables and switched
        to use applicationIsSafari().
        * platform/mac/RuntimeApplicationChecks.h: Added.
        * platform/mac/RuntimeApplicationChecks.mm: Added.
        (WebCore::applicationIsAppleMail): Runtime application check for
        Apple Mail.
        (WebCore::applicationIsSafari): Runtime application check for
        Safari.

WebKit:

        * WebCoreSupport/WebContextMenuClient.mm:
        (isAppleMail): Removed.
        (fixMenusToSendToOldClients): Switched to use
        applicationIsAppleMail().
        * WebView/WebFrame.mm:
        (-[WebFrame reload]): Switched to use applicationIsSafari().
        * WebView/WebPDFView.mm:
        (-[WebPDFView menuForEvent:]): Ditto.
        * WebView/WebResource.mm:
        (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]):
        Switched to use applicationIsAppleMail().
        * WebView/WebView.mm:
        (runningLeopardMail): Ditto.
        (runningTigerMail): Ditto.
        (-[WebView _needsKeyboardEventDisambiguationQuirks]): Switched
        to use applicationIsSafari().

git-svn-id: svn://svn.chromium.org/blink/trunk@42909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=25374

Updated to fix regression test failures



git-svn-id: svn://svn.chromium.org/blink/trunk@42908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Based on a patch by Alp Toker.

        Cover more WebCore role -> ATK role conversions.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Do not call ATK setters in the getters, just return the
        value. Among other things calling the setter will emit the notify
        signal, which is wrong.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Based on a patch by Alp Toker.

        Implement AtkImage interface.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed debug build fix.

        * platform/gtk/gtk2drawing.c:
        (moz_gtk_toggle_paint):

git-svn-id: svn://svn.chromium.org/blink/trunk@42904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Build fix.

        https://bugs.webkit.org/show_bug.cgi?id=25382
        Remove direct reference to CallFrame.h include to pacify Win build.

        * bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
        * bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h

git-svn-id: svn://svn.chromium.org/blink/trunk@42903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=25374



git-svn-id: svn://svn.chromium.org/blink/trunk@42902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25382
        Move scriptStateFromNode to ScriptState.

        * bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
        * bindings/js/JSDOMBinding.h: Ditto.
        * bindings/js/ScriptState.cpp:
        (WebCore::scriptStateFromNode): Added.
        * bindings/js/ScriptState.h: Ditto.
        * bindings/v8/ScriptState.cpp:
        (WebCore::scriptStateFromNode): Added.
        * bindings/v8/ScriptState.h: Ditto.
        * dom/NodeFilter.h: Removed JSDOMBinding header include.
        * dom/NodeIterator.h: Ditto.
        * dom/TreeWalker.h: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@42901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
https://bugs.webkit.org/show_bug.cgi?id=25428



git-svn-id: svn://svn.chromium.org/blink/trunk@42900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Update the example plug-in for new changes to the Cocoa event model.
        
        * NetscapeCocoaPlugin/main.m:
        (handleDraw):
        (handleMouseEvent):
        (NPP_HandleEvent):



git-svn-id: svn://svn.chromium.org/blink/trunk@42899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
        * Plugins/WebNetscapePluginView.mm: The base class of WebNetscapePluginView.mm, WebBaseNetscapePluginView, already implemented 
        the two methods below. But the Tiger compiler didn't know that. 
        (-[WebNetscapePluginView webView]): 
        (-[WebNetscapePluginView webFrame]):



git-svn-id: svn://svn.chromium.org/blink/trunk@42898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        <rdar://problem/6352982>
        
        * Plugins/WebBaseNetscapePluginView.mm: Removed checkIfAllowedToLoadURL:frame:callbackFunc, cancelCheckIfAllowedToLoadURL, and 
        _webPluginContainerCancelCheckIfAllowedToLoadRequest from the base class. These methods now exist in the subclass WebNetscapePluginView.
        
        Added WebNetscapeContainerCheckContextInfo, which is used as a "contextInfo" object in 
        -[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]
        * Plugins/WebNetscapeContainerCheckContextInfo.h: Added.
        * Plugins/WebNetscapeContainerCheckContextInfo.mm: Added.
        (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:]): Added desiginated initializer.
        (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Added. Returns the checkRequestID.
        (-[WebNetscapeContainerCheckContextInfo callback]): Added. Returns the callback.
        
        * Plugins/WebNetscapePluginView.h: Added two new ivars: _containerChecksInProgress and _currentContainerCheckRequestID.
        * Plugins/WebNetscapePluginView.mm: #import both WebPluginContainerCheck.h and WebNetscapeContainerCheckContextInfo.h
        
        (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added. This is the implementation of WKN_CheckIfAllowedToLoadURL.
        Here, we increment the request ID and start the container check.
        
        (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Added. This is a callback method for WebPluginContainerCheck.
        It's where we actually call into the plug-in and provide the allow-or-deny result.
    
        (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Added. This is the implementation of WKN_CancelCheckIfAllowedToLoadURL. 
        Here we lookup the check, cancel it, and remove it from _containerChecksInProgress.
        
        (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added. WebPluginContainerCheck automatically calls
        this method after invoking our _containerCheckResult: selector. It works this way because calling -[WebPluginContainerCheck cancel] allows
        it to do it's teardown process.
        
        (-[WebNetscapePluginView fini]): Release _containerChecksInProgress ivar.
        
        * Plugins/WebPluginContainerCheck.h: Removed initWithRequest: method from header; no client was using this method directly.
        * Plugins/WebPluginContainerCheck.mm: 
        (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:contextInfo:]): Added optional contextInfo parameter.
        (-[WebPluginContainerCheck _continueWithPolicy:]): If there's a contextInfo object, pass it as a parameter to resultSelector.
        (-[WebPluginContainerCheck cancel]): Release _contextInfo ivar.
        (-[WebPluginContainerCheck contextInfo]): Added new method. Returns the contextInfo object, if one so exists.
        * Plugins/WebPluginController.mm:
        (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Pass nil for contextInfo. WebKit-style
        plug-ins do not need additional context information.



git-svn-id: svn://svn.chromium.org/blink/trunk@42897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=25399
        <rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
        beneath WebCore::Cache::evict

        The crash happened because a cached resource handle was removed from a document's cached
        resources map twice recursively, so a destructor was called for a value in a deleted bucket.
        The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
        CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
        an inconsistent state.

        I couldn't fully reconstruct the loading sequence to make a test.

        * loader/Cache.cpp:
        (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache
        (it makes no sense to revalidate one that isn't).
        (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource
        from the cache in no way implies that documents no longer use the old version. This fixes the
        crash, and also fixes many cases of resource content being unavailable in Web Inspector.

        * loader/CachedResource.h:
        (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache,
        reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never
        being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases,
        switchClientsToRevalidatedResource() results in the same resource being requested again,
        but we were only enforcing CachedResource invariants after calling this function.
        (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.

        * loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed
        resource is removed, not some other resource that happens to have the same URL (this used to
        fail on LexisNexis search before this patch).

        * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED
        with notImplemented(). This method can be legally called via document.write(), and should
        work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it
        doesn't affect site functionality.

        * loader/CachedResource.cpp:
        (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate
        is being revalidated - this may no longer be true, because we now reset this member in
        CachedResource::setInCache().



git-svn-id: svn://svn.chromium.org/blink/trunk@42896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - make BidiContext a RefCounted class, starting with a refcount of 1,
          and share the root BidiContexts.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
        * platform/text/BidiContext.cpp:
        (WebCore::BidiContext::create): Added. For the four "root" contexts,
        returns a reference to a shared static BidiContext.
        * platform/text/BidiContext.h:
        (WebCore::BidiContext::BidiContext):
        * platform/text/BidiResolver.h:
        (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::determineStartPosition): Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42895 bbb929c8-8fbe-4397-9dbb-9b2b20218538