- 10 Sep, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I83438888e9bc42b8965e4e3aebd045da75dc9dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805960}
-
Charlie Hu authored
This CL adds feature author guide section for document policy to README.md. Change-Id: Ib75b203192545fbbb8de48ceef25f1156398c4a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380609Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#805959}
-
Xianzhu Wang authored
This reverts commit cf0f02ca. Reason for revert: may be the cause of crbug.com/1127106 (linux-blink-rel failure in webdriver_tests_suite) Original change's description: > [chromium] Enable ChromeDriver log for WPT tests > > Enable chromedriver log for CI wpt tests > > Change-Id: I02d4acb627ca90233b7c0dab401c7c28e6759604 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402319 > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Shengfa Lin <shengfa@google.com> > Cr-Commit-Position: refs/heads/master@{#805817} TBR=sky@chromium.org,johnchen@chromium.org,kyleju@chromium.org,shengfa@google.com Bug: 1127106 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0ca84f034e92e8858cd4fcf23bb49b0e52161f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404158Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805958}
-
Tomasz Wiszkowski authored
This change ensures that the RecyclerView clears the view pool when the user ends interaction with the Omnibox. Bug: 1075602 Change-Id: Iacd36ade19e67144421674cc85c05b750bd0b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404390 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#805957}
-
Peter Kasting authored
This replaces it with direct callback registration on the underlying links, conveyed by setting the callback on the RangeStyleInfo corresponding to the link. This allows eliminating parameters like the range, since a different callback or different bound arguments can be set for each range. With a change to how ContentSettingBubbleContents works (which was the other place using the Link* argument of Link::ClickedCallback), this allows reducing Link::ClickedCallback to one argument as well. It makes sense to make these changes simultaneously since they mostly affect the same listeners and thus this avoids changing lots of signatures twice. Bug: 1108460 Change-Id: Ie7c9cc7cafeb92b91aad2949e176b99d26d493e3 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388944 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805956}
-
Ben Mason authored
Bug: 1126713 Change-Id: Ie53a32768b8246f6ec7443281c65a08608f4e04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404521 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805955}
-
Kalvin Lee authored
This change prepares all public methods of PpdProvider to accept arguments that may contain mixed-case effective-make-and-model strings and explicitly converts any such members to lowercased ASCII. Bug: chromium:888189 Test: none Change-Id: I7ed8399858924828c138f0c27f86408a9ddcae32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363656 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#805954}
-
Shengfa Lin authored
main page Chrome has recent behavior change that it sends out load event fired for Out of Process Iframe(OOPIF). When ChromeDriver received it, it assumed that it's for the main page causing navigation to complete prematurely. The fix is to check the load event fired come from main page. Bug: chromedriver:3594 Change-Id: Icdc589ec6733c28e549b9110ea225fe7df00ce01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402323Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#805953}
-
chrome://signin-internalsJun Kokatsu authored
This change moves a style added for expired token in C++ code to JS code, in order to be compatible with Trusted Types. Bug: 1125965 Change-Id: I69c9d75364cf2ece4ed5009d981ebdf063f88fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401811 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805952}
-
Wenyu Fu authored
Add the content description for the loading spinner so that the screen reader can read out the loading status correctly. Change-Id: Ifa46b4b1c2d8255a592751132d56f66edb8b1257 Bug: 1119587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368445 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#805951}
-
Gang Wu authored
The CL-https://chromium-review.googlesource.com/c/chromium/src/+/2382958 caused this test to fail was reverted, so enable the test now. I thought "about"blank" was the problem, but after check the code, "about:blank" should not been recommended in the Omnibox suggestions, Therefore, using "about" here is kind of a test for that as well. Bug: 1126145 Change-Id: I2d78194c4663436d91a9c5965ca9fb4bdd0fc27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402324Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805950}
-
Josh Nohle authored
Using base::Time::Min() for the overdue private certificate expiration time resulted in integer overflow because base::Time does not use clamped arithmetic. See crbug/1127026. Change-Id: I00a898858bf6d2b97aa6a34a37ca2ee90d2c9836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404363 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#805949}
-
Scott Violet authored
If clip is set along one axis, the other axis must be either visible or clip. If not, clip is forced to hidden. This also removes a DCHECK in ComputedStyle::IsOverflowVisible(). I'm going to rename that function shortly (https://chromium-review.googlesource.com/c/chromium/src/+/2402303) BUG=1087667 TEST=StyleAdjusterTest Change-Id: Id00c6cd3269a81a391d541f994b9326a493c7bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402295Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805948}
-
Tsuyoshi Horo authored
Bug: 1053702 Change-Id: I65814fdd8ba45c46195141c5d5303bf49baf2c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397996Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805947}
-
Chromium WPT Sync authored
Using wpt-import in Chromium da055314. With Chromium commits locally applied on WPT: d3d1f16b "Visited background-color alpha channel in Forced Colors Mode" d5e233ea "WPT: Refactor idle-detection tests to use test-only-api.js" 612ba1ba "CookieStore: Remove matchType" 79f6cff0 "Animation effect now remains after timeline goes inactive while paused" da055314 "Revert "CookieStore: Remove matchType"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I06216c4604638b04c7c043f4a570e60f41b0f20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404482Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805946}
-
Arnaud Coomans authored
When simulating a fake audio device with the --use-fake-device-for-media-stream --use-file-for-fake-audio-capture=audio.wav arguments, the filepath (`audio.wav` here) isn't accessible because of the mac sandbox. As a result, opening the file fails and the audio file isn't played. This changeset adds a suggestion to disable the sandbox if simulating a fake audio device fails reading the audio file. Bug: 1032604 Change-Id: Ia4bc9a1ba4eb9a6d199f7d018bb0122bbd912517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383230Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805945}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 10 on the bug for details on why these studies are candidates for removal. Also, cleans up the ChromeSmartSelection feature flag. htpp://crbug/1127065 was filed for cleaning up a test file related to CopylessPaste, which can probably just be removed. Bug: 1126640 Change-Id: Ib63ce18c5cdbc8832f8cd8e98c7e007c8ba322b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404940Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805944}
-
Chris Thompson authored
This replaces the SCTReport struct used to store SCT audit reports in the SCTAuditingCache with the TLSConnectionReport proto we will use for sending reports to the server. Creating the proto at the time of adding the report to the cache avoids having to later translate the SCTReport into the final proto form, and lets us remove the SCTReport struct entirely. Bug: 1082860 Change-Id: Ib5848744fb79d33ce50f0909531ff983dc55af54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333302Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#805943}
-
Kalvin Lee authored
This change modifies the ZeroconfPrinterDetector to use the ty field specified in the ParsedMetadata class (instead of the product field) when calling Printer::set_make_and_model(). Bug: chromium:1062865 Fixed: chromium:1062865 Test: chromeos_unittests Change-Id: I7b1b742b402843cfa6e2d43f6318085ff578b2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399572Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805942}
-
Noah Rose Ledesma authored
This change fixes a bug where the "Devices" button in GMC had no text on Mac canary builds. The string associated with this button was moved to a more appropriate grd file. Bug: 1127069 Change-Id: Ic72ee633cdbd0094f7c6f402c15f2ea7a558a19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404942Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#805941}
-
Matt Jones authored
This patch moves the ownership of SceneOverlays from individual Layouts to the LayoutManager. Deciding whether an overlay should be shown can be done at the feature level rather than depending on the LayoutManager to sort them. For the most part, this patch is a logic move, but checks for whether an overlay is showing have been added before calling their respective methods. Bug: 1100332 Change-Id: Ic7f4bc9823295684bf3cc45007b0b227db11dd82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380267Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#805940}
-
K. Moon authored
This reverts commit 3e085ec3. Reason for revert: Test is crashing with a segmentation fault Original change's description: > Add a pop-up for Chrome OS secondary login screen > > Bug: 1066489 > Change-Id: I5af5d0ab745176572dfa01cb02e6d45ac1b27c99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303429 > Commit-Queue: Thomas Tellier <tellier@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Thomas Tellier <tellier@google.com> > Cr-Commit-Position: refs/heads/master@{#805844} TBR=antrim@chromium.org,raleksandrov@google.com,tellier@google.com Change-Id: I35550da66bba011cb35b9e50d38b4b02b572ce29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404061Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805939}
-
Noah Rose Ledesma authored
This change adds MediaNotificationViewModernImpl which will be used in place of MediaNotificationViewImpl when the off-by-default "Global Media Controls Modern UI" flag is enabled. This change also adds the logic to switch impls based on this flag. Bug: 1124401 Change-Id: I85893609cc8e6c072d37cd1df878498441a0044a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398950 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805938}
-
Toby Huang authored
This CL extends the expiry for the AddSupervisionDialog* UMA histograms to September 8, 2021. Bug: 1125645 Change-Id: I06478fca1b7448cd2ac46ba6722901f7ba8f6456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401266 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#805937}
-
Akihiro Ota authored
This change merges the implementation for the hint and nudge systems in the interactive tutorial. Now, nudges and hints are both mangaged by the tutorial component, instead of being split between the tutorial and lesson components. Bug: N/A Change-Id: I68f237690f336ec22f2af97bf978e76340d6ecb5 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401945 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805936}
-
Rouslan Solomakhin authored
Bug: None Change-Id: I6df78c2937779d00733d213d9607768095926de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403388Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805935}
-
Michael Bai authored
Currently to get the visual rect from layout tree requires document being paint clean, it became not a good way for ContentCapture task to get the visual rect now. This patch get the visual rect from cc while capturing the content. It should have better performance than from layout tree. Bug: 1126615,1122472 Change-Id: Id10fa1ad84f64058f30c3523b78d2aff822e62a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388344Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#805934}
-
David Black authored
This UserAction is recorded from a user click on the body of a screenshot notification. Bug: 1126573 Change-Id: Ifcb2a3910e55b5019e641b24b4b4a64288361a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401267Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#805933}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599738815-ff1bf13166c585a2e1282bb43357481f321e4e87.profdata to chrome-mac-master-1599760756-5eeaad3a0935fac8a24777486ae90bd2f43c056f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I52a51996f7a1b9bf3a5b6486429441a873db68f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805932}
-
Rakina Zata Amni authored
If a page is not stored in the bfcache, the unload event will be dispatched and might trigger actions that are currently tracked in ActionAfterPagehide. This case is not interesting to track (as it is expected for these actions to happen after pagehide), so we should only track when the unload event is not in progress. This also obsoletes the version 1 of the histogram and adds a new version (recording ActionAfterPagehide2 instead of ActionAfterPagehide now). This CL also adds tracing and fixes a bug in DOMWindow::DoPostMessage where we check the target frame instead of the source frame for pagehide status. TBR=alexmos@chromium.org Bug: 977562, 1110744 Change-Id: I5d8036c5a7037a2266cef821c44c98ee55bdfd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402849 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805931}
-
kylechar authored
Fuchsia doesn't support the GL renderer backend and always uses Vulkan. This mainly stops running parameterized pixel tests with GLRenderer or SkiaRenderer+GL on Fuchsia, except LayerTreeHostCopyRequestTest* will start running on SkiaRenderer+Vulkan when Vulkan is enabled. Bug: 1117587 Change-Id: I47a9e1286a9278c4aa901359bcb1a020b3b63ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401322Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805930}
-
John Lee authored
https://imgur.com/a/lmrQgaq Change-Id: I5d7621d209b0f081fc562250a82cef839760fc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399443Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805929}
-
Robert Sesek authored
These denials were observed in local testing. Change-Id: Iccfdbdbe4d755ac954bf6757505ee583dd89fa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404411Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805928}
-
Liquan (Max) Gu authored
Change: * Move the interface NormalizedAddressRequestDelegate from PaymentRequestImpl to PaymentUIsManager. Address normalization is treated as UI logic because it's part of Autofill which is regarded as UI logic for its tight coupling with the PaymentRequestUI. This moving includes these methods: - onAddressNormalized - onCouldNotNormalize * Because the delegate is assigned in PRImpl.startShippingAddressChangeNormalization(), the method is moved into PaymentUIsManager as well. PersonalDataManager's delegate is assigned with a different "this" (from PRImpl to PaymentUIsManager). * Refactor onAddressNormalized(): - Since redactShippingAddress() is mainly used for business logic, it's taken out from onAddressNormalized(), and turned into a static method of CPRImpl. - onAddressNormalized()'s business logic is generalized into onUiServiceError() and onShippingAddressChange(). Bug: 1102522 Change-Id: I61daf4240ca64be354cc537280948ce55481155d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401515 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805927}
-
Yuheng Huang authored
Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3259362 Bug: 1099917 Change-Id: I45be750e33c43852314516e638ef348f1efabc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399499Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805926}
-
Ryan Hansberry authored
As per post-submission convo in crrev.com/c/2370094. Change-Id: I1a8ab0fd4ff9bf1b27cbfe05c36408fce9bf2438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402399 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805925}
-
Olivier Yiptong authored
This change removes a bug on Mac: a redundant ScriptPromiseResolver creation. Bug: 1043306 Change-Id: I302255dad325c2cbca96bde07f414da689f635d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404260 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805924}
-
Evan Stade authored
//chrome/android/features/media_router is moved wholesale, with the following exceptions: * integration tests move to //chrome/android/javatests as they depend on Chrome. * ChromeMediaRouterClient is moved to //chrome/android/java as it's specific to Chrome. The unit tests are now part of components_junit_tests instead of the standalone media_router_junit_tests. Bug: 1057100 Skip-Translation-Screenshots-Check: True Change-Id: I4ee0ee59ec1622fc12983f2c5d6964ec52d4ab04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389021 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805923}
-
Tamir Duberstein authored
The referenced bug is long closed. Bug: fuchsia:20851 Change-Id: I29b79d15545b5231f09da91a0afc81451608328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404623 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#805922}
-
Kevin McNee authored
InnerWebContentsCreated was only being called for GuestViews. We now call it for portal inner contents creation. This allows for test code, namely Safe Browsing tests, to be notified of the creation of the inner contents, so that test classes are created in time to observe the necessary events in the newly created contents. Bug: 1096115 Change-Id: I6cc7e3cabb72523a8c116988194db2cbd42036cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385775Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#805921}
-