- 28 Jan, 2020 40 commits
-
-
Alexei Svitkine authored
The new presubmit about Windows command line limit fires with the current tip of tree. This CL attempts to remove more stale field trial configs to get it to pass. Removing both configs where the feature is no longer defined and those where the feature is enabled by default. Note: Not an exhaustive list, just based on some spot checks. Bug: 1045530, 1045636 Change-Id: Ie14de78fbfbc80d30cab931dd405cdc97c3120c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025829 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736138}
-
Xiaoqian Dai authored
Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804 doesn't fix the issue entirely. Looking deeper in this issue, it's actually caused by ClientControlledShellSurface::UpdateBackdrop() can be called on a dragged window (whose backdrop has been disabled (kDisabled) when drag starts) to re-enable the backdrop. This CL makes sure an ARC window with disabled backdrop mode won't be modified. Bug: 1027269 Change-Id: Ia3508a92b5c9133b5821d5f9f0a2345eccad382f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#734250} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021283Reviewed-by:
-
John Delaney authored
This CL adds a new UI thread class, ConversionManager, owned by the StoragePartition. The ConversionManager initializes and owns a ConversionStorage instance and also implements the ConversionStorage::StorageDelegate. Specific API constraints like delaying conversion reports, and setting the maximum number of conversions are implemented in a separate composable class ConversionPolicy to allow tests to easily mock certain functionality, as well as centralize these constraints to a single include. Intended functionality of the ConversionManager includes: - ownership of the ConversionReporter, and timers for periodically fetching reports to send from storage. - methods to log new impressions / conversions to storage - ownership and usage of Report Cooldown throttling implementations This functionality is intended to be implemented in follow-up CL's due to dependencies, and to keep these changes small. A more complete implementation can be seen on the prototype change below. The functionality of the API is described on https://github.com/csharrison/conversion-measurement-api Design-doc(RVG): https://crbug.com/1039466 Reference prototype change: https://chromium-review.googlesource.com/c/chromium/src/+/1967220 Bug: 1014604 Change-Id: If432b0046b8c6dcd12ce828aea3917cf887fbe08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994016Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736136}
-
Wez authored
These tests were disabled on Fuchsia because all DomCodes were mapped to native_keycodes of zero. Bug: 829551 Change-Id: I7401117eecfd8e1f4c8af04ad3cc475051699a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025388 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
-
Omer Katz authored
This is a reland of 31f93aa2 Original change's description: > heap: Check empty or deleted keys on local copy > > Tracing an HashTable involves checking whether keys are empty or > deleted. This can result in data races with the mutator if the > HashTable is modified while it is traced. > To avoid such data races, we create a local copy of the key on the > concurrent thread and perform the check on the copy. > > Using the local copy on the mutator thread would result in significant > regressions. Measured locally on the facebook_infinite_scroll:2018 story > from v8.browsind_desktop benchmark, showed an increase ranging from 70% > to 110% in the time it takes to process ephemerons (this measurement > doesn't cover all HashTables, just the ephemeron HashTable). > To avoid these regressions, the local copy is used only for concurrent > visitors. > > For further details see > https://drive.google.com/open?id=13DTRcF3xfVjJ2QaKzAOYFzqvTfGRNiX6WWL3CCACSoM > > Bug: 986235 > Change-Id: Ie135c1076bd1834ae7f8b97ca6446890fc30a02c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012961 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735833} Bug: 986235 Change-Id: Ib12f495dd24cd3a1b310d46927c2cd13d605e566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025667 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#736134}
-
David Van Cleve authored
We wanted to land crrev.com/c/202225 promptly so that it could be verified prior to stable cut, but it includes a couple temporary changes that will get reverted briefly as part of a follow-up change implementing a riskier but conceptually more coherent fix for the same issue. Change-Id: I8ebe8dd3d19686446a37754446bf536eda043671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023728 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736133}
-
Evan Stade authored
Probably fixed by 88094724 but the tests were never re-enabled. See bug for history. Bug: 1029568 Change-Id: Iffb9e629c30db1e78be7ab9100e0551f43f7eac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026190 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
This CL only modifies comments, pointing them towards the official video-raf spec. TBR: mlamouri@chromium.org Bug: 1022186 Change-Id: I2da26aa139e453ea5547b3bab84e64a2e64c29be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025831Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#736131}
-
Christopher Thompson authored
This adds a new net error and cert status for when a connection uses an obsolete version of TLS (i.e., TLS 1.0 or 1.1 in the default configuration). This also adds support for the SSLVersionMin enterprise policy setting which version triggers the error (and will thus show an interstitial warning), allowing enterprises to opt-out of the legacy TLS interstitial. A new interstitial for this error will be added in https://crrev.com/c/1940707. Support for the control site list will be added in https://crrev.com/c/1906779. Bug: 896013, 1039756 Change-Id: Ib24d4b3efcfbbad1f37a41bfed3690280d4d2b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894616 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#736130}
-
Devlin Cronin authored
Add some documentation on how extension APIs work, and best practices for writing a new one. Bug: None Change-Id: I82e2ca785d474ba533dec244b91e36b9b55178b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024122Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736129}
-
Mathias Carlen authored
This patch introduces a new UI section in the collect data view. It can be used to show a flat, informational string and is independent of other sections. The info section does support links similarly to what the terms sections do. Meaning, <link0>text</link0> will be handled the same way as the latter. The initial plan was to add an additional state to the terms states to handle a new use case where only text is shown, no UI elements. This was deemed to involved and the result is this stand-alone new section that also supports the same use case even if distinct in the proto. Bug: b/147580725 Change-Id: Ib1d51b169040dc8981d0565b3faa292bfea1c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022648 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#736128}
-
Demetrios Papadopoulos authored
cr.exportPath() is no longer used, and therefore does not need to be handled by polymer.py. Bug: 1028829 Change-Id: I6113a4f5feb94f8e17217cad279e2cab214c3c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025868 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#736127}
-
Joshua Bell authored
During upgrade transactions, a store or index can be created and then immediately used from script in operations (e.g. "count"). On the backend, the creation will not run until the transaction acquires a lock, and pending tasks are queued. A handful of operations (including "count()") were synchronously checking to see if the target store/index had been created before queuing the task, which would fail if the lock had not yet been acquired. The checks must occur when the task is run; remove the bogus early checks, which would abort the transaction. Bug: 1045585 Change-Id: Ibef191e24916333da4e9b2449dda5ff775a35138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023521Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736126}
-
Yi Gu authored
This test may timeout on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBibGlua19oZWFwX3VuaXR0ZXN0c0BIZWFwVGhyZWFkRGVhdGhUZXN0LlBlcnNpc3RlbnRTYW1lVGhyZWFkQ2hlY2sM TBR=bikineev@chromium.org Bug: 1043580 Change-Id: Iba18b7c7f6c57c65ef285397198d2a12e2d19951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025975Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736125}
-
Xiaoqian Dai authored
But tab dragging is still kept enabled. However, it will not be visible to the user from M81 since they have mohnstrudel (#webui-tab-strip) enabled. If mohnstrudel is disabled from chrome://flags, then the user should still be able to do tab dragging. Bug: 1041928 Change-Id: I2bfd2cc677ee82d9088006614ecb4f0d21b61cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025574 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736124}
-
Dominic Mazzoni authored
The options in an HTML select element are present in the accessibility tree even when the popup is not visible. As a result it's possible for AT such as ChromeVox to fire a click event on an option. However, since the popup is collapsed, the expected behavior is for the menu to pop open - then clicking it again should close it. This wasn't implemented before because most AT only sends the click event to the <select> element when it's collapsed. Bug: 1046087 Change-Id: Ic110efc771490035e24041362211dc5c61585248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025323Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736123}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a0715c4..390a4513 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1159011773ad7d987333cb6a4a7475b92dfbe75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025249Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736122}
-
Guido Urdaneta authored
This policy allows enterprises to disable screen sharing (desktop, window or tab) via the getDisplayMedia() and extension APIs. Bug: 1003720 Change-Id: Ie4271e7e6cf29f670f3730cae8119800520e6b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025347Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736121}
-
Yi Gu authored
This reverts commit 4717f398. Reason for revert: Broke ios-simulator-xcode-clang bot. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8889981707645765280/+/steps/compile/0/stdout Original change's description: > Basic implementation and tests for HangWatcher. > > This class is a successor to ThreadWatcher which aims to be more > versatile and provide a larger coverage for hang watching. > > Bug: 1034046 > Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736080} TBR=fdoray@chromium.org,olivierli@chromium.org Change-Id: I88af4ad3baf02af94adcc0770168ce7adc7ede45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026174Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I90a426425fd15b06ea935b17be00094dcd0a5d01 Tbr: agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025788 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736119}
-
Manu Cornet authored
Also calculate the new hotseat state as part of calculating new target bounds instead of passing it in. Bug: 1042911, 1040177 Change-Id: Ie3471df435ba9ce49130e528811c17da0e249b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025428 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Darwin Huang authored
Bug: 1045591 Change-Id: I9d9b169f2abc286c84f0906658e9be9b8af31791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020406Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736117}
-
Tommy Li authored
Currently, the on-focus configuration in fieldtrial_testing_config.json is in the "NTPZeroPrefixSuggestions" trial. The problem is that about_flags.cc configures on-focus suggestions with the "OmniboxBundledExperimentV1" field trial. This mismatch between fieldtrial_testing_config.json and about_flags.cc causes a crash. It's most proper to match what's in fieldtrial_testing_config.json and about_flags.cc. We won't be able to match the server-side config all the time, since Dev/Canary uses the "unbundled" experiment format, and Beta and Stable use the "bundled" experiment format. But so long as fieldtrial_testing_config.json and about_flags.cc match, the client-side code is correct. Bug: 1015174 Change-Id: I93fd6cf6392f3de2a0e326bbdfe736bb9a10acc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019329Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736116}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8c52e8a2efb0..ed9a401f277b git log 8c52e8a2efb0..ed9a401f277b --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01683979..5146474c (735581:735951) Created with: gclient setdep -r src/third_party/webrtc@ed9a401f277b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I66916bf3af6ef66fee2b3c40007163be6ddf7d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736115}
-
Nick Diego Yamane authored
This fixes libgtkui-based file dialogs support on Ozone X11 and prepares X11 event source implementations for the upcoming PlatformEvent migration CLs. Further details: CL standardizes the X11EventSource interface (i.e: Support XEvent => ui::Event translation, XEvent specific dispatchers and observers, etc), moving most of the code out of the default delegate implementation into X11EventSource itself. 2 reasons motivate this change: 1. Gtk-based file dialogs do not work in Ozone X11 with FdWatch-based source. So, as an initial fix, this CL makes it possible to use the pure glib-based implementation (i.e: uses glib API, GSource directly, etc) in Ozone builds with use_glib=true. FdWatch-based impl, originally used in ozone-based products, misses some events because it does not use the XPending() function to check for new events (instead it only watches for X11 connection FD changes). Thus, with this change, pure glib-based X11 event source is used in Ozone when use_glib GN arg is set explicitly, otherwise the fdwatch-based one is used (e.g: CrOS on Linux). 2. It is a preliminary and required step for the upcoming PlatformEvent migration CLs [1]. As one of the first speps of the migration, event source must support the same API and logic as the one originally used in ozone, as described above. As, at this point, it still must support the non-Ozone path (where PlatformEvent is still defined as XEvent*), Ozone specific code is guarded under USE_OZONE build flag. As a side effect, this simplifies a lot of X11EventSourceDelegate impls so that they turn into XEvent "watchers" instead, so this CL also renames them accordingly. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=965991 Bug: 1008755, 963419 Change-Id: I060ec0dab519590e485e5baa96b5e84a7afad5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863940Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#736114}
-
Arthur Wang authored
R=harringtond@chromium.org Bug: 1044242 Change-Id: I05b9eb75f8d1ae507492fbdb987e44719e9b2bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016188Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736113}
-
chrome://settings/settings_v3.htmlDemetrios Papadopoulos authored
- Modify Settings data source to serve generated files. - Add top-level JS/HTML files that will host the V3 version. - Use a JS import for the generated chrome://settings/search_settings.m.js as a proof of concept. - Update BUILD.gn files as needed. Note that the dummy page is currently only available for optimized_webui=false builds. This is in preparation of migrating to Polymer 3. Bug: 1026426 Change-Id: I53dc831bfad3cf4645fa91c643bd5e34d14190de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024161 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
sczs authored
- Creates SaveCardInfobarMetricsRecorder inline with other Infobars, to record Save Card infobar specific metrics. - Creates Mobile.Messages.Save.Card.Modal.Event and its enum to record when a user starts editing any of the editable fields Bug: 1029067 Change-Id: Icc2588dad0578d8c232baa720b74585a15f5ef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024282Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#736111}
-
Henrique Nakashima authored
TBR=pasko@chromium.org NOTRY=true Bug: 1033305 Change-Id: Ic5595b4315cd98ee92de1d820ffcfda81fc1a58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026149 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736110}
-
Sami Kyostila authored
Remove the deprecated trace id mangling facility and convert the last remaining uses to the new API as follows: TRACE_ID_MANGLE() => TRACE_ID_LOCAL() // Process-local id. TRACE_ID_DONT_MANGLE() => TRACE_ID_GLOBAL() // Cross-process id. Test: Checked that a trace with input flow events still looks correct. Bug: 639003 Change-Id: I2493e89787a49368528f844e8d37cfd120558fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016648 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Yi Gu authored
The test is currently linked to a general purpose bug which has been marked as wont fix. This patch links it to a new bug to track the fix. TBR=aaronhk@chromium.org Bug: 1045346 Change-Id: Ib15d2f362b1c39e2e635a609dad922095b1088ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026108Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7488a0964115..4a8fa19f0574 git log 7488a0964115..4a8fa19f0574 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 spang@chromium.org Fuchsia: Switch to gfx_tests sandbox configuration 2020-01-28 shrekshao@google.com Turn on clampArrayAccess globally but off for compute shaders 2020-01-28 jmadill@chromium.org D3D11: Fix uninitialized BufferEx SRV. 2020-01-28 jmadill@chromium.org Fix overlay build. 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 881bbb347a08..726435870206 (1 commits) 2020-01-28 ianelliott@google.com Vulkan: SwiftShader now getting correct sample positions 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 1b3441036a8f..97f1d485b763 (1 commits) Created with: gclient setdep -r src/third_party/angle@4a8fa19f0574 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042252 Tbr: tobine@google.com Change-Id: If355a57e253e59a906fb54cd74f9eb1c80fc8b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025690Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/153a537a3f87..6c3dc3581eaf git log 153a537a3f87..6c3dc3581eaf --date=short --first-parent --format='%ad %ae %s' 2020-01-28 capn@google.com Support LLVM 8+ build changes Created with: gclient setdep -r src/third_party/swiftshader@6c3dc3581eaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9a1a4055a5689f4fa52d0efe5486253873ecccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025628Reviewed-by:
-
Oriol Brufau authored
If a ::marker has the 'content' property set to something different than 'normal', then the contents of the marker should be determined according to that value, not from 'list-style-type'. Before this patch, the behavior was already correct when laying out the marker for the first time. But if 'list-style-type' changed afterwards, the marker was updated to reflect the new value, ignoring 'content'. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-021.html The test fails in legacy since 'content' is not supported yet. Change-Id: Id845774739927c9c574a66e9d1cc94e6ea59d5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020957Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#736105}
-
Sigurdur Asgeirsson authored
Also run all events through serialization and deserialization in the ports_unittests to make sure new event types go through this in a unittest. Bug: 1003391 Change-Id: I3347308db5e1c339b9f639b1cb32a5d41600d97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024185 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#736104}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1970742 - it adds a new interfaces to read the structure tree from PDFium, then generates a tagged PDF using the new command-line flag and tests that the resulting PDF file has the correct structure tree. Bug: 607777 Change-Id: I796b15ea477ae4e20099e95982430fe770166577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970744Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Francois Doray authored
This reverts commit 015752ce. Reason for revert: Adds unnecessary complexity. Reverting it to simplify moving TabLoadTracker to PerformanceManager. Original change's description: > [tabloadtracker] Mark a visible tab as LOADING when navigation starts. > > The goal is to ensure that a policy that reduces background work when > a tab is loading is applied as soon as possible. In particular, on > startup, we don't want background work to start before the first tab > has received a response. > > We want to move TabLoadTracker to the PerformanceManager. However, > that shouldn't block experimenting with no background work when a > tab is loading. > > Bug: 839110 > Change-Id: Idf59ef95192200e76e3fe387fb76adab88ad85a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906508 > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719364} TBR=chrisha@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839110 Change-Id: I23d9a9eccc2a20bd0b1513ece6b7f519c20a5988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017922Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#736102}
-
Sean Gilhuly authored
Simplify GpuProcessStartAllowed(), currently it returns false on Windows with GPU and swiftshader disabled, or on Chromecast with the flag --disable-gpu. This matches exactly when |gpu_mode_| is GpuMode::DISABLED. The test GpuStartsWithGpuDisabled has a special case for Chromecast audio-only builds, but it isn't run on Android Chromecast. Separate out the Chromecast-only test. Also fix a couple of typos. Change-Id: I166bf1c7f482e7b97c31ed607949044f3ef7ac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023949Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#736101}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/912cec0c6822..109232bcf479 git log 912cec0c6822..109232bcf479 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chshrest@microsoft.com [Elements]: Fix keyboard accessibility in color-picker Created with: gclient setdep -r src/third_party/devtools-frontend/src@109232bcf479 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1bab803d488ea07cdf4f58e20efe88940b13fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025695Reviewed-by:
-
Martin Šrámek authored
This enum must be kept in sync with the histogram of the same name in resources/settings/metrics_browser_proxy.js, but it's currently not. This causes a DCHECK when settings attempt to record this value. Bug: None Change-Id: If04dc1d3852854a02659d9bd056f10eafe80b8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025668Reviewed-by:
-
