GitLab

This CL changes the way the UserAgent is stored and used.
Now the UserAgent to be used when loading a page is stored in the
WebState. Each NavigationItem is storing the UserAgent that was used
when the item was loaded. This is the UserAgent that is used to display
the option (request Mobile/Desktop) and to reload the page when
navigating back/forward.

As the UserAgent is now in the WebState, it has to be restored as part
of the session restoration. This also allows the UserAgent to be kept
when the preloader is used, as the session is restored.

When the mobile/desktop version is requested, the NavigationManager is
updating the UserAgent of the WebState.

Bug: 1049094, 1076855, 1078343
Change-Id: I459ec728f01da814ba23bafc0aa7fb1e185f95e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193994Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779359}

CableDiscoveryData uses memcpy, without including the header that declares
it. So include <cstring> is required.

Bug: 819294
Change-Id: I1b8157d2565dc1333be51c6371de1f84374ceb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247037
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#779358}

Bug: 819294
Change-Id: I073c5b4200b92736ba533c176fb116f83f3ee8ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248758
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#779357}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

TBR=jorgelo

Bug: 1031540
Change-Id: I4e85df6fa0687ec8b891d77f1fb788acf309b28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248763
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779356}

When user with child account tries to modify timezone preference, prompt
parent access code validation dialog. Timezone changes can only be
applied if the validation success.

Bug: 997310
Change-Id: I90e1b5ebd79f5ca92dcc32223d637f37615e6699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210749Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779355}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I5040ce1488344ab719ff53b71286958b655798a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248764
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779354}

This is a bunch of tests that are broken by the fact that the RFH
changes after navigation.

Change-Id: I10578a56bbb382dd1e41a57f645e75d5ff51a3ba
Bug: 1064944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245166Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779353}

Some permissions tests rely on a prompt being shown when requesting
location access, but location access is automatically denied when
geolocation is turned off in system settings. This causes flakes on
certain bots that don't have geolocation enabled.

Bug: 1094586
Change-Id: I08a6b5add43a90ea40ad99ec5272373ceaf03ad7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246925Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779352}

- Displays a message to indicate users that no print jobs are currently
  printing.

Screen shot: https://screenshot.googleplex.com/YSGD579DA0U

Bug: 1053704
Test: browser_tests
Change-Id: I62ce23ac6cafc805e31a153cea4e847b49c3d619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244123Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779351}

This is a reland of f4240b29

This fixes two issues:

- A real UAF in ServiceResolverImplMac::OnResolveComplete, where the
  callback can delete |this|, so StopResolving() is now called before
  the callback.
- A test-only UAF caused by the background thread outliving the object.
  The thread is now flushed and joined. The -stop methods for both
  NetServiceBrowser and NetServiceResolver are now called in their
  respective -deallocs, in case the Stop posted task does not run.

Original change's description:
> mac: Simplify the local_discovery ServiceWatcher and ServiceResolver.
>
> This removes the inner Container classes by moving the logic into the
> ObjC classes that already exist.
>
> Bug: 1072841
> Change-Id: If22d2d90ce3235ce160a0b740337fd71353a7ef7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243995
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778341}

Bug: 1072841
Change-Id: Ice53eb92d6c73c75ad6f276b301eaa1841536c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248076Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779350}

All test pools should now have the needed templates.

Bug: 812428
Change-Id: Ia40c73ca7760b7be0aa03e5694e14142e502291b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248880Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779349}

Roll ChromeOS Orderfiles from 85-4147.33-1591609549-benchmark-85.0.4163.0-r1 to 85-4147.33-1591609549-benchmark-85.0.4170.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I486c509b35f3b9890da4eab6d47570c77941dd49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779348}

... instead of WebMediaStreamTrack.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

Drive by, this CL also changes the uses of blink::WebString
to WTF::String.

BUG=704136
R=guidou@chromium.org

Change-Id: I99226ef3efbbf9d85ed3db45df5081e2f23f51ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246928
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779347}

This makes the chrome.test.checkDeepEq() and the chrome.test.assertEq()
functions more robust when handling the values of different types, in
particular in the following scenarios:

  chrome.test.checkDeepEq([], {});
  chrome.test.checkDeepEq([1], {0: 1});

Before this CL, both of these expressions evaluated to |true|, despite
that the values are logically different. The bug was caused by the fact
that iterating using a "for" loop may result in the equal key-value
pairs for an object and an array, so it's not a sufficient criteria.

The proposed fix is to additionally compare the results of the
"Array.isArray" check.

Also fix the "AppWindowApiTest.Get" test that was (accidentally?)
relying on this bug.

Bug: 1078761
Change-Id: I00f24a567ba8589e5445313d9b49dd7cf394f1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245913
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779346}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I23b0ca3dba58d76657f6acce9d8cd4a21ce505da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248633
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779345}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I3708de40ea110f27b8d3ab1e9e63df72cc2dba70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249765
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779344}

This patch makes PaymentAppProvider methods take a WebContents* instead
of BrowserContext*. This is a first step toward making WebContents own
PaymentAppProviderImpl rather than it being a singleton.

The payment_handler_windows_ map is changed to a single
payment_handler_window_, but note this is just to remove the
BrowserContext* key dependency, we still enforce one payment request
per browser via PaymentRequestDisplayManager.

PaymentAppProviderImpl's RespondWithCallback and callback repository
still depend on BrowserContext*, since the callback may outlive the
WebContents. This will be cleaned up in step (3) of the bug, where the
callbacks will be owned by PaymentAppProviderImpl instead of a singleton
repository.

Bug: 1075687
Change-Id: Ib4460b82f9938e973f067f45669a6031f7f0da3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240064Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779343}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I232b5159e7816b2f2bb640ede69bed7fac7a75da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248630
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779342}

The original code converts the Origin to GURL, then uses

net::GetHostOrSpecFromURL(). This is likely the result of mechanical
conversions replacing GURLs representing origins with url::Origin.

Change-Id: I1fb5e38987b569c88a69bed41450957a33db3f57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249387Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779341}

Since Googlers may not be able to use ssh in crostini, add a link for an
alternate way to set up VS Code remote development on chromebooks.

Tbr: minor doc change
Bug: None
Change-Id: Ie59e888dca4f7d86522584b012af671f8b544b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246859Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779340}

The latest UX style indicates we shouldn't show a (x) button in modal
dialogs. Update the extension settings overridden dialogs to match.

Note that the dialog can still be dismissed without a decision by
- hitting the escape key (which triggers the "closed" callback)
- closing the parent widget

Bug: 1079364
Change-Id: I4dea1c41656f76e5951267cfd3c2459ad9e148e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247352Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779339}

This CL removes DirectoryCryptographer and its last usages.

Bug: 1083924
Change-Id: I800c9aee00c1f35e81fc177bf835ea76916bd760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228553
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779338}

This reverts commit c75217d6.

Reason for revert: https://crbug.com/1095643
Broke run_web_tests.py for Windows developers

Change-Id: Id7422be7bed874a65cf35da952978f42f0cb76c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248725Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779337}

Bug: 1044038
Change-Id: I48ac13f6ffc6f44f990c5dfd7f3248ab3b614d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248629Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779336}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Icf68406e5513792097ba9b7ed6da2e7e8b75b080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248576
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779335}

Change-Id: Ie4b2ecd7e64a19d17fb84790b844fc96751621a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246545
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779334}

Change-Id: I0b6e93ae809189b749d10b35365a52bf40297c28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247349
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779333}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: I0ed5a3c7a64e4fcc3a68a2ec0522d639f1fa4474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249801
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779332}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Icaa271ea7e32c0494a7b3f578696e397e7cd0a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249675
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779331}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

Bug: 1031540
Change-Id: Id378f4f3ceaabbfeabb83a02779708f5707c4fd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248762
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779330}

This change will make sure that the availability logger ignores
previously failed attempts.

Bug: 1095136
Change-Id: I129bd9b2357fd831fe9a82749cdde2b85390ef85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248866Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779329}

Sched slices with utid = 0 correspond to the time when CPU is idle,
so they don't contribute to the total power consumption.

Bug: b/155073796
Change-Id: I072b2e9bb8984161518634633d9b4a7bf411eceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247893Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#779328}

Moves the following functions:
 - NGInlineLayoutAlgorithm::ComputeAnnotationOverflow()
 - LastLineTextLogicalBottom() in ng_block_layout_algorithm.cc
 - FirstLineTextLogicalTop()  in ng_block_layout_algorithm.cc

This CL has no behavior changes.

Bug: 1069817
Change-Id: Ie59211a2644f81a4e43bcde5f7010f8765b2955a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249431
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779327}

In this case compiler warns about function declared never referenced.

Change-Id: If8f7458c930890182c74e776dd31bb168956a693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246167
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779326}

https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/046920fc491a..11659d420a71

$ git log 046920fc4..11659d420 --date=short --no-merges --format='%ad %ae %s'
2020-06-15 wittman Make new upstream version build with Chrome
2020-06-15 wittman Update to upstream a7b4c5d25aeb
2020-06-16 wittman Streamline update process

Created with:
  roll-dep src/third_party/libunwindstack

Also includes updates to Chrome's native_unwinder_android.cc to account
for libunwindstack interface changes:
  - split of Step() function into StepIfSignalHandler() and Step()
  - use CreateLocalProcessMemory() to create memory subclass for the
    current process

Bug: 1004855
Change-Id: I54590d7c7ef3670fde42cc03ec1697c0f605d40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248759Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779325}

This reverts commit f1e5e2aa.

Reason for revert: Broke WPT importer: crbug.com/1095643

TBR=robertma@chromium.org

Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c

Bug: 1095643
Change-Id: Ice2e5f837095b2ea09c48bef7f6565d145d0d32c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248061
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779324}

No DoClose() implementation actually reads this argument.

Bug: none
Change-Id: Iee84eb6f912351eb80f7655b26aabc586d3fef67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248464
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779323}

This is a reland of aa42f61e

Original change's description:
> CDP: make a11y info optional
>
> This CL adds an attribute to the highlight config object to control
> whether a11y info should be shown. The test expectations have been
> updated accordingly. There is an accompanying CL in DevTools which makes
> use of the new attribute[1].
>
> [1] https://crrev.com/c/2238230
>
> Bug: 1092841
> Change-Id: Ic4a888ecf134b852fd67430b924da3812f244dac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238828
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778791}

Bug: 1092841
TBR: caseq@chromium.org
Change-Id: I9b14d446efe6355af0e8a8f43dcf1f866783a216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248680Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779322}

This CL fixes regression introduces in CL:2230472. Before *ForTesting
methods checked if WC is created. After the offending CL WC is always
created. So in this CL the methods also check if the WC is initialized

Bug: 1094552
Change-Id: I603de486c6da5e62a406c7f6ecd407dafabf7762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247734
Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779321}

As far as I can tell from examining the affected locations, any possible
behavior changes are either oversights or can't really happen.

Bug: none
Change-Id: I7bf4095d15c022a6a35f672871d123b96c96c604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248350
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779320}