- 28 Jan, 2020 40 commits
-
-
Mohammad Refaat authored
TabModel is provided to the CrashRestoreHelper as a SessionWindowRestore protocol delegate. and it's used to restore sessions from there. Replace that with browser and use sessionRestorationBrowserAgent from the CrashRestoreHelper instead. Also while at it, i changed the members ivars to use trailing underscore instead of the leading underscore. Bug: 1010164 Change-Id: I53360ac9a34f7f9e42aacd459e233f40c5def60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024028 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736047}
-
Avery Musbach authored
When you start dragging a maximized window from overview and drag into another display, the drop target on that display shall be adjusted to reflect that if you drop the window there, it will fill the work area. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DropTargetBoundsForMaximizedWindowDraggedToOtherDisplay/? Bug: 961170 Change-Id: I682d75dd8a95544ffa0d952920d174f8ab102c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024153Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#736046}
-
Wez authored
This test was disabled on Fuchsia in 2018, due to flake, but appears to be flaky across all platforms, especially Mac, suggesting that the test is inherently racey or timing-dependent. TBR=sahel@chromium.org Bug: 866946 Change-Id: If4669a4935833101422f60fa56a6e58b23b704c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025430Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736045}
-
Yi Gu authored
This test has been flaky on Mac and Win10. Only 1 occurrance on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZQsSBUZsYWtlIlpjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2JsdWV0b290aC9pZGwvaWRsaGFybmVzcy50ZW50YXRpdmUuaHR0cHMud2luZG93Lmh0bWwM TBR=jameshollyer@chromium.org NOTRY=True Bug: 1041851 Change-Id: If303b5744745a9f13a72155fac21f4fde48478fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025916 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736044}
-
Katie D authored
In some places, Reader Mode was still being referred to as distilled pages. Corrects this. Bug: 1016619 Change-Id: I6ee56597b60c8a95550a9e2eec90891751ce5024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025635 Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736043}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34e2627e. With Chromium commits locally applied on WPT: 3157910d "SharedWorker: Add WPT for referrer-policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9cce59568aec57c537f12f5dc79e692d86a5feeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025329Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736042}
-
Elly Fong-Jones authored
This change introduces alternatives to overriding these methods on DialogDelegate: Accept Cancel Close Each of these methods now has a corresponding settable callback. callback. The callback, if set, is invoked from the default implementation of the corresponding method before it returns its default value. For many cases, this obviates the need to override Accept/Cancel/Close. Bug: 1011446 Change-Id: I4b7ce930bb6f7108665a2d5b6c789aa29e4ec839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017988 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736041}
-
Tommy Steimel authored
This CL fixes an issue where previously frozen sessions would be marked as active and an issue where uncontrollable sessions would be marked frozen. This caused uncontrollable sessions to end up backdooring themselves into the GMC dialog. This CL adds a new unfrozen callback to |MediaSessionNotificationItem::Freeze()| so that MediaNotificationService can know when an item becomes unfrozen. This is needed since it no longer assumes it. Bug: 1045053 Change-Id: Ia03c903d25f419f1dd724af71dc7f02afea76f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016354Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736040}
-
Albert Chaulk authored
There is a crash in ProcessNavigationDecision, accessing an almost null pointer. From disassembly inspection this is likely accessing the vtable which means the Throttle got destroyed Likely code path - start navigation - send throttle decision request - navigation cancelled for some reason, throttle destroyed - reply arrives There was no code path to handle nulling the throttle if it got destroyed. This CL adds this path and a second one to prevent a future webview dtor -> throttle dtor crash Bug: b/148126060 Test: None, can't repro crash Change-Id: I4cb4d5720c114c97d49bae95f0768da0d8c025b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023048Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#736039}
-
sczs authored
Previously the Card was editable after it had been saved when accessing the modal by tapping a blue (accepted) badge. This makes it so the textfields and save button are disabled if the card was already saved. Bug: 1029067 Change-Id: Ifae44abbd8c790f6b1ef49ccf92cfb623bcdfc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024157 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#736038}
-
Regan Hsu authored
Move OS Network element strings from browser string provider to OS string provider. Bug: 967888 Change-Id: Idfc743fedaa742e97f2ac025da63da1d05e4305e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018257 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#736037}
-
Nico Weber authored
https://gn.googlesource.com/gn/+log/83dad00a..97cc440d 97cc440 format: Fix not getting to fixed point in one step d874bb9 Remove extraneous quotation marks 201a0b5 format: Fix single line list suffix comments being dropped c367761 format: Improve suffix comment handling 564de29 Format all .gn and .gni files of examples This changes the formatting of a couple gn files, so reformat all gn files for this again (and manually tweak comments in a few cases where things look weird otherwise). TBR=creis Bug: 1046505 Change-Id: I79924a5eb8e03af9a69bf944301897287eba06e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025529 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736036}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib578f1903003f673895b42e746faed7909118570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025077Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#736035}
-
Piotr Bialecki authored
Change-Id: I8f1eff2dcf757406fbeecc7378888ae7547dda2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024033 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#736034}
-
Adam Langley authored
NFC support was never fleshed out and BLE will be removed. Change-Id: I7182c3f613ff8bc3b43ce03e876e6c90634f48cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025575 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#736033}
-
Yi Gu authored
The test was flaky on Win and Mac but not after Jan 25 [1]. Disable it on Linux for now. [1]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUwsSBUZsYWtlIkhjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEluc3RhbnRUaGVtZVRlc3QuVGhlbWVDaGFuZ2VkV2hlbkFwcGx5aW5nTmV3VGhlbWUM&show_all_occurrences=1 TBR=sweilun@chromium.org Bug: 1045708 Change-Id: If47bee4e8eaca59e68138b57606c6e81d69a2090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025641Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736032}
-
Wez authored
Wait explicitly for the ViewRef to be registered, during test setup, rather than relying on RunUntilIdle() causing the CreateView() and ViewRef registration calls to have completed. Bug: 973095, 1045872 Change-Id: I790d04a609f116635e311b01e8e032e239b3832e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020765 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736031}
-
Takumi Fujimoto authored
Remove HoverButton::SetStyle() and SetSubtitleColor(), which were being called only by a test. Also remove some #includes. Change-Id: I82796f7263763cbc58204b74e02d4e26796f202f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024271 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736030}
-
Wez authored
The waitWithTimeout calls are unnecessary now that browser tests always run with a default RunLoop timeout configured. Bug: 1021777 Change-Id: Icc5eab59b739a9b5c00d9c7820b75d5b092e1c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020762 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736029}
-
Bo Liu authored
Bug: 1042063 Change-Id: I8b61a7ccdbf50703115a0e6b971a02623771756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019603Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736028}
-
Yi Gu authored
The test is flaky on Win and Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVAsSBUZsYWtlIkljaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BEdW1wQWNjZXNzaWJpbGl0eVRyZWVUZXN0LkRpc3BsYXlMb2NraW5nQWxsDA TBR=rakina@chromium.org Bug: 1043480 Change-Id: Ibaf32c82c5f823717a587c8377aa9484a2b8b803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023480Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736027}
-
Alexei Svitkine authored
This reverts commit 1547c775. Reason for revert: Causes "No module named fieldtrial_util" error when running "git cl try". Original change's description: > Set limit for field trial parameters length. > > Windows has a limit of 32767 on a command line. When testing with field > trails, the command to launch chrome.exe may exceed the limit if there're > too many field trial configs passed as parameters. This was causing > the chrome perf waterfall to completely fail on Windows. > > This CL added a presubmit check to see whether the configs under Windows > will exceed the limit of 31000. > > Bug: chromium:1045530 > Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468 > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735981} TBR=asvitkine@chromium.org,crouleau@chromium.org,wenbinzhang@google.com Change-Id: I42f928aa6bc87b1f5696f8bda50d6d307d53ff7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1045530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025830Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736026}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36331312..0a0715c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60c7023501fe5d2a67414b034172528a283b65dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025228Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736025}
-
Robert Ogden authored
This service is a BrowserContextService which owns the proxy configurator, but more singletons will be added to it over the course of development. Bug: 1023483 Change-Id: I4731a742158133ea304c53e2b54c15063f69302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020885 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736024}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Id47c3c92df05cbff973e86553c63e0af9bd58400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025588Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#736023}
-
Martin Kreichgauer authored
When toggling "Allow apps to control device radios" off in Windows privacy settings, calls to Radio.RequestAccessAsync() seem to always fail with DeniedByUser. The API docs state that the RequestAccess call triggers a permission UI, but that is not the case (perhaps that only works for UWP apps). When in this state, an applciation is unable to control Radio power via SetStateAsync(), but the Radio is otherwise fully usable. BluetoothAdapterWinRt previously early-exited its initialization routines whenever RequestAccessAsync() returned anything other than Allowed. The resulting instance would have a nullptr |radio_| member. Consequently, it would always return false for IsPowered() (but true for IsInitialized() and IsPresent()). Instead, continue initialization even when RequestAccessAsync() fails. Also change CanPower() to consider the RequestAccessAsync() return value. This fixes a WebAuthn bug, where caBLE requests on a device in this state would show a UI telling the user to power on their BLE adapter, even if it was already powered on. Also make BluetoothTestWinrt inject a FakeRadioStaticsWinrt. It was previously using the real implementation. Bug: 1043410, 1006688 Change-Id: I50946ec0c3be12331ac286d6728b2ce58fd0c6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015444 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736022}
-
Mark Yacoub authored
If the device supports atomic APIs, use drmModeAtomicCommit to modeset and disable instead of drmModeSetCrtc. Abstracted Modeset and Disabled code to HDPM to handle both atomic and legacy call. Updated tests to support Connector and CRTC props. BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, HardwareDisplayPlaneManagerLegacyTest.Modeset, HardwareDisplayPlaneManagerLegacyTest.DisableModeset, HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on Nautilus(Intel), Grunt(AMD) and Cave(Legacy). Change-Id: Ic6d3873c94cb657fbe8de6dcd0faf97aeea05bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020809Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#736021}
-
Yulun Wu authored
Bug: 1034168 Change-Id: I1551a4cbf59669c514f46e17919fe7e91bc7bbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020561 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#736020}
-
Thomas Tellier authored
Bug: 1010254, 1010258 Change-Id: If4ec84dd21391b5eb2211d9eea955a7d05f6c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005989 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736019}
-
Chan Li authored
TBR=yigu@chromium.org Bug: 1046440 Change-Id: Iaca3b5b330162e4c2c194a354cddfaea8bc0bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024496Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736018}
-
Gauthier Ambard authored
This CL enforces the assumption that the tests are running in portrait by forcing the orientation to portrait in the setup of the test. Individual test can still override this setting if they want. Bug: 1046339, 1045966, 1046096, 1046253, 1046258 Change-Id: I1a7ec04e06efaee1d558f038b2d333673330a80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023891Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736017}
-
Gabriel Charette authored
TBR=fdoray@chromium.org (TBR for side-effects of mechanical change) Bug: 1026641 Change-Id: Ic0805fa52bd28aa93780749842f094e92a3e2ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994069 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736016}
-
Jérôme Lebel authored
bzanotti no longer works in Chrome sign-in team. Change-Id: I6c6b2e73599c5cc4340d2283059db9b3d2909ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024892 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736015}
-
behdad authored
Unittests are added to test the functionalities of representative perf test scripts. Bug: chromium:1029952 Change-Id: Ie3ab5d1a976d9511fbde6a401fc544ead3e50091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017163 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#736014}
-
Daniel Libby authored
This CL implements percent-based scrolling for Windows. This makes mousewheel initiated scrolls be interpreted as a percentage of the size of the intended scroller, instead of being translated directly into pixels. This is done as a part of the effort to port Edge-style scrolling into Chromium. The deltas reported by the wheel event are unchanged in order to maximize compatibility with the web. Bug: 1009735 Change-Id: I4987cb6916fe5961cdb479018ccd7a464d574ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776898 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#736013}
-
Mingjing Zhang authored
Histogram History.DomainCountQueryTime is now emitted with SCOPED_UMA_HISTOGRAM_TIMER instead of an explicitly maintained timer; Typos and other minor nits in HistoryService unittests are also fixed. Change-Id: Idbd3ff3fb676a00ae21db1ef126d67afe947a161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023233 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#736012}
-
Sylvain Defresne authored
Change remoting code to only link with MaterialComponents.framework if the code is compiled as a framework (this will allow removing the fake targets that exists in ios/third_party/material_components_ios/BUILD.gn). If using MaterialComponents.framework, then bundle it with the app. This is a reland of https://crrev.com/c/2020960 with a fix for the compilation of ios_remoting_unittests when building a framework for MaterialComponents (which is the default on the internal builder and why the original CL was reverted). Bug: 1040871 Change-Id: I77bb04480bc6b7b1a01133a795f73bc5860b7686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023888Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736011}
-
Daniel Murphy authored
IndexedDB doesn't need to know the file path for V8 File objects, as these work just fine being hooked up to a mojo blob handle. This CL removes all usages of external file paths in IndexedDB, and removes them from even being serialized from the renderer. Bug: 1036415 Change-Id: I6e074c5fe11654faaf2afb56d8fe290ded4f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978848 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#736010}
-
Matt Menke authored
The DNS cache is now a per-NetworkContext cache, instead of a global, so clearing the cache when closing incognito is no longer useful - destroying the incognito profile will destroy its own DNS cache. This CL also updates the network::mojom::HostResolver API to allow stale DNS lookups. I'm adding a lot of tests for DNS cache isolation, and this option is needed to avoid tests racily failing due to DNS cache eviction, particularly on slower bots. This option was already supported by the HostResolver; it just wasn't being exposed outside the network service. Bug: 1042354 Change-Id: I8cd4332f6d28b5cc783b256550f720807cfb9c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023507Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736009}
-
Gavin Williams authored
-Add a property to cr-searchable-dropdown so we can track whether the user's current text input in the dropdown matches the previously saved value. This flag will be used to disable certain user actions if the dropdown is invalid. Bug: 950887 Change-Id: I578086632568dc0e76ec8bb2726dd002158392dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016334Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#736008}
-