- 25 Aug, 2020 40 commits
-
-
Garrett Beaty authored
Macs all have SSDs, so generating ssd:0 for builderless mac builders forces the definition to also specify ssd=None. Change-Id: I61b09dab79e9ec37867c6d24c39982f360083a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368322Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#801475}
-
Alex Chau authored
- Moved check for active profile into InvalidateSurfaceState, so send/receive surface can still be registered without profile being active - OnNearbyProcessStopped will InvalidateSurfaceState to potentially restart the flow if profile is still active Bug: 1120087 Change-Id: I40cc43949a46808d2c090c1681d34e0450f62fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375289 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801474}
-
Nohemi Fernandez authored
The spinner causes EarlGrey to crash following 'infinite' page wait. Bug: 1116650 Change-Id: I20c808dfe77115ba10ba2da5ea06d60688bf76da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375173 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#801473}
-
Thomas Lukaszewicz authored
Currently NativeViewHost applies a masking path to the NativeView's layer to achieve the rounded corners effect. Tbis CL updates the API to use gfx::RoundedCornersF and uses the rounded corners layer fast path for Aura platforms. Bug: None Change-Id: I038d7b01f315e930cd2577d1c6b4f5dc7f6ca5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371309Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#801472}
-
Xiaocheng Hu authored
Bug: 964333 Change-Id: I4388432ab6651ef64fa9fcd6b23e687069e6979c NoTry: True Tbr: apotapchuk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375934Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801471}
-
Peter Boström authored
This tears down DialogModel by through model_.reset() to simulate dialog closing being synchronous. This gives simpler lifetimes for client code as a synchronous delete is more predictable than an asynchronous task from GetWidget()->Close() on its own which is asynchronous. Note that from an implementation perspective the Widget teardown is not synchronous, but this should not be a concern of DialogModel client code. Bug: 1106422 Change-Id: Ib35ec2389e78459ae98a4f901a35858a7fe97189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372929Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801470}
-
Lei Zhang authored
In https://crrev.com/651373, the package_exists() implementation changed but the comment did not reflect this change. Change-Id: Ic13e7a3cef28a980ebd167af1bab31006bbf5b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375928Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801469}
-
Muyao Xu authored
MediaRouterViewsUI is not dependent on ui/views/view.h and can be moved to c/b/u/ directory. Also renamed the class to MediaRouterUI. Bug: 1116045 Change-Id: I222f5b194b7e707602feb53221ba9e6ec8b35a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354414 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#801468}
-
RJ Ascani authored
The FuchsiaCdmManager needs a FilePath to write CDM user data to. The Fuchsia ContextProvider receives the persistent directory via the CreateContextParams::cdm_data_directory field. This CL takes the cdm_data_directory and mounts it to /cdm_data. This path is provided to the FuchsiaCdmManager, which does not use it yet. Bug: 991723, b/162078899 Change-Id: I8c6ba6236deb936f743fb70a7f22779e0d3802c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330811 Commit-Queue: RJ Ascani <rjascani@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#801467}
-
Vladimir Levin authored
This patch removes ScheduleAnimation calls from lock/unlock. These are not required because we invalidate paint anyway so the lifecycle will already happen. Either that or we are already in the lifecycle when we determine that we need to lock. R=chrishtr@chromium.org, szager@chromium.org Change-Id: I1284b435882e2365f75b1b8baaf79fab8713ba99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375069Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801466}
-
Weilun Shi authored
Fix a typo in PRESUBMIT.py and sort th |HISTOGRAMS_XMLS_RELATIVE| because different OSes have different file system which introduces non-deterministic into the output of _FindHistogramsXmlFiles() . Bug: 1116807 Change-Id: I8ff36de29464d388f012864155028a77fdb44e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372775Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#801465}
-
Koji Ishii authored
This test once timed out if LayoutNG and VizDisplayCompositor were enabled. This seems to pass on the current bot. This patch tries to reenable. Bug: 959261 Change-Id: I818fcc015f9e6254fa7f8c17588d6406efeabe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354375Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801464}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008250800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/q7fJGoUZfsUaMt-ae3SViUsR1NdBaXcLVuaNOAI_8CMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I81f2aca91d47a911af36225de7e3ec04b10ae617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801463}
-
Alexander Cooper authored
Now that the OpenXR runtime has been shipped for a while, and WMR has been updated to interface with OpenXR in a frictionless manner, we would like to unify OpenXR as the single runtime that supports WebXR. Given that WMR support has shipped, rather than delete the runtime immediately, we will first disable it, and see if any issues arise. However, given that almost all WebXR sessions on desktop go through OpenXR, we don't expect any issues. Bug:1121624 Change-Id: I2276f8a5a5954e09276a44b2cfcaf8ad10747100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373393Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#801462}
-
Victor Vianna authored
Fix style consistency in the file. Change-Id: Ib43e942e8acc3a551c9f224a791ef641b55b794d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375425Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#801461}
-
Ana SollanoKim authored
A fieldset-specific regression was introduced by the following change https://chromium-review.googlesource.com/c/chromium/src/+/2263353. This change fixes the bug crbug.com/1097012, addressing now all the TODOs that were added as a result of this issue. Because the padding of the fieldset's content is applied to the anonymous fieldset content box rather than the fieldset itself, we don't want to directly subtract the block-end padding from the fieldset in the finish fragmentation function. For this reason, we're only passing the border so that when subtracting to get the final block size, we're not mistakenly eliminating the padding as well. The minimum border box block size was not being calculated in every case due to legends not fragmenting, thus resulting in missing padding and border for some fragments. Additional conditions were added to allow that calculation when needed. Bug: 1097012 Change-Id: I8e9fd55ae11a14ce83e035a591ab0ec6a7f34261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373382 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801460}
-
Kyungsun Lee authored
The code in //components/payments has a lot of raw pointers that rely on careful memory management. It would be better to use base::WeakPtr to avoid mistakes. This CL is a part of those changes, which replaces the raw pointer of PaymentRequestState::Delegate with the base::WeakPtr. BUG=1086284 Change-Id: Ieeef4f5be886d78fce7f3f28cbb902691f1aa341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364380Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801459}
-
John Delaney authored
What: Move base::PathExists() check for database file to the storage task runner. Because ConversionStorageSql is created on the UI thread, this call blocks startup execution. How: Defer initialization of |db_status| to LazyInit() Fixes the startup regression introduced on https://crrev.com/c/2360471 Bug: 1121307 Change-Id: I3842320f507695643a306cac709aba605b1b276e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372596 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#801458}
-
Yuki Shiino authored
Supports property installation of IDL operations with enabling V8 Fast API mechanism. This is a preparation of https://crrev.com/c/2315680 . Bug: 1052746 Change-Id: I0f1a4ac0e12f32f2db32f161b3fe65198052a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361939 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#801457}
-
Yu-Hsuan Hsu authored
Add --use-cras flag when it is running on ChromeOS. BUG=b:151905045 Change-Id: I336a928b512fb1489a82c90a7fd1b776107ef0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374487 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#801456}
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2360325, that moved the respective files from content/renderer to Blink. Since this class is used in chromecast/, it is not expected that it will be moved out of the Blink API layer any soon. TBR=spang@chromium.org BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5fe091066e03a0e3d147601196bf3a4da7ef056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363708 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801455}
-
Gayane Petrosyan authored
When right-clicking on media element, selection is "\n" and associated doc is null. Thats why creating a range with null document in TextFragmentSelectorGenerator results in referenced crash. Fix the issue by creating the range in TextFragmentSelectorGenerator only when data.selected_text was assigned. Bug: 1119309 Change-Id: Ib8a035d6779a3c8636d0ec6e5cf9167a2a9bdaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362873 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#801454}
-
Sammie Quon authored
Test: compositor_unittests LayerWithDelegateTest.Cloning Change-Id: I13496c5e339db87ad2b78f868cf135e53c1f1aed Fixed: 1121302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374025Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#801453}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6256ac5. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 9f6eb4ab "[scroll-animations] Support animation-timeline:none" 407a71e3 "[fetch] Empty destination should be the empty string, not "empty"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id8ab9fd635bdc7733db44bd02b523f6f24806a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375070Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801452}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b19dea038322..b8ae5a73f875 2020-08-25 tvanderlippe@chromium.org Typecheck bindings/CompilerScriptMapping.js with TypeScript 2020-08-25 pfaffe@chromium.org AsyncScope-ify the console helpers 2020-08-25 pfaffe@chromium.org Language Extension API: First-class support for constant variable values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1113662 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1d491d2d696357641fd0690ec7f18bf2e1130720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801451}
-
Theresa Wellington authored
This is a reland of 90d9fea6 Added a wild card for the test name. Original change's description: > Disable P/CompositorImplBrowserTestRefreshRate.VideoPreference on M x86 > > Test flakes frequently on M emulator. > > BUG=1120813 > > Change-Id: I481b39088f22e295e31ec5eed155f168e0fbad78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373284 > Commit-Queue: Theresa <twellington@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Auto-Submit: Theresa <twellington@chromium.org> > Reviewed-by: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#801172} Bug: 1120813 Change-Id: Ideade1b3c2bb4959d20f26014a131925a8ae1a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375545 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801450}
-
Caroline Rising authored
Add a new menu triggered by the StarView which gives the option to either bookmark the tab or save it for later. If bookmark is selected the user flow matches previous behavior. If save to read later is selected the tab will be saved to the reading list model. Note this change is hidden behind the read later feature flag. Follow-up work: Update the read later icon in the menu when new icons are available. Update the omnibox star tooltip. Update StarView/bookmark metrics and add metrics for read later. Update menu size. Bug: 1117023 Change-Id: I09c6cf4973338faa272bc6ec6da06e26f0f9aa8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359550 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#801449}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-23. TBR=chromium-metrics-reviews@google.com Change-Id: I125c148476a40629faca017a9d396f2b172af1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375605Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#801448}
-
Nohemi Fernandez authored
Disallows clients from accessing internal library SigninEarlGreyAppInterface. If they need to access sign-in internals developpers may use the SigninEarlGrey test API. Bug: 1103274 Change-Id: Ib437ae134beaab81bde6dacad69b3f8179b5c9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372303Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#801447}
-
Richard Knoll authored
This adds a fuzz target for the DecodeFrame method of the NearbyDecoder. Bug: 1091349 Change-Id: Iac7eabc35d57c2786e5cffbe2b292910d859c244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374868Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801446}
-
Lei Zhang authored
Newer distros have lib32gcc-s1, but older, supported distros have lib32gcc1. Support both, rather than only one of the two. Bug: 1119692 Change-Id: I2ba4ee25507976683c987ea89623e7e0d80957af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372588Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Junichi Uekawa <uekawa@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801445}
-
Clark DuVall authored
Recycler view is only being used in WebLayer. When experimenting with WebLayer in a DFM, the recycler view code still gets added to the base APK since R8 does not (yet) have support for adding proguard rules that only apply to a DFM instead of globally. This change removes all recycler view deps from WebView, and splits out the code from //ui/android that depends on recycler view since most places that use ui/android don't actually need it. See go/chrome-webview-isolated-splits for more info. Bug: 1105096 Change-Id: I808cba5530a4d211361db0beab8ab1e9aa57137f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363873Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#801444}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic436e3540d038b8cf8f6df81725ae5d3ebc5336a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375068Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801443}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a96e2c4c1ca..8025507f746b 2020-08-25 robertphillips@google.com Simplify SkComputeBlurredRRectParams 2020-08-25 mtklein@google.com refactor SkArenaAlloc footers 2020-08-25 brianosman@google.com SkRuntimeEffect SkSL has a new signature for main() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I3ffac2765495063ffdfed7d4cfdb9be7af4e71d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801442}
-
Richard Knoll authored
Before crrev.com/c/2232978 the icon size was hardcoded in MenuItemView, but that CL changed it to respect the incoming vector icon size. We can't modify the vector source so we need to set a size when using it. This also cleans up the duplicated *WithIcon methods and unifies them to a single one taking a ui::ImageModel instead. Bug: 1109643 Change-Id: Ib78f683ffee672668c79397122a0e3f5725f58f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369181Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801441}
-
Anders Hartvoll Ruud authored
This CL adds CSSScrollTimeline, which is like a regular ScrollTimeline except it originates from an @scroll-timeline rule. For now, the CSSScrollTimeline doesn't do anything beyond what ScrollTimeline does, but in the future CSSScrollTimelines will contain additional information needed to invalidate attached Animations when @scroll-timelines, the computed value of animation-timeline, or other circumstances change. All the Compute* utilities have been moved to css_scroll_timeline.cc without any changes. In general this CL is a pure refactor, and should have no behavior change. Bug: 1074052 Change-Id: I42291cc5fda4d8386c37803a3bf461c007fb5198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374646 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801440}
-
Boris Sazonov authored
Removes ChromeSigninController as it is no longer used - all callers of ChromeSigninController have been migrated to IdentityManager. Bug: 1046412 Change-Id: Ic1923ac33007be61156f76627e9da50fa5a8e195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372424 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801439}
-
Xiaocheng Hu authored
Bug: 1119361 Change-Id: Id75173327b6bb53706489225ca95c500e8a95ba7 NoTry: True Tbr: ellyjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375927Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801438}
-
Peter Wen authored
Lint does not correctly determine whether chromium targets depend on appcompat since it uses string matching that does not match our library name. Since this is the same for all chromium targets, ignore this lint warning globally. Bug: 1116130 Change-Id: I106f4dbbabd50e2e781b6152816c02ae8036f999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373206 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801437}
-
Arthur Eubanks authored
Be more specific about "reasonably green". Add instructions on how to roll your own Clang. Change-Id: If5fd297e41f9a66c7c6e736903c14e911fe5819f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373265Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#801436}
-