- 16 Sep, 2020 40 commits
-
-
Leonard Grey authored
Bug: 1014639 Change-Id: I2168155284dd77296a6e26410e0d242092de8b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410525 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807544}
-
Owen Min authored
Three example cls for blocklist/allowlist renaming are broken due to a missing '/c/'. Change-Id: Ia586dc337a92c4e22f353304ba6b99098791ee63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414829 Auto-Submit: Owen Min <zmin@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807543}
-
Dana Fried authored
Avoids a case that reliably reproduces the attached bug, but does not completely fix the bug. (Also makes sense since other touches outside tabstrip close the tabstrip, so this is consistent with existing/designed behavior.) Bug: 1126230 Change-Id: If39c356594c639c11821ff36b3b3fcd238885186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411399Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#807542}
-
Bo authored
This reverts commit b8079095. Reason for revert: DumpWithoutCrashing no longer needed Original change's description: > Add a DumpWithoutCrashing to RPHI::ProcessDied > > After some discussion of a bug in webview that detects "abnormal" > renderer process terminations, this failing DCHECK may be the cause. So > add a DumpWithoutCrashing and see if it gets and if so, what the stack > is. > > Bug: 1115216 > Change-Id: Iaa969d2c6cd7e25237be3ee0ae52fcd5aececfd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359555 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798764} Bug: 1115216 Change-Id: I0aa82cfc5708f5b31bfc850f2b4cdc45e3553429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412938Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807541}
-
Alex Turner authored
Currently, many subresource_filter/ web_tests rely on the behavior that Frames are tagged as ads immediately when they are created if ad script is on the stack. This flow requires that first the script's URL is set as disallowed, then the script is loaded and then the frame can be created. This new call allows for web tests to more simply create ad frames by setting their ad status directly. We adapt existing web_tests to use this new functionality. We remove the ad script creation and onload setting boilerplate that is no longer necessary, also converting affected promise_tests to async_tests to further simplify them. These changes will additionally allow for an upcoming refactor that defers ad status calculation until the frame has navigated to access additional information. As this logic is in the subresource_filter/ component, it cannot be used in web-tests. Bug: 1119476 Change-Id: Id2fc2faa392f06c3b1845981f06f19a0650461d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364956 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#807540}
-
Robert Ogden authored
We'll experiment with the delay to find something ideal. Bug: 730587 Change-Id: Ib583939abfbf641f43ce15103ce20e75a9fae4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412551Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#807539}
-
Stephen Chenney authored
When classifying images for dark mode the src rect can be smaller than 1x1 (the src is a floating point rect). Rather than rounding down, giving divide by 0, we should round up. The downstream code was reviewed to look for cases where this might break and none were identified. Bug: 1119761 Change-Id: I4b8eea35ff33274a0f30e68f1487677ea4f19c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413040 Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#807538}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2610e8261e9e..1592361414e0 2020-09-16 herb@google.com add special type for SkGlyphIndex If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I6eb8e37c3e73ee4db5f0fe7b45bd040d67f201e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807537}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d1382ae74fac..b14a3f7cf6d0 2020-09-16 treehugger-gerrit@google.com Merge "Fixed mouse hover over slice" 2020-09-16 treehugger-gerrit@google.com Merge "Log unwinding errors in heapprofd e2e test." 2020-09-16 treehugger-gerrit@google.com Merge "probes: update vmstat counters to latest 4.14 and 4.19" 2020-09-16 hjd@google.com Merge "perfetto_cmd: Remove Dropbox upload code" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iec7259997d8b7c252e2c32e69800543767b2c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414470Reviewed-by:
-
Robbie Gibson authored
Accessing the pasteboard on startup seems to cause hangs in the pasteboard machinery often. These hangs are in system code, but we can work around them by not accessing the pasteboard on startup. For the location bar, this is relatively simple because we present the edit menu ourselves. For the omnibox view controller, the edit menu is presented by the system. To know the pasteboard state before the edit menu is presented, we check the state when editing starts on the omnibox text field. Bug: 1121957 Change-Id: Icadb1710b2ea3684fe4250d556a3bd355339a0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414270 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807535}
-
Kyle Horimoto authored
Will be used to create a Bluetooth Classic connection via the Nearby Connections library; required because we will not have access to the full RemoteDeviceRef object when making the request (only the ID will be available). Bug: 1106937 Change-Id: I80ea9f180f95525cd8b679c3ac15eb418b1007c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412839 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#807534}
-
Elaine Chien authored
See the bug for details about why. Bug: 1127496 Change-Id: I73978517810d1061c9662d2f051953baf3806e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413289 Commit-Queue: Elaine Chien <elainec@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009160800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/zmwXsYnENXvIpO-aIRtYuL3CNQy4Zl9nUn3q_aulscEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/141204984,b/159892033,b/163418698,b/167632244 Tbr: media-app@grotations.appspotmail.com Change-Id: I02f131c5e5427674a2805303fa672000fb33f6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414468Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807532}
-
Jaeyong Bae authored
Original code reviews: https://crrev.com/c/2351959 https://crrev.com/c/2345928, https://crrev.com/c/2302970 https://crrev.com/c/2257090 Reverted in: https://crrev.com/c/2354149 Reason for revert: Suspected of causing the https://crbug.com/1114556 crash. Reason for reland: The root cause of the crash was determined to be something else. More test coverage is added. Original change's description: > [Web Payment] Revert header view changes. > > This reverts https://crrev.com/c/2351959, https://crrev.com/c/2345928, > https://crrev.com/c/2302970, and https://crrev.com/c/2257090 because > they are causing hard-to-diagnose crashes in production for a feature > that is supposed to be still turned off. The patches should be > relanded with more test coverage. > > Bug: 1114556, 1052493 > Change-Id: Ic221c99e28246676d24bcd2185773657abef4781 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354149 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797651} Bug: 1052493 Change-Id: I4b16ee3d383fd01431498444f8d2ef709b3d6204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389860 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#807531}
-
Alexander Surkov authored
pattern Implement basic application pattern support which allows to indicate which app to dump by its name. For example, --pattern=Safari or --pattern="Sublime Text" will dump accessible tree for Safari or Sublime Text applications accordingly. Bug: 1124366 Change-Id: Ie2ee3868968d9f369aa208cc546af27ee1c6770f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404361Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#807530}
-
Ken Rockot authored
The eliminates service_manager::Main/Delegate and moves logic back into ContentMain. Bug: 977637 Change-Id: I741b6f5a9e6c8dd6c5af43dd5f98a557b5aa8391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410663 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#807529}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4240.27-1600081136-benchmark-86.0.4240.38-r1 to 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie9c7cd6bf950f716f83aca75914a37d1c934a2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414538Reviewed-by:
-
Nikita Podguzov authored
There is no device_wifi_fast_transition_enabled.enabled field in chrome_device_policy.proto so this mapping should be removed. Bug: 1108908 Change-Id: I198173a5d99687bb53e9e246a5fbf73fb5e89abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414171Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807527}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: Icdd96655c87a6770ee7b9138426d7a3807e6d757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414295 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#807526}
-
Alice Wang authored
This CL implements the action of |Sign in again| button on sign-in auth error page of the web sign-in bottom sheet. Bug: 1119360 Change-Id: I358efc2e3c9d0d6971b1b5c14f4eebd8e6cb2bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379896 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807525}
-
Mathias Bynens authored
This patch renames `DevToolsFrontendHostImpl::BadMessageRecieved` to `DevToolsFrontendHostImpl::BadMessageReceived`. Change-Id: Ia5763d7a1aa5c91827ddbca59c19d71e93f625ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410862 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807524}
-
Siye Liu authored
When |TSFTextStore::ConfirmComposition| is called, we should set cached selection to the end of composition text. This change also add re-entrancy protection when performing writing operation to text input client. Bug: 1124023 Change-Id: I9fbe7768eba534a3896d9a7778a30e2c277b5a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392758 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#807523}
-
Chris Sharp authored
To clarify what happens to unmanged users when the policy isn't set. Change-Id: I0b027f4c708de03c32fba752e817d8828be711aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414016Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#807522}
-
Nohemi Fernandez authored
Various aspects of sign-in expect a non-nil identity in order to successfully finish their post sign-in completion. This patch makes it more explicit that identity must be non-nil following an error in add account. Bug: 1126170 Change-Id: I2a9cf96b55ec2f4118cd7fee2d9947498b051fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410253 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807521}
-
Nohemi Fernandez authored
Adds a temporary UI that displays the list of accounts currently on the device when a user selects sign-in on the web. https://drive.google.com/file/d/1uBEdtsq3MPDaAas7sVSRWWEsqqk_avCo/view?usp=sharing Bug: 1125631 Change-Id: I225a6f81bbe677458a062b7ad78b1491d4c8b2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411934Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Take the browser dependency canActivateExperiment() out of SkipToGPayHelper into an individual class SkipToGPayHelperUtil because this method happens to be a static one. * Move SkipToGPayHelper into //components Bug: 1102522 Change-Id: I7076c49908a0d86c97e4cb423dc3a80704c1d423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405637 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807519}
-
Hongchan Choi authored
The BACKGROUND thread priority impl on Windows 7/10 is confusing [2], and it seems very flaky [1]. The team agreed that using the NORMAL priority thread for OfflineAudioWorkletThread is a sensible fix for this. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1124980#c7 [2] https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBibGlua191bml0dGVzdHNAQXVkaW9Xb3JrbGV0VGhyZWFkUHJpb3JpdHlUZXN0LkNoZWNrVGhyZWFkUHJpb3JpdHkM Bug: 1124980 Change-Id: I8b4063f9a6ee802cafd4a05daaec23bf5f0170d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411395Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807518}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: I7a92943edb690010495c8014d51b493e110301bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412633Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807517}
-
edchin authored
https://crrev.com/c/2312556 is a refactor that introduced a DCHECK failure regarding (mouse) pointer support. The signin confirmation button can either have an opaque background (i.e., "Add Account" or "Yes, I'm in!") or a transparent background (i.e., "More") when scrolling is needed to reach the bottom of the screen. This CL changes the style provider to one that handles both opaque and transparent buttons. Bug: 1127293 Change-Id: I9e27f012d79885324b32ba918bd4f3f48a59d235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413172 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#807516}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4240.27-1600081136-benchmark-86.0.4240.36-r1 to 86-4240.27-1600081136-benchmark-86.0.4240.38-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idbb062c864a4e3301eefc4967e4e430ef3c649f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414535Reviewed-by:
-
Xiaohan Wang authored
Add cros and arm/arm64 to be future proof. Bug: 1111381 Change-Id: If6310e006710c2857d6c9be1297796374dcb3f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411344 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#807514}
-
Xiaohan Wang authored
When Widevine CDM host verification signing failed due to no signing cert, the build process will fail by default. However, developers making local builds typically don't have those certs. This CL introduces `ignore_missing_widevine_signing_cert` gn arg so the error caused by missing Widevine signing cert could be ignored. By default, `ignore_missing_widevine_signing_cert` is set to false on official bots (is_official_build=true) to catch real failures. Developers needing to set `is_official_build` can manually set this gn arg to be true to suppress the error. Bug: 1127616 Change-Id: I41a43e922399497c75f1f967219d41d1566d90dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412933 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: I0f59c9d6812ca93e2d7b5d100d7857467b685f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414193 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#807512}
-
Demetrios Papadopoulos authored
Without this attribute, screen readers don't announce whether a tab is currently selected. Bug: 1123470 Change-Id: Ie88959bf1cd4fc68003fffa62fbebe57877b899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410496 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#807511}
-
Xiaohan Wang authored
Bug: 1128458 Change-Id: I0a08be5ccb2e245134b12f264b90ccd2376cd2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413207 Commit-Queue: John Rummell <jrummell@chromium.org> Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Carlos Frias authored
This CL enables obtaining a finer control for OS hooks supported by OSIntegrationManager::InstallOsHooks(). Currently, there is no option for file handlers and file_handler_manager_->EnableAndRegisterOsFileHandlers() is being called every time InstallOsHooks() is executed. This CL adds the bitset OsHookType to InstallOsHooksOptions struct to allow controlling which OS Hooks to install, including file handlers. bool add_to_application_menu now becomes os_hooks[OsHookType::kShortcuts]. bool run_on_os_login now becomes os_hooks[OsHookType::kRunOnOsLogin]. Bug: 1087219 Change-Id: Ib370c394235efe66fca23267928184b9841c76ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373229 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#807509}
-
danakj authored
The code has moved, so update the includes. R=avi@chromium.org Bug: 1091083 Change-Id: Ib618539c1215d137cb1f109ee6109fe2e9b63fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413560Reviewed-by:
-
Yuke Liao authored
This CL runs lacros_chrome_browsertests on CI/CQ to prevent regressions. Bug: 1120582 Change-Id: I2350852341b1be0319e06350e3412ad43c771868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411845Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807507}
-
David Bertoni authored
This CL adds more tests to be run as Service Worker-based extensions. Bug: 1093066 Change-Id: Ib984bb47dfc16c1e7c5bca8838a5c6e71d0c9671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405552 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807506}
-
Jonathan Ross authored
This reverts commit 0e23bba9. Reason for revert: crbug.com/1128983 Causing linux-lacros-rel to fail compile almost 25% of the time. Making it tough to land changes Original change's description: > Use mojom::V8CacheOptions instead of blink::V8CacheOptions > > Now we can use mojom::V8CacheOptiosn directly in Blink. So, > this CL replaces all uses of blink::V8CacheOptions, then > remove it. > > Change-Id: I636e0259d0b7da692bf693c3ec13f99dba9cd410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409665 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#807427} TBR=kinuko@chromium.org,haraken@chromium.org,gyuyoung@igalia.com Change-Id: I0387c6f09f0a3bcb06fa6f62ce5ef53cb82e6860 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414671Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#807505}
-
