- 21 Aug, 2020 40 commits
-
-
Liviu Tinta authored
Pointer lock is acquired and released asynchronously. Remove reliance on timeout from the test by waiting until lock is properly acquired/released during the test steps. Bug: 1025944 Change-Id: Ibd5b1c19efb9c00794f1b900e12a5f5a4edab16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360494Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800553}
-
Roman Sorokin authored
This CL modifies existing behavior in the way that HID Detection screen is always shown on OOBE start if it's needed. It proceeds to the saved in the local state screen (or welcome screen) after that. Also removed CheckIsScreenRequired from the handler. Change-Id: I0253eae1a67c39567aba4f0cc522488c465056a4 Bug: 1105889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339655 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800552}
-
Anna Malova authored
TBR=arthursonzogni@chromium.org Bug: 1119555 Change-Id: I9c83227a0aae954e57d8f15cd7b4fc1cc1970a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368873Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#800551}
-
Weilun Shi authored
Temporary disable validate_prefix.py until we split all histograms because this blocks all updates in the current histograms.xml. Bug: 1120228 Change-Id: I5f3a607942098c4aa9341d1f86dda7913d185c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368080 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#800550}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8fa384f..ce9f3a41 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idacdb9154bd2679c28d63ac986dbcce89cbd2823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367495Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800549}
-
Stephen Sigwart authored
Home key changes to first of month, January in month view, and week 1 in week view. End key changes to last of month, December, or last week. For time, home goes to 1, 00, and am while end goes to 12, 59, and pm. Bug: 1062025 Change-Id: I40daebeca55eeb578a3b75d1ab06b6013d9bc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358476Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#800548}
-
kylechar authored
This CL changes how pixel tests are defined in viz_unittests. This is intended to be a refactor only change with no changes to the test logic or what tests run on each platform. Vix pixel tests previously used gtest typed tests, where the RendererType was a template parameter. Typed tests are not particularly extensible and don't work well when the parameter space to be tested isn't directly mapped to existing types. Some hacks to define pseudo types and use type deduction were used to specify things like running SkiaRenderer with different graphics backends (eg. GL vs Vulkan). This CL converts switches viz_unittests to use value parameterized tests to specify different renderer and graphics backend combinations. Value parameterized tests are the most extensible in gtest, and this fits in well with existing value parameterized tests. The key change here is replacing the cc::RendererPixelTest base class with a new VizPixelTest class. It's essentially equivalent except the RendererType is passed a constructor parameter instead of template parameter. An attempt was made to keep the test names stable, however some changes were introduced when changes as tests suites were merged. A follow up CL will use the renderer name instead of an arbitrary number to identify variations of the same test with different renderers, so the test naming is about to change significantly anyways. Bug: 1117587, 1047820 Change-Id: Ib626a081fb7797938a5cd34e96d8af44d7181965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364222 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#800547}
-
Roman Aleksandrov authored
Create all needed Update screen steps, use newly added time left estimation and progress procent. Bug: 1119399 Change-Id: Ia7ff7f76fb21fa683457f71f0bab3f598571e096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364634 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800546}
-
Mohamed Amir Yosef authored
... in CompromisedCredentialsConsumer. This is similar to OnGetCompromisedCredentials(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: Icc4e8135f4181b17f23fbee23666d20ad4f04277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367717 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800545}
-
Harald Alvestrand authored
Rewrite test so that it does not hang (create promise before event that it is waiting for). Bug: chromium:1115080 Change-Id: Ic445bef22561a1d997b4d3657a76e1b0779a1259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367854Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#800544}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bfb423d26610..490961030b55 2020-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I26a9e59c62ff3bbc0b82df23bfa6210d0c1abd8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800543}
-
Tanmoy Mollik authored
The sync related icons will now change color depending of light mode or dark mode. Screenshot: https://crbug.com/1109149#c3 Bug: 1109149 Change-Id: I631b6940f2ced0903f3687bd6ce84b5cbe7c0ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362807 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800542}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e719fca9. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I9bde9e84e4306a1c69914262376fcfc4ec7c364f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800541}
-
Ewann authored
This CL is developed under a flag. It displays the OpenIn.. toolbar to all files that support preview. Bug: 1117398 Change-Id: I32ad05e7cf0de89f3407366fa6767a29af3b80f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276269 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#800540}
-
Irina Fedorova authored
This feature flag allows as to enable checking passwords for weakness in chrome://settings/passwords/check. Bug: 1119752 Change-Id: I24984ee3cd64778260195b4319262c8b7851895d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367033 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#800539}
-
Mohamed Amir Yosef authored
This CL only introduce the simplest version of the reader which handles only one store. Follow-up CL will wire it up to the rest of the code, and then make it handle multiple stores. Bug: 1108422 Change-Id: If5202f5112cb841bd1c3ac65b37b5a1fa0eade4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367065 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Swapnil authored
Add swapnilgupta@ to OWNERS in the following directory: forced_extensions in chrome/browser/extensions/ Change-Id: I051d997768624f720c7950250b17eb488db62b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364534Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#800537}
-
Eleonora Rocchi authored
This CL adds tests to verify the number of compromised credentials is correctly updated: if the status is IDLE the count should be updated, otherwise the count should be null. Bug: 1117543, 1092444 Change-Id: I1f5a63745bc20789fc7df7bb5b5672df97e3b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367719Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#800536}
-
Mohamed Amir Yosef authored
... DatabaseCompromisedCredentialsObserver. This is similar to OnCompromisedCredentialsChanged(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: I76fffc36c65554bbe3e812c9e21ab229437f20a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368554 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12ffc2536244..c153394161f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1115567 Tbr: mxcai@google.com Change-Id: I69d01e6985fe8d4c24c945227d10488057df24e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368546Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800534}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d93c7e06451..d7508751f4e1 2020-08-21 patrick.brosset@microsoft.com Grid: Transform grid lines and labels based on the current writing mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096971 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96147e0515c03dfb66f28fcbdf9db251b680a6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368923Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4909d08c1410..a2c33e3fa098 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cbfd396756c6 to 44e1791f100c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ib7262936b7d170cce9dd20f38b60d742b4bbd991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368478Reviewed-by:
-
Igor authored
Currently three links from feedback form don't work properly on login screen, by opening invisible incognito windows only. This CL removes the links until the problem can be fixed on login screen. screen and click on the links for privacy/terms of service. Nothing is expected to happen, the links are disabled. Bug: chromium:1116383 TEST: Manually verified on device by pressing alt+shift+I on login Change-Id: Ieffd4cccbc8fbac52f45890761783cadb29cd3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362797 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Auto-Submit: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#800531}
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/899af242..f8fa384f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I336d80b56df8dff866a47b0796a7cebf3ad038d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366276Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maggie Cai authored
This reverts commit f5cdac12. Reason for revert: This might be the cause of test failure virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html for https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48699 (and some builds after this). Revert to see if this fixed the test. Original change's description: > Don't trigger main-thread overlay scrollbar animations if composited > > There are already hit tests and animations entirely in the impl thread > for such scrollbars. > > Bug: 1116800 > > Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800302} TBR=bokan@chromium.org,chrishtr@chromium.org Change-Id: Ided42e8aa3339e93f85d9f73f3737197864b493d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369076Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800529}
-
Friedrich Horschig authored
After this CL, CrOS tests will only execute 2 more tests from this test suite but the flakiness has reached a frequency of 1 failure per run (not the same test though). The failure reason is not easy to track down but the error log is pretty much always show the same DCHECK being hit: Check failed: casting_session_count_ > 0 (0 vs. 0) #0 0x561ba221ecab in __interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4176 #1 0x561ba221ecab in ?? ??:0 #2 0x561bb683aea9 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840 #3 0x561bb683aea9 in ?? ??:0 #4 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:206 #5 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:203 #6 0x561bb656d143 in ?? ??:0 #7 0x561bb65cd766 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:543 #8 0x561bb65cd766 in ?? ??:0 #9 0x561bb65cee7e in logging::LogMessage::~LogMessage() ./../../base/logging.cc:537 #10 0x561bb65cee7e in ?? ??:0 #11 0x561bc20145a9 in ash::ProjectingObserver::OnCastingSessionStartedOrStopped(bool) ./../../ash/display/projecting_observer.cc:50 #12 0x561bc20145a9 in ?? ??:0 #13 0x561bc1fe0c33 in ash::Shell::OnCastingSessionStartedOrStopped(bool) ./../../ash/shell.cc:404 #14 0x561bc1fe0c33 in ?? ??:0 #15 0x561bb6cc6e86 in MediaCaptureDevicesDispatcher::UpdateMediaRequestStateOnUIThread(int, int, int, GURL const&, blink::mojom::MediaStreamType, content::MediaRequestState) media_capture_devices_dispatcher.cc:? #16 0x561bb6cc6e86 in ?? ??:0 #17 0x561bb6cc9822 in Invoke<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:498 #18 0x561bb6cc9822 in MakeItSo<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:637 #19 0x561bb6cc9822 in RunImpl<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), std::__1::tuple<base::internal::UnretainedWrapper<MediaCaptureDevicesDispatcher>, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState>, 0, 1, 2, 3, 4, 5, 6> ./../../base/bind_internal.h:710 #20 0x561bb6cc9822 in RunOnce ./../../base/bind_internal.h:679 #21 0x561bb6cc9822 in ?? ??:0 #22 0x561bb6702dd1 in Run ./../../base/callback.h:99 TBR: mfoltz@chromium.org Bug: 822231 Change-Id: I1780e4f0be20361bded9d38a070e6dfacdfdd45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367676Reviewed-by: -
Mugdha Lakhani authored
Bug: 1119726 Change-Id: If3a82e7718590e51bafeee191e2176cd2a3f2a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366754 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800527}
-
Maggie Cai authored
This reverts commit 029e171b. Reason for revert: This CL is likely the causes of failed test QRCodeGenerator.GenerateVersionSelection since build https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20302 Original change's description: > qr: add support for selecting the mask. > > The QR standard says that the mask should be auto-selected, not fixed to > three, and specifies a fitness function for choosing the best mask for > each QR code. > > This change adds support for that and lets the caller specify a mask if > it really wants … say if it wanted to cycle through a series of QR codes > for the same data with a dancing dinosaur on top. > > Change-Id: Ief4dedce236aa2ae13cc94b2248a17a0488f88ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365222 > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#800326} TBR=agl@chromium.org,martinkr@google.com Change-Id: Iacd4ff5dd235bbd54992061589ac93d73c76a708 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368658Reviewed-by:
-
Yuki Yamada authored
This is a reland of 351529d8 The previous CL was reverted since M86 branch cutoff was coming, so let's reland it again :) Update summary from the original CL: - Made WebSocketChannelImpl::ProcessSendQueue() not called when the execution context is already destroyed. https://crrev.com/c/2362042 - Add kForceWithoutContextObserver parameter to VibrationController::vibration_manager_ to avoid automatic reset. https://crrev.com/c/2355638 - Check IsContextDestroyed() before calling Abandon() in PrerenderHandle::remote_handle_. https://crrev.com/c/2355357 - Check sensor_remote_.is_bound() before accessing it from SensorProxyImpl::RemoveConfiguration(). https://crrev.com/c/2352588 These ware all related to HeapMojoWrapper's ContextDestroyed() because the original CL broke the order of callbacks invoked from ExecutionContext::NotifyContextDestroyed(). Original change's description: > Change HeapObserverList to HeapObserverSet > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > addressed two things: changing HeapObserverList to HeapObserverSet and > allowing removal while iteration, and was reverted for performance > reasons. This CL only does the former and avoids performance > implications of the latter. > > This CL is for migration of NewLinkedHashSet. > See: https://crrev.com/c/2134039 Bug: 1100257 Change-Id: Ib8d21b44bf1447326428e0976f39e4c53677f838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369012Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800525}
-
Nela Kaczmarek authored
This change covers adding change_password_url field to Facet and adding a RequestInfo struct that enables caller to set Affiliation Fetcher request mask. Change-Id: I544e5ab0d9f07d0b711e4b8775a40f1130ba1563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362590 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a711c594b8cc..b79773a35d52 2020-08-20 dnovillo@google.com CCP should mark IR changed if it created new constants. (#3732) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7b9d99754553c859342a3fd48553b74b3d09b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97ff660720cd..5d93c7e06451 2020-08-21 alexrudenko@chromium.org Move Layout pane to the 3rd position in the sidebar 2020-08-21 alexrudenko@chromium.org Show grid elements across iframes 2020-08-21 nsatragno@gmail.com Update webauthn OWNERs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12b3ea8365c75d34a73c45f4b61438c03744eab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368917Reviewed-by:
-
Marc Treib authored
The default timeout values are 10s without interaction, or 3s after mouseover. That's a bit short for this IPH bubble, so this CL changes the values to 30s/10s, and also makes the configurable via a variation param. Bug: 1115476 Change-Id: Ifa80371e4126c9ba21f0651e64ec68f18f9f36c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363755 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#800521}
-
Clemens Arbesser authored
With this CL, the controller will remember the last successful user data options, such that subsequent actions can refer to it. This allows the ShowDetails action to only surface the information that was requested in the preceeding CollectUserData action. Screenshots of the resulting UI are in the linked bug. Bug: b/160214328 Change-Id: I31cd5fa13257ff6f1f10cfaef75ebb7de5099df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367036Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800520}
-
Jeremie Boulic authored
When trying to open an encrypted archive with a wrong password, display an 'Invalid password' message, and prefill the password input field with this previous password. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FilesPasswordDialog" Change-Id: I11ceb75bc824c550fbb0c96ec516f2b6d391d615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366515 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#800519}
-
Alexey Baskakov authored
The WebAppProvider system couldn't download it given the url from the manifest: chrome://media-app/system_assets/app_icon_48.png It would be nice to have some offline integrity checks for SWAs metadata. Fixed: 1110768 Change-Id: Ie8fb1b2bc06bb9f64fdc2d0c22bafc3cb43da4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367589Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800518}
-
Reda Tawfik authored
This Cl adds |AllPasswordsBottomSheetView| which implements |BottomSheetContent| and chnge its visibility state from the controller. Adds a junit test. This Cl skips adding screenshots for string resources. The UI is in early stages and taking a screenshot for it does not help for translation. Will be added when the UI gives helpful context. Bug: 1104132 Skip-Translation-Screenshots-Check: True Change-Id: If6be6f9dbea93489b69b367d4d997cec595fb7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320171Reviewed-by:
-
Aya ElAttar authored
- Changed Web-originated clipboard access to set the destination trying to access the clipboard data if possible. - Renamed EndpointType::kVm to kGuestOs Bug: 1103614 Change-Id: I895ea000e985611896f842274ea6849a822753d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346288Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800516}
-
Karel Král authored
Create a tool to enable developers to annotate large amount of code with tracing. This is an MVP which just adds tracing of the method name. Bug: 1111787 Change-Id: I7a6fd7f51b9a3887074b1f53f005f1c0c8671a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332401 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#800515}
-
Jana Grill authored
Replace the word "device" with the actual device name in ADB sideloading notifications texts by adding a placeholder to the affected strings and replacing it with the corresponding device type when displaying the notifications. Bug: 1115444 Change-Id: I6aadf09594bbf19a31dc62a2aab81d855f81fcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367041Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#800514}
-
