- 29 Sep, 2020 40 commits
-
-
Yi Gu authored
This reverts commit 7b693e30. Reason for revert: caused test flakiness on several bots. e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12320 Original change's description: > [iOS][Password Check] Rewriting Passwords test with new details screen > > This change rewrites Passwords tests with new Password Details screen. > Obsolete tests are deleted. Fixed flakiness for > testSearchAndDeleteAllPasswords. > > Bug: 1075494, 1129441 > Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811668} TBR=eugenebut@chromium.org,gambard@chromium.org,vsemeniuk@google.com Change-Id: I9bd75ad7f3173c30e9174e0728575f77d8abdd10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075494 Bug: 1129441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438430Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811702}
-
kylechar authored
The test passed 100 of 100 runs locally so I think we can remove the test expectations for RetryOnFailure. Bug: 1097962 Change-Id: I2bb483528c5307011e128a738bf779b66d92df37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435283Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#811701}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601358844-b8defbe977309018021c72a700e18c84f94d16d4.profdata to chrome-linux-master-1601380366-03c4c1b9f0c0034a1b47d4510e955a5823e9948c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I9d8dadae361e1d1684465474da6b385872f5ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811700}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once the review is done and code merged, then the testing needs to be figured out[2]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 [2] - https://bugs.chromium.org/p/chromium/issues/detail?id=1124347 Bug: 682122 Change-Id: Ifbe91fda3d58d5eeaace7aff438cc0c0e08dbde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438054 Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811699}
-
Yi Gu authored
See bug for details. TBR=hansenmichael@google.com Bug: 1133295 Change-Id: I18353dee3eac0b18a1e5f4ccb6d333c3f0561662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438192Reviewed-by:
-
Hidehiko Abe authored
This reverts commit 465489da. Reason for revert: The original CL was reverted in order to revert the depending CL. Now the fix there is available, relanding this CL. Original change's description: > Revert "exo: Send keysym on zwp_test_input_v1_send_keysym." > > This reverts commit f4423821. > > Reason for revert: Blocking the revert of a CL that blocks chrome-uprev. See issue 1132766. > > BUG=1132766 > > Original change's description: > > exo: Send keysym on zwp_test_input_v1_send_keysym. > > > > According to the document, the zwp_test_input_v1_send_keysym's argument > > named |code| should be XKB keysym. > > Currently, XKB keycode is sent, so fixed to the collect one. > > > > BUG=1123705 > > TEST=Ran locally. Made sure expected keysym is sent to client. > > > > Change-Id: I9db31cf84b21a7c9a400d75bcbec2fbfe69a2ad4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432165 > > Reviewed-by: Jun Mukai <mukai@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810912} > > TBR=mukai@chromium.org,hidehiko@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1123705 > Change-Id: I7852ff3d577044e82cd2f8fb5c859f1947b1b3fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436509 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811362} TBR=mukai@chromium.org,hidehiko@chromium.org,afakhry@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132766 Bug: 1123705 Change-Id: I6ba86f015ba597625a4c2ff8ffaba5d7b796d272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437545 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811697}
-
Laís Minchillo authored
Bug: 1111789 Change-Id: I53dec0cac2c6a28ea70aa7ee215cd4c1325ef054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421653 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811696}
-
Tanmoy Mollik authored
Add a sign-out icon on the sign-out row in AccountManagementFragment Screenshot: https://crbug.com/1131891#c2 Bug: 1131891 Change-Id: I3820aab37d54d7e9dd0e525dc0141072b884ef07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435193 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811695}
-
Martin Šrámek authored
Although there already is a histogram tracking NTP promo clicks in general, we need to also add an action, so that we can measure the funnel from this promotion to the actions the user takes in settings on the action sequencing dashboard. Bug: 1015841 Change-Id: Ic68918b48339402af7d700d7d134eb242ee8537f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429048Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#811694}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2663e6012911..dbb090f41f9b 2020-09-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 30cee4f4 to 3049a95d (469 revisions) 2020-09-29 ianelliott@google.com Add Context* to EVENT() & DebugAnnotator::beginEvent() 2020-09-29 jdarpinian@chromium.org EXT_float_blend is core in ES 3.2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Ief4313a806641fa210d1ece46ce521dd7bc3f053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438162Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601294375-ec6f4fd0c2345f1003140fa4e4e991347147fa6d.profdata to chrome-win32-master-1601326576-88be268f41c8e627e3f353defda83bb3fe16d327.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: Ia88dec736e0c5c0a85989d54224c09906587a28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437640 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Omar Morsi authored
This CL removes key_permissions_manager_user_service.h file which is unused after https://crrev.com/c/2405576. Bug: 1127284 Change-Id: I42a4a45f4b8deea57c2d52c490499fef06706ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437432Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#811691}
-
Hiroshige Hayashizaki authored
This reverts commit 44541a20. Reason for revert: The bot failure should be fixed by fixing a DCHECK() in worker_or_worklet_script_controller.cc that contained side effects. (crbug.com/1132893) Original change's description: > Revert "Introduce ScriptEvaluationResult" > > This reverts commit 3a4677f6. > > Reason for revert: bot failures due to crash at blink::AnimationWorkletGlobalScopeTest::RunScriptAndGetBoolean() > see https://crbug.com/chromium/1132893 > > Original change's description: > > Introduce ScriptEvaluationResult > > > > This CL introduces ScriptEvaluationResult with clearer uniform > > semantics that covers both classic and module script evaluation. > > ScriptEvaluationResult has ResultType enum class, to explicitly > > distinguish cases where normal exceptions are thrown (kException) > > from cases where not (kNotRun and kAborted). > > > > This CL merges ClassicEvaluationResult and ModuleEvaluationResult > > into ScriptEvaluationResult. > > > > This maps: > > - ClassicEvaluationResult::IsEmpty() > > => ScriptEvaluationResult::GetResultType() != kSuccess > > - ModuleEvaluationResult::IsSuccess() / IsException() > > => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess > > > > To keep the invariant of kSuccess <=> non-empty v8::Value, > > this CL makes ModuleRecord::Evaluate() to return > > ScriptEvaluationResult with a non-empty value > > on successful evaluation + top-level await is not enabled, > > while previously it returned ModuleEvaluationResult::Empty(). > > This value is not used, and thus this change doesn't change > > the behavior. > > > > Bug: 1111134, 1129743 > > Change-Id: I350860171a3c3b63517641dfb9555b8788386438 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789 > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811244} > > TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,cbruni@chromium.org,dom@chromium.org > > Change-Id: Iaaca1345213b1f3e4fc8ec703257217998ec0826 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1111134 > Bug: 1129743 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435918 > Reviewed-by: Gayane Petrosyan <gayane@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811258} TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,gayane@chromium.org,cbruni@chromium.org,dom@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1111134 Bug: 1129743 Bug: 1132893 Change-Id: I494cf7b5c1d55b65d9bd4552f1ed2d9b05ffae1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438073Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#811690}
-
Tal Pressman authored
The AgentSchedulingGroup interface is (currently) associated with the Renderer interface, so message ordering is preserved. For now, the ASG simply calls the appropriate method implementations on RenderThreadImpl. Bug: 1111231 Change-Id: I1dc1ffced95f6210894550d1864a93ef92b4b943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409721 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd99a610db07..5c1904772b36 2020-09-29 szuend@chromium.org [ts] Type-check timeline/TimelineDetailsView.js with TypeScript 2020-09-29 szuend@chromium.org [ts] Type-check timeline/TimelineLoader.js with TypeScript 2020-09-29 alexrudenko@chromium.org Set up ThemeSupport in component-server to allow importing CSS 2020-09-29 szuend@chromium.org [ts] Type-check timeline/UIDevToolsController.js with TypeScript 2020-09-29 szuend@chromium.org [ts] Type-check timeline/TimelineLayersView.js with TypeScript 2020-09-29 janscheffler@chromium.org [WebAuthn] Store available authenticators 2020-09-29 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from timeline/TimelineFilters.js 2020-09-29 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from timeline/CLSLinkifier.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1131055 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9906edeb4b645529174bcda8588857690cb6f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438160Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/44be0942f9a8..1075baee443c 2020-09-29 bclayton@google.com Vulkan/Debug: Add Context::Lock::findFile() 2020-09-29 bclayton@google.com src/Pipeline: Misc fixes 2020-09-29 bclayton@google.com Vulkan/Debug: Various fixes / improvements to Thread 2020-09-29 bclayton@google.com Vulkan/Debug: Don't accumulate function breakpoints 2020-09-29 bclayton@google.com Vulkan/Debug: Overhaul Values / Variables 2020-09-29 bclayton@google.com Vulkan/Debug: Assert on locking context twice on same thread 2020-09-29 bclayton@google.com Vulkan/Debug: Add File::getBreakpoints() 2020-09-29 bclayton@google.com Vulkan/Debug: Split EventListener If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iced72a9e541f152ff48e53084c402c5d48ba8037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438154Reviewed-by:
-
Peng Huang authored
I think the crash is because the SharedContextState is released before calling the dtor. Fix the problem by holding a ref of the SharedImageContext in the backing. Bug: 1127327,1131357 Change-Id: I72667f7ff8362757533c1992636575f4d726ba18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435325 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811686}
-
Roman Sorokin authored
Most of the times the screen has its implementation as the OOBE screen (html + javascript). But it could happen that there is no html part. In that case OobeScreenExitWaiter is useless because screen on the OOBE part might not change. This CL create a WizardController screen exit waiter. Which should help in such cases. Bug: none Change-Id: I9e48e892a4e46d2f417d92a27d59b8319b8ce965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431046Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811685}
-
Boris Sazonov authored
Refactors SigninManagerTest: * Switches to explicit creation for SigninManager, thus allowing writing tests for SigninManager ctor. Such a test will be added in a subsequent CL. * Adds explicit SigninManager.destroy call. * Removes redundant Mockito stubs (doNothing & doReturn(null)) where they don't improve the readability of the test. * Switches to @Mock annotations instead of manual mock(...) in setUp. Bug: 1132290 Change-Id: I630cc95d84c6ba4f5d2fc737dbb8a786e6dd6f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431486 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811684}
-
Paula Vidas authored
Proxy types do not exist at the server, so they are not part of invalidations. Bug: 1082115 Change-Id: I332978e945bd9e44ff7b74bcd2c708ac77bef18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436337Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#811683}
-
Mark Brand authored
This is a rebase of adetaylor@'s original CL https://chromium-review.googlesource.com/c/chromium/src/+/2253149 on top of the refactorings. Bug: 1105910 Change-Id: Ic6dc70400bcb9aec9f37981ed5e41fa5eb6fa3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410491 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#811682}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601337561-8feee235133953607f7453082566ed5b7d8ffb34.profdata to chrome-mac-master-1601358844-3b872c2864f88be4ab51b10f2fd5f4046a4261fe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I35d8efa5559ae6c9edc7a3fcf04c0db1590524f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438113Reviewed-by:
-
Sebastien Lalancette authored
- Fixed the Copy Link test that wouldn't pass on devices. - Reused helper function for Open In New Tab and Incognito actions. - Added test coverage the new context menu actions: - Share - Delete Bug: 1131831,1067812 Change-Id: Ic5b6e4487aea4bd7c972f5ca8caf6632e4c6dbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435329Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#811680}
-
Viktor Semeniuk authored
This change adds metrics for the Password Edit dialog. It records what exectly user updated. Bug: 377410 Change-Id: I8940bb9960eaf79b569cae2130246ea043e1adda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426594 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Swapnil authored
Analysing the statistics, we observed that we get BAD_APP_STATUS error with "unknown-app" error in the app status in the update manifest. This means that the server has no record of the extension or that there are visibility rules preventing it from disclosing the existence of such a record (e.g. extension is only visible internally for Google, and the request is from outside Google). This is a misconfiguration from the admin side. Bug: 1130609 Change-Id: I5fb7bee74a564635ffa67bc218906576db27e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421602 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#811678}
-
sandromaggi authored
This allows the SelectOptionAction to use a value from a previously selected profile. If the profile is not available the action will terminate with an error. If the value expression cannot be resolved the action will terminate with an error. Bug: b/169521597 Change-Id: Ibd34fa922b9c7d1ac2846e0327caf194697e5f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437810Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#811677}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/88c194fccd3b..76404b01d531 2020-09-29 treehugger-gerrit@google.com Merge "Fix typescript error" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iff22b6c7c1ddf212c14f484c7ec9f4ecad67c8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438151Reviewed-by:
-
My Nguyen authored
list-frame default padding is 60px, update to 40px because top-level spell check title has a 20px padding, spell check languages title has 60px padding, making it a 40px visual indentation. Old view: http://screen/7REeFrimicVBjWM New view: http://screen/6kZ4if6qVnZjKso Bug: 1113439 Change-Id: I24bb4e805d64f1adb5772355a3de9823a079a23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437544Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/95c0414b..fa4bfe45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9601fa5406391df8f809261a6a4afa59875f0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437969Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#811674}
-
Aga Wronska authored
Extends the histogram expiration and updates owners. Bug: 1088897 Change-Id: Id0ac5473c4065f5e8de9b3eb5a93e32976d4829f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434464Reviewed-by:
-
Dominick Ng authored
Crash reports indicate that ChromeLauncherController::InsertAppLauncherItem seems to be called to insert an item that already exists in the shelf. This CHECK has been around for a long time. Convert it to a conditional DumpWithoutCrashing, and return the ID of the existing item. Adding the return doesn't functionally change behaviour since no callsite uses the returned value. Additionally, since the item must already exist in the shelf model, presumably this preserves the desired behaviour, though the desired pin position may be changed. Further investigation is needed to see what exact train of events led to this CHECK being violated. BUG=1090134 Change-Id: I9dc5d37e82663f6a80b25f8747a62ad2a11f8607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437336Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811672}
-
Aya ElAttar authored
- Added kArc as a data endpoint type of the clipboard data. - Changed the notification strings of the toast shown when the clipboard data sharing with ARC++ fails. Bug: 1129345 Change-Id: I8e61ddbb1dc9ea9f36d1965152fe57e471787479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428970 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811671}
-
Titouan Rigoudy authored
For subresource URL requests, the renderer URLLoader uses its factory's parameters to determine the client security state of the request initiator. Navigations however use a central URLLoaderFactory in the browser process. This change propagates the client security state in the ResourceRequest to the URLLoader as a trusted parameter, and acts on this state in URLLoader. It only improves the situation for non-top-level navigation requests. The latter need some thought given to the UX first, see: https://crbug.com/1129326. Bug: chromium:1124346 Change-Id: I8736706ef402831375f34f9c7f2a96d3059c25be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410406Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811670}
-
Yi Gu authored
This reverts commit ceada96f. Reason for revert: The tests are still flaky. e.g. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AccountManagerUIHandlerTestSuite%2FAccountManagerUIHandlerTest.OnGetAccountsWithSecondaryAccounts%2F0&testType=browser_tests Original change's description: > Re-enable AccountManagerUIHandlerTest tests > > AccountManagerUIHandlerTest tests were disabled in > https://bugs.chromium.org/p/chromium/issues/detail?id=1131834 > due to flakiness with ExternalWebAppManager. This is due to > https://chromium-review.googlesource.com/c/chromium/src/+/2423823 > altering the behaviour of when > chromeos::ProfileHelper::IsPrimaryProfile() gets called uncovering > an incompatiblity between the profile created by these tests and > IsPrimaryProfile(). > > This CL disables ExternalWebAppManager's start up flow to avoid > triggering the IsPrimaryProfile() incompatibility so we can > re-enable these tests. > > Bug: 1131834 > Change-Id: Ia4d15785a64b45689f742d3604c10e1b8502cafd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811404} TBR=michaelpg@chromium.org,alancutter@chromium.org Change-Id: I6b783ce2797fd5e88e5a1a131782a1598ab2f1b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437171Reviewed-by:
-
Viktor Semeniuk authored
This change rewrites Passwords tests with new Password Details screen. Obsolete tests are deleted. Fixed flakiness for testSearchAndDeleteAllPasswords. Bug: 1075494, 1129441 Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#811668}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/18d69fb4e7b2..0f6ed710764d 2020-09-29 fancl@chromium.org auto-triage: Don't update closed issue when all alerts recovered If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132463 Tbr: rmhasan@google.com Change-Id: I93fcd4735e66f24e25c7ddad564942d59232cde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437939Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ead81e2ba233..991ead187c14 2020-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I7e7bab48bd1a344cbe22b41624c2fed52baed7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437647 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Nohemi Fernandez authored
We display the account consistency promo on top of Google web sign-in to allow users to dismiss the promo and only sign-in on the web. Bug: 1125631 Change-Id: Ife6da5203a3bff8e72fe79a9be06cefd902cc5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416376 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#811665}
-
Austin Tankiang authored
Bug: 1067346 Change-Id: Ie7c5503754d1e2a1808e11230b9f6c6916c97269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426063 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#811664}
-
Michael Ershov authored
Enable the check that AttestationEnabledForUser policy is configured from cloud and the level is "Mandatory". This CL reverts https://crrev.com/c/1865340 because the values in the corp policies were fixed. Bug: 1000589 Test: *TpmChallenge* Change-Id: I17058e673100673023c3e8f0f759e0b4b92afac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436822 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
-
