GitLab

Changelog: https://github.com/googlechrome/lighthouse/compare/v4.0.0...v4.1.0

Change-Id: Ief76c7c2d0fb4b44e9332b91c2a6bb99f46a9d2e
Bug: 772558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506382
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638298}

Previously, boolean fields such as the "Can be default" which display a green
check-mark or red x-mark would additionally contain invisible (CSS font-size 0)
text "true" or "false" in order to allow selecting and copying them.

This CL removes this hidden text as we're no longer supporting selecting and
copying partial outputs.

Bug: 937321
Change-Id: Ic347c3f99d645463c59bc2c15d95aaf9148b2f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496923Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638297}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2179093ac06..0ab64c504cf5


Created with:
  gclient setdep -r src-internal@0ab64c504cf5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:937987
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I2f2f1b098b44f2404bf4d9fee5dc52c364a536e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506364Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638296}

Bug: 933784
Change-Id: I3bc03760dea254fa33f8c660689739db65a1ce9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492791
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638295}

The attribute values change from on/off/auto to lazy/eager/auto

Bug: 936572
Change-Id: I014891934cde248c1ea0a969d89b3b0d75eec2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500017Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638294}

A nested clip-path should resolve against the original elements
reference box, but it would instead resolve against the referencing
<clipPath>.
Pass the appropriate reference box to SVGLayoutSupport::IntersectsClipPath.

Took the opportunity to export some related tests to WPT.

Bug: 938913
Change-Id: I6d6ad88f0a97028b21b1f1a488afbdd42a96264b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505949Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#638293}

Bug: 937218
Change-Id: I66a30f2f095731957055cf082e39657a5c551b3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497415Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638292}

https://pdfium.googlesource.com/pdfium.git/+log/9ba187ae4751..3df5c7cf7b58


git log 9ba187ae4751..3df5c7cf7b58 --date=short --no-merges --format='%ad %ae %s'
2019-03-06 tsepez@chromium.org Fix temporary going out of scope too early in XFA_LoadImageData()


Created with:
  gclient setdep -r src/third_party/pdfium@3df5c7cf7b58

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:937199
TBR=dsinclair@chromium.org

Change-Id: I89e3c61b3e366e54de2f5ef32bc6b18d1d339ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638291}

And instead make function public.
I did not move the definition, because, as far as I can tell, the
declarations/definitions are rather out of sync for this file.

BUG=none
TEST=none

Change-Id: Ie0b21ffdf14513e1e67c4d1d0dce70703745387f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505838
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638290}

This CL adds origin_trial_feature_name to
- "BuiltInModuleInfra"
- "BuiltInModuleKvStorage"
While "BuiltInModuleInfra" origin trial is not needed for
end users, this is needed in terms of implementation, because
"BuiltInModuleInfra" should be enabled if "BuiltInModuleKvStorage"
is enabled, and thus "BuiltInModuleInfra" flag should also depend
on origin trials.
By adding origin_trial_feature_name to "BuiltInModuleInfra",
origin_trials::BuiltInModuleInfraEnabled() takes care of
the dependency.

As origin trials requires ExecutionContext, this CL associates
built-in module feature control with Modulator, by introducing
- Modulator::BuiltInModuleInfraEnabled()
- Modulator::BuiltInModuleEnabled()
This CL plumbs Modulator via ModuleScriptFetcher::Fetch() and
ImportMap, to plumb Modulator::BuiltInModule*Enabled() to
layered_api.cc.

It seems a little confusing that ModuleScriptFetcher takes
both Modulator and ResourceFetcher that refer
module map settings object and fetch client settings object,
respectively.
This is actually consistent, because built-in modules are
associated with module map settings object and the current
implementation of import maps is also associated with
Modulator (crbug/928435), while fetching should refer to
fetch client settings object.
This apparent inconsistency should be resolved by
- Fixing Issue 928435, or
- Enabling Built-in modules by default (which will remove
  dependencies to ExecutionContext/Modulator again), or
- Refactoring ModuleScriptFetcher.

This CL implements individual control over built-in modules
in ModulatorImplBase::BuiltInModuleEnabled().
After this CL,
- "BuiltInModuleKvStorage" enables "kv-storage" and "blank" only, and
- "BuiltInModuleInfra" flag enables "blank" only,
while they enabled all built-in modules before this CL.

Bug: 829084, 928435
Change-Id: I0ee2838c0981192e9a993cb784bc39d866682836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497468
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638289}

This works for network service both enabled and disabled.

Bug: 938696
Change-Id: I2210f44861976b14508c1eff8401bc12958dc87c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504692
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638288}

Before this patch, a payment app that was slow to respond to
`canmakepayment` event would leave a window of time when the user could
enter the tab overview mode in Android, which did not cancel the ongoing
payment, even though the merchant page was no longer in focus.

The tab overview mode displays a list of user tabs and is used for tab
switching. Chrome already listened to tab switch events, so selecting a
different tab does cancel the ongoing payment.

This patch cancels the ongoing payment when Chrome enters into the
overview mode.

After this patch, Chrome cancels the ongoing payment if the user enters
the tab overview mode, which can happen when the payment app is slow to
respond to `canmakepayment` event.

Bug: 817073
Change-Id: I852d8467bb4e349bcc9afb322d973a9bccca0910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506374Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638287}

This is a cleanup CL to add a few missing, and simplify existing,
interstitial tests. It also includes a few unaddressed nits from earlier
CLs.

Bug: 927924
Change-Id: Iaa177d8dfc69d127b6ba2af5c8f508d5e5d8db83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497756
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638286}

Partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1481899.
It turns out that that change did not remove a full screen blit, so it
was a lateral change at best. But that cl does fix another wallpaper bug
and left some framework for the next change, which confirm to remove a
fullscreen blit, but will not make it in time for m74.

TBR=xiyuan@chromium.org

Test: none
Bug: 774690
Change-Id: I3a42d9a2dfdc81b848998858ea4fad0218c7f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506372
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638285}

The |window_type| is always ws::mojom::WindowType::WINDOW, so it
doesn't need to be a parameter.

Bug: none
Change-Id: Id0ec9146d64e9653983f12945a1436083371633c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506110
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638284}

A previous change to use the network service introduced two
WeakPtrFactory members to DialServiceImpl.  Although this gets around
the advice to only use WeakPtrs from one factory on a single sequence,
it doesn't actually solve the problem: ~DialServiceImpl still runs on
the IO thread, which may cause some UI thread WeakPtrs to be
invalidated, resulting in a DCHECK (or a race).  The UI thread doesn't
actually need any of DialServiceImpl's data though, so this change just
makes the functions previously using it into free functions which then
call back onto the IO thread with a proper WeakPtr.

Bug: 934611, 936531
Change-Id: Iee1612cd9934bef109bbfa79d497685dbd275d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504980
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638283}

ImageCapture API has been stable from M59.
We can retire this flag now.

Bug: 518807
Change-Id: I78efd9694b9f2f34fb20fe1f760066b98e371708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506073Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#638282}

... for different operations instead of AsyncFileSystemCallbacks.

The only noticiable missing operation that still refers to
AsyncFileSystemCallbacks (instead of a more speciallized class)
is CreateSnapshotFile. This is because blink::DOMFileSystemSync::CreateFile
uses its own AsyncFileSystemCallbacks derived class to perform
CreateSnapshotFile operations (namely CreateFileHelper).

BUG=933878

Change-Id: I977911f1d97557d4da308337720436556c622f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499873Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#638281}

This change adds the Open Screen Protocol library to DEPS so that our
team can begin working on Chromium integration and testing ahead of its
completion.

Change-Id: I52ebca0b3eb890b4be2529b4cbb99a944e5133eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480703Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638280}

This reverts commit c92b0f22.

Reason for revert: Causing https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/31011

Original change's description:
> Changed XRHandedness enum to 'none' from empty string
> 
> Bug: 933411
> Change-Id: I7e698846e7c733c15a82bd9079855df1e2d5abf4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504223
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Commit-Queue: Brandon Jones <bajones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638243}

TBR=bajones@chromium.org,bsheedy@chromium.org,klausw@chromium.org

Change-Id: I09a7db9d04fb9d51a07e3600a593ec20c1d398bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 933411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506568Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638279}

Change-Id: I421e266c8b9be2839f3c106ce0a7935b7f030706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506467Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638278}

This is the first step towards implementation of Extension messaging
in Extension Service Workers. The CL implements chrome.test.sendMessage
from a tab (content script) to a Service Worker running as extension
background. Replying to the message through callback isn't implemented
in this CL.

The basic changes in this CL are:
- Make the messaging bindings available in the service workers'
  script context: runtime.sendMessage and runtime.onMessage.
- Handle IPCs to open/close a port for workers as well.
- Handle these IPCs in the browser process in the existing
  MessagingService class, expand ExtensionMessagePort to support
  workers along with RenderFrames/tabs.
- Both JS and native bindings work.
- Future CLs can expand on this base CL to support other messaging
  source and destinations as the implementation is meant to
  move the code towards generic support of messaging endpoints
  (worker or RenderFrame).

Some more detailed implementation notes:
- ExtensionMessagePort can track and target workers along with
  existing RenderFrames/tabs support. Handle the IPCs sent by it on
  worker thread (WorkerThreadDispatcher), these IPCs are:
    * ExtensionMsg_ValidateMessagePort
    * ExtnesionMsg_DispatchOnConnect
    * ExtensionMsg_DippatchOnDisconnect
    * ExtensionMsg_DeliverMessage
- MessageService can now work with Service Workers, similar to how
  they used to work with event pages.
- Introduce a generic ScriptContextSetIterator class in the
  renderer to apply IPCs to a set of ScriptContexts. Expand that
  to cover WorkerScriptContextSets as well as non-worker
  ScriptContextSets. Messaging IPCs targeted to workers now
  get dispatched to WorkerScriptContextSets. An unfortunate
  consequence of generalizing this to worker is Dispatcher provides
  a non-const ptr getter to ScriptContextSets
  (script_context_set_iterator) as worker script context sets require
  tls lookup.

Add an end-to-end test for the feature.

Bug: 925927
Change-Id: I8f77e6d63318925b85dc5707f9367e904bde634c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441274
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638277}

The recent refactor to TranslateManager made it so that some cases that
didn't trigger translations were misreported in the wrong buckets for
InitiationStatus. This CL adds buckets for those cases.

Bug: 924980
Change-Id: I6a00b523842ea4fb665e27e8791b399964c7f66a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504253
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638276}

Change-Id: Icabee8c59a5c776d1d56322621db1862a13322f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506553Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638275}

Fix last nits from
https://chromium-review.googlesource.com/c/chromium/src/+/1501497

Bug: None
Change-Id: I845ee28bce4f9558254eb2680f976bf024f404a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506118
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638274}

Change-Id: I9b9e2291b56981fe11a5b3ed3033aefbdd2c1779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506461
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638273}

This CL reenables using the Vision framework for Barcode detection on
Mac (this was broken in previous 10.14 OS updates and as expected is
now fixed). It also takes the chance to fill in |corner_points| in
DetectedBarcode.

Tested by local compilation and running it via:
./out/gn/Chromium.app/Contents/MacOS/Chromium https://yellowdoge.github.io/shapedetection-polyfill/demo.bundle.html --enable-experimental-web-platform-features

and verifying the QR (and other) codes, including slanted ones (!).

Bug: 921968
Change-Id: Ic485a41305d0290e8a35751a0de703bd674493fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506011
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638272}

This patch ensures that we don't put isolation nodes in place if we have
replaced content transform in an non-svg. The reason for this is twofold:

1. Typically, isolation wouldn't buy us anything, since we're likely
   looking at an image, which has no subtree to isolate.
2. When we get the chain of transforms, we need to decide whether we're
   returning a replaced content or an isolation transform since they are
   both leafs of a chain, but not a part of the same chain. Currently we
   return the isolation node first. We could fix this by returning the
   replaced content first, but then we specifically bypass transform
   isolation which may cause other bugs down the line.

R=pdr@chromium.org

Bug: 937571
Change-Id: I39f51a2e7810f058bfdf49c28c8f2e3857565ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506572Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638271}

This is a reland of 703661c8

Original change's description:
> Add flag for #omnibox-deduplicate-drive-urls
> 
> Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde
> Reviewed-on: https://chromium-review.googlesource.com/c/1481121
> Commit-Queue: Travis Skare <skare@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634850}

Change-Id: I3551f9b6216795713d7435d534d8b6cebbb9370b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484857Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638270}

This reverts commit 5027aad0.

Reason for revert: it's still suspect the test flaky.

Flaky tracing issue:
Bugs: 939054

Original change's description:
> Reland "[blink] Remove old script streamer thread"
>
> This reverts commit 50b4e186.
>
> Reason for revert: It was incorrect suspicion, bot became green w/o this revert
>
> Original change's description:
> > Revert "[blink] Remove old script streamer thread"
> >
> > This reverts commit 96c748b0.
> >
> > Reason for revert: it's suspect in failures
> > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/88931
> >
> > Original change's description:
> > > [blink] Remove old script streamer thread
> > >
> > > The script streamer thread has now been replaced with posting tasks to
> > > the scheduler, so remove the flag picking between the two options and
> > > the dedicated streaming thread itself.
> > >
> > > Also, remove the streaming task re-posting now that the blocking/
> > > non-blocking worker pools are merged.
> > >
> > > Bug: 874080
> > > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420
> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> > > Reviewed-by: Steven Holte <holte@chromium.org>
> > > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#638031}
> >
> > TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,leszeks@chromium.org
> >
> > Change-Id: Ia67f3fcfbff3155f9da4b53f371115f3dfd0089c
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 874080
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505412
> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#638055}
>
> TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org
>
> Change-Id: Ic4eb793dacdaa7565e92ba1b908162f5d3e02e15
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 874080
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505552
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638059}

TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org

Change-Id: I01a8e948c4b971bedcd8dd27c08d49e7c959c4d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506756
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638269}

Update bindings-inject-key.html from an async test to promise-based.
This allows the test to run so that each subtest is run serially.

Patch by Joshua Bell <jsbell@chromium.org>.

Bug: 934844
Change-Id: If9834a35fcb964a6fe15776e3e091d326f3f8a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504458Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638268}

This change is needed, so TimeLimitOverride can be used outside of
TimeLimitsProcessor for local override with parent access code.

Refactoring done while moving the class:
* Replace constructor that exits early and leaves object in inconsistent
state with factory methods
* Make class members private and add accessors to comply with style
guide
* Remove the need for storing second copy of dictionary keys used for
serialization in test code
* Add serialization to the dictionary

Bug: 911326
Test: usage_time_limits_processor_unittest.cc
Change-Id: I68ac5a6f17c41e28d3d4905abdfc96901694316b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493154Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638267}

The combination of a 1m length laser and showing a cursor
at 1m distance is visually very confusing when trying to
hit objects, especially when doing quick tests on a
mirror display without wearing the headset.

Instead, use a long laser beam, and only show a cursor
when there's a valid intersection with the scene.

Change-Id: Id4178b1ba72994c9148d53c8bc58f041fb42520d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506463Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638266}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/86f6ac086c8b..07f80c4df1b0


git log 86f6ac086c8b..07f80c4df1b0 --date=short --no-merges --format='%ad %ae %s'
2019-03-06 stevenperron@google.com Fix python scripts to work with python3 (#2426)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@07f80c4df1b0

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5bed70327a7b1df928572f0b1c0ab2a99f956786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506363Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638265}

File transfer may be undesirable in some enterprise environments, so
this adds a policy to allow disabling it.

Bug: 679313
Change-Id: Ided7fcb5cb5789851022c61605fb762fcf96705e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501853
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638264}

This fixes the placement of the Cancel and Send buttons in the feedback
UI when the available screen area is smaller than the height of the
feedback dialog. Previously, in that case the buttons would be pinned to
the bottom of the viewport and the content in the dialog would scroll
underneath the buttons. This separates them out into a separate div and
removes their absolute positioning so that they no longer overlap. Some
other margin were changed as well in order to prevent it from having
60px of gap between the privacy notice and the buttons.

on current builds or another bug prevents this from being scrollable at
all

Bug: 866931
Test: Verified w/ and w/out magnifier on, SPM also needs to be disabled
Change-Id: Ic58ee0cd3e7251ae3a37fc623f8928e9522066b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504232Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#638263}

1) A bug introduced during addressing review feedbacks so now the split
files can't be split further because they are wrong.

2) The script doesn't work if one if the four switches are missing. This
is problematic because we could easily split into a state where certain
switches no longer have values.

Added unit tests to make sure the above two issues are covered.

BUG=932197
TEST=unittests
R=askitkine@chromium.org

Change-Id: Ic961f609f0a0d00ebf213206a70b4fb76b83aac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497797Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638262}

This updates the consent flow to
1) Enable revocation via the consent activity
2) Only present the privacy preference when the user has consented
3) Have the privacy preference launch the consent activity for revocation
instead of being a checkbox

Bug:902490

Change-Id: I34fdc210ee03db100ab9c310ab5fe3d9cda15d76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481739
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638261}

IndexedDBFactoryImpl isn't scoped per origin and so can be used by
multiple origins. The original code assumed that it was scoped per
origin, so when in actuality it was used by multiple origins, when a
single origin requested a lock this could interrupt other origins in
certain cases.

https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.6cqn78xajqmp

R=cmp@chromium.org

Bug: 934790
Change-Id: I10f3e7c1b43ad7310d8824648575d940568b534d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487369
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638260}

During OOBE enrollment flow we fetch the list of policies and this may
contain users such as a public session user.

1.If the list of users fetched is not empty we show the account picker
screen.
2 If the list of users is empty we show the GAIA login screen.

We should only update session state to LOGIN_PRIMARY if we show the
account picker screen. Session state should remain OOBE if we show the
GAIA login screen.

Setting the value of session state controls the colors of the buttons
and icons in the shelf and setting it incorrectly causes visual bugs.

Bug: 937367
Change-Id: Iaa8f5913a36936f0959da8a517ddfb21ea5d5971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500632
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638259}