GitLab

c950cb0 Only disable export of libunwind symbols when libcpp is static

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_arm

Bug: 750392, 593874
Change-Id: I420202d5c83663da56654009350206784c7f6bc5
Reviewed-on: https://chromium-review.googlesource.com/596668
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491182}

This CL is the followup fix for CL/569538/ which was reverted because it
caused timeouts of egtests.  This CL made some change on a egtest to
prevent the timeout. Other than that, this CL is identical to CL/569538.

[Patch set 1] is identical to CL/569538.
[Patch set 2] added the fix to prevent egtest timeout.

[Demo videos]
- account with bookmarks:
https://drive.google.com/open?id=0B1O0Z7eoZMuGeTBjVXdla0RPeFE
- account with no bookmarks:
https://drive.google.com/open?id=0B1O0Z7eoZMuGR0pGb2tYUHcyOWM

TEST=Make sure it works when signed in user has no bookmarks or there is any sync error...

Bug: 696893
Change-Id: I92af0f4a1c9f88f6595f8a851ff92f0b5215132b
Reviewed-on: https://chromium-review.googlesource.com/587517
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491181}

Prior to this change, WebContentsTaskProvider would defer task creation if the
PID was not known at RenderFrameCreated time. However, for a newly-cloned
WebContents, no event ever occurred to re-create the Task once the process
finished launching. This was bug 738169.

Fix the problem by never deferring task_manager::Task creation; instead, create
Tasks for all live, current RenderFrameHosts. If the PID is not known immediately,
allow it to be set on the task at a later time (when RenderProcessHost::IsReady()
becomes true).

Because the TaskManagerImpl was written with the expectation that Tasks have
a constant PID, PID mutation is implemented in terms of temporarily removing the
task, mutating the PID, and re-adding it.

In WebContentsTaskProvider, we no longer need to implement RenderProcessGone.

In TaskGroup, don't waste time collecting stats for a null process ID.

Tests are added exercising this bug, and its subframe equivalent. Test coverage
is added for the PID==0 case, and we ensure that the "Memory" column is
populated with something nonzero.

BUG=738169

Review-Url: https://codereview.chromium.org/2961423002
Cr-Commit-Position: refs/heads/master@{#491180}

This is a reland of 26c8b12c

BUG=751309

Original change's description:
> Implement wait-for-logs functionality in user_session binary
> 
> This ports the wait_for_logs method from the Python script, and forwards
> the pipe write fd to the Python script.
> 
> Change-Id: Ief54da136894cd13e0761b9755aa3c7d51fe17f8
> Reviewed-on: https://chromium-review.googlesource.com/594807
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491058}

Change-Id: I9daf4957636a99b5179975cf1db33ba101bc179d
Reviewed-on: https://chromium-review.googlesource.com/597087
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491179}

This test creates its own TestBrowserContext, but it derives from
ExtensionsTest, which also creates one. Making the test use the
provided context instead of creating its own fixes the flake. The
flake is fairly rare but becomes more frequent as we add new tests
to app_shell_unittests. Read on for details on how this failure
occurs, why it was flaky and why more tests make it fail more often.

When run in combination with other tests, once in a while the new
context happened to be created at the same address as a context used
in a previous test, just by chance.

The process-wide DependencyManager keeps track of the pointers to
contexts that have already been shut down. ExtensionsTest is smart
enough to register its own context as "live", so this flake doesn't
normally happen, but this test didn't bother.

A new context at an old address would be fine *if* the context was
marked "live" again. When it isn't, accessing KeyedService with the new
context will cause DependencyManager to identify it as a "dead" context
(as seen in a previous test) and assert.

If we really needed a separate TestBrowserContext, we could mark it
live, but why bother?

Bug: 750530
Change-Id: I094be7ea4c715a8316547fb2b9f06c081f963483
Reviewed-on: https://chromium-review.googlesource.com/592546
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491178}

This reverts commit e0faf622.

Reason for revert: breaks debug compile

Original change's description:
> Validate rrects in PaintOpBuffer serialization
> 
> Also, consolidate all PaintOp validation into new IsValid
> functions.
> 
> Bug: 749023, 750010
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I1f5b695fe71c50d5ae126937c15a8957285a5487
> Reviewed-on: https://chromium-review.googlesource.com/590749
> Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Commit-Queue: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491171}

TBR=vmpstr@chromium.org,enne@chromium.org,khushalsagar@chromium.org

Change-Id: I1dac9ee740450c29bd0a25f3923e0f047cda8250
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749023, 750010
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/597070Reviewed-by: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491177}

Change NetLogSpdyStreamErrorCallback() to stringify error.
Example netlog output before this change:

HTTP2_STREAM_ERROR
--> description = "SPDY stream closed with error_code: 2"
--> status = -337
--> stream_id = 59

After this change:

HTTP2_STREAM_ERROR
--> description = "SPDY stream closed with error_code: 2"
--> error = SPDY_PROTOCOL_ERROR
--> stream_id = 59

Change-Id: If58ad76f3b99dde7f22e8bf81c2251f6fba9d2e3
Reviewed-on: https://chromium-review.googlesource.com/594192
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491176}

Implements PageRenovator which is responsible for picking renovations,
injecting them into a page, and notifying the user of script
completion.

Design doc:
https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU

Bug: 736933
Change-Id: Icbd8b494d75298ed355f9666971ecf918b441d2e
Reviewed-on: https://chromium-review.googlesource.com/585907Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Yafei Duan <romax@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Collin Baker <collinbaker@google.com>
Cr-Commit-Position: refs/heads/master@{#491175}

[toosl/perf] Extend tools/perf/validate_wpr_archives to check for missing SHA filesin archive json file

This fixes does:
1) Change tools/perf/validate_wpr_archives to also keep track of missing sha files
2) Always invoke tools/perf/validate_wpr_archives in tools/perf/PRESUBMIT.py.
Doing this also require changing validate_wpr_archives slightly so that when
options.wpr_sha_files is empty, the script won't check any archive file in cloud
storage (before this, the logic is check ALL archive files in cloud storage if
options.wpr_sha_files is empty).

Bug: chromium:730036
Change-Id: Id12bb07c2abe47428235e859fdde9339100a1525
Reviewed-on: https://chromium-review.googlesource.com/596504Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491174}

There's an infrequently-occurring issue where webrtc never receives a
network update from FilteringNetworkManager, but it's not clear whether
the issue is related to FilteringNetworkManager interacting with the
permission service, or IpcNetworkManager underneath getting the actual
network list.

So, this CL adds some logging to FilteringNetworkManager and
IpcNetworkManager that will help pinpoint the cause, next time someone
is able to reproduce the issue and provide a log.

Bug: chromium:699973
Change-Id: I5eecf668c89963dd31ef66fc29687fe91dd2ac49
Reviewed-on: https://chromium-review.googlesource.com/587509Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491173}

This was added in r190833 to support a test, but the test and the code
it was testing got removed in r253803, leaving created_local_state()
with no callers.

Change-Id: Id988d101eb47b496f6e3502c220c5b23ba6144f8
Reviewed-on: https://chromium-review.googlesource.com/587347Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491172}

Also, consolidate all PaintOp validation into new IsValid
functions.

Bug: 749023, 750010
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1f5b695fe71c50d5ae126937c15a8957285a5487
Reviewed-on: https://chromium-review.googlesource.com/590749Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491171}

The problem with DoReplaceSubstringsAfterOffset was that the following search
would not terminate:

  ReplaceSubstringsAfterOffset(std::string("aaabaa"), 0, "aa", "ccc");

The root cause of this is an algorithmic bug, where it was assumed that
string::rfind and string::find would return the same matches in reversed order.

The fix is to only scan forward using find(). For the length-expansion case, if
capacity is insufficient, we swap with a temporary and build the result into new
memory. If existing capacity suffices, we'll shift the tail of the string down
to the new size, and then use left-to-right memmove loop of the length-
contraction case, with the shifted tail as the src.

BUG=749228

Review-Url: https://codereview.chromium.org/2979393002
Cr-Commit-Position: refs/heads/master@{#491170}

BUG=402805,596968,734762

Change-Id: I05a0b54423a5e6acdd5052e734cfd01e3ed49822
Reviewed-on: https://chromium-review.googlesource.com/597013
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491169}

Change-Id: I4a0a05dec6b7b768250889199775d6bc8b951ef4
Reviewed-on: https://chromium-review.googlesource.com/580522
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491168}

Bug: 748445
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5d10fdd84b302a3064056f73544d8c214aace2bd
Reviewed-on: https://chromium-review.googlesource.com/584558Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491167}

This CL drops clamping for long tasks to improve accuracy.
Discussion at https://github.com/w3c/longtasks/issues/29

Bug: chromium:681718
Change-Id: If6df344f0203f7b6347f54ffa49be8d6689b7d71
Reviewed-on: https://chromium-review.googlesource.com/587590Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491166}

https://skia.googlesource.com/skia.git/+log/249ee1f985b4..5a9a981edf54

$ git log 249ee1f98..5a9a981ed --date=short --no-merges --format='%ad %ae %s'
2017-08-01 fmalita Tiling support for SkSweepGradient
2017-08-01 bsalomon Make ProcessorCloneTest more robust, fix matrix conv. onIsEqual
2017-08-01 robertphillips Fix cleanup on program creation failure
2017-08-01 ethannicholas Revert "support for 'half' types in sksl, plus general numeric type improvements"
2017-08-01 ethannicholas fixed missing INT_MAX definition

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I43efa8eeb5e612e3ce9bcbae3d90bbcdb58efa2a
Reviewed-on: https://chromium-review.googlesource.com/597011Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491165}

We are turning on 50% on beta. Got a finch warning that we must add a field trial config for it.

Bug: 718154
Change-Id: I480d390acf1f9f903a00345169d270d6ca01b428
Reviewed-on: https://chromium-review.googlesource.com/596627Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491164}

The CanMakePaymentEvent is used to check whether the payment handler is able to
respond to a payment request.

Related spec change:
  https://github.com/w3c/payment-handler/pull/170

Bug: 736745
Test: payment_app_provider_impl_unittest.cc, payment_app_browsertest.cc
Change-Id: Ib4073d26fd8e24e1bcbf1b113c3fd3fd3451c609
Reviewed-on: https://chromium-review.googlesource.com/574992
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491163}

1. Remove an unused method from PaintLayerClipper.
2. Don't conditionally set cache slots which are ignored anyway for PaintLayerClipper
use-cases that use GeometryMapper.
3. Remove unnecessary pagination_clip parameter in PaintLayerFragment.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6cd7b8646ac68873a245c76813ec3723d48858c9
Reviewed-on: https://chromium-review.googlesource.com/595109
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491162}

While adding Expect-CT support for chrome://net-internals, I noticed that a
crash can occur if the report URL results in a net error. This appears to be due
to accessing the response code before checking the request status is
success. Unfortunately, I can't reproduce the crash in a browser or unit test,
perhaps because it's a race.

Bug: 751197
Change-Id: I60c2b4debe19da9ef98f838ce2013747644a39d8
Reviewed-on: https://chromium-review.googlesource.com/596514Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491161}

Bug: none
Change-Id: Ib8fdd720512dd134abd1d46b7c6276f3c0f8cccd
Reviewed-on: https://chromium-review.googlesource.com/596468Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491160}

Instead of having to serialize SkRegion (as clipRegion is the only call
that needs a region), instead add a top level "clip device rect" that
takes two parameters.  This is to support the use case that the
RasterSource canvas setup preamble uses to clear the canvas efficiently.

Bug: 737629
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icfb41557c716d5c52ef44454b8791e29c36d5bda
Reviewed-on: https://chromium-review.googlesource.com/590950Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491159}

Update feature flags

https://chromium-review.googlesource.com/c/596150/

Deprecate quic_reloadable_flag_quic_faster_bandwidth_sampler.

Merge internal change: 163489610

https://chromium-review.googlesource.com/c/595337/

Remove unused methods

Merge internal change: 163472196

https://chromium-review.googlesource.com/c/595336/

Adding two new QUIC BBR ack aggregation modes.

The modes are requested with the BBR1 and BBR2 connection options and
protected by quic_reloadable_flag_quic_bbr_ack_aggregation4, which
replaces quic_reloadable_flag_quic_bbr_ack_aggregation3.

Merge internal change: 163344044

https://chromium-review.googlesource.com/c/595335/

Deprecate quic_reloadable_flag_quic_bbr_ack_aggregation2 in the false state.

Merge internal change: 163252118

https://chromium-review.googlesource.com/c/595333/

Change QUIC ack type byte to match IETF 101NLLMM format

As specified by
https://github.com/quicwg/base-drafts/commit/fac7f9d91f781602d8425ccd1fa6aa521f78243a.

Merge internal change: 163211775

https://chromium-review.googlesource.com/c/594855/

R=rch@chromium.org

Bug: 
Change-Id: I7c7e1af913f98c8c8dfd4d98551ae320c0febf5d
Reviewed-on: https://chromium-review.googlesource.com/596227
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491158}

NO_TRY=true

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia08770feb6daae4844d50713271e19b5a2a8394b
Reviewed-on: https://chromium-review.googlesource.com/596770Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491157}

It's been enabled by default for a long time. We're just removing the
feature flag now.

Bug: 749174
Change-Id: I6cad01d596855c4320e219597789347c63a5b9a6
Reviewed-on: https://chromium-review.googlesource.com/587428Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491156}

Add ARC guard to bubble_util.mm so it can only be compiled with
Automatic Reference Counting enabled. Although it currently only
contains C++ symbols, it is convention to include the ARC guard on all
new files. If in the future Objective-C symbols were added to the file,
not having the ARC guard could cause memory leaks.

R=edchin@chromium.org, gchatz@chromium.org

Bug: none
Change-Id: I0b72bd93a904f04034ca85f9f21b969f9a358e07
Reviewed-on: https://chromium-review.googlesource.com/596587
Commit-Queue: Cooper Knaak <cooperknaak@google.com>
Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491155}

Previously when the user taps "Hide Keyboard" from the session menu, the
keyboard will immediately show then hide itself. This CL prevents the
keyboard from showing between (alert is shown, action is executed) and
manually shows it again only when necessary.

This CL also includes some refactoring to reduce redundant common code.

Bug: 750956
Change-Id: I545e1880352e279ebf324676f7680600761b78f3
Reviewed-on: https://chromium-review.googlesource.com/595016Reviewed-by: Scott Nichols <nicholss@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491154}

Add a function to replace existing quad with a solid color draw quad to
reduce duplicate code in overlay.

R=danakj@chromium.org

Bug: 739429
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6ea4df426dde50122b73923d970ea3e6429dd8aa
Reviewed-on: https://chromium-review.googlesource.com/596647
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491153}

Bug: chromedriver:1878
Change-Id: I1ae14a5e3700e442ca1507db5c2f51e9e1005044
Reviewed-on: https://chromium-review.googlesource.com/596531Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491152}

In particular, add suppressions for some new bluetooth/characteristic/
tests, an inspector-protocol test that's seen recent work, and a
scrollbar test that's falking for unknown reasons.

TBR=rdsmith@chromium.org
NOTRY=true

Bug: 729849
Change-Id: Ib26bad25b705c9e05c57f588362bcbc9233f5ae5
Reviewed-on: https://chromium-review.googlesource.com/596795
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491151}

This CL prevents the match part of the URL from being elided by
the experimental URL formatting flags.

Bug: 732582
Change-Id: Ic08a8cad845f4d4581d8f6310e59423191d4bd28
Reviewed-on: https://chromium-review.googlesource.com/594722
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491150}

Make clang build use msvs_use_absolute_paths gn argument to get same
behavior in msvc & clang builds.

https://chromium-review.googlesource.com/c/558871/#message-7a8946793945959784b225c192588fa4bb5f26b1

Follow-up: https://chromium-review.googlesource.com/c/558871/
Bug: 
Change-Id: I9c35d83b0f163356aac0fd2c94f4c56c02a794a5
Reviewed-on: https://chromium-review.googlesource.com/585467Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491149}

This CL reverts the changes in sysroot-creator.sh and
rolls the sysroots forward to reflect the change.

BUG=749077
R=thestig@chromium.org

Change-Id: Ia9ba4427666dbf9268138f7ec7a2f77df70a172f
Reviewed-on: https://chromium-review.googlesource.com/596419
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491148}

This is to ensure that we can provide functionality to update the AppCache using the URLLoader.
The plan is to implement the URLLoaderClient part of the update job in a subsequent patch.

This patch has the following changes:
1. We have a new class AppCacheUpdateRequestBase which provides the interface which is
   implemented by the URLRequest and URLLoaderClient subclasses. This interface is used
   by the URLFetcher and the AppCacheUpdateJob.

2. Subclasses AppCacheUpdateURLRequest and AppCacheUpdateURLLoaderRequest. These implement
   the URLRequest and URLLoaderClient portion of the update functionality. The URLRequest
   one is fully functional at this point.

3. I have left most of the reading and updating logic unchanged in URLFetcher unchanged.
   Will revisit this when I start working on the URLLoaderClient functionality.

4. The AppCacheUpdateURLRequest subclass maintains a pointer to the URLFetcher base and
   invokes its methods when it receives a response/redirect notification/data, etc.

BUG=715632

Change-Id: I16497e41aa5dbfab0c06c1ab0fc114945dd279e8
Reviewed-on: https://chromium-review.googlesource.com/592809Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ananta Iyengar <ananta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491147}

Bug: 748318
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieec84f84713dafde7e6186367032a09eb18af3f6
Reviewed-on: https://chromium-review.googlesource.com/584169
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491146}

R=dpranke@chromium.org
CC=thakis@chromium.org

Change-Id: I6ed223a1fe08fa95837156ae9f4800acf7396524
Reviewed-on: https://chromium-review.googlesource.com/592512Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491145}

Transient URL rewriters do not make sense for lazily synced navigation
items. Refactoring them out of CreateNavigationItemWithRewriters allows
GetItemAtIndex() to maintain its const contract.

There is no behavior change for LegacyNavigationManager or
CRWSessionController. The new behavior only affects
WKBasedNavigationManager.

Bug: 734150
Change-Id: Id39ef8151b268f44b2179977da5cc8ace10fafbe
Reviewed-on: https://chromium-review.googlesource.com/590150
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491144}

This CL removes the i18n-content on the <title> (afaik it was not being
set so I removed it rather than converting to $i18n{title}). Also removes
strings.js and i18n_template.js which should be unneeded at this point.

Bug: 677338
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iab29f07c23d200ed824f4207199853d982eefff2
Reviewed-on: https://chromium-review.googlesource.com/585769Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491143}