- 11 Sep, 2019 40 commits
-
-
Denis Kuznetsov authored
This is a cleanup that removes unused "android" attribute: 1) cr_button does not support this attribute anymore, so it does not have sense to have it in oobe_buttons. 2) There is no code that uses this attribute for oobe dialogs, so it can be safely removed. android attribute was introduced to make sure Assistant buttons were looking android-like about 2 years ago. TBR=alemate@chromium.org Bug: 1000606 Change-Id: I97f1988de91c8945f915110c705e9cc2b83697e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789706 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695575}
-
Fredrik Söderquist authored
Add this method, removing the two old IsFrozen() and PreviousIntervalBegin() to reduce API surface. Bug: 998526 Change-Id: I688dffc96cfe05462b81dbb3cbefad0d38ea00e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795826 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695574}
-
Reilly Grant authored
This change renames the following interfaces and removes the [NoInterfaceObject] annotation so that these types are now exposed to script: Coordinates -> GeolocationCoordinates Position -> GeolocationPosition PositionError -> GeolocationPositionError This is done in response to an effort to remove this annotation from WebIDL. Spec pull requests (merged): https://github.com/w3c/geolocation-api/pull/20 https://github.com/w3c/geolocation-api/pull/23 Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Xig9oewsQMA/eyC7dbtiAAAJ Bug: 931847 Change-Id: I38d0172afc33d5757b664e2807356d8727e82d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471230 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#695573}
-
Alexander Hendrich authored
(reland of https://crrev.com/c/1636350) This CL adds a new device policy to whitelist certain USB devices for certain urls in order to be used by the WebUSB API on the login screen. We already have a user policy for that, so this device policy reuses the existing user policy's infrastructure, but only affects the login screen (i.e. does not affect affiliated/non-affiliated user sessions). Bug: 1000270, 968373, 854329 Change-Id: I5abff8b7cca18650182af2dcfc63009cd9960f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789392 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#695572}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idf7dd4badb884c5a582da7b3cf3e425a44844f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695571}
-
Kamila Śledź authored
The API for sending the redirect URL is specified by the .proto file. The endpoint is still passed in a command line switch. Bug: 984021 Change-Id: I38fae8c86a942eae91ba3be3ad4eaa95701748d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787322 Commit-Queue: Kamila Śledź <kamilasledz@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
The behavior of percentage row tracks and gutters was updated long time ago (M70), but we never remove the deprecation message that was added before the change was shipped. That message is not useful anymore so we should remove it. The patch still keeps the use counter, as this behavior hasn't been updated on Firefox yet. So it's nice to keep the statistics of how many sites might be affected. Updated the test expectations to remove the deprecation message. BUG=846187 Change-Id: Ide2215b2c1527b87630a69dcc98cec27bc1963ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796368Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#695569}
-
Olya Kalitova authored
Adds call from CrostiniAnsibleManagementService to Cicerone in order to start Ansible playbook application. TEST=unit_tests --gtest_filter="Crostini*" Bug: 1000287 Change-Id: I2424856aff05d9a9d908fbaada43525b40943edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782562 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695568}
-
Peter Kasting authored
Bug: 1000055 Change-Id: Ib0243d3de02c933546521c46ac20b97cbec3f88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793255 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#695567}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLMeterElement> as new downcast helper 2. Use IsA<HTMLMeterElement>(element) in place of IsHTMLMeterElement(element) Bug: 891908 Change-Id: Ibd4d7866992b0ead69045e10af68d5faa4f36d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794365Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#695566}
-
Martin Robinson authored
Instead of calculating ATK hyperlink indices and constantly having to keep them up to date, always attempt to calculate them when queried via the API. This prevents them from ever being stale. Bug: 999631 Change-Id: I769c778baa513b52cc6a50d1b6d92b51594f4c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789590Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#695565}
-
Makoto Shimazu authored
This measures the performance for docs. Bug: 1002397 Change-Id: I15d38c9ed62057cea2471a1002bbcaa60a9de8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794723Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695564}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<HTMLOListElement> as new downcast helper 2. Use IsA<HTMLOListElement>(element) in place of IsHTMLOListElement(element) Bug: 891908 Change-Id: Iee700b7dbe624b28bf202e0c01e21dfb906ec693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794443Reviewed-by:
-
Julie Jeongeun Kim authored
It updates CreateNetworkContext() from ContentBrowserClient and all methods and members which implements it. The unit tests which use NetworkContextPtr are converted to mojo::Remote or mojo::PendingRemote. Bug: 955171, 978694 Change-Id: I0df0f9fec0b70f2704d924c7b52a24127f21c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784026 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#695562}
-
Jan Krcal authored
This is a reland of 5a3884b6. The original patch has been reverted because it caused flakiness in ChromeLauncherControllerWithArcTest.Arc* tests. Since the real underlying issue 966561 has been fixed in the mean-time, it should be safe to reland. Original change's description: > [Sync] Use forwarding delegate for PRINTERS sync > > Printers sync runs on the UI thread but so far uses a proxy delegate > that posts tasks from UI thread to UI thread. > > This CL simplifies that and employs a forwarding delegate that runs > tasks synchronously. After this CL, all data types running on the UI > thread will have forwarding delegates. > > Bug: 867801 > Change-Id: I08e261323a9caa816899dd924f09ecdee69ec936 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621907 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661732} TBR=mastiz@chromium.org Bug: 867801 Change-Id: I653d746337b860570447abdd74532b288161f203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796807Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#695561}
-
Himanshu Jaju authored
For Q and above, we don't open the dialer in any case. For N and below, we always open the dialer. If the device is locked then a notification is shown which is dismissed on unlock. For O and P, we open dialer if devices is unlocked. If the devices is locked then we don't open the dialer and keep the notification. Bug: 1002137 Change-Id: I81f4386439efe2b60b6b35a8bb8cdc7c59fb591c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795766 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695560}
-
Tanisha Mandre authored
- Fixed the QR code 'loadResultImmediately' boolean & result' receiver to use the superclass property value instead of duplicated instance variable. - Shifted the scanner transitioning delegate to the QR scanner view controller as it is not required in the superclass. Bug: 1000343 Change-Id: Id1d214e72df0cfd92111c56c04bcb22d37d731c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791156 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#695559}
-
Fredrik Söderquist authored
This state is fairly high maintenance and used only for frame scheduling and to check if updates need to be triggered for newly added timed elements. So get rid of it. (For now - it may reappear in the future but then more likely as part of the time container.) Also make a pass over arguments which passes the current presentation time, and rename it to that as well as using double rather than SMILTime. Bug: 998526 Change-Id: Icdb477ad86c349d0ddab5b9843b87dc186fd3b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795764 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df70582bd999..d10454e66ac1 Created with: gclient setdep -r src-internal@d10454e66ac1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I612c2b1c82cf493921b40e50626dfe152c44707c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797157Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695557}
-
Julie Jeongeun Kim authored
This CL converts ApplicationMediaCapabilitiesRequest and ApplicationMediaCapabilitiesPtr to new Mojo types. It uses ReceiverSet and PendingRemote or Remote instead of BindingSet and ApplicationMediaCapabilitiesPtr. Bug: 955171 Change-Id: I4b03e7bc1c4412e370d2fbd95d812a0ee53a08dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786705 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Sigurd Schneider authored
This CL displays the duration of a network task in the timeline view as a sum, for example: 15.10 ms = 12.66 ms network access duration + 2.44 ms resource processing The 12.66 ms match what is displayed for the resource in the network tab, but only if the resource has been loaded by the renderer. The numbers are still wrong for navigation requests issued from the main thread, but this is because the back-end reporting is wrong. (To be fixed in a follow-up). Bug: chromium:865066 Change-Id: Id5e2aa71349836352a4bf62f9a0bb17e8c8b59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764146 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#695555}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/050abd8dd5c4..c5f9c0682125 git log 050abd8dd5c4..c5f9c0682125 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 khokhlov@google.com [Telemetry] Always serialize traces Created with: gclient setdep -r src/third_party/catapult@c5f9c0682125 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:981349 Change-Id: Iea64d0dbc517e81b8cb4a96b99f6f9cb8979b4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797156Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55f663f5ddff..70767cba4254 git log 55f663f5ddff..70767cba4254 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d65ce76c..95ebb2b7 (695395:695497) Created with: gclient setdep -r src/third_party/webrtc@70767cba4254 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I99ffd71cd8c0dfa00deaa6df560f69da4397ae97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797087Reviewed-by:
-
Henrique Ferreiro authored
As part of the Mojo migration, there was a remaining reference to mojo::ChildProcessRequest from the content/common/child_process.mojom interface. Bug: 955171 Change-Id: Ic79fdcecca3f4cce29be5f027992999731f69ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796804Reviewed-by:
-
Fredrik Söderquist authored
This adds helpers to check if a time is before/after begin/end of the interval or is contained within an interval, as well as a method to check if the begin time has been resolved (== it's a usable/valid interval). Bug: 998526 Change-Id: I0d16fec31bd3b46f7bedda0f3815c785996f14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795445 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ApplicationMediaCapabilitiesObserverPtr to new Mojo types. It uses Receiver, RemoteSet, and PendingRemote or Remote instead of Binding, InterfacePtrSet and ApplicationMediaCapabilitiesObserverPtr. Bug: 955171 Change-Id: I95a366faed461a5108f1abea78a4ee8ebf973aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787673 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
We are planning to provide a temporary policy escape hatch for the OOR-CORS enterprise-friendly rollout. With this policy, Chrome handles any webRequest API users as specifying "extraHeaders" option so that such Extension can work without any fix for a while. Before adding such enterprise policy, we want to run a field trial if such approach does not introduce any other problems. This patch adds this escape hatch as a base::Feature trial. We will run a field trials in non-stable channels for a while, and convert this to an enterprise policy for m79. Bug: 1000982 Change-Id: I27b96d4fbc70fb52eb2c878058d0fd22078fd339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792506Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695549}
-
Robbie Gibson authored
A few colors weren't updated in the first pass. The biggest thing is the "Clear Browsing Data" button, which was normal red, instead of the new Chrome dynamic red. Bug: 1002407 Change-Id: I09ec5bd06271748826b5dbe6e458eeec0ed1b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794863Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#695548}
-
Jan Wilken Dörrie authored
This change makes std::wstring usage explicit in //base/win. Exposing std::wstring in the //base/win interfaces will make it easier to prepare other Windows only code for a future where base::string16 is no longer std::wstring. Bug: 911896 Change-Id: I7f214d0ea1d72d80f8b510eb9e22ae7ef1a2f988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789388 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#695547}
-
Elad Alon authored
Prior to this CL, clearing browsing history left behind traces of calls for which the log file is missing, but for which entries in the log index file exist. This CL fixes this problem. Bug: 826253, 992478 Change-Id: I4ceec22c99017e8e7826902195de5326f8123a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782904Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#695546}
-
vitaliii authored
Disable external/wpt/webdriver/tests/take_screenshot/screenshot.py>>test_format_and_dimensions because flaky. TBR=johnchen@chromium.org Bug: 855860 Change-Id: I5f8853cbc22d327d3cb48b99978de7ac2b8e0b77 No-try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796665Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#695545}
-
Yoshifumi Inoue authored
This patch renames |NGPhysicalTextFragment::Length()| to |TextLength()| to simplify source code for improving code health. This patch is follow-up the CL[1] which introduced |TextLength()|. [1] http://crrev.com/c/1794542 Make NGTextFragmentPainter faster as before Change-Id: I617c5c9871a315b1df72e09c8e78f1780048f4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798062 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#695544}
-
arthursonzogni authored
Content's embedders are not notified the visible URL has been invalidated. This CL adds a regression test showing this. Bug: 998284. Change-Id: Ib3a239d65f98209688b3b682cbe9a6184707c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780822 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#695543}
-
Hiroki Nakagawa authored
This CL removes the "externalfile" scheme support from URLLoaderFactories for service worker updated script loading. The scheme is used for loading files from ChromeOS-specific local file systems (e.g., "Downloads" and "removable"): https://cs.chromium.org/chromium/src/chrome/browser/chromeos/fileapi/file_system_backend.h?rcl=7bd9f2e138d37076a1ed3380126be8d00ae3837c&l=38 Service workers never support the scheme: https://cs.chromium.org/chromium/src/chrome/common/chrome_content_client.cc?rcl=013d0ec7da2f2c1b4c78af14fa1bdc83290dfb35&l=645 https://cs.chromium.org/chromium/src/content/browser/service_worker/embedded_worker_instance.cc?l=1092-1095&rcl=183f7e64155459d1c5f50155234a176e4fce7b3f See the following comment for the context: https://chromium-review.googlesource.com/c/chromium/src/+/1669251/7/chrome/browser/chrome_content_browser_client.cc#4893 Bug: 648295, 964229 Change-Id: I4d18bb972f38eba4498b109e595627a43cfdc6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798102 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#695542}
-
nancy authored
BUG=998004 Change-Id: I3bccc70e1a2d372585bf015ebc0b808b43b4be85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787618Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#695541}
-
Julie Jeongeun Kim authored
This CL converts MediaCapsObserverPtr to new Mojo types. It uses Receiver, ReceiverSet, RemoteSet, and PendingRemote or Remote instead of Binding, BindingSet, InterfacePtrSet and MediaCapsObserverPtr. Bug: 955171 Change-Id: I26460b5c0a13f858997c6141d6ca437cb84a674d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786704 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds an explicit base::WriteInto overload for std::wstring for Windows. For now this method is called WriteIntoW, as otherwise it would cause redefinition errors with the other overloads as long as base::string16 is std::wstring on Windows. Bug: 911896 Change-Id: Icaa681c6d0e1bcefcd4096e59194213dace14f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796432Reviewed-by:
-
Fredrik Söderquist authored
This splits said method into a CheckAndUpdateInterval() and an UpdateActiveState(). CheckForNewRestartInterval() is also folded into the former. Bug: 998526 Change-Id: Ie1b10e06cfc0aed64e8576c820c59978596c5083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795428 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Pâris MEULEMAN authored
This CL creates the java counterpart of the PrimaryAccountMutator, and modifies SigninManager java to use it instead of going through the C++ API. The aim is to have SigninManager.java interact with IdentityManager solely through its java interface, for which a few follow ups are required. Bug: 934688 Change-Id: Ic2b893d5831d53b2ea6df5184fd5f7894c665924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784721 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#695537}
-
Marc Treib authored
According to the linked bug, the reason for disabling the test has been long resolved. Bug: 84575 Change-Id: I21847fb8199ddedae72db3d58facc7f801db1453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796423 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
