- 18 Sep, 2014 40 commits
-
-
pneubeck authored
This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/ Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations. Now, the import itself is asychronous and calls back on completion. While there, this also removes the GMock of the importer. BUG=413219 Review URL: https://codereview.chromium.org/547553005 Cr-Commit-Position: refs/heads/master@{#295534}
-
John Abd-El-Malek authored
This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=zmo@chromium.org Review URL: https://codereview.chromium.org/578413002 Cr-Commit-Position: refs/heads/master@{#295533}
-
vitalybuka authored
Review URL: https://codereview.chromium.org/581163002 Cr-Commit-Position: refs/heads/master@{#295532}
-
earthdok authored
This fixes an issue with missing newlines in stacktraces. BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/584673002 Cr-Commit-Position: refs/heads/master@{#295531}
-
wnwen authored
While the keyboard is in the process of hiding, the proxy's visibility flag may not be updated yet. Use the private keyboard_visible_ flag instead as it stores the future visibility of the keyboard window after animation is completed. BUG=401670 TEST=Updated: KeyboardControllerTest.CheckOverscrollInsetDuringVisibilityChange On device: As the inset update must be initiated after the animation is started and before it is finished. Tested on clapper with the same method as in the bug, i.e. switch tab after hiding keyboard to trigger fast inset update. Review URL: https://codereview.chromium.org/578653004 Cr-Commit-Position: refs/heads/master@{#295530}
-
https://codereview.chromium.org/579903002/vollick authored
Reason for revert: Appears to be causing build failures. Here's an example. http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/12428/steps/steps/logs/stdio Original issue's description: > Roll ANGLE. > > Contains fixes for setting sampler uniforms. > > BUG=414450 > > Committed: https://crrev.com/ee4fc3e3db62b0a19e39f575b8faecd2dcc2f88b > Cr-Commit-Position: refs/heads/master@{#295519} TBR=vmiura@chromium.org,geofflang@chromium.org NOTREECHECKS=true NOTRY=true BUG=414450 Review URL: https://codereview.chromium.org/585593002 Cr-Commit-Position: refs/heads/master@{#295529}
-
reveman authored
Each RasterWorkerPool implementation is tied to some RasterBuffer implementation. By moving the RasterBuffer code into RasterWorkerPool implementation this relationship becomes more explicit and more easily adjusted for the need of the RasterWorkerPool implementation. BUG=406404 Review URL: https://codereview.chromium.org/562833004 Cr-Commit-Position: refs/heads/master@{#295528}
-
gunsch authored
R=asvitkine@chromium.org,isherman@chromium.org, BUG=404791 Review URL: https://codereview.chromium.org/577823002 Cr-Commit-Position: refs/heads/master@{#295527}
-
jamiewalch authored
This also fixes a bug in the tool-bar position when the window is scrolled. BUG=411996 Review URL: https://codereview.chromium.org/575303002 Cr-Commit-Position: refs/heads/master@{#295526}
-
miletus authored
The flaky test recovers by itself somehow. Remove the debug logging. BUG=393995 TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/574813002 Cr-Commit-Position: refs/heads/master@{#295525}
-
jianli authored
BUG=384041 TEST=new tests added Review URL: https://codereview.chromium.org/561943002 Cr-Commit-Position: refs/heads/master@{#295524}
-
rockot authored
of Chrome-specific "constants." These URLs can be overridden by extensions embedders now and are no longer incorrectly classified as "constants." BUG=398671 TBR=xiyuan@chromium.org,sky@chromium.org for various files with header updates Review URL: https://codereview.chromium.org/575113002 Cr-Commit-Position: refs/heads/master@{#295523}
-
erg authored
Revert of mojo: Add deserialization to python structs. (patchset #3 id:40001 of https://codereview.chromium.org/578263003/) Reason for revert: New unit tests fail. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13695 Original issue's description: > mojo: Add deserialization to python structs. > > BUG=415491 > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/ea8a6ef576c314506c4b3ee25544f6bcaa895fe1 > Cr-Commit-Position: refs/heads/master@{#295478} TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true BUG=415491 Review URL: https://codereview.chromium.org/579383002 Cr-Commit-Position: refs/heads/master@{#295522}
-
megjablon authored
For platforms other than iOS and Android, the preference data is stored in memory and written to disk at 60 minute intervals and on shutdown via the DataReductionProxyDelayedPrefService. For iOS and Android, the DataReductionProxyDelayedPrefService takes a delay time of zero and simply passes the prefs through to the PrefService. Review URL: https://codereview.chromium.org/473723002 Cr-Commit-Position: refs/heads/master@{#295521}
-
alekseys authored
BUG=414159 Review URL: https://codereview.chromium.org/585573002 Cr-Commit-Position: refs/heads/master@{#295520}
-
geofflang authored
Contains fixes for setting sampler uniforms. BUG=414450 Review URL: https://codereview.chromium.org/579903002 Cr-Commit-Position: refs/heads/master@{#295519}
-
isherman authored
BUG=none TEST=none R=blundell@chromium.org Review URL: https://codereview.chromium.org/581473003 Cr-Commit-Position: refs/heads/master@{#295518}
-
cylee authored
BUG=chromium:350245 Review URL: https://codereview.chromium.org/581583003 Cr-Commit-Position: refs/heads/master@{#295517}
-
bengr authored
Adds a link to the infobar and updates strings. BUG=383988 Review URL: https://codereview.chromium.org/581833002 Cr-Commit-Position: refs/heads/master@{#295516}
-
sataya.m authored
When the track rect or scaled track rect is empty, UiResources of Track and Thumb resources are released, instead of holding in the memory. These UIResources will be created on PaintedScrollbarLayer::Update when the Track rect is not empty. Similary When Scrollbar doesnt have Thumb release UIResources of Thumb. Bug=410845 Review URL: https://codereview.chromium.org/537943003 Cr-Commit-Position: refs/heads/master@{#295515}
-
jam authored
This might have been useful before while trying to get the system running. But now we have swarming running on Linux/Mac/Windows trybots, so it's not so useful. It's also confusing when tests fail on swarming machines because an isolate file referred to a binary that wasn't in the dependencies. BUG=414808 Review URL: https://codereview.chromium.org/575363002 Cr-Commit-Position: refs/heads/master@{#295514}
-
Adam Langley authored
I was hoping to make a change to the way that the header was generated before doing this but, as it turns out, I need to do this in order to make that change cleaner. Cr-Commit-Position: refs/heads/master@{#295513}
-
estade authored
BUG=412968 Review URL: https://codereview.chromium.org/582783003 Cr-Commit-Position: refs/heads/master@{#295512}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/a0537de..65b427c CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/580163002 Cr-Commit-Position: refs/heads/master@{#295511}
-
tdresser authored
linux-release-64/sizes/chrome/chrome : https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome&checked=all&rev=295451 BUG=415523 TBR=bokan@chromium.org Review URL: https://codereview.chromium.org/583603003 Cr-Commit-Position: refs/heads/master@{#295510}
-
oshima authored
BUG=None Review URL: https://codereview.chromium.org/579053002 Cr-Commit-Position: refs/heads/master@{#295509}
-
rsadam authored
BUG=414841 Review URL: https://codereview.chromium.org/579183003 Cr-Commit-Position: refs/heads/master@{#295508}
-
erikchen authored
Attemping to open multiple files using the native Cocoa dialog causes a crash. This CL inserts a safety check to work around it. A Yosemite AppKit bug causes an NSWindowWillCloseNotification to be sent during the -dealloc for a specific NSWindow. Any autoreleases sent to that window must be drained before the window finishes -dealloc. BUG=406944 Review URL: https://codereview.chromium.org/582103002 Cr-Commit-Position: refs/heads/master@{#295507}
-
jzern authored
dsp/lossless: workaround gcc-4.9 bug on arm force Sub3() to not be inlined, otherwise the code in Select() will be incorrect. https://android-review.googlesource.com/#/c/102511 Change-Id: I90ae58bf3e6cc92ca9897f69974733d562e29aaf BUG=414154 Review URL: https://codereview.chromium.org/577793004 Cr-Commit-Position: refs/heads/master@{#295506}
-
marcheu authored
GetSelectedModeForDisplayId doesn't work for internal displays. This results in failing the query, and falling back to refresh rate approximation in the scheduler. To fix this, we use GetActiveModeForDisplayId which exists even on internal displays. This fixes the swap interval that the cc scheduler sees. BUG=chromium:415359 TEST=make a trace on pixel, look at interval_us, it is a constant 16677 now (before it was variable and inaccurate) Review URL: https://codereview.chromium.org/582543002 Cr-Commit-Position: refs/heads/master@{#295505}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/87e28d4..21980cb TBR=dpranke@chromium.org,apavlov@chromium.org Review URL: https://codereview.chromium.org/579343002 Cr-Commit-Position: refs/heads/master@{#295504}
-
pneubeck authored
BUG=NONE Review URL: https://codereview.chromium.org/582723002 Cr-Commit-Position: refs/heads/master@{#295503}
-
oshima authored
This will be used in athena. BUG=414968 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/576863003 Cr-Commit-Position: refs/heads/master@{#295502}
-
jiayl authored
BUG=390853 Review URL: https://codereview.chromium.org/549303003 Cr-Commit-Position: refs/heads/master@{#295501}
-
mukai authored
BUG=413353 R=pkotwicz@chromium.org TEST=athena_unittests Review URL: https://codereview.chromium.org/566753003 Cr-Commit-Position: refs/heads/master@{#295500}
-
peter authored
Also removes two methods from Notification which only forward calls to the delegate, and have a single call-site. BUG= Review URL: https://codereview.chromium.org/574273003 Cr-Commit-Position: refs/heads/master@{#295499}
-
mlamouri authored
The orientation's value will be passed to the shortcut intent and will then be used when trying to find out the default orientation. BUG=366145 TBR=eseidel@chromium.org (for chrome/browser/DEPS change) Review URL: https://codereview.chromium.org/579883002 Cr-Commit-Position: refs/heads/master@{#295498}
-
viettrungluu authored
Witht this, I can begin removing knowledge of the Channel, etc. from the ProxyMessagePipeEndpoint. (Eventually, ProxyMessagePipeEndpoint will really just look like a stupid proxy, and relative sanity will prevail.) R=darin@chromium.org Review URL: https://codereview.chromium.org/577313002 Cr-Commit-Position: refs/heads/master@{#295497}
-
creis authored
This requires updating subframe RenderFrameHosts when we know that the RenderFrame is created, and using IsRenderViewLive for main frames. Several test updates as well. BUG=414894 TEST=FrameTreeBrowserTest.IsRenderFrameLive TEST=CrossProcessFrameTreeBrowserTest.CreateCrossProcessSubframeProxies Review URL: https://codereview.chromium.org/552683004 Cr-Commit-Position: refs/heads/master@{#295496}
-
dmichael authored
BUG=367896 Review URL: https://codereview.chromium.org/318763003 Cr-Commit-Position: refs/heads/master@{#295495}
-