- 13 Dec, 2017 40 commits
-
-
Rob Percival authored
SingleTreeTracker could previously reveal to a DNS resolver that a user was accessing a particular host, as a side-effect of performing a Certificate Transparency inclusion check over DNS. It will now first check that a DNS lookup for that host has already occurred (i.e. the DNS resolver already knows that the user has been accessing that host), otherwise it will avoid revealing that information by not performing an inclusion check. Bug: 506227, 682193 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifd5ef10773155b5b27aea32bee9c460320c1e264 Reviewed-on: https://chromium-review.googlesource.com/768790 Commit-Queue: Rob Percival <robpercival@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523717}
-
Guido Urdaneta authored
With this change, it is safe to enable the SYSTEM_MONITOR caching policy for MediaDevicesManager. Bug: 788687 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3b067a566e825c5a8219705bc75ee4b66c198787 Reviewed-on: https://chromium-review.googlesource.com/822935Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#523716}
-
rhalavati@google.com authored
Network Traffic Annotation is added to the socket write of the AdbClientSocket class. Bug: 656607 Change-Id: I1e05fc201290e0c55b78b8b03aee79284ffd7b4d Reviewed-on: https://chromium-review.googlesource.com/813757 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523715}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/fbee1329c2da..3ac7c0f0224e $ git log fbee1329c..3ac7c0f02 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 yuzus Fix logical errors in leak detection metric test & change the timing of error throw Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8aed07f40849a85037e057c724e6dbb4c97e5e5b Reviewed-on: https://chromium-review.googlesource.com/823527 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523714}
-
Hiroki Nakagawa authored
Before this CL, credentials tests for worklets are completely broken as follows: - In credentials.py, |credentials_mode| is compared by "is" that conducts the object equality check. As a result, all conditions unexpectedly pass through and the script always returns a valid response. - In credentials.py, |is_cross_origin| value is always |False| because requests don't have the GET param. - fetch() needs { credentials: 'include' } option for configuring the document's cookie with the Set-Cookie header, but it's not specified. - Response headers are not specified for a 404 response. This results in test timeout instead of a network error. This CL fixes these bugs and cleans up tests. Bug: 738769 Change-Id: I9aeb11fca23dec3fd3057a765fa60eb6e59d8258 Reviewed-on: https://chromium-review.googlesource.com/799730 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523713}
-
nikhil authored
Fixing names of password_manager PasswordImport feature as per the naming convention. Bug: 785953 Change-Id: I7c7bbdd5852f40e6735ffd51e9c519e59d3a6b0c Reviewed-on: https://chromium-review.googlesource.com/817458Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523712}
-
Stuart Langley authored
The overriden_deps field was removing the dependency on :mojo_platform_bindings, which is needed because message_port/message_port.mojom depends on blob/blob.mojom. I tested this fix using the following: $ gn clean out/Default $ ninja -C out/Default -j 1 obj/third_party/WebKit/common/mojo_bindings/message_port.mojom.o ... Build fails fatal error: 'third_party/WebKit/common/blob/blob.mojom.h' file not found With change: $ gn clean out/Default $ ninja -C out/Default -j 1 obj/third_party/WebKit/common/mojo_bindings/message_port.mojom.o Build works. Bug: 794419 Tbr: mek@chromium.org Change-Id: I8d2e98ae51da4228d1a8be396616d02814130f84 Reviewed-on: https://chromium-review.googlesource.com/823051Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#523711}
-
Matt Falkenhagen authored
This reverts commit a5b3a661. Reason for revert: This seems to be causing flaky build errors on chromeos-amd64-generic-rel: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/chromeos-amd64-generic-rel/ In file included from ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp:60: In file included from ../../third_party/WebKit/public/platform/Platform.h:56: In file included from ../../third_party/WebKit/public/platform/WebURLLoader.h:36: ../../third_party/WebKit/public/platform/WebURLRequest.h:41:10: fatal error: 'services/network/public/interfaces/request_context_frame_type.mojom-shared.h' file not found #include "services/network/public/interfaces/request_context_frame_type.mojom-shared.h" Probably need to add some DEPS to BUILD.gn. I will revert for now. Original change's description: > Merge all native enums RequestContextFrameType into single mojo enum > > This CL creates blink.mojom.RequestContextFrameType enum type and uses > it to replace existing native enums content::RequestContextFrameType and > blink::WebURLRequest::FrameType. > > This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo, > and finally to remove content::ExtendableMessageEventSource, which is an > incremental step toward Onion Soup: having less dependence on content types > for service worker. > > BUG=782528 > > Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd > Reviewed-on: https://chromium-review.googlesource.com/791916 > Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523699} TBR=falken@chromium.org,horo@chromium.org,dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org,tsepez@chromium.org,shimazu@chromium.org,xiaofeng.zhang@intel.com Change-Id: I25d74d983877227b5482a441f6cebb74374751b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782528 Reviewed-on: https://chromium-review.googlesource.com/823332Reviewed-by:
-
Renjie Liu authored
Original author: amoylan@chromium.org Original cl: https://chromium-review.googlesource.com/c/chromium/src/+/706439 This CL adds the GeoLanguageProvider browser singleton as described in the design doc: https://docs.google.com/document/d/18WqVHz5F9vaUiE32E8Ge6QHmku2QSJKvlqB9JjnIM-g This interface provides a list of language codes corresponding to local languages based on the device's approximate geolocation derived from its public IP address, using the PublicIpAddressGeolocator service. IP geolocation updates are requested no more often than every 24 hours. This singleton is started up after Profile init in PreMainMessageLoopRun. The startup runs on a background task runner, connecting & subscribing to the IP geolocation service. Startup is gated on the Feature setting "GeoLanguage" which is false for now. Bug: 76915 Change-Id: I9af2b1375fabda3d029ca396043b9195acab7cf0 Reviewed-on: https://chromium-review.googlesource.com/807884 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#523709}
-
Hajime Hoshi authored
This is the 4th trial to add the UKM Document.OutliveTimeAfterShutdown. This change caused a problem that logs became huge, but now the problem has been fixed by holte@'s fix (https://chromium-review.googlesource.com/c/chromium/src/+/795362). This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is recorded when a Document object survives 5, 10, 20 or 50 garbage collections after detached. If a document outlives such long time, the document might be leaked. The UKM would be very useful to know where such leaky documents exist and to fix them. Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing Bug: 757374 Change-Id: I20c390c8f3856ed8a9cd733ab6ac18d667b12d95 Reviewed-on: https://chromium-review.googlesource.com/818676Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523708}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I9d5948b3a480a183aafbe2579adba93427056c93 Reviewed-on: https://chromium-review.googlesource.com/823782Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523707}
-
Darren Shen authored
Currently CSSTranslate, CSSRotate and CSSScale do not accept calc values (CSSMathValues) because it requires type checking the calc value to see if they match the right type [1]. Since type checking and matching are now implemented, we have all the machinery to accept CSSMathValues too. This patch uses CSSNumericValueType.Matches* functions to check if the CSSNumericValues passed in resolve to the right type. We also (re)moved some redundant DCHECKs. We will have a follow up patch for CSSSkew and CSSPerspective. Note that percents are not allowed in CSSTranslation (spec needs edit): https://github.com/w3c/css-houdini-drafts/issues/530 [1] https://drafts.css-houdini.org/css-typed-om-1/#cssnumericvalue-match Specs: https://drafts.css-houdini.org/css-typed-om-1/#dom-csstranslation-csstranslation https://drafts.css-houdini.org/css-typed-om-1/#dom-cssrotation-cssrotation https://drafts.css-houdini.org/css-typed-om-1/#dom-cssrotation-cssrotation-x-y-z-angle https://drafts.css-houdini.org/css-typed-om-1/#dom-cssscale-cssscale Bug: 789370 Change-Id: I6f538a3f07b4c58eb15c9f059c39751e66f64f2f Reviewed-on: https://chromium-review.googlesource.com/812364 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#523706}
-
Doug Arnett authored
This is a refactor to consolidate the commit-time previews decision in one place (in ChromeResourceDispatcherHostDelegate) for both server-determined and client-determined previews with propagation of decision to renderer (via PreviewsState in mainframe response info) and UI thread (via PreviewsUserData). Bug: 782922, 725645 Change-Id: I8f7e5ef3a8a45b9ba2e1bbc07f09bfb9670e16b1 Reviewed-on: https://chromium-review.googlesource.com/807305Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#523705}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/106e17aa38c9..c0720db247f4 $ git log 106e17aa3..c0720db24 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 rmistry [Infra] Fix revision in upload_skiaserve 2017-12-13 angle-deps-roller Roll skia/third_party/externals/angle2/ 3acfc6255..9db70de8e (1 commit) 2017-12-12 mtklein disable f16<->f32 instructions on Google3 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit) 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ a98a28112..3acfc6255 (1 commit) 2017-12-12 rmistry [Infra] Missing configuration in out dir Created with: roll-dep src/third_party/skiaBUG=794086,794086 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I09ca5ff52d18a8bb0068e3286b2e887fd6508716 Reviewed-on: https://chromium-review.googlesource.com/822928Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523704}
-
Xianzhu Wang authored
This is a reland of 3b36628a Fix crashes on release-without-DCHECK builds by adding check for contex.tree_builder_context before dereferencing it. Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} Bug: 790560 Change-Id: I2bc134f829aa38398cf87ad8fa89ac229634d6d0 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR: chrishtr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/822139Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523703}
-
Frank Barchard authored
Using all_dependent_configs to pass libyuv_config around. Using public_configs, client projects must rely on public_deps to propagate configurations up in the build graph. This is bad because public_deps allows the exposition of headers that live in another target. This can lead to a really unhealthy build. On the other side, all_dependent_configs is automatically propagated up in the build graph but if a target includes a libyuv header it is forced by GN to declare the dependency (and this will propagate libyuv_config). Bug: webrtc:8605, webrtc:8603 Test: None Change-Id: I590c620b29102f2f7720da36872335f83ea7c453 Reviewed-on: https://chromium-review.googlesource.com/822334 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523702}
-
yoshiki iguchi authored
Previously, I have added SystemTrayView class which was owned by SystemTray class (crrev.com/727379). But the views in the tray are assumed to be destroyed with the parent view and the bubble, so that caused some issues. This patch changes that and makes SystemTrayView owned by the view hierarchy. Then the issues are solved. This patch also updates the newly-added code in NetworkStateListDetaiedView because the code didn't assume that lifetime of views. Bug: 790716, 789833 Change-Id: I62eca328780cabb7c5d68967cc1ddee7a1e23b9a Reviewed-on: https://chromium-review.googlesource.com/813153 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#523701}
-
Victor Miura authored
This CL enables RasterInterface for Compositor Worker contexts in content/renderer and content/browser. RasterInterface provides a subset of GLES2Interface APIs required for OOP Rasterization. This will gradually diverge away from GLES2. The initial change adds a client-side implementation of RasterInterface on top of GLES2Interface. Design Doc: https://goo.gl/Q6E1ZC BUG=757607 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaefd861f0c51b9995ad27eb94de2068d0f9dab22 Reviewed-on: https://chromium-review.googlesource.com/778242 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523700}
-
xzhan96 authored
This CL creates blink.mojom.RequestContextFrameType enum type and uses it to replace existing native enums content::RequestContextFrameType and blink::WebURLRequest::FrameType. This is the preparation to impl the blink.mojom.ServiceWorkerClientInfo, and finally to remove content::ExtendableMessageEventSource, which is an incremental step toward Onion Soup: having less dependence on content types for service worker. BUG=782528 Change-Id: I6f7787575f1583297a27a0213b1440d01e94e2dd Reviewed-on: https://chromium-review.googlesource.com/791916 Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#523699}
-
dpapad authored
Bug: 794003 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4dc96f9a899ccc9b0b208f2f326772208b47c187 Reviewed-on: https://chromium-review.googlesource.com/822974Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523698}
-
Scott Violet authored
Creating BluezDBusManager is unnecessary for --mus, as WindowManagerService (in ash) takes care of it. BUG=776514 TEST=test only change Change-Id: Ie3b7e39a507a9263779ce8f1045141e51d81192f Reviewed-on: https://chromium-review.googlesource.com/823526Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523697}
-
Tetsui Ohkubo authored
Notification center used fixed font sizes for UI labels. This is not the right way of settings font size. This CL - removes ash::message_center_style::GetFontListForSizeAndWeight(). - replaces all fixed font sizes with delta. TEST=manual - compared screenshots and verified it cause no visual change on actual device (chell) BUG=793207 Change-Id: Ia2c50965e6a132520d63921252e78a76a644734f Reviewed-on: https://chromium-review.googlesource.com/817456Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523696}
-
Victor Miura authored
This reverts commit 3b36628a. Reason for revert: Suspect this broke the build. Unexpected Failures: * compositing/geometry/repaint-foreground-layer.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-clipped.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled-late-noncomposite.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited-scrolled.html * compositing/gestures/gesture-tapHighlight-1-iframe-composited.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scroll-clip.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited-scrolled.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html * compositing/gestures/gesture-tapHighlight-1-overflow-div-scrolled-late-noncomposite.html * compositing/gestures/gesture-tapHighlight-2-iframe-composited-inner.html * compositing/gestures/gesture-tapHighlight-2-iframe-composited-outer.html * compositing/gestures/gesture-tapHighlight-2-iframe-scrolled-inner-late-composite.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner-scroll-outer.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-inner.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer-scroll-outer.html * compositing/gestures/gesture-tapHighlight-2-overflow-div-composited-outer.html * compositing/gestures/gesture-tapHighlight-img-and-text-2.html * compositing/gestures/gesture-tapHighlight-img-and-text.html * compositing/gestures/gesture-tapHighlight-pixel-rotated-link.html * compositing/gestures/gesture-tapHighlight-simple-cancel2.html * compositing/gestures/gesture-tapHighlight-simple-longPress.html * compositing/gestures/gesture-tapHighlight-simple-margin.html * compositing/gestures/gesture-tapHighlight-simple-multi-line.html * compositing/gestures/gesture-tapHighlight-simple-nested.html * compositing/gestures/gesture-tapHighlight-simple-scaledX.html * compositing/gestures/gesture-tapHighlight-simple-scaledY.html * compositing/gestures/gesture-tapHighlight-simple-window-scroll.html * compositing/gestures/gesture-tapHighlight-simple.html Original change's description: > [PE] Don't ignore clip change not across transform boundary > > If the clip change is caused by the object having transform, we should > not ignore the clip change because it actually affects descendants. > > Bug: 790560 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 > Reviewed-on: https://chromium-review.googlesource.com/822919 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523653} TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org Change-Id: Id760d5784db00715f5f16cd0eeed0cb4e2812688 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/822138Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#523695}
-
junweifu authored
Create Windows bitmap from detected SkBitmap that is Rgba8/Bgra8 color type, then convert the pixel format SoftwareBitmap to Gray8/Nv12 that is supported in current version. Detect faces asynchronously with the created Windows bitmap, and pause incoming method call to prevent the Detect function from being called before the AsyncOperation completes. Add unittest to test the result of detecting faces. Split original large CL[1] up in smaller subpatches including this CL. Link Face Detection demo[2] here. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG=767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: If2f93ede374bdebc6921cee4b0c9a09df879b693 Reviewed-on: https://chromium-review.googlesource.com/787790Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#523694}
-
Devlin Cronin authored
Update the include rules for //extensions. There are many test-only exceptions (including quite a few that violate layering). These rules are currently applied for all tests in //extensions, but most only need to be applied to //extensions/browser. Trim the //extensions/DEPS include list to only have includes that are included from multiple subdirectories, and move the rest into //extensions/browser/DEPS and //extensions/renderer/DEPS. Also remove a few includes that were no longer necessary, or didn't exist. Bug: 773004 Change-Id: Ib6e705faae4472369858102e8a9ebe555e2a8d66 Reviewed-on: https://chromium-review.googlesource.com/820937 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523693}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. See the discussion about this that has happened in https://groups.google.com/a/chromium.org/d/topic/chromium-dev/pcgYLSJsii8/discussion TBR=sky@chromium.org Bug: 289619 Change-Id: Ic03e825bf2a65ec1edff0bd2c9e36b2a8c24c39b Reviewed-on: https://chromium-review.googlesource.com/821831 Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#523692}
-
Patti authored
ShouldShowPermission() in page_info.cc always returns true for geolocation on Android because Android does additional filtering to check if geolocation should be shown due to DSE settings. The test PageInfoTest.NonFactoryDefaultAndRecentlyChangedPermissionsShown touches upon this in testing, but was coincidentally passing on Android because it later expects geolocation to be shown regardless by changing it to a non-default setting. Fix by changing the vector of the expected permissions to a std: :set instead. Change-Id: I9841563ddb6add41ea6f4d2edea4569d16b879a9 Reviewed-on: https://chromium-review.googlesource.com/813439Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#523691}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/199942f3e6d4..3fe1b15413a6 $ git log 199942f3e..3fe1b1541 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I19fea3155f2ad4323614ad88e27b87af0b607f07 Reviewed-on: https://chromium-review.googlesource.com/823682Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523690}
-
chaopeng authored
Currently the receiving of WM_MOUSEWHEEL messages lags when we open a URL on a new window until we resize. The issue was introduced by r384698. That CL change wait for MOUSE_EVENT to wait for SENDMESSAGE in MessagePumpForUI::WaitForWork to optimize the GPU thread. But the GPU thread does not use MessagePumpForUI anymore so it should be OK to just remove that code. The updated version of Chrome was tested to make sure that the hangs that were occasionally seen when using chrome://tracing are still gone. After this CL chaopeng@ need to monitor to make sure that the crash rate not increase. Bug: 713907, 596190 Change-Id: I7545a867de4851acd4e57c9b8c7a3dd05def1dd8 Reviewed-on: https://chromium-review.googlesource.com/809829 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523689}
-
Xiaohan Wang authored
These tests were flaky and disabled. But we have not been able to repro the issue locally, nor understand the root cause of the issue. Part of the problem is that the top part of the test log is truncated, which has been fixed in a previous CL. Now we need to reproduce the test failure to be able to examine the logs for investigation. This CL reenables those flaky tests by reverting two CLs that disabled those tests: This reverts commit 9f4bee97. Revert "Disable ECKEncryptedMediaTest.Renewal on linux asan" This reverts commit b023b4e8. Revert "Disable EncryptedMediaTest.Playback_VideoClearAudio_WebM on Linux asan" TBR=jrummell@chromium.org,cfroussios@chromium.org BUG=793426 Change-Id: I7441ccf1d89ea81d396ba0ab84a77eb41c9bf700 Reviewed-on: https://chromium-review.googlesource.com/823572Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523688}
-
Chris Watkins authored
This CL only touches base headers (the headers were accidentally excluded from the previous change to cc files). This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md BUG=778959,778957 Change-Id: I4d3b4ca1218b835a671c2e0c8f31c2b528e25a0c Reviewed-on: https://chromium-review.googlesource.com/813316Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fe678147. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7534 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2f32e481b487712f35e114f73a349bfa8abe03c7 Reviewed-on: https://chromium-review.googlesource.com/822304 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523686}
-
kylechar authored
Always turn on surface synchronization when the --enable-viz flag is present. Disable a few extra tests which now fail in the new configuration. The --enable-surface-synchronization flag was added to an FYI trybot to check for failures. No failures were observed over the weekend. Remove the now unneeded flag from the FYI trybot. Bug: 793302 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6bc0aff21d968ba5ee38f7453fbd7b5779efb34a Reviewed-on: https://chromium-review.googlesource.com/812409 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523685}
-
Katie Dektar authored
These simplify recording a boolean value and are more readable. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I77165d0f6aaa760c7126d7c29083f139600fcf5d Reviewed-on: https://chromium-review.googlesource.com/820631 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#523684}
-
Ted Meyer authored
Basically we always scale up, rather than scale width, which is what the spec was changed to require about a year ago. BUG=606039 Change-Id: Iebfed41771a5b11bad6daf3655de750cce4c6cf8 Reviewed-on: https://chromium-review.googlesource.com/813201Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#523683}
-
Nicholas Verne authored
the renderer. As a result of this, several intermediate classes that passed MojoPipeHandle over IPC now pass the URLLoaderFactoryPtr over mojo. Also, AppCacheDispatcherHost no longer needs to be an IPC::Sender. Further simplifications of the AppCache class hierarchy should now be possible, but are out of scope for this CL. Bug: 611938 Change-Id: I5c05f66fbbab0dc4a2afa1aa6979b2ba0ff4f1f4 Reviewed-on: https://chromium-review.googlesource.com/810345Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#523682}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: Ia6333c6b1e8851ea565b82fc7a826865c2cbfc44 Reviewed-on: https://chromium-review.googlesource.com/822873Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523681}
-
Dmitry Gozman authored
Fragment is a piece of DOM generated from a template string, to be used instead of manual dom construction. - Allows functions ("binds") to be executed during instantiation: <div ${(fragment, node) => node._owner = fragment} />. - Exposes selected elements via $: <div $=myName />. - Toggling states which affect arbitrary attributes: <div s-selected-attr=value /> changes the value of "attr" to "value". - Inserting elements into markup: <div>Some ${myDiv} text</div>. - Inserting text into markup: <div>Some ${myText} text</div>. - Composed attribute names: <div ${foo ? 'foo' : 'bar'}-name=value />. - Transforms <x-shadow> to shadow root: <div><x-shadow>dark dom here</x-shadow></div>. - Caching preprocessed template if needed. Bug: none Change-Id: Ib1eb7c10b0f3f4aaebf98c022697111f38d55f9f Reviewed-on: https://chromium-review.googlesource.com/809952Reviewed-by:Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523680}
-
Noel Gordon authored
Speculative fix: back off from using -O3 on Android for the inflate chunk copy code to see if -O3 caused the perf bot regression on the Android One bot, http://bit.ly/2AfaxhG Bug: 772870 Change-Id: I06bd941224dacbc5d7024a65934faaa53e4a4ce5 Reviewed-on: https://chromium-review.googlesource.com/823503 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523679}
-
dpapad authored
Bug: 790755 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I853f3765273c34fbd057708c745b5bc807d8dc3b Reviewed-on: https://chromium-review.googlesource.com/822736Reviewed-by:
-
