- 21 Oct, 2020 40 commits
-
-
Roman Arora authored
Bug: 1128599 Change-Id: I2d11e4b33ca9500ffeba2a8721c788b25e50f1ec Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3308643Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819628}
-
Roman Arora authored
Screenshots Hover: https://drive.google.com/file/d/1xxvmhVfUMVn6gKTC5N2nNL9HrvyaPzKK/view Focus: https://drive.google.com/file/d/1AQoUfTUeKRyPhmlmb5CdnQLrvBFyQuZc/view Bug: 1128599 Change-Id: Ia856b9e25b006fd5710ce2af8ca08ae7e2596740 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3303965Reviewed-by:
-
Tom Lukaszewicz authored
Fixes break in existing tests. Bug: 1099917 Change-Id: I4b110eb133128b68994f35b4d16a9e38e49da7d3 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3304907Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819626}
-
Yuheng Huang authored
A simple scoring function gives us better search results based on match index and match count. It also enables us to control title vs hostname matching weight similar to fuzzy search. Bug: 1099917 Change-Id: Ifdc9a71f856854b77851a7b133cfb34439441d16 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3301747Reviewed-by:
Tom Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819625}
-
Roman Arora authored
Depends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2441333 Bug: 1133575 Change-Id: Id13dfa24226ec87a0940328df4777ed18928877b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3303663Reviewed-by:
-
Tom Lukaszewicz authored
Matching src-public CL: https://chromium-review.googlesource.com/c/chromium/src/+/2432589 Bug: 1099917 Change-Id: I19496be097ef9714e0e46872ff6966e54e442086 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291206Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I8430ce511cc625ec06bf87402e643a4a540386af Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284870Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates search such that if an exact match search is expected an exact match algorithm is used. We will rank items for exact match as follows: 1. Rank all items that match at the beginning of the title or hostname first. 2. Rank all items that match at the beginning of a word next. 3. All remaining items with an exact match are ranked at the end. Change-Id: Icd6cd647ce3b0d39eb535998dab5e49973c24b0b Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3299647Reviewed-by: -
Yuheng Huang authored
This change makes URL title fully visible when mouse over it Bug: 1099917 Change-Id: I306711584fc1ed139a9b925378f27e477ce6430c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3300861Reviewed-by:
-
Roman Arora authored
This is a reland of 218a19d8afddea116cf66cd2764fa5fb1988716a Updated TabSearchAppFocusTest that expects submit feedback footer. Please review agains the Patchset 1 for new changes. Original change's description: > TabSearch: Enable/Disable feedback button based on a config > > Bug: 1099917 > Change-Id: Ia79387286a56d411dead0018c6a22a36fbc4daac > Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288761 > Reviewed-by: Tom Lukaszewicz <tluk@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> Bug: 1099917 Change-Id: Ibe13fd00d7e00c669b7e675cda1daa6d2470605c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291234Reviewed-by:
-
Yuheng Huang authored
chunkingItemCount_ = 0 should be called when chunking is started, instead of waiting for the second getProfileTabs calls() because getProfileTabs() can be called only once. Bug: 1099917 Change-Id: Id3d0ee0c29220ccee66b8c3ffaff40db42d03f80 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3295842Reviewed-by:
-
Roman Arora authored
This reverts commit 218a19d8afddea116cf66cd2764fa5fb1988716a. Reason for revert: Has test failures Change-Id: I8c2faf5cc691c9bd041f02aeac5cbeb71f4e2e66 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3291232Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#819617}
-
Roman Arora authored
Bug: 1099917 Change-Id: Ia79387286a56d411dead0018c6a22a36fbc4daac Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288761Reviewed-by:
-
Tom Lukaszewicz authored
Dom-repeat chunking used for the first render of the Tab Search UI to eliminate the need to render the full list before showing the UI to the user. This bounds the time to interactive for users with an arbitrary number of open tabs. This CL disables chunking after first load due to flickering when the tab list updates later on. Bug: 1099917 Change-Id: I2924756230ef50aea8d0623c0f2a2637623b9b22 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3288859Reviewed-by:
-
Tom Lukaszewicz authored
This CL updates fuzzy search to take option values from tab search feature parameters passed in via the WebUIDataSource. Related CL: https://crrev.com/c/2425724 Bug: 1099917 Change-Id: I04a5b52a88dc2397870f3ce615e1cd874785ac18 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3285252Reviewed-by:
-
Tom Lukaszewicz authored
This CL adds a wrapping container around the tab search list items. The height of the container is updated as the number of items to be rendered is updated. This allows the tabContents container to assert the final list height even as the items are rendered piecemeal in dom-repeat's chunking mode. This is dependent on the following: https://crrev.com/c/2417548 Bug: 1099917 Change-Id: Ib6e28cbac01f23e7f8dda918f19ff168be5989b6 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3281029Reviewed-by:
-
Roman Arora authored
Depends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2414513 Bug: 1128653 Change-Id: I7c5c978a08279dba77db0d28914af345d06d9d99 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3281181Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2424510 Bug: 1099917 Change-Id: I9a3272fb1040a002498be4dd876a579804234695 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284531Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I657e15ea2a76f8286c94a7c1471579267e5bb2a2 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284828Reviewed-by:
-
Roman Arora authored
UX audit related changes: - Search field, list item, and feedback footer height changes - Search field background color and styling changes - Component alignment related changes Dependends on CL: https://chromium-review.googlesource.com/c/chromium/src/+/2417548 Screenshot: https://drive.google.com/file/d/1ahWvFnnpFgJOJXgWqDihMZFcoE0KLzf3/view?usp=sharing Bug: 1128599 Change-Id: I231688d955cbda00c4109dd48ddb5eed77f94165 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3276513Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Ia2fcf03cae03c05ed9229812f1740488a2441ec9 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3269809Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I450254884611778547c85a6e8cf6fafa7a2b6030 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3284425Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I9038a2ac5911ad01cfa3b0683c4e062146b05dd3 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272139Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I14d98855e3389320ce10a94f161cb94d283c318f Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3280945Reviewed-by:
-
Yuheng Huang authored
Fuzzy search should not take match location into account Bug: 1099917 Change-Id: Ie7ca087b1b0d0375cfdeb008257a7184ac64b904 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3278048Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819604}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I26318b0c4fc054f9627a5208f4dfcbb5e5608486 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3273923Reviewed-by:
-
Roman Arora authored
When the search field gains focus, if there are any tab items present one should be in a selected state Fixed: 1128616 Change-Id: I5290e7609a03ad2239660dd940bcb79cc30c6663 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272424Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: I138f487c76e70efa81e4509ee7c0f95496a69b40 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272425Reviewed-by:
-
Tom Lukaszewicz authored
This CL uses Polymer's dom-repeat chunking mode for the Tab Search list items. This allows an initial small list of tabs to be rendered, allowing the bubble appear at the correct size without waiting for the entire list to render. Bug: 1099917 Change-Id: Ib30d69923383e37e8241f62ed546ddb9ad73bbfd Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3270637Reviewed-by:
-
Roman Arora authored
Bug: 1099917 Change-Id: Icc72b9bde3157f2d603173340e5c000e0b33474c Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3272131Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I8668b0dadf87721aec2c0d1ef42ffa94f769ab28 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3271919Reviewed-by:
-
Takashi Toyoshima authored
Change-Id: I380bc7ce1b8bf17d8fe95dbb6bb92e9222efd11d Bug: 1126827, 1099917, 1053866 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3263707Reviewed-by:
-
Yuheng Huang authored
tab.faviconUrl is a base64 stream of image for each tab. It's slow to generate, heavy to transfer and not reusable. getFaviconForPageURL uses chrome://favicon2 to get fav url from history, which is much more efficient but can not work in incognito mode. Since tab search is not supported in incognito mode, using getFaviconForPageURL is a performance win. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2406932 Bug: 1099917 Change-Id: If8b711b2b566fef2b1334c17ac768008f50ca867 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3265887Reviewed-by:
-
Roman Arora authored
Enable focus navigation for tab items and their buttons. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2388711 Bug: 1113470 Change-Id: I32b1ed98f0f832ff4c7dba5747e3437a860ab0d0 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3209477Reviewed-by:
-
Yuheng Huang authored
Search for item.title and item.hostname using weighted search from fuse.js. Scores are calculated from matching item.title and item.hostname. Items are sorted by scores by desc so better matching items will show up first. Also extract item.hostname from item.url. Bug: 1099917 Change-Id: Ieaee008b778dda90ef08ed504da034080b71cc58 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3222931Reviewed-by:
-
Yuheng Huang authored
This CL needs to be checked in before the related CL to prevent a revert due to src-internal build test breakage. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2382655 Bug: 1099917 Change-Id: Id79e1fa21be1bf0bdea52aa902f6685d8c985a4a Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3261333Reviewed-by:
-
Yuheng Huang authored
This CL makes sure the related CL does not break the js code when it lands. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2382655 Bug: 1099917 Change-Id: I766285c8114d279e6d466fa4d39c0dc3d47d8755 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3261323Reviewed-by:
-
Yuheng Huang authored
Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2399499 Bug: 1099917 Change-Id: I7b4856080e0b4b3939c6eb55f3c456af2a83dfc6 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3259362Reviewed-by:
-
Roman Arora authored
Add a footer to the Tab Search web contents to request user feedback. Feedback svg icon source: https://github.com/PolymerElements/iron-icons/blob/master/iron-icons.js Updated UI screenshot: https://drive.google.com/file/d/1cjPo0ec9UmKfhYwiy33E1F1NMgAElkEp/view?usp=sharing Original screenshots: Light mode: https://drive.google.com/file/d/17cFUycqQp-YnslTRVQigKEu2_eJ5wITK/view?usp=sharing Dark mode: https://drive.google.com/file/d/1HGxd1h2Dj10iR40rNRE-3M8T6XdZHTx1/view?usp=sharing Bug: 1099917 Change-Id: If562dbe74114e93bd0da1c42e04477e69a477370 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3228548Reviewed-by:
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Iadbf0be900c229a47dcf83bff9298c0580d83e93 Reviewed-on: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3251545Reviewed-by:
-
