- 24 Jun, 2020 40 commits
-
-
Joe DeBlasio authored
This CL does three things to the target embedding heuristic. It: 1. detects embeddings with multi-label eTLDs (eg. google.co.uk), 2. allows finer-grain matching against engaged sites, so that if a user has engaged with foo.bar.com, and that entire domain is embedded, it can recommend the full domain (not just the eTLD+1 bar.com), and 3. removes support for cross-TLD matching. This is a significant re-write, and the cross-TLD ("enhanced protection") matching was removed because it kept the implementation simpler, and we've decided that we couldn't ship that capability without further tweaks anyway. I may re-add it in a future CL. Bug: 1092570, 1098473, 1087636, 1075659 Change-Id: Ia30bd2025ca938c8431ab22300c6e2e8de2a658c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261424Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#782132}
-
Dan Harrington authored
On first run, when the user signs in, we were making a signed-out FeedQuery request. This happened because the IdentityManager hadn't yet gotten any signals about the sign-in process before the feed surface was opened. This change waits to attach the feed surface (to native) until after ChromeTabbedActivity reaches the right initialization step. Bug: 1044139 Change-Id: Ia55096e8720bb2289ccddef14533caff4cb0c25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261217Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#782131}
-
Mei Liang authored
http://crrev.com/c/2149626 converts the LayoutTab to a PropertyModel and uses the constant start and end animation value when creating the CompositorAnimator for the shrink tab animation. The use of the constant values causes the shrinking tab animates to a wrong position, since the targeted Rect can be changed after the CompositorAnimator is created. This CL fixes the issue by using the Supplier to supply the start and end value. Change-Id: Ife607faa06aadd508816179ad856eadacc3e1e90 Bug: 1096718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254715Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782130}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I52d90c494d13f4e9bb9aeb0ee516a96077d7c63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782129}
-
Li Lin authored
We decided to defer the translation use case to future milestone. Added a feature flag to gate translation intent. Bug: b/159472031 Test: unit tests Change-Id: I5772750202c2a3862f6efc437db7c82ef58a7652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261877Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782128}
-
Findit authored
This reverts commit f384aa73. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 782049 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2YzODRhYTczYWJmMmE5NDg2YjFkNTU2NjA0MzhmNGRkZTdiZGZmMjgM Sample Failed Build: https://ci.chromium.org/b/8876578106556883360 Sample Failed Step: compile Original change's description: > Secure DNS UI for Android > > This replicates the desktop UI, with platform-appropriate adjustments. > > Bug: 1040146 > Change-Id: I33cea7dd37086d87580e149404ed3619a828ee45 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240456 > Reviewed-by: Peter Conn <peconn@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Commit-Queue: Ben Schwartz <bemasc@chromium.org> > Auto-Submit: Ben Schwartz <bemasc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782049} Change-Id: I1abb9d420a08bab8476728e1f0ab3a36d298dfbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265358 Cr-Commit-Position: refs/heads/master@{#782127}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: Ia396cc134a5f3edb09fb148066e60bfcee077855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265235 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782126}
-
Khushal authored
The swap acks from the platform for SurfaceControl arrive on the binder thread and are posted directly to the GpuMain thread's message loop. Since the gpu::Scheduler doesn't have visibility into these acks, they don't take advantage of the scheduling policy that would allow prioritizing running these acks over other lower priority raster work. Hook up the async task posting mechanism in GLSurface to the gpu::Scheduler to fix the above. R=sunnyps@chromium.org,vasilyt@chromium.org Bug: 1009282 Change-Id: I5b23e08679cadb249164183c35709aaf6929fd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263233Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#782125}
-
Zhenyao Mo authored
If an entry specify a device without revision number, then any revision numbers should be considered a match. Currently we always compare the numbers. When unspecified, revision defaults to 0, so all devices end up as no match. BUG=1093625 TEST=gpu_unittests R=liberato@chromium.org Change-Id: I146b0e725ebf3bf8aa22998011d98e77c773160f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265237Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782124}
-
David Munro authored
We currently wait for polymer updates by flushing then by continuing after Polymer.async. This doesn't actually wait for everything, since it's a Polymer microtask, so it preempts macrotasks and will run before nested microtasks (e.g. a Polymer update triggers an attached event which kicks off its own promise, we'd run between the attached event and the promise). Instead use test_util.flushTasks which has macrotask timing. Test: browser tests Bug: chromium:1082027 Change-Id: I5d35b0c61570913d7a36e89600dce597703c2aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263634Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#782123}
-
David Dorwin authored
This log statement can occur when adding/removing supported arguments, so reduce it to a WARNING and provide context. Bug: 1032439 Change-Id: I500c5ff5d64268b1557da18724ad9c061c216936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261066Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782122}
-
Renjie Tang authored
Also remove 0-RTT for tests that don't actually need it. Change-Id: Ia33016ee631f288b7d3aa3c619b6f31b148e7f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261268 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#782121}
-
Mike Dougherty authored
This class is no longer used nor referenced from any BUILD files and can be removed. Fixed: 925207 Change-Id: I8da4b3c8889bd7b595790c2ecd445c2eeb1d5bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264602 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#782120}
-
Jarryd authored
Change-Id: Idf1b887e4936fad34eef27dd7de74946e4225aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264600 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782119}
-
Josh Nohle authored
The private and public certificates store encrypted user and device metadata. Private certificates are for the local device and are only stored locally. Public certificates are uploaded to the Nearby Share server and distributed to user's whitelisted contacts. Certificates are used to authenticate a channel between the local device and a remote device before the actual payload is exchanged. These classes handle all of the crypto operations surrounding certificates: * Private cert: signing a token * Private cert: encrypting the metadata key before advertising it * Private cert: encrypting the device metadata * Private cert: converting to a public certificate * Private cert: managing the set of consumed salts * Public cert: verifying a signed token * Public cert: decrypting an advertised metadata key * Public cert: decrypting its metadata See http://go/nearby-chrome-cert for more details. The test vectors from that document are used in the unit tests here, as well as in the GmsCore implementation, to ensure cross-platform consistency. Fixed: b/154862766 Change-Id: Ifd24decf4e896667797add3c292c69ebd312f232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157285 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#782118}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky,nickdiego Change-Id: I31c3972ad51ccad320abd3554eec9cd8396aff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262113 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782117}
-
Nico Weber authored
Doesn't build at all, but hey, it's a start. Bug: 1098899 Change-Id: I63500b3650b315c47219614cc9ae9a3ddbcf42c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264499 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#782116}
-
Vladimir Levin authored
This patch ensures that when we have a find-in-page target, we keep it unlocked for two frames, so that the visibility detection can take place and if needed keep the context unlocked. The root problem here is that sometimes our contain-intrinsic-size is too small, so that when we find a match and scroll it into view, we actually scroll past the locked size by enough distance that the container remains locked, so we never see the match. With this patch, the container is unlocked for two frames which is the least amount needed for visibility to kick in and start being unlocked. This patch also cleans up the previous focus-clearing bug to use the same mechanism of unlocking-until-lifecycle. R=chrishtr@chromium.org Change-Id: I75a2d8b2f41335d5d6fb7a4ec0f42d93438807e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264756Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782115}
-
rbpotter authored
Fix a race condition where if the download button is clicked while a form field is still focused, the plugin may not have yet notified the UI that the document has edits. This results in the "Edited"/"Original" menu not appearing, and the original document being directly downloaded instead. Check before saving the original document if a form field is focused, and if so, wait for the form field focus to change, which gives the plugin time to send the edit status update. Bug: 1098082 Change-Id: Ib11aa2ca9c06d06b9d05041272b070a674b316f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261188Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#782114}
-
Andrew Grieve authored
Android does not use it, so we shouldn't build it. When looking at a ninja trace on the android-binary-size trybot, this target showed up on the critical path and taking ~2 minutes to build. TBR=agrieve # Mechanical BUILD target renames. Bug: 1078460. Change-Id: I645277778762cd5e30cd81ce84a5776d38c3fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258469 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782113}
-
Christian Biesinger authored
The in-flow version of abspos-007 Bug: 1045668 Change-Id: I9c33eea25b5378e39e8a9b4f57016cf17828588c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261169Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#782112}
-
Patrick Noland authored
TBR: szager@chromium.org Bug: 1096612 Change-Id: I598cbcf55ff97a453b714759e458915030355a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264768Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782111}
-
Lei Zhang authored
For extensions, instead of having a per-extension last-saved location, use the browser downloads location. Adjust some file_manager tests to pass with this change. In production, file_manager is not affected by this because it is an app and not an extension. However, some of its tests use a test extension, so the tests are affected. Bug: 1011587 Change-Id: I62d08a9b1855ee8e5454098d37ca5a8a685f9d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245686Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782110}
-
Tommy C. Li authored
UX folks suggested 8dp instead for aesthetic reasons. Bug: 1078415 Change-Id: I56ab151c4147b10b8853ebf1b9ae22cf1f4af90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265180 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782109}
-
Albert J. Wong authored
This allows APIs, such as DOM gettings, to take a StringView instead of an AtomicString. On platforms where externalization isn't supported for short strings, this will yield a speed benefit as there will be no AtomicString created. This can especially affect (questionably useful) microbenchmarks like blink_perf.binding get-attribute.html which can hammer the non-externalized path on some platforms. Usages of this API will come in a follow-up CL. This is partially broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: I44d36dadcb341042e7eaf84395be7cc4a069b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261270 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#782108}
-
Robert Ogden authored
Leaves the command line flag for use in browsertesting and in the about:flag. Note: The browser tests can't set features with params because of this: http://shortn/_ZytN1SHiqN Bug: 1082505 Change-Id: I474fe012c6a00b15f38d70334d677a29815b24b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782107}
-
Clark DuVall authored
WebLayer now has support for opening in a new tab since http://crrev.com/c/2228365. We can now fix the TODO about captive portals opening in a new tab. Bug: 1047130 Change-Id: I1d2bf894caef6d0cc8f536db6d687fce0397ce0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264879Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#782106}
-
David Van Cleve authored
This is a reland of 7d4baea7 Fixed the underlying issue necessitating the revert: crbug.com/1098019. Ran some of the failing tests locally with setup mimicking the failing FYI bot's environment and they seem to pass. Unfortunately, I wasn't able to run the entire failing test suite on a bot with the exact same setup as the failing FYI bot that prompted the revert. Original change's description: > variations: Add a field trial testing config entry for Trust Tokens > > We're rolling Trust Tokens (https://bit.ly/trust-token-dd) out so we can > start its origin trial. (The feature is gated behind both an origin > trial and a base::Feature; see [1] for a longer description of the > rollout strategy.) > > This CL updates the field trial testing config to enable the > `TrustTokens` feature with the configuration we're using during the > rollout. > > [1] > https://groups.google.com/a/chromium.org/g/blink-api-owners-discuss/c/WY17UlZFG3g > > R=chromium-metrics-reviews@google.com > > Bug: 1036483 > Change-Id: If9cb0611d0f2f236f99918326ce5ee33c991df25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255649 > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Auto-Submit: David Van Cleve <davidvc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780881} Bug: 1036483 Change-Id: I549c6eaff38e019f5d9ca878e2160c0e87b6aee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261403Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782105}
-
Sam Sebree authored
This CL add correct styling for the dark mode focus ring on mac Bug: 1096269 Change-Id: Ib0fe9c18470a2333f48eeee921c9a8c02ac92162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256153Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782104}
-
Matt Falkenhagen authored
Some additional changes this CL makes: - Now the existing unit_tests that exercise prefetching go through throttles. These would crash in ProtocolHandlerThrottle, because a ProtocolHandlerRegistryFactory isn't created in unit tests. A nullptr check is added to not crash. - Revises the comment for ContentBrowserClient::CreateURLLoaderThrottles to be more general, since now any embedder can call it for any browser-initiated request. The comment was already missing the case of requests from PrefetchURLLoaderService before this CL. - Splits out network::EmptyURLLoaderClient from the static helper function DrainURLRequest(). This is needed because ThrottlingURLLoader doesn't use the Mojo pointers to the loader/client, which DrainURLRequest() needs. Bug: 1095842, 1092329 Change-Id: Id036135e9b9d15f6357b3cc1bd36be98d5cb155b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259734Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#782103}
-
Maggie Chen authored
Bug: 850881,863086 Change-Id: I37ca7c191bb70d9571b3bea620df382496ae2498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265172Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782102}
-
Thomas Lukaszewicz authored
Currently bubbles rely on having the NonClientFrameView apply a clip mask to the ClientView so that the ClientView's contents are correctly constrained to the bounds of the frame. However, if the ClientView's content view hierarchy employs layer backed views, the ClientView's clip mask is ignored if the ClientView does not itself paint to a layer. This results in clipping issues where views can clip outside the bounds of the bubble when corner radius is increased. This patch addresses this issue by having the BubbleDialogDelegate supply a ClientView that paints to a textured layer. To address the existing cases where bubbles rely on the frame's background color (i.e. they assume that the ClientView is transparent), the BubbleFrameView will update the background color to ensure existing bubble behavior is preserved. Currently these features are gated behind the kEnableMDRoundedCornersOnDialogs feature flag. Bug: 932970, 822075 Change-Id: I68542ffe84b533fd8b751acc01e5852a8b9bf6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257452Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#782101}
-
David Schinazi authored
We've seen an increase in errors without the GQUIC error recently, so we're adding this new histogram to help figure out where those specific errors are coming from. This CL also adds some error codes that were missing from enums.xml. R=renjietang@chromium.org Change-Id: I58507c206ccbf3063ac7e1dc5b776306fe71e1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265233 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782100}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593014209-7e980a1dfa67a2e51666ab74889d15022f0ab030.profdata to chrome-win64-master-1593018578-236971dc116ecc25bb19bba334b12df71f24465e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If5f129ee763c377e3211b31c2e7aa52342a69cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782099}
-
Joel Hockey authored
This reverts commit 159ca7c4. Reason for revert: fixed build script error Original change's description: > Revert "Add CrostiniController class to manage foreground tasks" > > This reverts commit b2e67312. > > Reason for revert: Caused compile failure on Linux ChromiumOS MSan Builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Builder/19874 > > Original change's description: > > Add CrostiniController class to manage foreground tasks > > > > This is a refactor to move code out of file_manager.js and > > into crostini_controller.js in preparation to add more features > > for showing messages. > > > > Updated UI tests to use FILES_NG_ENABLED and work with all files > > that import from chrome://resources such as files_message.html. > > > > Bug: 1095889 > > Change-Id: I9c9f34304e26dca8df4c0aa64a51c124650385b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259873 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781773} > > TBR=joelhockey@chromium.org,lucmult@chromium.org > > Change-Id: I91a7bd3837cf2ab2108ba672c36b3e5a5d5c743c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1095889 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263833 > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781810} TBR=bsep@chromium.org,joelhockey@chromium.org,lucmult@chromium.org Bug: 1095889 Change-Id: I83b5dd3369e186ccffa29a63f25de370b73d7e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264086Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782098}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a13d6a8f2b4d..44e38c4643ce 2020-06-24 chiur@google.com Merge "Clarify gpu_render_stage comments for use with OpenGL" 2020-06-24 lalitm@google.com Merge "tp: cache counter dur column after first creation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06223f331ea93461491e169eed4a84314e1d98d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265165Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782097}
-
Jesse McKenna authored
This change makes gfx::CheckWindowCreated() check whether the system is out of Graphics Device Interface (GDI) resources if window creation fails. Exhaustion of GDI resources indicates a GDI leak, either by Chrome or by another program, caused by the acquisition of handles to many GDI objects without the release of those handles. Explicitly checking for this case will make it easier to diagnose crashes in gfx::CheckWindowCreated(), e.g., crbug.com/1091696, which is suspected to be GDI-leak-related but impossible to diagnose with certainty without understanding the GDI-object counts at the time of the crash. Bug: 1091696 Change-Id: Ifaeceae8f7c511a9c7d0f80f37709fbc1c5bb9d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244124 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#782096}
-
Matt Reynolds authored
This CL sets up the origin trial feature name "WebHID" and modifies WebHID permissions UI in preparation for an origin trial. * WebHID settings is visible by default in Site Settings * Site settings includes granted HID devices Intent to Experiment thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/LoyzK8xTRME BUG=1038966 Change-Id: I16f52e3c8d112f1f173c62a5a9fe073106e1560e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985174Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#782095}
-
Tom Anderson authored
BUG=1066670 R=msisov CC=sky,nickdiego Change-Id: Iaec104e97e18dca682229a6c52edd1e770c63e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261490 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782094}
-
Tommy C. Li authored
Before this CL, we always set the Headers text color to GoogleGray700. This is not correct, and this CL fixes it so that it's dynamically calculated by the theme just like the dimmed results text. In practice, the result of this calculation is still GoogleGray700 in the standard light-mode configurations, but is enhanced to be a better contrast ratio in dark mode. Bug: 1095205 Change-Id: Ieee2bd1db87b8806cb8cac8dcf0e30cc9859d6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264765 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782093}
-