- 27 Aug, 2020 40 commits
-
-
Robin Lewis authored
Bug: 1119561 Change-Id: I0c4b5826cb4ed3e4bc18893f696f80089ad82f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365755 Commit-Queue: Robin Lewis <wrlewis@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#802115}
-
Henrik Boström authored
This reverts commit 3dbd8ec2. Reason for revert: I don't think this is the culprit and it looks like this test has been flaking for a couple of weeks, see: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnJ0Yy9wcm90b2NvbC9jcnlwdG8tc3VpdGUuaHR0cHMuaHRtbAw More details here: https://bugs.chromium.org/p/chromium/issues/detail?id=1122106 Original change's description: > [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time." > > This reverts commit 3bc91ccc. > > Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329 > > Original change's description: > > [Perfect Negotiation] Surface session descriptions at the right time. > > > > This fixes another timing related issue that blocks Perfect Negotiation. > > > > Before this CL, current/pending local/remote description attributes do > > blocking-invokes on the webrtc thread, fetching the most up-to-date > > states. This can prematurely expose the result of "in-parallel" > > operations that have not surfaced yet, such as: > > - setLocalDescription > > - setRemoteDescription > > - addIceCandidate > > > > This CL fixes that by copying the SDP states when any of these > > operations complete on the WebRTC thread and carry them over in the > > PostTask to the main thread. Here, we store these snapshots in > > "internal slots" (variables living on the main thread). With this CL, > > reading SDP attributes from RTCPeerConnection is non-blocking and > > spec-compliant. > > > > WPT test coverage added for the exact timing of SLD/SRD and other test > > expectations are updated. addIceCandidate updating the SDP is already > > covered by old WPTs. > > > > Bug: chromium:1110347 > > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801798} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1110347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715 > Reviewed-by: Amr Aboelkher <amraboelkher@google.com> > Commit-Queue: Amr Aboelkher <amraboelkher@google.com> > Cr-Commit-Position: refs/heads/master@{#801822} TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com Change-Id: Ia0f82e0d1b4660cf0d3641aaa446127092c6e6f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379192Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802114}
-
Sven Zheng authored
It's been ~1 week on CI/CQ and the builder is stable. Bug: 1104291 Change-Id: I546734d0719faa1d48db4910ff2db14b11b7bdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378617Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802113}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f729a8b7cc84..788aa6fd2c18 2020-08-27 jleconte@google.com Monorail links in group_report by group_id page are missing project ids. 2020-08-27 landrey@webrtc.org Implement /uploads/<token> api If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773,chromium:1114056 Tbr: skyostil@google.com Change-Id: I086f47b3fab9cf2bcc201319495de95b4e6a93d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802112}
-
Chih-Yu Huang authored
This reverts commit a1921808. We postpone the VD migration at ARC++, so the mojo struct for media::DecoderBuffer is not used now. BUG=b:136716638 TEST=ninja chrome TEST=./testing/xvfb.py ./out/Debug/components_unittests --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I783480520c82793bd41af3b904011969c37d4adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377261Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802111}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/398ecf1876f1..e6c0f0157c6f 2020-08-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from c3e3c30b0d7f to 8c012e879646 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: Ibb9093339a14a93c6b4b69ef0ba1af326f7f6b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378767Reviewed-by:
-
Xianzhu Wang authored
This CL (temporarily) explicitly enables SubresourceWebBundles for web tests. Two tests under webexposed/ are rebaselined. virtual/subresource-web-bundles is removed. This is to seperate the change of web test expectations from crrev.com/c/2375886 which will enable the feature for web tests by adjusting the application order of blink feature status and chromium feature status. Bug: 1121839 Change-Id: I21da03bc90e456fbf606056f03351dd5f72e2161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378711Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802109}
-
Maksim Sisov (GMT+3) authored
This reverts commit 75363679. Reason for revert: Looks like it broke linux trusty bot Original change's description: > Reland "X11 and Ozone: enable use_x11 and use_ozone" > > This is a reland of f985905e. > > This change broke our headless build: > ERROR at //ui/events/platform/x11/BUILD.gn:51:5: Assertion failed. > assert(ozone_platform_x11) > ^----- > See //components/viz/demo/BUILD.gn:73:7: which caused the file to be included. > "//ui/events/platform/x11",. > > Fix: > Don't include x11 build for headless case. > > Original change's description: > > X11 and Ozone: enable use_x11 and use_ozone > > > > This is the final change that enables use_x11 > > and use_ozone for Linux builds and (as it was > > before) excludes X11 for chromeos, chromecast, > > lacros. > > > > in order to run ozone/X11/wayland, one must pass > > —enable-features=UseOzonePlatform > > —ozone-platform=x11 or wayland. otherwise, > > non-ozone/X11 is used. > > > > it’s also possible to completely disable X11 > > so that clients, who need that kind of build can > > continue to have that. > > > > Bug: 1085700 > > Change-Id: I171bcb53c406555a1d4bec3e88d76dc676310d48 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315869 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#801523} > > Bug: 1085700 > Change-Id: I8bf0abead6c94c95ddc58443de7cf2268c977cf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376806 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#801692} TBR=rjkroege@chromium.org,sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I6c4e523808341b75c0f734492ac71cb2b9767617 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377814Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#802108}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69ed1bc0165a..167cbab7ee8e 2020-08-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifde1a09a963a8f921d33ae13e14b65b5e820f2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378668Reviewed-by:
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/c2e5361f375a..d8fb72d5a $ git log c2e5361f3..d8fb72d5a --date=short --no-merges --format='%ad %ae %s' 2020-08-26 vasilvv Switch the experimental use of absl from absl::node_hash_map to absl::WrapUnique. 2020-08-26 vasilvv Add missing QUIC_EXPORT_PRIVATE attributes. 2020-08-26 renjietang Deprecate QuicSession::CloseStream(). 2020-08-26 quiche-dev Rename QuicSpdyStream::IsClosed() -> IsSequencerClosed(). 2020-08-26 vasilvv Attempt to use Abseil in QUICHE. 2020-08-26 bnc Test-only change 2020-08-25 danzh In IETF quic, start peer migration by switching peer address as soon as detecting a non-probing frame in the incoming packet rather than after finishing parsing the whole packet. Protected by --gfe2_reloadable_flag_quic_start_peer_migration_earlier. 2020-08-25 fayang Deprecate gfe2_reloadable_flag_quic_retransmit_handshake_data_early. 2020-08-25 fayang Deprecate gfe2_reloadable_flag_quic_fix_extra_padding_bytes. Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: Ieab7e0aaf9c8098f993036e75e0725eaaaadd72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378532Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#802106}
-
Garrett Beaty authored
Bug: 1119446 Change-Id: I9b099b03b634425ff6ee7149bbdd4dcc0f4b0fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378901 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#802105}
-
Tal Pressman authored
This reverts commit feae489c. Reason for revert: Caused OSSettingsPersonalizationPageV3Test.All to fail in linux-chromeos-dbg. See, e.g.: ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20179 Original change's description: > [OsSettingsDeepLinking] Add deep links to the Personalization Page > > Adds deep links to the Personalization Page, including the change > picture and ambient mode subpages. Also fixes a bug where the ambient > mode page tests were not run. > > Bug: 1084154 > Change-Id: Ife0a6602e9fecdef57db116ce6dd7e74c9ce3cc7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375730 > Commit-Queue: Daniel Classon <dclasson@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801999} TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,dclasson@google.com Change-Id: Ic647c9416c75f53a712829976483819e8d6c45c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1084154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377629Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#802104}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53daab94768a..a3467211f5c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC talp@google.com,estade@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093993,chromium:1121776 Tbr: talp@google.com,estade@google.com Change-Id: I3953a78028df9a874c1d9e1daa8ade92e5d1f31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802103}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aa79ac23ec8d..f729a8b7cc84 2020-08-27 landrey@webrtc.org Add logging of upload completion token events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: skyostil@google.com Change-Id: I71b1834b91f4ae7a1cf5b7d740002935240808be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378936Reviewed-by:
-
Yoshisato Yanagisawa authored
With Goma builders, we have confirmed that chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com works as without using task service account for Goma. Let me migrate the builders. Bug: 1105814 Change-Id: Ic4dedf38c59f358909014d4f8b0c9379914bcb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378780Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#802101}
-
Sadrul Habib Chowdhury authored
Not all dropped-frames affect smoothness. For example, the compositor thread may be driving a css animation, while the main-thread drops frames while doing busy js work (e.g. handling event, etc.). These dropped frames do not affectthe smoothness of the animation. So count the dropped frames that specifically affect smoothness separately. To do this, for each frame, track whether the compositor and/or the main thread are affecting smoothness. BUG=1115376 Change-Id: I6cd3e3d2a10ed63c53ab929386abae1d5e29e7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366039 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802100}
-
Jinsuk Kim authored
The flaky test was already fixed. Re-enables the test on android-pie-x86-fyi-rel. Ignore-CQ-Freeze: enabling tests for emulator builder Bug: 1061216 Change-Id: I004a09829c410d40bea6d40d3b79bd5c748de739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363509Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802099}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008200800_RC01.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/HZNHFa2CcUZB-FO9DToAmE5qKZsX_2h2bM8NbJPrGd0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159384835 Tbr: help-app@grotations.appspotmail.com Change-Id: I7e756cb8946ae0170759fdcb0b9c3672f05b4799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378224Reviewed-by:
-
Darren Shen authored
None of these are used in the internal VK code. Change-Id: I28d9658372fbef6208a9bc1efc7ec2b7c271e29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371149Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#802097}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib3da838045fa77faf3ac6a3b333d2df07cf35a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378660Reviewed-by:
-
Chih-Yu Huang authored
Add the current ARC++ video team member to the OWNERS. BUG=None TEST=None Change-Id: I502e3445104efe5327d2a780e29d8ca934ea4696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377183Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802095}
-
Andrew Xu authored
This CL implements the highlight background and the close button view for the Multipaste menu item. Note that the item deletion is not included in this CL. In addition, the rounded corners of the bitmap are removed in this CL. Because the previous implementation utilizes the paint layer, which brings us troubles when scrolling. The rounded corners will be added back in a separate CL. Bug: 1112888 Change-Id: Ib3f469124b01b5a6c0602cca0ebc29d177b678ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370656 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#802094}
-
Noel Gordon authored
Says as much but avoids an unfortunate auto-formatter line break. Also remove a comment that no longer matches the error code behavior. Bug: 1114622 Change-Id: If495124221d6bbeb416cb69a1a4b30fc6d95f1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377827 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802093}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/320c6c87b2ed..8575cb3ec773 2020-08-27 bajones@chromium.org Add setIndexBufferWithFormat method If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I6eb4a619817bb207509b18e99e3ed45baff5fb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378935Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I7521072eb9321e902a6325eda954db44c38bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378766Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802091}
-
nancylingwang authored
The function GetIconPurpose uses the parameter |size_hint_in_dip| to calculate the max supported pixel size, however, the input parameter |icon_size_in_px_| is incorrect, and |size_hint_in_dip_| should be used. BUG=1121480 Change-Id: I249f369e194eca9db96d8d2da68a9bdac03dedcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377667Reviewed-by:
-
Greg Thompson authored
The various SpellcheckCustomDictionaryTests post background tasks to update the dictionary file. Allow these tasks to complete at TearDown before destroying the TestingProfiles so that the directories on disk aren't being removed while background threads are trying to write to them. This CL unblocks making base::CreateAndOpenTemporaryFileInDir DCHECK if the target directory doesn't exist. BUG=1075917 R=groby@chromium.org Change-Id: I25b3317447f0928504e3315caa6b215410030c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193111 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#802089}
-
Songtao Xia authored
This is based on https://chromium-review.googlesource.com/c/chromium/src/+/1725223 by Dmitry Gozman. Part to support "stepping back from fetch" is in a different CL. Explainer: https://docs.google.com/document/d/1WJcNA9PymdWQXOZ4b0xSPmqQCDplWO6c01Ve47lQ2xo/edit?usp=sharing This patch introduces debug header "X-Debug-Stack-Trace-Id", which is added when Network.setDebugHeaderEnabled is called. This header plumbs stack trace id and can be used to stitch async stacks between page and service worker, or between page and node.js backend (future work). The header is added by InspectorNetworkAgent and parsed by ServiceWorkerGlobalScope. Frontend changes to enable 'step into service workers': https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2292897 Screenshot before: https://imgur.com/pIxDfHa After: https://imgur.com/MHXM5BI Change-Id: I4aeeca29802318fe063459562c31e147e7b0d9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335644 Commit-Queue: Songtao Xia <soxia@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#802088}
-
Ian Kilpatrick authored
This patch removes counting various UseCounters, and assumes that HasLineClamp will always be true for a LayoutDeprecatedFlexibleBox object. Bug: 305376 Change-Id: I56ae40850698b6e04cebc320f78d7a0af4992c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954927 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#802087}
-
Josh Nohle authored
Set the expected uploaded contacts/certificates. Change-Id: Iaa927d9ee31e43ddf1d641cea7137d2507cab765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378597 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#802086}
-
Leonid Baraz authored
Bug: b:165851833 Change-Id: Id4d65e2426663783d510a72a8a1f298462e3d2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378655 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#802085}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008260800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/NDPCcgJvuhM3F7KyVFnMa4mftVlWMdK9ysK3cuxhi2oC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/163669074,b/165878563 Tbr: media-app@grotations.appspotmail.com Change-Id: I9f32f007dc5d2f80af54e4d63a75c855e6c3dce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378933Reviewed-by:
-
Rachel Wong authored
The privacy container score was previously set to INT_MAX to ensure that it was the first container, because other container scores could fluctuate. The app list config now consolidates the scores for all search result containers, see https://chromium-review.googlesource.com/c/chromium/src/+/2345924. Bug: 1079169 Change-Id: I1caf9a3bd94f2c71aed68fe79f2ec88fa4f39645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377185Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#802083}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/14a9bffb3e9e..ced41e1f394d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1f53c2b234ac21a8c10748bbeebc32487102ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378887Reviewed-by:
-
Alan Screen authored
Advanced capabilities for ChromeOS are always strings, but those values can contain content that is to be interpreted as numbers or a boolean. These different types were previously distinguished by using the base::Value::ValueType enum, which is a superset of what ChromeOS requires for these capabilities. Use of this enum creates a hurdle in the effort to mojoify PrintBackend class for out-of-process print drivers. In particular, extending the mojo definition of base::Values has been deemed undesirable. [1] While the original reason for using base::Value::ValueType here is unknown, it seems that it should be replaced with something that reflects its more limited possible values. Rather than pull in CloudPrint-specific types into core printing code, introduce a type locally to reflect the expected capability types. [1] https://crrev.com/c/2368138 Bug: 809738 Change-Id: I42efff084a394cb6e0ac4e1f89ffd41aa58ae323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369496Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802081}
-
Kyle Horimoto authored
This class exposes the notifications which have been synced from the phone and provides APIs to dismiss notifications and send inline replies. The functionality to add notifications to this class and to implement dismissal/reply are not yet implemented. This CL also simplifies some logic in FakePhoneHubManager to avoid unnecessary unique_ptrs. Bug: 1106937 Change-Id: I9cc743bbb85aea64fe47f839ffa6b631f88e4e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378774 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802080}
-
Xinghui Lu authored
The SafeBrowsingExtendedReportingEnabled policy is supported on desktop platforms since M66. We should support this policy on Android as well. Screenshot: http://screen/AxEr3pc9q6s4KMi Bug: 1108604 Change-Id: I456de70a9a0435cbe3fa6e54e2648e7d834a42c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378542Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802079}
-
Danyao Wang authored
Allow origins enrolled in the Secure Payment Confirmation trial to use skip-the-sheet flow to trigger secure modal. Bug: 1122028 Change-Id: I8d9e41ad6ac3b8851e72fa5416562d85a8b14f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378446Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#802078}
-
Alexander Cooper authored
Oculus and OpenVR both have beta runtimes that will allow running their devices via OpenXR. In order to simplify the Chrome codebase, we will stop running Oculus and OpenVR against their own runtimes (which have not shipped), and run them via their OpenXR implementations. Note that with OpenVR being removed, the test macros needed to be modified to stop running against it, as well as a few OpenVR specific tests needing to be removed. Oculus runtime was never tested in an automatic fashion. Bug:1121624 Change-Id: Ibdf13532e922db1290062186fd5ec45885d5b46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373392Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#802077}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1752e62f5c2a..69ed1bc0165a 2020-08-26 brcui@microsoft.com Remove Settings from More tools menu 2020-08-26 michael.liao@microsoft.com [Accessibility - Console]: Adding SR alert for clearing the console If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1120065,chromium:1121312 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9e73541b8212b21c4d1cbf678bf190ae7416db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378666Reviewed-by:
-
