- 14 Dec, 2020 40 commits
-
-
Rune Lillesveen authored
If there were no @font-face rules in the document, but @font-face rules in user origin stylesheets, we would collect fonts based on the previous set of active user sheets. Pass the correct new active sheets. Bug: 1157821 Change-Id: I19a4578b5cced1568516e586208e37066c7df873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584926Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#836642}
-
Jana Grill authored
Adjust IDS_POWERWASH_REQUEST_MESSAGE_FOR_ARC and IDS_POWERWASH_REQUEST_MESSAGE_FOR_CROSTINI to support FlexOrgs by adjusting the domain placeholder names and descriptions to make it easier for the translators to understand the usage of the texts. Additionally replace a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172685729 Test: Manual Change-Id: I7636b1b9123fa2714cb002d1561e0665628ca8ec Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587029Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#836641}
-
Christian Dullweber authored
The PageInfo dialog is closed when the activity is restored e.g. due to screen size changes. Subpage fragments should be removed since they are not needed anymore. Bug: 1157410 Change-Id: I1468f5d259e7ba9a1c33b842a4f1fa9d24bdb289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584804Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#836640}
-
Joon Ahn authored
http://screen/9giUqca89s2rTHh Bug: 1156229 Test: browser_tests --gtest_filter=*NearbySh* Change-Id: Iccf9a78133a5face8c66518659ab1d941ff9a203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587491 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#836639}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/2abecbba1670..24bbbbb25f7d 2020-12-14 dsinclair@chromium.org Add Symbol to struct type. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I2f7d2e8598450c86c0d66e3cb57ed4fc01ba33d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836638}
-
Yao Xiao authored
This is a reland of e16309d9 The diff: disable floc event logging for 2 user-event related sync test suite: SingleClientUserEventsSyncTest & TwoClientUserEventsSyncTest. Add a wait-for-floc-network-response call at the end of ProfileSyncServiceHarness::AwaitSyncSetupCompletion, so that the user event logging behavior now becomes more deterministic and new flaky test won't be added by accident. Original change's description: > [floc] Remove the EventTrigger field in the FlocIdComputed event > > Why: That field is never used & not useful for the server side analysis. > > This CL also removes a workaround that disables the initial floc > loggings when permission disallows > (in FlocIdProviderImpl::LogFlocComputedEvent). We had this workaround > because otherwise the logging would mess up with the user event > expectations in SingleClientUserEventsSyncTest, but that workaround is > not ideal. This CL fixes it by disabling kFlocIdComputedEventLogging for > the test suite, and adds a new test for the enabled case. The impact > of this fix is it will cause additional events to be logged. > > > Bug: 1148358 > Change-Id: I70cef531b89b434b5572b419acc8dd2412888498 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572733 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835468} Bug: 1148358 Change-Id: I12c8230ee5edc3de7337e9daa8c07143ae83949d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584607 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#836637}
-
sczs authored
Since the Discover feed uses a diffable data source its not completely loaded at this time, in order to make this work we need to add a short delay before scrolling. Bug: 1108403 Change-Id: Id40dcc0655fe3fe01fdd4966611c475dce44bcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587474Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836636}
-
Fredrik Söderqvist authored
This converter converts "<url> | none", so add DCHECKs to that effect. Bug: 109212 Change-Id: I35f7629a1d233ed5a6e884af6538441e5a4a8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587170Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#836635}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f37a8715452c..406249fca52c 2020-12-14 tvanderlippe@chromium.org Split up ESLint rules configurations in sub-folders 2020-12-14 tvanderlippe@chromium.org Enforce specification of return type in function/method declarations 2020-12-14 tvanderlippe@chromium.org Add missing return types to function/method definitions 2020-12-14 patrick.brosset@microsoft.com [Flex] Adding gap support to the flex overlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1057042,chromium:1150832 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I633f813acbbf87784976d653cf8306f6ae5046b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588615Reviewed-by:
-
Christian Dullweber authored
mSubpage can be null if a storage fetch finishes after the subpage has been left. Bug: 1156888 Change-Id: Ib24378750a87606d36032f338486499ef7725819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589873Reviewed-by:
-
Andres Olivares authored
The 'Escape' key is used in multiple keybinds that collide with each other and thus, the action that is effectively triggered cannot be known beforehand. This test relied on the usage of such key and on the specific order in which actions were loaded. Now, with the migration of extensions out of module.json files, the order for loading actions is altered and this tests starts failing in consequence. This change modifies the test so that the tested behaviour is triggered without relying on the usage of the 'Escape' key. Bug: 1134103 Change-Id: I508704d4507f24441988a837c06f5c009817a91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586533Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Andres Olivares <andoli@chromium.org> Cr-Commit-Position: refs/heads/master@{#836632}
-
Jacobo Aragunde Pérez authored
According to the ARIA spec, a checkbox must have a name, but in the history page we are not giving a name to the item with role checkbox but to its parent instead. The cr-checkbox component can render its light-DOM children to a hidden div used by the checkbox as accessible label container, we make use this feature to fix the problem. Bug: 1152721 Change-Id: Ia36bab94497caa60832d02876307f844744340a5 AX-relnotes: make checkboxes in history page ARIA-compliant. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584502Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#836631}
-
Yi Gu authored
Bug: 1152263 Change-Id: I6b4db7e7fd955a5016b54775993447a5b21d1580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585817Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836630}
-
Pavol Marko authored
PreSigninPolicyFetcher was only used to evaluate the EcryptfsMigrationStrategy policy which was removed in CL:2513205. Bug: 832127 Change-Id: I73a84409706808f8c11412be1500896c71c3318c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513592 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836629}
-
Clark DuVall authored
This provider had minimal dependencies, and moving to the base module will give chrome module preloading more time to work. See http://crrev.com/c/2577546 for more background. Bug: 1150600 Change-Id: Ic35fbe75a82aa19bea76dcbfb3aed534cbd2e600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587821Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836628}
-
Yaron Friedman authored
Introduce a temporary helper to get internal repo off this function. BUG=783819 Change-Id: Ifd650b1361b5ddd4617500c4448190ae75d64c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588250Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836627}
-
Jana Grill authored
Replace references to enterprise_display_domain with enterprise_manager. Additionally replace a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172684922 Test: None Change-Id: I604450887da6c54e8747b5a4d679179dc13b056b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584929Reviewed-by:
-
Sami Kyöstilä authored
This reverts commit 3bdb9041. Reason for revert: Seems to be causing crashes on Pixel 2: https://ci.chromium.org/ui/p/chrome/builders/ci/android-pixel2-perf/13030/overview Original change's description: > Accessibility Image Descriptions Port, Part VII - Incognito > > This CL is the seventh part of an effort to port the existing Desktop > feature to Android. This feature enables a user to send an image to > Google to process to generate a descriptive alt text if a website > does not provide one. > > Design Doc: go/2020-q1-android-image-descriptions > Slide Deck: go/clank-imageDescriptions > Launch Bug: 1057168 > > Original Desktop Design Doc for reference: > go/chrome-a11y-annotations-design > > This is a conservative approach, we use a separate set of profile > Prefs for this feature rather than syncing with the Desktop Prefs. > This can be updated in time as needed. > > ---------- > > This CL adds the following: > > - Syncs Regular and Incognito behavior as per new reqs > - Corrects unit tests for above > - Adds an AXMode observer to watch for screen readers being enabled > > ---------- > > > AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. > Bug: 1057169 > Change-Id: I27b6cb1c3da4cae441a6519815f7835049827452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585587 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Mark Schillaci <mschillaci@google.com> > Commit-Queue: Mark Schillaci <mschillaci@google.com> > Cr-Commit-Position: refs/heads/master@{#836174} TBR=dmazzoni@chromium.org,twellington@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,mschillaci@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1057169 Change-Id: Ib28af4808090c432219137456451aa1b9ce6c230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589933Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#836625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68da2313ca77..39f69dcae076 2020-12-14 kjlubick@google.com [fuzz] Fix CI Fuzz build process If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I9d29ff03e6cbd6b5d6f09bc88763ee46f4cd8a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589657Reviewed-by:
-
Andrii Shyshkalov authored
R=bpastene, liviurau, machenbach Bug: 1142484 Change-Id: Id121d0fb153a2a7de3c2fab5f432d0083e841dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589032 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836623}
-
Matt Menke authored
They had been using the NetworkIsolationKey of the last committed navigation, but since preconnects are triggered on headers received, they can bear the commit to the RenderFrameHost. This does mean that on navigating away, if the RenderFrameHost is reused, there's a greater chance of using the NIK of the new commit rather than the old one, when preconnecting. Bug: 1157450 Change-Id: Id02e590cb47221194fee8e68cc7d213483c1920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584466 Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836622}
-
Hidehiko Abe authored
crrev.com/c/2560279 had a mistake of updating the configuration. "!is_linux" (not is_linux) needed to be expanded to "!is_linux && !is_chromeos_lacros". This caused link-time error, when thinlto is enabled. Bug: 1157567, 1052397 Test: Built locally. Change-Id: I0d7547e326706b6ceb734f98c05d7a96fdd4ce5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584633 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836621}
-
Frédéric Wang authored
This CL removes SecurityPolicy::IsUrlTrustworthySafelisted() which is basically a wrapper to IsOriginTrustworthySafelisted(). The only place where it is used outside SecurityOrigin::IsSecure() is in PaymentsValidators::IsValidMethodFormat() for a non-opaque http URL. However, the corresponding section can thus just be replaced with a call to SecurityOrigin::IsPotentiallyTrustworthy(). Bug: 1153336 Change-Id: I3f3362aa12ab10ee2a2ed945064203deec622ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587738Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#836620}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0a8e6d54fba6..6df594ecc557 2020-12-13 vapier@chromium.org run_pytest: improve chdir handling 2020-12-11 tcwang@google.com config: Deschedule PFQ builder on R87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I79f1e32e2f7d757a97b3a8ed982a6cde81b4bc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589659Reviewed-by:
-
Peter E Conn authored
This moves the browserservices code to do with verification into a separate package and makes its dependencies explicit. Change-Id: I8776ca289021cf319b4518acb1e4089cf4f9dc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563260 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836618}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/_TKKqA3exvCH4VzT1gCIG6C-puG_FBbSIZzLoiwSxzUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/158043291 Tbr: help-app@grotations.appspotmail.com Change-Id: I7b79a1e353e604860549bc44f3b4ab86f9b727d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589656Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836617}
-
Richard Stotz authored
This CL adds longer timeouts to some WPT that occasionally time out under macOS. I expect this will reduce the flakiness for tests that spend a long time accessing the hard drive. Bug: 1157915 Change-Id: I5fc3e4716dec5a9d0c17021bf02e449b5dda400d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587164 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836616}
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I0923f28a081341cf84a5e989b31b7dc648b1fd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588977Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#836615}
-
Alessio Bazzica authored
AGC2 includes SIMD optimizations for different platforms. Recently, AVX2 code has been added (see [1]) and a kill switch has been added to the GainController2 configuration in APM. When `avx2_allowed` is set to false, AVX2 won't be used even if available. Tested: appr.tc call made [1] third_party/webrtc/modules/audio_processing/agc2/rnn_vad/vector_math_avx2.cc Bug: webrtc:7494 Change-Id: I12fe73008e4d1a434d2e57b38fef191e6db0d71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580528Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#836614}
-
Alice Wang authored
This CL moves the method logAccountConsistencyPromoAction to SigninMetricsUtils to regroup the signin metrics logging util methods in one place. Bug: 1158341 Change-Id: I6e7935020aaf1e28abcb3634aa0b91f498ee6665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588932Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836613}
-
Caitlin Fischer authored
This reverts commit 23484e80. Reason for revert: Some of the Android tests that were ported to chrome/browser/metrics/ukm_browsertest.cc are flaky. Temporarily re-adding these test files will make sure we have coverage while we fix the tests. Note that this isn't an entirely clean revert. Here is a list of things that were tweaked in the revert. 1. BUILD.gn - Dependencies in this file needed up to be updated to be able to build Chrome. 2. UkmTest.java - Some TODOs were not restored because their associated tests no longer exist. 3. ukm_utils_for_test.cc - Formatting is slightly different. 4. ukm_browsertest.cc - The functions CreatePlatformBrowser() and ClosePlatformBrowser() continue to be used. Original change's description: > Enables the C++ test HistoryDeleteCheck on Android. > > Also, deletes the corresponding Java test, which is now redundant. > > Bug: 1049736 > Change-Id: Ib8fb2833128d88c6fc6189ab2e45bbb245a8d697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208597 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Cr-Commit-Position: refs/heads/master@{#771794} TBR=asvitkine@chromium.org,treib@chromium.org,caitlinfischer@google.com Bug: 1049736 Change-Id: I8eb02788bbac007a37dc321d172c2453b4aad3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578096 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#836612}
-
Matt Menke authored
RenderFrameHostImpl was recently modified to only update the value GetIsolationInfoForSubresources() returns to only return the value of the committed page. This matches the behavior of GetCommittedOrigin(), and the old behavior of ComputeSiteForCookies (which was accidentally changed a couple months back), so callers will get a consistent view of the world. This API is necessarily racy, since neither RenderFrameHostImpl nor the caller generally know whether the call wants the old IsolationInfo value, or the new one. ContentAutofillDriver seems to be calling this method before a page commits, while it's still pending. This CL switches it over to using the pending IsolationInfo value, instead of the committed one, which should match previous behavior. Once RenderDocument is implemented, consumers will hopefully be bound to a document instead of a frame, which will resolve the ambiguities/raciness with this API. Fixed: 1157517 Change-Id: I938a23a08a96e4ad4e79798b9e930d2a321b9328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586237 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836611}
-
Xida Chen authored
It appears that this is the last spot in chrome/browser/prifles for base::bind, after this change, there is no base::bind left in this dir. Bug: 1152275 Change-Id: Ibedb72b77ae14bc40ff683146793f45b30a40398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588638Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836610}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6a32d1681184..b46e4dd997f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ftirelo@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141127 Tbr: ftirelo@google.com,sinhak@google.com Change-Id: Ia1a5ad328070d9cac6cc2abd2f13a3734f8e6197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589655Reviewed-by:
-
Nicolas Ouellet-Payeur authored
ProfileManager::ProfileInfo now stores a refcount for its Profile. The refcount is incremented by instantiating ScopedProfileKeepAlive (a new class), and decremented in ~ScopedProfileKeepAlive(). The keep-alive is used by: - Browser - BackgroundModeManager - OffTheRecordProfileImpl (keeps the regular profile alive) When the refcount hits 0, it should trigger Profile* deletion. For now, this is left as a TODO for a future CL. ScopedProfileKeepAlive is a no-op when the DestroyProfileOnBrowserClose flag is disabled (which is the default). Bug: 88586 Change-Id: Ib8275c0dba276743750e5481ec5c9a1aa1f2bb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555198Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Wez authored
ReportFatalErrorInMainThread() is supplied with a |location| and |message|, which are logged in Debug builds with verbose logging enabled, but not otherwise. The function then invokes LOG(FATAL). Combine the two so that |location| and |message| are passed to LOG(FATAL), thereby providing useful context in crash reports. Bug: 1157386 Change-Id: I43e877b3d537b759c9db3c64534349009fefa7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584852Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836607}
-
Evan Shrubsole authored
These are measured the first time the capture process enumerates devices. This can give insights into which pixel formats would be good options for optimizations. Tested with the unit tests, and compiling Chromium and checking chrome://histograms Bug: 1156144 Change-Id: Idb72a74822ac2e9206fadb37fe365fd85cb16a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579510 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836606}
-
Alice Wang authored
This CL batches SignOutDialogRenderTest. Bug: 1120258 Change-Id: If64cb7472e2abea0ccb0f613e1597a8aeff83da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587735Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ORxPzHZ0YsN2W2bglOcsXbN1i-kvfEAj0sbC9jZ38UYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/173974643,b/173979024,b/174421355,b/175080523,b/175186196,b/175344485 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia6a65d182553bb7b192da76d7767af587b029115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589654Reviewed-by:
-
Regan Hsu authored
If the phone is observed to be in the connected state, but no phone status is observed after 10 seconds, disconnect from the phone. Fixed: 1155652 Bug: 1106937 Change-Id: I18d2a396d4624220405fcbd479ff36bc78c2a0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580518 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
