- 15 Dec, 2020 40 commits
-
-
Stephen Roe authored
These test suites are passing on the fuchsia arm64 FYI builder. Bug: 1054545 Change-Id: I097b673f48decaeea7ede4c8b9b787a3d86687b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591967Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#836911}
-
Stephen Roe authored
This test suite is passing on the fuchsia arm64 FYI builder. Bug: 1054240 Change-Id: I6e5be624827bb0b29aa1aeba91a6009c4cc29a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591491Reviewed-by:
-
Wenbin Zhang authored
This reverts commit f5a171b9. Reason for revert: Android builders on perf waterfall started failing since this commit. Original change's description: > Create ExternalAuthGoogleDelegate > > * Create ExternalAuthGoogleDelegate, owned by ExternalAuthUtils, which > will be used to implement isGoogleSigned downstream, rather than doing > so with an overriding subclass. > * This is patch 1/5 for providing ExternalAuthUtils as a singleton > instead of from AppHooks. > > Change-Id: I13c8d972f8ca1a4d2dac1bdda4ad8911ae8c275b > Bug: 1154371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587429 > Commit-Queue: Nick Burris <nburris@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836817} TBR=tedchoc@chromium.org,agrieve@chromium.org,nburris@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I030f8adaeb650eba09100242eebb9417d5e3908c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592387Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#836909}
-
Tibor Dusnoki authored
Fixes assert when trying to generate ninja build files for Windows Arm64 platform. Bug: 1157842 Change-Id: I3e1858696696537bb96b36d3969f9f7f355faa28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584813 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#836908}
-
Xing Liu authored
Open reading list page in CCT. Bug: 1158610 Change-Id: I9bf94d348cb722136512c52071141ee3f27b5c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591707Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836907}
-
Darin Fisher authored
This also helps fix <select> drop down menus to have taller items for Lacros as expected on Chrome OS. Bug: 1157228, 1141261 Change-Id: I9d3df7083823184c683e782fe5e9d3bf90e08bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590364 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836906}
-
Matt Menard authored
Bug: b:168650771 Change-Id: Ic4c5d025ae0e5ebea8b81d6182fed34bbfe8be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583218 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836905}
-
Luciano Pacheco authored
Generate JS modules for most of the mocks in: //ui/file_manager/file_manager/background/js/ Files in //ui/file_manager/file_manager/background/js/: crostini.js mock_crostini.js crostini_unittest.m.js mock_drive_sync_handler.js mock_file_operation_manager.js mock_progress_center.js Files in //ui/file_manager/externs/: progress_center_panel.js background/crostini.js background/drive_sync_handler.js background/file_operation_manager.js background/progress_center.js Bug: 1133186 Change-Id: I12d665f413d9965bd5ef5d8db7f93d724fdfbea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589234 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836904}
-
Matthew Denton authored
MultiThreadedCertVerifier keeps a list of MultiThreadedCertVerifier::InternalRequests in order to eagerly reset callbacks passed to Verify() if the MultiThreadedCertVerifier is itself deleted (CertVerifier contract guarantees this eager reset behavior). In ~MultiThreadedCertVerifier we loop through this list and reset the callbacks, but then delete the InternalRequest from the list. However, the callbacks are allowed to own the InternalRequest, so this leads to a UaF. We don't need to remove the InternalRequest from the list in ~MultiThreadedCertVerifier, because we are not in charge of the lifetime of the InternalRequest. InternalRequest can remove itself from the list during ~InternalRequest, or MultiThreadedCertVerifier can remove it from the list when a CertVerification job is complete. The former is safe because ~InternalRequest won't remove itself from the list if the MultiThreadedCertVerifier is already destructed. The latter is obviously safe because if the request was cancelled, then InternalRequest::OnJobCompleted will never run, so |this| is always valid to remove from the list during InternalRequest::OnJobCompleted. The added test reproduces the UAF without the fix. Bug: 1157562 Change-Id: I92d0dc6ca6df084f55ea511ea692853ee63f5033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587560Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#836903}
-
Luciano Pacheco authored
Tbr: jdoerrie Bug: 1157926, 1158588 Change-Id: Id10db4c2218625c7331ec64706705218fa5bbdb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591028Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836902}
-
Matthias Körber authored
This CL adds the ability to detect apartment number fields in forms when they are adjacent to a street name and house number field. The CL also adds support for the apartment number and the floor number to SQL. Support for sync will be added in a subsequent CL. Change-Id: I9d890d5855fe9aa1d20fc4684906e1eb16d838bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563692 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#836901}
-
Stefan Zager authored
IntersectionObserver may require sticky position information, so if a lifecycle update is forced by IntersectionObserver, make sure it proceeds far enough to update sticky position. As noted in the code comments, even if sticky position update is moved up to the layout phase (which is planned, I think), if the document is servicing any IntersectionObservers with track_visibility=true (i.e. V2 features), then we will still need to force the lifecycle update to continue far enough to enable hit testing. That's the root cause of the bug. Bug: 1156937 Change-Id: I809d822d7abf0789aea97113bc87907fdd11b345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583159 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836900}
-
Aaron Leventhal authored
TBR=kbabbitt@microsoft.com Bug: None Change-Id: I14d580e7e20409fdf2ecc4d8a9294076f11ec07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584562Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836899}
-
Azeem Arshad authored
This CL makes sure that when sharing is initiated from the sharesheet action, the feature is silently enabled and the user is taken to the discovery page if they've already completed the onboarding flow once. Fixed this by exposing the onBoardingCompletePref value in nearby share settings mojo interface and checking this value in the send flow. Fixed: 1157142 Change-Id: Ie65aa9ce22d8e8a38ce06e299b446865837ca60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586099Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836898}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c7f6c25c004..cf06cad1be4f 2020-12-14 ehmaldonado@google.com [subprocess2] Replace VOID with DEVNULL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ifa44c11ad8d266718eb99b3989de0de261ba3a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591453Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836897}
-
Jarryd authored
Replace the deprecated DISALLOW_COPY_AND_ASSIGN macro with deleted copy constructor and assignment operator. Change-Id: I63c8719a9ee49b602d3a6e5e9c74925f2699551a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590690 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836896}
-
Meilin Wang authored
Bug: b/163064897 Change-Id: I796a1f8efdb4d14d07cca102257413bf46aac429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586018 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#836895}
-
Josh Nohle authored
Currently, the discovery page might show multiple share targets corresponding to the same physical device. This can happen if the receiving device goes in and out of high-visibility mode, locks/unlocks the screen, etc. The endpoint ID and share target ID change after these events, and the stale share target records are not reported as "lost" until a timeout occurs after ~30s. For contact-based sharing, a share target has an immutable device ID corresponding to a physical device. In this CL, we remove stale, previously discovered share target records that have the same device ID as the most recently discovered share target. Note: If the receiving device is not using contact-based sharing or is not a contact of the sending device, there is no device ID available in the share target to dedup on. A different solution, if one exists, will need to be considered for that scenario. Fixed: 1146075 Change-Id: Ife49eb677fa0e973be845f2b715ce0db3f580cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589040Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#836894}
-
dpapad authored
Bug: None Change-Id: Ib7791d9a5a46f07d733c8926973cc45a797c2f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587567 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
compile skew test binaries Currently there is a freeze in increasing GOMA usage. So I had to remove goma compilation from the skew test refresher recipe, CL crrev.com/i/3462616. Bug: 1147459, 1099017, 1041619, 1156861 Change-Id: Ibdbc2dfb7364dd7ed0083a76bf041a48de7be392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590372Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#836892}
-
Jeroen Dhollander authored
This reverts commit 340ff5b3. Reason for revert: causes crash crbug.com/1158611 Original change's description: > Remove external dependencies from |AudioInputImpl| > > This will allow us to easier move this class to the Libassistant mojm > service. > > All dependencies have been moved to the new class |AudioInputHost|. > This class currently talks directly to |AudioInputImpl|, but later > it will instead talk to the mojom APIs. > > Some notes: > - |AudioInputImpl| still depends on > |AssistantClient::Get()->RequestAudioStreamFactory()|, because the > Libassistant mojom service will also use an audio stream factory to > open/close its audio input. In a follow up CL I will introduce a > delegate to sever this dependency. > - There is one behavior change: > |power_manager_client_->NotifyWakeNotification()| was previously > only called when DSP was enabled, and it is now always called (when > Libassistant starts a conversation). I can think of no reason why > this would be an issue. > > Bug: b/171748795 > Test: chromeos_unittests, deployed on real hardware with and without DSP. > Change-Id: I119521c7a72bf5361019d70240c02ba47a23d6ad > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582537 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836710} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org Change-Id: I2525fce21492c0417d0411db99fbb8463583cb02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/171748795 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591771Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836891}
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: I475aa0fb47961e8d3d50c5721522586359b3e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587701 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#836890}
-
Nancy Wang authored
This CL adds 2 interfaces for the window management component to save the window information, and get the saved window info based on: go/chrome-os-full-restore-interfaces There will be separate CLs to implement these 2 interfaces. BUG=1146900 Change-Id: Id2885863f4e9a1725382793064e10ac7597cfb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586648 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#836889}
-
Wei Li authored
The difference between NO_SHADOW and NO_ASSETS is that we still draw a border stroke for the former. Since live caption uses the same background color for different themes, it should not use a themed system border stroke. This CL removes the border stroke which is not visible anyway. Bug: 940027 Change-Id: I249191cfd51e82ea835e7e1f5997ac98a9c33bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590706Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836888}
-
Brian Sheedy authored
Fixes/improves the GPU unexpected pass finder script in the following ways: 1. Adds support for preventing expectations from being auto-removed via block or inline comments. This is mainly intended for cases where the flake rate for a test is low enough that the script does not reliably find a flake with a reasonable sample size. 2. Works around the suite name being reported to typ/ResultDB not being the same as the suite name reported by Telemetry for several suites. Bug: 998329 Change-Id: Ie9119dbf24353de7487cb1601db8234fd8efcd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590365 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836887}
-
Brandon Wylie authored
Bug: 1158272 Change-Id: I86da7a24ce0f182de56548479e6381689efa9c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587873Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836886}
-
Reilly Grant authored
The DCHECK in ~Bluetooth() is reachable because navigator.bluetooth can be destroyed before the execution context is destroyed. Bug: 972058 Change-Id: I5ed4d4c3b874a6bb7b73e91efcf918945dbf4250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591240 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#836885}
-
Eugene Zemtsov authored
Bug: 1122395, 1157765 Change-Id: Ib4bb91970cc582b26c0010a07168ad109ae04d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591888 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Bug: 687225 Change-Id: I57449229bf443ce33613a41b21e47f3fe52ca4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586096 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Brian Salomon authored
Bug: chromium:1156804 Change-Id: Ief802cd221d57d8379a31f16224d654e4fa0dd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587355Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#836882}
-
Roman Arora authored
Bug: 1099917 Change-Id: I57bfd6b3cb8b5496663b5d5d9fcd75a9603d5e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590627Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#836881}
-
Findit authored
This reverts commit ffac4483. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 836656 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmZhYzQ0ODNlNTQ4Y2RmODk3NzJlYmM5ODk5MTM3MDU4OTczOGZjNww Sample Failed Build: https://ci.chromium.org/b/8860905823939722448 Sample Failed Step: browser_tests Sample Flaky Test: TranslateModelServiceWithoutOptimizationGuideBrowserTest.TranslateModelServiceEnabled Original change's description: > [LanguageDetection] SimpleKeyedService and optimization guide. > > > This change converts the translate model service to a > SimpleKeyedService and moves it to components which will enable > easier support beyond just browser use cases. > > This change also registers the translate model service to > the optimization guide for provided necessary model files. > > A future change will add loading and service the model files > to consumers of the translate model service. > > Bug: 1151407 > Change-Id: I4e903115c82a30757d46d75ed8d733874726d830 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580339 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836656} Change-Id: I9f63ed714aafbe14ce8c48c23474becadd752186 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591947 Cr-Commit-Position: refs/heads/master@{#836880}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b99456364d8..e9409d7cfa91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ftirelo@google.com,atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1157567 Tbr: ftirelo@google.com,atotic@google.com Change-Id: Ieded572b3576033cf474ec013fe3aabd1f7a12f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590418Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836879}
-
Anupam Snigdha authored
This patch removes the logic to process input panel policy changes in TSF in favor of VirtualKeyboard APIs that we have been suggesting to web authors to use instead and not rely on TSF to manage VK for them as it leads to lot of buggy behaviors and its non-deterministic. Bug: 1031786 Change-Id: I5fe03a8a7dba40eef1101f3172751dd9f597e216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587587Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#836878}
-
Taylor authored
This reverts commit 36efcfc8. Reason for revert: Need to revert this in order to revert the last usrsctp update: https://chromium-review.googlesource.com/c/chromium/src/+/2586379 Original change's description: > Add fuzzer targets for usrsctp. > > Bug: chromium:1025302 > Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Commit-Queue: Taylor <deadbeef@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816872} TBR=hta@chromium.org,deadbeef@chromium.org,orphis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1025302 Change-Id: Ib984dc975c5802ad52d07b96d91e8fb1367bc4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586282Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#836877}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4d2246a2f93..f22b977bc4c0 2020-12-14 bsheedy@chromium.org Reland "Switch to vpython version of mock" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1156832 Tbr: oysteine@google.com Change-Id: Ibcf954b81a25d673a5d159491084688b3435b8ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591288Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/5c3a0b9..899e1838 TBR=jshin@chromium.org Bug: v8:11039 Change-Id: I111a7aaec74c909f4e3a68a9fcd44500ebb42392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591229Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836875}
-
Xiaodan Zhu authored
This CL disable the prevent fake login screen feature Following concerns from leadership, we are going to disable the fake login screen feature for M88. We will revisit in M90. Bug: 1158574 Change-Id: I12abd81a2871da1864ad166bb2929d6f38dd9dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590751Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#836874}
-
Kinuko Yasuda authored
Bug: 1010491 Change-Id: I122de2811a029c17afd184077d7693350917179f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586296Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836873}
-
Richard Knoll authored
macOS 11 introduced a new notification UI that has a dedicated close button in the top left corner. Unfortunately we're no longer able to override the caption of the overflow menu button via the NSUserNotification API so this will also remove the "More" button. The overflow button will now have the default label which is "Options" instead. Once we switch to the new API we can have our own labels on macOS 11 again. Before: https://imgur.com/6pOt5NH After: https://imgur.com/ImCqjQ5 Bug: 1157781 Change-Id: I3924fed16b54147f6de7fadb65ab32ac18f250a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587014Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#836872}
-
