- 08 Nov, 2019 40 commits
-
-
Ana Salazar authored
Bug: 1020386 Change-Id: Ife52a8257203b980492d77f4290b4bf1802f8c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902229 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713885}
-
John Z Wu authored
Bug: 723854 Change-Id: I6cb7a4c60dd458c76d59019175c04984e0b75abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904757Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713884}
-
Eric Seckler authored
This reverts commit 0d929861. Reason for revert: Breaks UBSAN builds (crbug.com/1022818). Original change's description: > perfetto: Use TraceProcessor for proto2json conversion > > TraceProcessor replaces the existing (unmaintainable) proto2json > converter and adds features like combining of BEGIN/END events > and support for heap profiles. > > Also updates a devtools test that was expecting separate begin/end > events where TraceProcessor now combines them into a complete event. > > We have reduced the trace procesor's binary size overhead > by selectively excluding features Chrome doesn't need from >400kB to > ~50kB. We could probably save a couple more kB if we invest even more > eng time and accept the maintenance burden for this in trace processor, > however, we feel that we've reached an acceptable state that balances > binary size & code health. > > Binary-Size: see paragraph above. > Bug: 1006770 > Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713593} TBR=caseq@chromium.org,oysteine@chromium.org,skyostil@chromium.org,eseckler@chromium.org Change-Id: Icc6bd802248c59d82d9697caaaae65a98f0487cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006770, 1022818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907006Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#713883}
-
Nektarios Paisios authored
This is a followup to crrev.com/c/1796047 This patch changes AXPosition::CreateNext/PreviousCharacterPosition so that it can also accept the BoundaryBehavior::StopIfAlreadyAtBoundary. This is necessary to be able to support navigating through characters that are not in the basic multilingual plain when using IAccessible2 and ATK. If a client calls e.g. IAccessibleText::get_CharacterAtOffset and the provided offset is in the middle of a multi-byte character, both the start and end offsets need to be adjusted. We can't always assume that only the end offset would need to be changed in order to cover the range that a particular character occupies. R=dmazzoni@chromium.org, kbabbitt@microsoft.com Bug: 720370 Change-Id: I1ce87325da2479b9d8d7085adae8aac41f79f294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888540 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#713882}
-
Alex Moshchuk authored
It is possible for window objects in <webview> tags to have window.opener relationships. In particular, one <webview> can use window.open('', 'foo') to look up another <webview> which has window.name equal to 'foo', and update its window.opener to point to itself. This triggers an UpdateOpener IPC, which ensures that the new opener chain has proper proxies so that 'foo' is able to reach any frame on that chain (see RenderFrameHostManager::DidChangeOpener). Unfortunately, this had a bug because the proxy creation also tried to create proxies for the outer delegate (i.e., the chrome app) SiteInstance, for all frames on the new opener chain, including subframes. This is wrong because we intentionally do not want to expose a guest's subframes to the embedder -- see RenderFrameHostManager::CreateProxiesForChildFrame(), which intentionally skips the outer delegate's proxy. In this case, this later led to a crash in CreateRenderFrameProxy(), because the proxy we tried to create for a subframe didn't have a RenderViewHost (which is intentional -- we do not create a RVH for the outer delegate's SiteInstance, just the proxy, and only for the guest's main frame). This CL fixes this by ensuring that we skip the outer delegate SiteInstance when creating proxies for subframes in CreateProxiesForSiteInstance(), which is used when updating the opener chain as well as more generically (e.g., when creating speculative RenderFrameHosts). This hopefully will better protect against this type of bug in the future compared to a more targeted fix in opener update logic (e.g., if/when we add OOPIF support in GuestViews). Change-Id: I6a2e452883faa140a86523b2afda372c62cbdbcb Bug: 1013553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903245Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713881}
-
Michael Lippautz authored
Pre-finalizers are heavy and not supposed to be used on short-living small objects. Spend an additional word to store the header on registration. This allows inspecting liveness without going through a call on every garbage collection. Bug: 982754 Change-Id: I30a2d60198dd6b2b49febcd49983d17175874dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904177 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713880}
-
Scott Graham authored
On being asked to review https://chromium-review.googlesource.com/c/chromium/src/+/1732329/30#message-bf7d81a19611d7d93e129ac9921dbea9f690ae3e I realized I'm not too up-to-date on the latest Chromium styles, so I should probably remove myself here. Removed cpu@ too, as I don't think he's active here any more. Change-Id: I7bdfa937384c931dbb6d6b5f52d0fefb76296864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906253Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713879}
-
John Z Wu authored
- Turn on kAutofillNoLocalSaveOnUploadSuccess so that uploading a card does not create a local only copy. - Turn on kAutofillNoLocalSaveOnUnmaskSuccess so that unmasking a card does not save a full card locally. - Remove ability to delete cards from Google Pay. - Add menu item to go to payments website. Change-Id: I009ab5b1671320f8eac0c10d7e3c0843a2139c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904541Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#713878}
-
Toni Barzic authored
Change-Id: Ic6231566fbf929d263ce69dcf2437e7650d3d5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904337Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713877}
-
Wez authored
Bug: 999737, 706728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#712377} Change-Id: I627b5250055233ea89718a9143de356c85633add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905270 Cr-Commit-Position: refs/heads/master@{#713876}
-
Aaron Leventhal authored
- Do not call MSAARole() in InternalQueryInterface(). It calls GetParent(), which is dangerous here, because as JAWS responds to the destruction of a Window by releasing some objects, and that can lead to a QI by UI Automation -- However, BrowserAccessibility::GetParent() calls into the render frame host which is already destroyed. In any case we only need to get the role once here, and we can just use the internal role that is stored. - Remove some duplicate conditions in BrowserAccessibilityComWin::InternalQueryInterface() that will be reached in the upcall to AXPlatformNodeWin::InternalQueryInterface() - More consistency in IsImage() across renderer/browser, which allows url to be exposed in more situations. Bug: 1012643 Change-Id: I51808cb0b578f5eceed58168d9ab77494ad65b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903963 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713875}
-
Luke Sorenson authored
Bug: 1022208 Test: Not necessasry. Change-Id: I0a8c0a3b473fec93e13e68583dd0aea52d1c057e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906328Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#713874}
-
Elly Fong-Jones authored
These are part of the 10.15 SDK but are not yet implemented or used in this code. Bug: 973128 Change-Id: I8b34aa764d9501323f97c9650f3e1555cfa89dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906332Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713873}
-
Dirk Pranke authored
PLY has a feature where it'll load a generated lexer table by importing it as a python module. It turns out that we were being inconsistent in how we were generating these modules and that could lead to incomplete builds depending on when the various IDL compilation targets ran. This CL attempts to be more consistent about the generation of the cached files to eliminate that problem, by requiring the scripts to consistently pass in the location of the cached files. We can't really fix this without doing more serious surgery on PLY (or working around it) to be more deterministic in how the cached file is imported. R=dcheng@chromium.org, haraken@chromium.org BUG=1022647 Change-Id: I141059341634633f0df33848638eecc432aa764c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903938Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713872}
-
Alex Turner authored
When creating a new subframe or WebContents with an initial empty document, it inherits the last committed origin of the originating frame. We now also set the Network Isolation Key (NIK) at the same time. Certain subsequent requests are both same-document navigations and the first to result in a call to RenderFrameHostImpl::CommitNavigation, e.g. the last navigation of NavigationControllerBrowserTest. BackAfterIframeDocumentWrite. Previously, requests in such a case could be made without a valid NIK. We also add a DCHECK to ensure the NIK is always set after the call to CommitNavigation. Bug: 1014077 Change-Id: I33e3c223352d6f82fb7849b6be9ce6bd585b96fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872790 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#713871}
-
Sam Maier authored
compression_utils_portable This allows client code to select the wrapper format used which may be faster (e.g. zlib format on older ARMv7 and early ARMv8 SoCs) depending on the application. The wrapper format selection code was partially taken from zlib_bench.cc. Bug: 833361 Change-Id: I8a317e6abc8bd2d66f2e940406badfd7e930e809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904505Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#713870}
-
Mikhail Khokhlov authored
This will help to discover bugs and incorrect Results Processor usage earlier. Bug: 981349 Change-Id: Icd2ba7f2187166b452702681392417ab3ec8e6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904168 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#713869}
-
Aran Gilman authored
Bug: 1017341 Change-Id: I719f13dd45a75783dc919a0f74be996445951be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875481Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#713868}
-
Aran Gilman authored
Change-Id: I47d8314c480b1a3e64a5f8ebb63c97c0af9bf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903759Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#713867}
-
Chris Harrelson authored
Change-Id: Iecc102fca57b21132085671f43e597ae43263bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904618 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#713866}
-
Robert Liao authored
BUG=5027 Change-Id: Iab491d8e238f49c981e026e07fde9de916af82f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904816 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#713865}
-
Fredrik Söderquist authored
(Re)use EventTarget::EnqueueEvent rather than (re)implementing something pretty much identical. Bug: 998526 Change-Id: I79a8d84141e37f485c9b74ee6dc2e4afacda080a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906150 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#713864}
-
Raymond Toy authored
This also allows us to replace base::Bind with base::BindOnce. Bug: 1007798 Change-Id: Iab43f746e3c4507d9b9b7b82e6f58cedcd08faa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904847Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713863}
-
Toni Barzic authored
Enables OverviewWindowDragTest.NormalDrag and ScreenRotationTest.RotateInTabletOverview back, as the use-after-free because of which they were disable has been fixed. Bug: 1021936 Change-Id: I431f8fe4fb1be1eb0f4c8816d9dcb91a42d41ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904160Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713862}
-
James Cook authored
For go/split-settings-sync we want to defer sync of all OS types until the user turned on the feature. Add a user profile pref that enables the feature. Add ModelTypeControllers for OS preferences and printers that observe the pref and use it to enable/disable the their sync via preconditions. The two ModelTypeControllers are very similar but are separate because they have different superclasses. I think trying to create a mixin that could be shared would be more complicated than just having each class have a separate PrefChangeRegistrar. For now the "feature enabled" pref is set via a placeholder toggle button in the OS settings UI. A future CL will tie it to the sync consent that appears in OOBE. Bug: 1013466 Test: added to unit_tests Change-Id: If4e24eea93a103f2cf5fada3771481a7ab843759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904342Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#713861}
-
Yi Gu authored
Tested locally and didn't see the crash mentioned in crbug.com/545547. Bug: 545547 Change-Id: I597c4ae170b3d5297a18472d3e4f1b7923856057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897244Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713860}
-
Chris Hamilton authored
This creates a policy engine that forwards calculated priority values out of the graph, applying the priorities to RenderProcessHosts (and subsequently to the process itself). BUG=971272 Change-Id: I11c8c040e5382a8fa6881c40f80f6885f26e88df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904367 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713859}
-
Greg Thompson authored
This function has historically been opening a file for exclusive r/w/d with FILE_ALL_ACCESS. FILE_ALL_ACCESS is nearly almost never, ever the right choice when opening a file. This is especially true when opening a file from an ordinary non-elevated user session, since it attempts to gain things like WRITE_DAC and WRITE_OWNER and will fail if it's not possible to gain those access rights. A better way to determine if a file is "in use" (and what we really mean is "is an executable that is running") is simply to try to write to it. This is because CreateProcess opens its target with only exclusive write mode (read and execute are shared for obvious reasons). This change also eliminates the exact copy of this function, which included the incorrect formatting from the original, that was used in the unittest. R=gab@chromium.org BUG: 474401 Change-Id: I0488e2a5333f74353f46ae6c87795e2833a30b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905948 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713858}
-
Friedrich Horschig authored
This cl removes an unnecessary break condition that prevented collection for CreditCards. The metrics recorder already supports recording non-password tabs (like addresses) but this artifact prevented recording sheet triggering. Bug: 926372 Change-Id: Ia4a92e06b2c21000ee61aa14a060bb4a521fc360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905687Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713857}
-
Mihai Sardarescu authored
This CL converts all ChromeOS code to use CoreAccountId instead of std::string for the account id. Bug: 959157 Change-Id: Ia27b9e566100ecd7c1ead3a5ca8e46da39e569ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906149Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713856}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c6f1f9af3f4..fc61fb037d2c git log 8c6f1f9af3f4..fc61fb037d2c --date=short --no-merges --format='%ad %ae %s' 2019-11-08 dburger@chromium.org config: mark grunt-unittest-only not important. Created with: gclient setdep -r src/third_party/chromite@fc61fb037d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic9762f94cdd7cbbe558456837496a25508e5b30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906290Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713855}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b14632a5ba8..7eee1a626bd1 git log 3b14632a5ba8..7eee1a626bd1 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 almuthanna@google.com Cover Geometry.js with Karma tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@7eee1a626bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I93fc261f075067df575f9d6b92bada76bb3ed966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713854}
-
Antonio Gomes authored
This CL fixes the clusterfuzz issues reported (see "Fixed" below) by using WTF::Bind and WrapPersistent in RTCRtpSenderImpl::ReplaceTrack. This is a regression from crrev.com/c/1899786, where code used to have a WebRTCVoidRequest wrapping RTCVoidRequest instances (garbage collected). Now that RTCVoidRequest is used directly, we need to properly wrap-persist its instances with WTF::WrapPersistent when passing it to callbacks. Reason: With Oilpan and WTF::Bind, raw pointers of garbage collected objects are not allowed. Fixed:1022558 R=hbos@chormium.org, jbroman@chromium.org Change-Id: I8f0fcf7275c9e07240e3b2e20f89c4cf96c72439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906506 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713853}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2bc811ea07b7..d6b9b0a1f413 git log 2bc811ea07b7..d6b9b0a1f413 --date=short --no-merges --format='%ad %ae %s' 2019-11-08 danilchap@webrtc.org Cleanup MultiStreamTester Created with: gclient setdep -r src/third_party/webrtc@d6b9b0a1f413 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I9b6e4aa2c4f191db79df4e7512a6fe1e6b6874c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713852}
-
Sean Gilhuly authored
Create a Dawn device using D3D12 on Windows and Vulkan on Linux, and use it to create a Skia Dawn GrContext. On Windows, create a SkiaOutputDeviceDawn, which uses a native D3D12 swapchain for presentation. On Linux, use a SkiaOutputDeviceX11 for now, until the Vulkan swapchain is ready. Bug: 1021566 Change-Id: If3e1f435fe87132c9294f5613c85d675a7282b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899200 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#713851}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e6e728c..814c68a9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0fcb4a1600db047f1944680dad357056a00928bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906066Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713850}
-
Robert Ma authored
Manual import because of https://crbug.com/1022519 (with https://crrev.com/c/1904340 applied locally to fix rebaseline-cl) Using wpt-import in Chromium a53cf24b. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases" 85c1bdf8 "Improve scroll to text WPT coverage." a42521dd "Roll WebGPU CTS" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-text/overflow-wrap meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=smcgruer No-Export: true Bug: 1022519 Change-Id: Idb9348b86ecf24b64fa94c79b92565671031a079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904343Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#713849}
-
Mikhail Khokhlov authored
This CL adds some basic support for traces in perfetto protobuf format. The traces are concatenated, converted to json and then processed as usual. For that to work, one needs to build trace processor shell with sqlite and json support, and supply it to results_processor via the --trace-processor-path command line argument. Bug: 990304 Change-Id: If6d7c903813fd1f860e4f11ea98bf22e4b70e057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903144Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#713848}
-
Ian Clelland authored
This adds support for the generalized 'List' syntax in https://tools.ietf.org/html/draft-ietf-httpbis-header-structure-13. Since some types have changed slightly between revisions, the parser now takes a version parameter on construction, which can be used to switch between draft 9 (for compatibility with existing Web Packaging deployments) and draft 13 (for new headers). Bug: 1011101 Change-Id: Ie8a76384430f5319e1d564e51f4f62af7c0ada7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872764 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713847}
-
jonross authored
A recent change to support mixed Vulkan implementation and GrContext led to requiring an additional flag to enable Vulkan as the GrContext. It looks like one test suite was missed in that update. TEST=vulkan_content_browsertest Change-Id: I6474e113d45d3854edd67ec704a6704161585a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901800 Auto-Submit: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#713846}
-