Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Dec, 2020 37 commits
  3. 16 Dec, 2020 3 commits
    • Koji Ishii's avatar
      Remove NGPaintFragment · 075dfec2
      Koji Ishii authored 
      Also removes some references still in the code. Calls to these
references were already removed.

The runtime flag for |NGFragmentItem| is still in the code.
Removing it will be in following patches.

Bug: 1154531
Change-Id: I98fa03d124d8f7684b3974eae2c6e6b82d38e25b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589576
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837819}
      075dfec2
    • Collin Baker's avatar
      Replace ThumbnailImage::Observer with Subscriber · e4a4b7a3
      Collin Baker authored 
      Previously, clients interested in seeing thumbnail updates had to
derive from ThumbnailImage::Observer and register themselves with
ThumbnailImage.

Removing ThumbnailTabHelper and ThumbnailImage from the public API and
instead exposing a global ThumbnailService is a design
goal. ThumbnailImage::Observer makes this refactor difficult.

This CL uses a callback-based subscriber model instead.
base::Callbacks replace observer methods. Hints are supplied
directly on the subscription object. The subscription models loosens
the coupling between clients and ThumbnailImage.

Clients subscribe by ThumbnailImage::Subscribe(). Subscription can
later be pushed up easily to the ThumbnailService level by a method
like ThumbnailService::Subscribe(content::WebContents*).

Bug: 1090038
Change-Id: I020d848e00331d5f5bbb562f0c53aec5f8ccbc62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593158Reviewed-by: default avatarDana Fried <dfried@chromium.org>
Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837818}
      e4a4b7a3
    • Jimmy Gong's avatar
      Phone Hub: Don't process incoming notifications if notifications are disabled · 3ad33407
      Jimmy Gong authored 
      If the user opts out of displaying phone notifications we should not
attempt to process any incoming notifications. This change adds an
additional check to ensure that notifications are allowed before
processing any new incoming notifications.

Fixed: 1158612
Test: chromeos_components_unittest
Change-Id: Idfa464dd0dcc4e4ee225ebb4405a0da3c87d8f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594563
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837817}
      3ad33407