GitLab

Rename sim-detect-page to setup-loading-page and update UI to be used
for both psim and esim flows.

Bug: 1093185
Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827473}

This is in preparation of splitting RulesetSource class into a
RulesetSource base class and a FileBackedRulesetSource derived class.
This will be useful for implementing session scoped rules which are not
file backed.

BUG=1043200

Change-Id: Ia099b9f180408d4b3518c4f80d41ec312d5f740f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495875
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827472}

This CL improves the error messages for array parse failures in
generated code.

BUG=1113513

Change-Id: Ic1edfab5e005f363b8670b1f798a241673b856ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520799Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827471}

Replaces remaining CalculatePreferredSize() overrides that are used to
unconditionally set a specific fixed width.

Bug: 1128500
Change-Id: I93abc6b85be7fa956e65608819806aaac23d8d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538131Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827470}

This reverts commit 34bf7349.

Reason for revert: Failing SingleRulesetTest.SessionRules unit_tests on multiple platforms:

https://ci.chromium.org/p/chromium/builders/ci/win-asan/15627
https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17985
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110233

Original change's description:
> DNR: Add initial implementation for [get/update]SessionRules.
>
> The session rules are not indexed and evaluated yet. This will be done
> in a follow-up.
>
> Skipping presubmit since this seems to be hitting crbug.com/956368.
>
> BUG=1043200
> Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only)
>
> No-Presubmit: True
> Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827418}

TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org,kelvinjiang@chromium.org

Change-Id: Ibdd5c17fb41abc19809fb9fe7224c1ecdd30c1ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1043200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537185Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827469}

Previously, ImageReaderGLOwner created a ScopedJavaSurface that did
not call Surface.release() upon destruction.  Unfortunately, this
meant that nobody called release().

This was never noticed because we also leaked the Surface object,
so it was never finalized => no helpful diagnostics.  After

https://chromium-review.googlesource.com/c/chromium/src/+/2453270

the leak was fixed, but now the lack of release() caused strict-
mode violations.

This change switches ImageReader's ScopedJavaSurface to call release
properly. It's safe because CodecSurfaceBundle makes sure that the
surface outlives the MediaCodec instance that's using it.

This change also reverts

https://chromium-review.googlesource.com/c/chromium/src/+/2527563

which replaced the leak-the-surface behavior intentionally,
as part of the investigation.

Bug: 1146071
Change-Id: Ib8187530299ba7790e30e630250cc2a7fd4eebf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537782Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827468}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33eec64159df..07569638a739

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sclittle@google.com,adithyas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1115463,chromium:1119406,chromium:1147179
Tbr: sclittle@google.com,adithyas@google.com
Change-Id: I047fca48aab5d00503ef3edfddfe3872908f9b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537031Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827467}

This reverts commit 56334b9e.

Reason for revert: causing a bot to crash see crbug.com/1148972

Original change's description:
> Add CriticlaPersistedTabData to fieldtrial_testing_config
>
> This was determined to be necessary in cl/342061697
>
> Bug: 1148823
> Change-Id: I125e177fa057e6aebd92a0750559e4a68940c312
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537699
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Commit-Queue: David Maunder <davidjm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827346}

TBR=mpearson@chromium.org,davidjm@chromium.org

Change-Id: I7238b95d7e0577f6d5797fe500a3031d5e7f5960
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537003Reviewed-by: David Maunder <davidjm@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827466}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Idc00f2369a9496d35ac7e3f775b1ded9dd2703a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537000Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827465}

playerIDs were getting added to dead players, then removed from the
player map - when it came time to delete players, the dead players
tried to be removed again. Looks like CF was running without DCHECK
enabled, so it never hit the check for iter != players_.end().

Bug: 1148757
Change-Id: I13486c59ec362b023ddbf93462d359bec7707512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537789Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827464}

This was only needed for testing, but tests can start a test server and
have all names resolve to 127.0.0.1.  In this case, a little additional
work is also required due to the HTTPS requirement.

Bug: 819406
Change-Id: I07af6e568a53e1eda54e5d553d05001b2a12a213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536071Reviewed-by: Elad Alon <eladalon@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827463}

This reverts commit 28c8eb1a.

Reason for revert: This CL seems to have caused SitePerProcessBrowserTest.ScrollBubblingFromOOPIFTest to become flaky. Sorry for reverting such a big CL, but please fix and reland. See:

https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4495
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4494
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4491
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4475
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21297

Original change's description:
> Convert FrameHostMsg_SynchronizeVisualProperties to RemoteFrameHost message
>
> This CL migrates FrameHostMsg_SynchronizeVisualProperties IPC message
> to RemoteFrameHost Mojo interface. To do that, this CL moves
> FrameVisualProperties struct from //content to //blink. Then, this CL
> introduces SetSynchronizeVisualProperties function in WebRemoteFrame
> class in order to make RenderFrameProxy::SynchronizeVisualProperties
> call SynchronizeVisualProperties in blink.
>
> Bug: 1093956
> Change-Id: I38088e71df5d1d7743c6ec1826b17301b6bc57b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376766
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827199}

TBR=kinuko@chromium.org,haraken@chromium.org,dtapuska@chromium.org,gyuyoung@igalia.com

Change-Id: If0cea40964f6f7d417e9aceb9d8505bac2d7764a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535812Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827462}

If one unchecks the checkbox in the QR-scanning dialog, the phone is no
longer linked to the desktop.

BUG=1002262

Change-Id: I9c6d97637ba5361b6d1f24f4d270f172d7e15363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527888Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827461}

This reverts commit 3846b220.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 827420 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM4NDZiMjIwMzIxYTRlYTM3MWJiNmE0NGUzYTEyN2NmNjllZTUyNDEM

Sample Failed Build: https://ci.chromium.org/b/8863709088659159040

Sample Failed Step: compile

Original change's description:
> Split the updater IDL file.
> 
> The IDL file is split in three parts: public, internal, and legacy
> definitions.
> 
> This is a fairly straightforward change, which consists of suffixing
> the path to the typelib in the executable file with a //<index> where
> the index matches one of the there source IDLs above.
> 
> Further work is needed to properly generate the GUIDs depending on
> the which IDL the GUIDs belong to. Some of the GUIDs must depend on
> branding, and some of the GUIDs must depend on branding and version.
> 
> 
> Bug: 1140562
> Change-Id: I6030977d3961ff24bbc8bc33392415d59884feec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527822
> Reviewed-by: S. Ganesh <ganesh@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827420}


Change-Id: I3821d3b2bb496016035c7192a1d3c3c7eb672e63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1140562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537122
Cr-Commit-Position: refs/heads/master@{#827460}

A potential fix landed for the flaky "Connection aborted" issue in iOS
(See bug). Enable ResultDB on some fyi builders to verify the fix:
  * ios-simulator-multi-window
  * ios14-beta-simulator
  * ios14-sdk-simulator

These builders are not monitored or already have failing suites.

Bug: 1136998
Change-Id: I30577514f365c676c9e5d22143bc08b104499ca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536932Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827459}

Most of the failures to stop a DIAL session is because the session no
longer exists. So we query for the app's current status, and if it's not
running, we remove the corresponding route.

Bug: 1141714, b/158693455
Change-Id: I71e9770d1188861c37bce996fedf30461a0f9bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492918
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827458}

When the browser is controlled remotely over the pipe,
and the pipe is disconnected, there is no way left to
control the browser. Every pipe client tries to kill
the browser at that point. Instead, we can just shutdown
normally, leaving no core dumps.

Change-Id: Ib03a727930b00f48a6869c12c66c86072d45b5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536354
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827457}

This change updated the 'Upgrade' logic in the CRD host WXS file
so that it no longer blocks downgrades.  I've run through several
upgrade and downgrade scenarios and it looks like everything gets
cleaned up and re-registered correctly with this change.

I looked into a few options to constrain the version window where
downgrades are allowed.  I think the most promising would be to
add a wxs param which takes a 'max_downgrade' var based on the
'chrome_version_full' + max version skew and use that for
blocking downgrades.  I'm not convinced this is necessary though
since we don't have any version checking for our MacOS package
and we haven't had any issues related to downgrading when using
Keystone.

Bug: 1148967
Change-Id: I4b36541ff901eb10f4c26c7652654f43f77762c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538202
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827456}

Ideally this conversion should happen in the XR service and off the JS
thread, but that's an optimization that can happen later. The actual
conversion may need some tweaking in the future, for things like better
tone mapping, but for the time being this gives a usable result.

Bug: 1147569
Change-Id: I0407eee6e4c8337bd376bd43ca0f32987a471055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535915
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827455}

Parse the existing icon_index of the
shortcut icon to preserve when the shortcut
is being reset.

Bug: 1116017, 1148962
Change-Id: Ia6528161bf4302e7abb5c5223c238ddb31856791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536033Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827454}

We were previously using file storage until LevelDB storage was
available. LevelDB storage requires a profile so some tweaks were
made to PersistedTabDataConfiguration. One of which is the factory
pattern was used to ensure we acquire LevelDBPersistedTabDataStorage
based on the current profile and that we only have one
LevelDBPersistedTabDataStorage instance per profile.

Bug: 1129626
Change-Id: Ia1f14c9c2b6f2da02bac27ccd255152e45a4218c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533843Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827453}

https://webrtc.googlesource.com/src.git/+log/c4ad6062fd17..f42a94a7f50d

2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6e17f939..5cee6c65 (827170:827322)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I8aa5d6c4aabcf8e85d7b81cb4926f71ccff42978
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537056Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827452}

It doesn't need to be done for each profile in the multi-profile
session restore case, since --app-id should always have an associated
--profile-directory, since apps are profile-specific.

Bug: 1132578
Change-Id: I1a898b2b911c8962dd6400fc821d4b05cf85fb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520220
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827451}

Also removing static_cast accidentally left in previously.

Bug: 1128169
Change-Id: Ica92357953149aa19bdb2ffc300f81363662fe94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537923
Auto-Submit: Jonathan Freed <freedjm@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827450}

Spec isn't clear on this, but when we are doing short term ref pic sets
that are relative to existing ones, these can keep chaining and then
grow their size without bound. Seems reasonable to constrain this value
for the delta based ones just as for the fully declared ones.

Also fixes range validation for cpb_cnt.

Also fixes zero valued NumPicTotalCurr.

Also fixes overflow in SPS parsing.

BUG=b:153111783,chromium:1148504,chromium:1148698,chromium:1148863,
chromium:1148910
TEST=Fuzzer no longer crashes

Change-Id: I430f1fe2d4e4e5affe6caea80be6d01b84896b14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536851Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#827449}

This reverts commit 5d6ecbfb.

Reason for revert: expected to be causing ui.ShelfLaunchedApps flakes
"Unexpected apps in the shelf. Expected only Chrome"
from:
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/47952
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863730536929393584/+/steps/chrome_all_tast_tests/0/logs/Deterministic_failure:_ui.ShelfLaunchedApps__status_FAILURE_/0


Original change's description:
> CrOS: Add Files app to default shelf pins in second position
>
> This adds the Files app to the spot after the Chrome icon, for new users
> only. There's also some variations of the default pin layout controlled
> by a Finch experiment, I've moved the Files app up in those layouts for
> consistency.
>
> This change was requested for M88 and will be merged back.
>
> Bug: 1148519
> Change-Id: Iae54561fec599b813ba97e82a5678fa834a02db2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537214
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827272}

TBR=xiyuan@chromium.org,tsergeant@chromium.org,dominickn@chromium.org

Change-Id: Ic86ed4ca44b70a2357395be9a44f5ace6997bd14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1148519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538145Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827448}

print-preview-destination-dialog is being forked for Chrome OS, but
the invitations logic is largely the same across platforms. Moreover,
this logic is unlikely to diverge going forward, given that cloud
print is deprecated. Split out invitation promo UI and invitations
logic into a new invitation-promo element.

Bug: 1148906
Change-Id: I51f4013867808748ffa9f39c9c8613019bc9fe5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536041
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827447}

Bug: 1148885
Change-Id: Ic517dddf9d4521cbe5b7338b47d74f84e251ee3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537935Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827446}

Some client resources (video, etc) will need to wait on a ResourceFence
before returning them to client. That fence is released when all GPU
work for the root render pass are finished on GPU. However, on macOS,
there isn't a root render pass for every frames, and all related client
resources will never be released. To fix the problem, we have to release
the fence for each GPU tasks (drawing non root render passes, drawing
render pass overlays, etc).

Bug: 1143042
Change-Id: I335e4a7c4a36557315cede7edd834b028c7b015d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537112Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827445}

- supply CaptureParams as an argument of IsCaptureAllowed().

Bug: 1145606
Test: Manual test
Change-Id: If73b39eff906ce1b44253522aedcde69bab444fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530290Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827444}

This CL further improves the algorithm of color selection to:
 1) Disallow colors with very low saturation (currently the first line
    in the color picker).
 2) Prefer colors with lightness similar to the lightness of the current
    profile (this disallows the very dark colors for the very light
    colors and vice versa).

Bug: 1108295
Change-Id: I3adcc347b84285d5d2659f1972f075e992e0bebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532565
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827443}

Enables intervention by default in the Chrome binary, and removes
it's associated testing config which is no longer needed.

Bug: 959849
Change-Id: I5963aebd84894a94d37af053a99b8050394f3426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535550Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827442}

When a cancel completes, run the cancel callback instead of the
completion callback. This prevents clients from having to wait for and
handle two separate callbacks when canceling a scan.

Bug: 1059779
Change-Id: I80083a1aed002abbdbf117ddad527c531e32bfba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537052Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827441}

1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
3. Set `hide_scrollbars` to avoid artificial scrollbars.
4. Set `record_whole_document` to force the whole page to be rendered.
5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".

Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37

Screenshots:

- Before: https://i.imgur.com/yt6WZRx.png
- Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
- Patchset #3:
  * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
  * https://imgur.com/MXpgHOl
  * https://imgur.com/haxemcr - not aligned with the node.
  * https://imgur.com/RbdlYVT
- Patchset #18:
  * https://imgur.com/EWUmn0O
  * https://imgur.com/DUrQ1yF
  * https://imgur.com/cT5oBSi - perfectly aligned.
  * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).

Bug: 1003629
Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
Commit-Queue: Maksim Sadym <sadym@chromium.org>
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827440}

This CL queries the driver for the encoding quality range and, if
available and the device is considered "low power" (celeron, pentium
and Core -Y devices), sets it to its maximum value, for highest speed
and lowest power consumption, albeit at lower encoding quality. The
quality difference should not be noticeable for video conference
scenarios.

I followed the code in both of Intel's VA backends.
For the legacy i965:
- VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least
 this CL can supersede the patch in [2] which is what it was set off to
 do).
- AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7
 see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only
 available in Gen9+ FTR).

For the modern intel-media-driver iHD, values are configured with
names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines).
By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be
TARGETUSAGE_BEST_SPEED.

Improvements depend on the input content. I measured kohaku with
EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with
this CL I see ~220 fps, 4.42W.

[1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151
[2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36
[3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142
[4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149
[5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76
[6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599
[6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653
[7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333

Bug: b:141147405
Change-Id: I7e5c54f1e5a7ac7a51c5503f37168db16f9e99f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344526
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827439}

Max suggested I join components/payments/OWNERS :)

Also update the component since UI>Browser>Payments was removed in favor
of Blink>Payments.

Change-Id: I604bb739dab79bc13652993299bca7e839fd0421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536900Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827438}

This reverts commit 9912841b.

Reason for revert: The linker has started segfaulting consistently: https://ci.chromium.org/p/chromium/builders/ci/Mac%20Builder/124684

Original change's description:
> mac: Use response files instead of -filelist, but just a little bit.
>
> This is a partial reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/2530350
>
> For reasons not yet understood, that change sometimes makes the
> linker segfault -- but only hours after it goes in. But once it
> happens, it's sticky.
>
> So reland a smaller version of this change to see if it still happens.
> - Use `-Wl,@rsp` instead of `@rsp` so that the clang driver doesn't
>   read the response file just to write it out again -- instead we
>   pass the response file to the linker directly for now.
> - Only put {{inputs}} in the response file for now, not yet
>   {{frameworks}} {{swiftmodules}} {{solibs}} {{libs}}
>
> Bug: 1147968
> Change-Id: If5c03c881e2469fa2a3c1d3297975ef4c3d19587
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538011
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827424}

TBR=thakis@chromium.org,brettw@chromium.org,mark@chromium.org

Change-Id: Ibdb3f64f745e89d63ab5df2dec2c6bda55bdf7d7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538177Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827437}

Roll Chrome Win64 PGO profile from chrome-win64-master-1605255855-dc6a80021d99bde94e7af4afa11767b88ac6fee3.profdata to chrome-win64-master-1605268075-daeeb1bc6080c8b4d9f48b3dab7bc22bf5a02dcb.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie1a82ebeb7d6021f9550c82363074eeab4f13459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538091Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827436}

- Added WheelEventRegions runtime feature flag.
- Changed mouse coordinates in wheel-event-target.html test to
  accommodate for rounding per [1].
- Changed wheel event handler region in layer-scroll-rects-get.js
  to enforce not empty wheel handler region.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/graphics/paint/paint_controller.cc;l=49;bpv=1;bpt=1?q=RecordHitTestData&ss=chromium%2Fchromium%2Fsrc

Bug: 1136588
Change-Id: I437c87d7c8a53f107f676b647d737ce1de7827f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521354Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sam Fortiner <samfort@microsoft.com>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#827435}

BUG=1146734
TEST=Ran locally.

Change-Id: Iba08d7f3c205c023b3b93b15e8e49f50ce3d5424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536577Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827434}