- 09 Nov, 2020 40 commits
-
-
Scott Lee authored
Re-enable SinkAPI-integration on blink_web_tests. A patch was made in https://crrev.com/c/2519885, and sample swarming tasks show that blink_web_tests with the SinkAPI integration ran acceptably fast enough, compared to it without the integration.. R=bsheedy@chromium.org, chanli@chromium.org,dpranke@google.com CC=robertma@chromium.org,bpastene@chromium.org,nodir@chromium.org Bug: 1141606 Change-Id: Ibb45d081f8d2fd869f2632da066fb461c641b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523747Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825415}
-
Mark Pearson authored
It seems to be flaky. TBR=marq@chromium.org BUG=1146303 Change-Id: Ibaa9ea626a6179af72a1b98d5660f990b3390f1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526608Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825414}
-
James Vecore authored
NearbyConnectionsManagerImpl holds a raw ptr to the PayloadTracker and it was not being cleaned up in all cases when the PayloadTracker was destroyed. Fixed: 1145726 Change-Id: I62321c6f9316b4af504d2db01dfa55c871d4c0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523917 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#825413}
-
Asanka Herath authored
Previously the Privacy Budget project added a tool to generate a list of APIs along with enough information to keep track of which ones have been marked with `HighEntropy`. This CL replaces that tool with one which captures a bit more detail about APIs. Bug: 1144960 Change-Id: I281b713839bf22e38d1963a54290f891dcd624ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515283Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#825412}
-
Christian Dullweber authored
Also add render test. Bug: 1146983 Change-Id: I3c411741e9043ff780708bed3a49e07b4a197453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526443 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825411}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/40c5e53e7bba..9217d49db032 2020-11-09 m.maiya@samsung.com Vulkan: Add EXT_external_buffer entry points If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4d781ed887956e4f7360f7fa285203a0d29fec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825410}
-
edchin authored
Change-Id: Id54a2d8ce9f5054eb4479e345568e93665133d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523673 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#825409}
-
Joey Arhar authored
This is the same issue/fix as crrev.com/703403 but for mac. On mac WebPagePopupImpl::HandleKeyEvent is called instead of WebPagePopupImpl::HandleCharEvent, but I'm not sure why. fast/forms/color/color-picker-no-tab-character.html should have already been testing this, but when the test is run on mac it doesn't actually insert tab characters into the input elements, which does happen when testing it manually. After doing much debugging, I wasn't able to figure out why, but I did find that keypress events are another observable side effect which happens in parallel with inserting tab characters, so I added a check for it to color-picker-no-tab-character.html as a test for this change. Fixes: 1146693 Bug: 1011168 Change-Id: Ib395fdad80d92452158c867bafb867e8db08e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524290Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sanket Joshi <sajos@microsoft.com> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825408}
-
Roman Arora authored
polymer_bundled.min.js file size increased by 10 bytes. Fixed: 1147095 Change-Id: Ic56ea90e44aff3aca19701db461451af93c1e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527185 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#825407}
-
Michael Checo authored
- Options are sorted alphabetically (http://shortn/_nYkelby30A) - "Default" will be displayed before scanner capabilities are loaded or when the scanner does not report any sources. - A follow-up CL will update "getSourceTypeString_" to return localized strings. Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I148e720ae3345baa069c385f6a977d8d90e809a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508366 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825406}
-
Mark Yacoub authored
1. Extend Mock DRM Device to get a count of test | modeset and modeset commit flags. 2. Test of the expected number of test modeset and commit modeset on displays enable/disable. BUG=b/172622447 TEST=ScreenManagerTest.{CheckWithNoControllers, CheckWithValidController, CheckForSecondValidController, CheckControllerAfterDisabled, CheckMultipleControllersAfterBeingRemoved, CheckMultipleControllersAfterBeingDisabled} Change-Id: Iac4b1fae4119677dad19b904ff6b1923d18b6a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526944Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#825405}
-
Gauthier Ambard authored
This CL makes sure that when the application doesn't start a new navigation when an error occurs while loading a session restoration page. Fixed: 1138895 Change-Id: I9d0b4558ddccf3f53f9dd8dd7d671434b31f1d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520896 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#825404}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=caseq@chromium.org Change-Id: Ic1010c21616f2349627b9219907376b419d85871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526941 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#825403}
-
Nico Weber authored
Still far from working though. Bug: 1147069 Change-Id: Ie6d519915076fe774c3a2af5fc4e089a6681eb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526911 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825402}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I939c65d12c4f1ecbc840d0f6fe9d13fae3f861ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526446Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825401}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3e17e33724b4..0053fef8a47d 2020-11-09 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 8655b62207a5 to 7b750dc7337d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I1951967c5c144c2dde7f8cdb56b9ba6c2e9d6c5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825400}
-
Illia Klimov authored
Bug: 1142548 Change-Id: Id0275f770fb2ffa2070438a1d16581d725937fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517492Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#825399}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/8655b62207a5..7b750dc7337d 2020-11-09 bclayton@google.com wsgl parser: Prefix methods with `expect_` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sarahmashay@google.com Change-Id: Ib70bb2c765bf960b5bc34cfcf89062ea85971e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525874Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825398}
-
Clemens Arbesser authored
With this change, LiteScriptShownToUser and LiteScriptFinished UKM metrics will now be recorded with the native coordinator. Unfortunately, the other two metrics (LiteScriptOnboarding and LiteScriptStarted) are still in Java for now. Recording the UKMs in native allows for better unit tests and tighter control of when to emit those events. This CL also fixes a bug which surfaced during testing: navigation events while the web_contents are invisible should be ignored. This CL does not add any new UKMs. The existing set of UKMs was approved in crbug.com/1110887 in the privacy section of the design doc. Note that this is not yet hooked up to prod. The relevant CL is currently under review, here: http://crrev/c/2524524 Bug: b/172548211 Change-Id: I93cdfc2ac52a33d63247f967063d34a353924833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521810 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#825397}
-
Chris Sharp authored
No-Presubmit: true Bug: 1146426 Change-Id: Idaca0e26e8414d42ffccfccdd8e2a95cf2363770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522235 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#825396}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/e62aab7101b7..7a74e09cab5e $ git log e62aab710..7a74e09ca --date=short --no-merges --format='%ad %ae %s' 2020-11-06 wub Add big red button to disable QUIC TLS resumption. 2020-11-05 danzh Fix compilation issues on gcc and windows. 2020-11-05 wub Deflaky Bbr2DefaultTopologyTest.SimpleTransfer2RTTAggregationBytes by increase the margin on smoothed rtt. 2020-11-05 wub Internal QUICHE change 2020-11-05 haoyuewang Internal QUICHE change 2020-11-05 fayang Mark gfe2_reloadable_flag_quic_split_up_send_rst chrome_value false. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: I220af7c164513ebd33ea32c52e4030ab96d6138b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526162 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825395}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c149740458bb..095896a516a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1078229,chromium:1128249,chromium:1137401,chromium:1146894,chromium:897470 Tbr: bcwhite@google.com Change-Id: Idbdca6efcec1d02e15c15aa525dbe5b9710ef2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526604Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825394}
-
Vladimir Levin authored
This patch makes the property not animatable. This goes with the proposed issue here: https://github.com/w3c/csswg-drafts/issues/5708 R=futhark@chromium.org, chrishtr@chromium.org Fixed: 1146181 Change-Id: Ia352f2c5aab324b1426dd68c00d4d92ea0e760c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526901Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#825393}
-
Jan Wilken Dörrie authored
This change adds a new TrackAutofilledElement() API to FormTracker, allowing it to track elements that have been autofilled following a user trigger. Bug: 1140497 Change-Id: I4a772a01dfc33315be3110e17db1d169b834ead7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517533 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#825392}
-
Dominique Fauteux-Chapleau authored
This adds fields in ContentAnalysisResponse::Result for malware_family and malware_category, and corresponding fields in reporting events. This should be removed once a better propagation for this info is agreed upon. Bug: 1147036 Change-Id: I0a74882830d5c4799fd5007e4aa3a8cee30178eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526163Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825391}
-
Arthur Wang authored
This reverts commit 969fb156. Reason for revert: The test fails because of a timestamp difference. Now we approved the new reference image and test should be stable by now. Original change's description: > Reland "
🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" " > > This reverts commit d8ad718b. > > Reason for revert: Goldens break every day as they contain information relative to current time. Needs updating before they will consistently work. > > Original change's description: > > Revert "🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" " > > > > This reverts commit 1d9e3ca2. > > > > Reason for revert: Updated golden images, test should now pass > > > > Original change's description: > > >🤠 Revert "enable FeedNewTabPageCardInstrumentationTest" > > > > > > This reverts commit 46de280d. > > > > > > Reason for revert: still flaky. > > > See https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/707 > > > > > > Original change's description: > > > > enable FeedNewTabPageCardInstrumentationTest > > > > > > > > Bug: 1143781 > > > > Change-Id: Ic7c1adad83cb472aeaeb8e82534288184a89d544 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518183 > > > > Reviewed-by: Dan H <harringtond@chromium.org> > > > > Commit-Queue: Arthur Wang <wuwang@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#824229} > > > > > > TBR=harringtond@chromium.org,wuwang@chromium.org > > > > > > Change-Id: I9ccace6afc3b4193000d094392c78468887a6249 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1143781 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519975 > > > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > > > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#824385} > > > > TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org > > > > Change-Id: I632bfabe8eacccec82dbd00d231569398f809b2c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1143781 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520812 > > Reviewed-by: Dan H <harringtond@chromium.org> > > Commit-Queue: Dan H <harringtond@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824433} > > TBR=arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1143781 > Change-Id: Ia9f3b45b0f1924e809e95a0f7112b14237350623 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526943 > Reviewed-by: Sky Malice <skym@chromium.org> > Commit-Queue: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825372} TBR=skym@chromium.org,arthursonzogni@chromium.org,harringtond@chromium.org,wuwang@chromium.org Change-Id: I60704b1368d4db93cca89fe2cedb6aa7cf9d5c3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527361Reviewed-by:Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825390}
-
Dominik Lang authored
Memory snapshots were missing process id data so the trace processor couldn't fill process_memory_snapshot table properly. Bug: 1098746 Change-Id: Id2341d81581624a07b8079fc2e08f9495479de9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522070 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#825389}
-
Michael Checo authored
Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: I6f4681eb55b73449794384ebae3f1e873eec6550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523238 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825388}
-
Yu Han authored
Prior to this CL, the outline focus color is gray outline. This has been updated to white color based on the UX review. Bug: 1146384 Change-Id: I6506f5116916087f5edc4fbf9a954c8b8310078d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524826Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825387}
-
Eugene But authored
- Remove "get" prefix us unnecessary, because method returns value directly - Return error from ChromeEarlGreyAppInterface and assert that error is nil inside ChromeEarlGrey. This way the test will fail and print the error onstead of relying on caller to do the right thing. Bug: None Change-Id: I1d52347ae48b998b29e6a59d037f3adbbf5025b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521840Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#825386}
-
Judy Wang authored
This CL removes the feature pod on lock/login screen. R=shidi Test: Manually tested on DUT. Bug: 1134315 Change-Id: I6afea7f835989fa1147e5d70d5cf770b185d441b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503831Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Judy Wang <shidi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825385}
-
Chris Sharp authored
Don't add a default roaming profile location, so this feature will only work when RoamingProfileLocation is set as well. BUG:1145172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#823795} Change-Id: Ib90c9e8b81577514d842f5790b326ccef4e1b191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520245 Cr-Commit-Position: refs/heads/master@{#825384}
-
Nohemi Fernandez authored
Adds title field attribute to that will allow InfoBar overlay in iOS code to set both a title and subtitle in its message. This is required in some instances where the required notification provides a title as will be the case for sign-in account notifications. Approved UX Design: https://docs.google.com/presentation/d/1tgAFQVKEUd-NcxyJhs6ZNqEu9j4QvX3-S_1wH9sU55k/edit#slide=id.ga6d0dd7c46_0_709 Bug: 1145592 Change-Id: Ic10bc8ed01f93f471e39c558dc09295d4257308c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521619 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#825383}
-
Dave Tapuska authored
Convert this message to a mojo message like ClearCache. The associated channel can be bound when the AwRenderProcess object is created because it doesn't need to be in the Ready state for it to get attached. Likewise this object will be deleted when the render process terminates so it doesn't need to worry about rebinding the mojo channel. BUG=1146490 Change-Id: I2e3d6888debf85570117ba79fece34530fa12b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522961 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825382}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62efc005477d..e42693daf419 2020-11-07 ythjkt@google.com merge_logs: Update SysInfoPatterns to UTC timestamp. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib6d9eba34faa349ababa5ddadba476e6aaffb47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525863Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825381}
-
Thomas Lukaszewicz authored
This CL adds the following metrics: - Time taken for the Tab Search bubble to become visible after construction. - Time taken for the TabSearchPageHandler to be created following construction of the WebUIHandler. Bug: 1099917 Change-Id: I0350cd69926e01a297de131b00a8cc324ba8873f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498835Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#825380}
-
Jeffrey Kardatzke authored
This is an additional header file for using libva in protected content mode that was supplied by Intel. This will not be merged into libva directly as it pertains to closed source functionality in the iHD driver. libva is able to pass through these details without knowing about them. BUG=b:153111783 TEST=None Change-Id: I10759537cd653e9a541b30931c6474c014dbb256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523100Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#825379}
-
Dave Tapuska authored
Since WebFrameWidgetBase is now a PageWidgetEventhandler we can deduplicate some of the input handling code. The remaining methods have a few fundamental differences in them and will need to collapse them. BUG=1097816 Change-Id: Id5bbeb435b9b0ed698c9644ed5b44e39844ed39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523335 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#825378}
-
Nico Weber authored
Follow-up to https://chromium-review.googlesource.com/c/2277455 Bug: 1098899,1147069 Change-Id: I240ea9caf53a62a632376fed45b0e488758c1305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526924 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825377}
-
Sky Malice authored
Bug: 1135799 Change-Id: I15d6bb6b866ce40c573eb251c53390229e26c541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499167Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#825376}
-