- 25 Sep, 2019 40 commits
-
-
rbpotter authored
There are a number of externs files for closure compiler that are autogenerated from files in chrome/common/extensions/api/ or extensions/common/api/ that do not have PRESUBMIT checks. Add checks for these files. Bug: None Change-Id: I9df36c4ef819244287c13538d28c765f9aba78cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815986 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699975}
-
rbpotter authored
Autogenerate the resources_private.js externs file, and update pdf_viewer.js to use an enum from the new autogenerated file. Bug: 721073 Change-Id: I177d3b229f27555bf811abc7087321606f412fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811499 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#699974}
-
kylechar authored
GPU.GPUChannelHostWaitTime.MicroSeconds records the amount of time the browser main thread spends blocked on sync IPCs to the GPU. This is measuring the same value as GPU.GPUChannelHostWaitTime but with different bucketing. GPU.GPUChannelHostWaitTime only cared about large values and we do not wish the change the existing bucketing for it. Bug: 1006924 Change-Id: I55447d3bd54cb7b24c84a6a4f5613880683cf571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816960 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#699973}
-
Jonathan Ross authored
This reverts commit 9747ecdd. Reason for revert: This is potentially crashing vulkan_blink_web_tests on Intel. A failure of one test in the following run, lead to a crash of the entire test suite: https://ci.chromium.org/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20%28Intel%20HD%20630%29/1639 Original change's description: > linux: Enable Crashpad for content shell > > Bug: 942279 > Change-Id: I221431e352f11b40c3bc39bbcd8297b431dd8f0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763346 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699880} TBR=jperaza@chromium.org Change-Id: I117aa67f345510a5eb9ae77ec60ea5122ac12b16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825920Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#699972}
-
Nektarios Paisios authored
According to the Mozilla Developer Network, the value attribute of an email field, or the value attribute of any other field that includes user-specified validation logic, doesn't always contain what the user has typed into that field. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/email#Validation The value attribute always contains the sanitized text. For example, if there are spaces at the start of an email address, they will be removed. Both the DOM and the AX selection logic in Blink work on the inner text contents of the field and not the sanitized value, so we have to switch to exposing the inner text contents of all input and textarea fields in the accessibility tree. Otherwise, caret and selection offsets between the inner text and the value attribute will not match. R=dmazzoni@chromium.org, dtseng@chromium.org Bug: 1007454 Change-Id: I0ae2125ddd716a84a9ae06557c0f9431a4007b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825166Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699971}
-
Sergey Ulanov authored
This reverts commit a2c0ced3. Reason for revert: Fuchsia doesn't provide enough protected memory. https://fuchsia-review.googlesource.com/c/fuchsia/+/322346 was reverted. Original change's description: > [Fuchsia] Reenable protected mode in WebEngine > > Bug: 982922, fuchsia:24570 > Change-Id: If9fb495249488c43f97e4451a14f0193911d600f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697683} TBR=sergeyu@chromium.org,emircan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982922, fuchsia:24570 Change-Id: I7f52d2fbfdabc14de398df68409dfd6d07f1fc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825725Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699970}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/693460a3a7b7..f57843cb20ee git log 693460a3a7b7..f57843cb20ee --date=short --no-merges --format='%ad %ae %s' 2019-09-25 thestig@chromium.org Reformat radial shading pixel tests. 2019-09-25 thestig@chromium.org Add an axial shading pixel test. 2019-09-25 thestig@chromium.org Fix nits in CPDF_RenderStatus. 2019-09-25 thestig@chromium.org Fix crashes in FPDFClipPath_CountPaths() and friends. Created with: gclient setdep -r src/third_party/pdfium@f57843cb20ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I95d4aab1e7a46e86c56b6451a38a70134691a699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825590Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699969}
-
Ted Choc authored
Kudos to Neiko Rivera for raising the issue. BUG=1006763 Change-Id: I38f0d96aba171c2f4bf6d84c958b224920857065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825622Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#699968}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b88dac708caf..d1d142297302 git log b88dac708caf..d1d142297302 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 lamontjones@chromium.org cros-signing migration. 2019-09-25 xianuowang@chromium.org chromeos_config: disable hwtest for beaglebone_servo-release builder. Created with: gclient setdep -r src/third_party/chromite@d1d142297302 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I995cb7bba56a16f4d70bb4de47440eadc4cee70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825589Reviewed-by:
-
Matt Menke authored
close(socket_fd_) is sometimes hanging in this test. While that doesn't necessarily mean this is a Fuchsia bug, it seems likely, given that this test passes on all other platforms, and the underlying code hasn't changed since this test was enabled on Fuchsia. Bug: 1005042 Change-Id: I71babfc0472658b662a3c9232f05ad4abe5b1e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825323 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
John Rummell authored
As the code is all related to media, use the /media OWNERS for changes rather than relying on chrome/common/ OWNERS. Bug: none Change-Id: I44b225b35bb409e38eaa8fe8423e6752ba96dd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823799Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#699965}
-
Istiaque Ahmed authored
While disposing a worker script context on worker thread, its corresponding extension might have already vanished from RendererExtensionRegistry because of ExtensionMsg_Unload IPC. This means that detecting whether the script context had extension API bindings installed through ExtensionAPIEnabledForServiceWorkerScript() won't return correct state. This CL changes worker disposal to inspect ServiceWorkerData instead, which should be non null if extension bindings were installed in the worker script context. Bug: 1005541 Test: Update{un,}packedExtension flakiness reduces locally, see crbug.com/984522 Change-Id: Ib33148a81ebcc720cf26b754c26a520bb4e22b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815226 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699964}
-
danakj authored
Web tests set page zoom on every RenderView's main frame, but some may be holding a remote main frame. Don't try to set page zoom on those ones and let the page zoom propagate from the main frame down to those RenderViews and their child frames. R=avi@chromium.org Bug: 1006580 Change-Id: I411b9cd8d21f16e03649c9c716a3e6d1e7fc271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823317Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#699963}
-
Matthias Körber authored
Change-Id: I2323455f22ecee9795b8b25eb0f95c5fd4c85f87 Bug: 875768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823844 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#699962}
-
Xiaohan Wang authored
This is to prevent abnormal cases from happening. Bug: 1007194 Test: Added a unittest. Change-Id: Ica15709371e833ed5fc423ed8ddc4f39a9aa6517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825462Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699961}
-
Mei Liang authored
This CL enables configuring toolbar properties for TabSelectionEditor, as well as shows the TabSelectionEditor with the given tabs. Change-Id: I2945e2fc8f4762b4bde6efb7ed02356e812eed5a Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814547Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#699960}
-
Peter Kasting authored
The status view is the contents view of a widget, but for some reason we were explicitly setting a |popup_size_| variable that it would base its size on, even though that should have always stayed in sync with size(). In addition, layout was mirroring the rect for the enclosed label, but the mirroring had no effect since the view margins were the same on both ends. By making the equal margins explicit (via collapsing to one constant) and eliminating the |popup_size_| field, layout can be done with a simple FillLayout. This also reorders the StatusView functions so superclass, declaration, and definition order all match. Bug: 1005568 Change-Id: I3d21285d3f7885f61e5d781116562ebf4a822678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824350 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699959}
-
Alan Screen authored
From crbug.com/1000936, failures in doing conversion of PDF for N-up caused the Print Preview UI to endlessly spin in the "Loading preview ..." state without ever showing that it had failed. Wrap the N-up conversion calls' callbacks with mojo::WrapCallbackWithDefaultInvokeIfNotRun() so that a status is provided even if the utility process disappears before completing. Update the OnN-up<something>Done() callbacks to include a notification call to the Print Preview UI to report errors. Bug: 1003171 Change-Id: Ifd3b249196256b6186569d5a41b10ea39763f1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823801Reviewed-by:
-
Petr Smirnov authored
Add public ash methods for showing network detailed view bubble. Rationale: we are creating new UpdateRequiredScreen on the sign-in screen, which contains a button for network selection. Click on this button should open the bubble with the list of networks. Bug: 1005151 Change-Id: I6a4acebcc700f7b400275598978f67ccc90d4d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807232Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Petr Smirnov <petrsmirnov@google.com> Cr-Commit-Position: refs/heads/master@{#699957}
-
Kurt Horimoto authored
crrev.com/c/1815943 did some ObjC modernization, but made mistakenly removed the synthesis, causing a mismatch with the internally declared |prerenderedURL_| and the sythesized |_prerenderedURL| variables. Bug: 995641 Change-Id: I7a2a9a2e31c6b36148378e714104c44c347a9c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825167Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699956}
-
Steven Bennetts authored
This and uses the mojo API for GetNetworkCertificates in the internet configuration WebUI. This also removes the last references to networkingPrivate in the Settings UI! For minor default value change in .mojom (documentation only since JS does not get default values): TBR=dcheng@chromium.org Bug: 1001598 Change-Id: I190b0aa30111abee05024da4ca3e21523b2a5273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809852Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699955}
-
sczs authored
Currently we were using a NSDictionary to store all Coordinators, using the InfobarType as Key. The Problem is that there can be more than one Infobar with type InfobarTypeConfirm, this meant that we weren't keeping track of the Infobars correctly. Or this meant that the wrong Infobar would be removed on childCoordinatorStopped. This CL creates an Array to store all Infobars and a Dictionary only for Infobars with badges, in this case the type matters for the Badge Commands. Bug: 961343 Change-Id: If47b2da8c3158ab3c7e093f5b1673a40464ce3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824073 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#699954}
-
Ryan Hamilton authored
Bug: 984738 Change-Id: Iff1257a3cb730fad8215b2bb9a755c7dcd67aed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821859Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699953}
-
Vladimir Levin authored
This patch ensures that we don't try to copy fragment data or set children positions for a block node that is display-locked. The added test (adapted from the referenced bug) causes a DCHECK without code changes and passes with code changes. R=mstensho@chromium.org, chrishtr@chromium.org, ikilpatrick@chromium.org Bug: 1006545 Change-Id: I0833d306edd17f893bdb31a327bcfece376fd48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822197Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699952}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8adff0796b31..19ac30b02093 git log 8adff0796b31..19ac30b02093 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 ssid@google.com Merge "Fix interned string fields from using the same iid map" 2019-09-25 nicomazz@google.com Merge "Allow recorded trace sharing" 2019-09-25 fmayer@google.com Merge "Copy raw perfetto trace to heap_profile output path." 2019-09-25 lalitm@google.com Merge "trace_processor: add benchmark for sparse vector" 2019-09-25 hjd@google.com Merge "Enable libperfetto on host with Android intree build" 2019-09-25 lalitm@google.com Merge "trace_processor: add benchmark for rowmap" Created with: gclient setdep -r src/third_party/perfetto@19ac30b02093 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Idb79e674fa4d679e812a2e8e418403b211a0e4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825820Reviewed-by:
-
Ce Chen authored
move on device head suggest installer policy into this folder. Such that the installer polciy can be imported and used in iOS later. Tested on Nexus 5X. Bug: 925072 Change-Id: I175c059eaa8e20b978fc91a61a9e49d9fe34d29e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811931Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699950}
-
Eric Stevenson authored
This CL was partially generated by //base/android/jni_generator/jni_refactorer.py. Some media unit tests needed to be refactored to use JNI mocks as they depended on an UnsatisfiedLinkError to pass successfully. In the process, converted MediaNotificationTestTabHolder to use lambdas for stubbing to make the test code more readable. Bug: 929661 Change-Id: I5937168ff0b20cd3e980fe08d877c558bfd70bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825583Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
This change converts CredentialManagerProxy to use BrowserInterfaceBroker, along with mocks in tests. Bug: 995422 Change-Id: I466ea95239108af5b106651adf18517b23828717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808300 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#699948}
-
khmel@chromium.org authored
Stress test shows that reading file from scratch is 1.6x slower than rewinding the existing file descriptor and reading again. This adopts this finding by re-using file descriptor for reading system stats. TEST=Locally on eve, minnie, functionality works, no error is reported. Additionally did perf inverstigation of ReadSystemStatOnBackgroundThread 10%/50%/90% mcs per invocation eve: before: 444/1049/1509 after: 305/688/721 minnie: before: 309/534/1441 after: 176/385/1033 BUG=b:140939504 Change-Id: I58ebb08299c43b58687eaaa6c9ad225872b2e70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823722 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699947}
-
Ben Pastene authored
And refactor how we skip verifications of internal builders in generate_buildbot_json.py Bug: 1006414, 991417 Change-Id: I3520df707bfb19ba979c024d8f197e1b058c322a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825780Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#699946}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/370924be227a..01c20b755102 Created with: gclient setdep -r src-internal@01c20b755102 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:1006414,chromium:None,chromium:None Change-Id: If384c99c71dfc118fdf2c0480ab324fd36ab8134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699945}
-
John Z Wu authored
- Remove flag for account wallet. - Add API for users to give consent. - Change CWVSyncControllerDataSource to be class property so that the sync/auth stack will be able to ask for tokens during setup. - Add method to CWVSyncControllerDataSource to return all accounts. This is required by chromium to maintain the freshness of tokens. - Clear all local data when sync stops until we can handle data migration situations. - Simplify CWVSyncControllerDelegate's did stop sync method. Change-Id: I1773c270958ecffa21aa5196c94c1510bc7084a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816641 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699944}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. In this CL, I do change how the DISABLE_EXTERNAL_INTENT_REQUESTS flag works to make it more correct, but that shouldn't affect users. Bug: 1006927 Change-Id: I8757fb70803d48d23e32b3ec62b3eeb3b89b64d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824119 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699943}
-
jonross authored
This test apparently fails on all variants of SkiaRenderer on Android, not just Vulkan. I'm suppressing it for now. TBR=ynovikov@chromium.org Bug: 1007019 Change-Id: Id89860b02bc29d113863af60f6d776fd87117602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825464 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699942}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf0e9d93f177..6ac5a9250dff git log cf0e9d93f177..6ac5a9250dff --date=short --no-merges --format='%ad %ae %s' 2019-09-25 beaufort.francois@gmail.com Add label to command buffer and compute pass descriptors Created with: gclient setdep -r src/third_party/dawn@6ac5a9250dff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I00603d83e31f1acb073fe227523280115560aee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825740Reviewed-by:
-
Evan Stade authored
This was necessary to help write a unit test that verifies behavior when an OTR profile is removed, but this part is split from that test because it's independent and potentially affects many tests. This CL also invalidates all weak pointers for Browser at the start of its destructor. This avoids re-entrant calls to Browser during its destruction, which suddenly became a problem in some unit tests because TestingProfile runs a message loop till it's empty, which allows delayed calls to Browser methods to run on a partially destroyed Browser object. For example, in one test, Browser::CloseFrame was running after being posted from TabStripEmpty. Bug: none Change-Id: I209f9501d61ca4fe08aa5c9228d0da6f4c72e664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823826 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#699940}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/121f6b79..a2830ee1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4f4184286eab89537985db8764508bc57e9e4381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825400Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699939}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7211cf64444c..6a5cb2517a2c git log 7211cf64444c..6a5cb2517a2c --date=short --no-merges --format='%ad %ae %s' 2019-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6a5cb2517a2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I49d4d967b92fc4e4e041ae6e42e6724087a9936c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825694Reviewed-by:
-
Victor Costan authored
IndexedDBCursor now calls IndexedDBTransaction::UnregisterOpenCursor() in Close(), which is called by the destructor. The previous setup missed an edge case where calling IndexedDBCursor::Close() directly would not unregister the cursor. This behavior was relied upon in IndexedDBTransaction::CloseOpenCursors(), but was not intended at other callsites. Bug: 1005753 Change-Id: I91944138d05faa2d91ecc03b1040ec16ca1a7e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821675Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#699937}
-
Connie Wan authored
Address remaining comments from https://chromium-review.googlesource.com/c/chromium/src/+/1809546 Bug: 905491 Change-Id: I92242ff19cd8c0d85500e7dd66b76a4d1b29fab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818434 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#699936}
-
