GitLab

Bug: 878324
Change-Id: I09976b84a4016d687c505f0808d92d57ab87ee7c
Reviewed-on: https://chromium-review.googlesource.com/c/1312138
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606262}

This also required implementing the type tables for int64/uint64 as
BigInt. Additionally, some test support code to pull BigInt out of V8 as
64-bit types because gin assumes always-Number.

Bug: 883496
Change-Id: I10d07124e59f0fdde8f053007eca30508751b211
Reviewed-on: https://chromium-review.googlesource.com/c/1318729
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606261}

This is because we don't want to allocate dedicated hardware for this
cq builder yet, as it's optional and still under development.

R=stgao,smut,liaoyuke

Change-Id: Ie0d896993ed54172c502af938229612e9e268714
Reviewed-on: https://chromium-review.googlesource.com/c/1325073
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: smut <smut@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606260}

The documentation for ScopedTaskEnvironment recommends making it the
first member of the test fixture:
  https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=54-59&rcl=376db7a96e0287f0d010acd18e7a379d190cac71

We are chaning this particular case because we want to make the
constructor of ScopedTaskEnvironment set a global variable that is
read by PlatformThread::SetCurrentThreadPriority(). If
ScopedTaskEnvironment is initialized late in the test execution,
setting this global variable races with a call to
PlatfromThread::SetCurrentThreadPriority() on the thread created
from this stack:
  base::(anonymous namespace)::CreateThread
  base::PlatformThread::CreateWithPriority
  base::Thread::StartWithOptions
  net::test::QuicHttpProxyBackendStreamTest::CreateTestBackendProxy
  net::test::QuicHttpProxyBackendStreamTest::SetUp

Bug: 902441
Change-Id: I4869410f43383bd7f94f68fc7790e3305f3d1b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1320654
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606259}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I4d1f6b4f7eec6ec938360dd955ce37b9df4a5914
Reviewed-on: https://chromium-review.googlesource.com/c/1325031Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606258}

This will add a comment to the gn_arg log link on chromium bots:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930669115526655984/+/steps/lookup_GN_args/0/logs/gn_args/0

This will hopefully help avoid confusion when a non-CrOS chromium dev
gets a CL blocked by a simplechrome bot. (See the linked bug where
someone wasn't familiar with it and tried copy-pasting the arg dump
outside the SDK.)

I looked into adding the comment further upstream in chromite's
cros_chrome_sdk libs, but it makes heavy use of gn_helpers, and adding
comment support to that is non-trivial.

This can't land until https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1320309
and gets rolled into chromium.

Bug: 901471
Change-Id: I9ad646a9b6ab6fd29d4adb7acfd842b26c3825ae
Reviewed-on: https://chromium-review.googlesource.com/c/1318179Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606257}

Adds new experimental protocol method, which uses
`WebContents::GenerateMHTML` underneath.

Bug: 901933
Change-Id: I52e707f89378fe3a1488a3cd8afd7cdded1b77ea
Reviewed-on: https://chromium-review.googlesource.com/c/1297732
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606256}

This'll be the builder that triggers nightly flashing jobs into the
cros-dut-flash builder.

Adding it to dev while I develop & experiment with it and the flashing
builder.

Bug: 866062
Change-Id: I0319bbcb3591a6488940a9a61330a787d9dbdc01
Reviewed-on: https://chromium-review.googlesource.com/c/1325013Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606255}

This adds a fake implementation of WinWebAuthnApi along with a scoped
override of WinWebAuthnApi::GetDefault, as well as a test to verify USB
authenticator instantiation depending on API availability and feature
flag state.

Bug: 898718
Change-Id: Iff3a317b4540986775a40fc872754ba0571ae88a
Reviewed-on: https://chromium-review.googlesource.com/c/1316839
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606254}

Needs https://chromium-review.googlesource.com/c/catapult/+/1320592 to
roll in first.

Bug: 892670
Change-Id: I71a8b9be3a0a2123e86ad4870d54fef5946c2835
Reviewed-on: https://chromium-review.googlesource.com/c/1321153Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606253}

This method will show our in-product help and notify when the promo is
finished. This will serve as the plumbing between chrome/browser/ui/
and chrome/browser/ui/views for in-product help.

Bug: 887991
Change-Id: I357853b7f21910945b19022eddda9294a8bebcf3
Reviewed-on: https://chromium-review.googlesource.com/c/1310494
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606252}

R=abdulsyed@chromium.org

Change-Id: I3b214ce6f4b97cabfb6de17412d3323ff24f0260
Reviewed-on: https://chromium-review.googlesource.com/c/1325084Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606251}

Preparing work for migrating ThreadRestrictions::ScopedAllowWait to
ScopedAllowBaseSyncPrimitives.
This CL updates the friendlist for ScopedAllowBaseSyncPrimitives and
ScopedAllowBaseSyncPrimitivesWithoutBlockingScope.
Some cases might need to be adjusted if it was labeled wrong, but we can assume
that most cases are correct. This saves us from updating this file for each
cases.

Bug: 766678
Change-Id: Ie11bca133f7664355425cfaefcffb4acc0373731
Reviewed-on: https://chromium-review.googlesource.com/c/1324100
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606250}

https://android.googlesource.com/platform/external/perfetto.git/+log/134e0525ddad..8621cb09ab31


git log 134e0525ddad..8621cb09ab31 --date=short --no-merges --format='%ad %ae %s'
2018-11-07 fmayer@google.com profiling: Allow to tear down BoundedQueue.


Created with:
  gclient setdep -r src/third_party/perfetto@8621cb09ab31

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I881862146e963b79ee4392edc9eeced1811bba29
Reviewed-on: https://chromium-review.googlesource.com/c/1324470Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606249}

The renderer process is blocking long enough in
Gpu::EstablishGpuChannelSync() that hung renderer detection code is
killing it. Add histogram to track duration from when the request
arrives in the browser to when a response is sent back to the renderer.
This should narrow down where potential problems occur.

Bug: 874797
Change-Id: I1d1825a6c3dbbadb916c64b97275a1593ac05f28
Reviewed-on: https://chromium-review.googlesource.com/c/1324189Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606248}

r605518 fixed a modified URL from URLLoaderThrottles not being sent over the network. However it didn't fix the headers case, which is used by other policies. This fixes the ForceYouTubeRestrict and AllowedDomainsForApps policies.

Bug: 899268,900574
Change-Id: I5d9666a7497c2c7e5642e5c74d5bc65dc0407ea9
Reviewed-on: https://chromium-review.googlesource.com/c/1324932Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606247}

Add a play pause button that will trigger the delegate
to call MediaController and toggle playback.

This also moves the play pause icons from //chrome into
//ui as they are needed in both //chrome and //ash.

BUG=897836

Change-Id: I691695f6ac1ba11bbd17537637d4d66e37f9725b
Reviewed-on: https://chromium-review.googlesource.com/c/1298250Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606246}

viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
allocation time for that viz::LocalSurfaceId. The purpose of this allocation
time is to determine how long it takes for a surface to get embedded once
an ID has been allocated for it.

There was some concern raised about drift between LocalSurfaceIds and allocation
times and so a previous CL bundled the two together in a class. This CL plumbs
LocalSurfaceIdAllocation to more places to ensure the two quantities remain
in sync with one another.

This CL plumbs LocalSurfaceIdAllocation through VisualProperties which ensures
we plumb valid timestamps from the browser to the renderer.

Change-Id: I4589a5835b82699de106b28cac4a85776975a1bf
Bug: 655231
Reviewed-on: https://chromium-review.googlesource.com/c/1321791Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606245}

004-vertical is removed per discussion on Slack.

svg/zoom/page/zoom-svg-float-border-padding.xml
There is no anti-aliasing in NG for top left corner.

tables/mozilla/bugs/bug2973.html
<td>inside of table<img src=""></td>
NG is consistent with FF/Edge.

Bug: 902591
Change-Id: Ie672601caef16f19914855ba83a2cfe8e58ab5d8
Reviewed-on: https://chromium-review.googlesource.com/c/1323794Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606244}

This is meant to allow Slow Page Triggering of Previews - that is, for
previews that may specify variable network quality thresholds based
on the URL (via OptimizationHints), the ECT is deferred until commit
time.

It renames and refactors the ShouldAllow* and IsURLAllowed* methods
to give them more power (it pushes down the ECT threshold determination
instead of having multiple call sites try to provide). There is some
reordering of the PreviewsAvailablity passed reasons.

Some more cleanup is merited but deferred to keep the diffs simpler for
this change.


Bug: 895581
Change-Id: Id8636312a9e707dd1181ca0df514f3f743347671
Reviewed-on: https://chromium-review.googlesource.com/c/1310562
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606243}

Bug: 896736
Change-Id: I3ccfd2188fb15704af14c8af050e0a5667855d34
Reviewed-on: https://chromium-review.googlesource.com/c/1324231
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606242}

|num_frames| can be 0 when mixer input is not ready to play yet. In this
case, all the previous_ended_in_silence_ logic should be bypassed.

Bug: b/119133585
Test: bulid and run on device, ensure crashes go away
Change-Id: I9a7eb69ecb015dffc9181e94d40d6a8de07d84ba
Reviewed-on: https://chromium-review.googlesource.com/c/1324417Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606241}

Experiments with hb-shape show that enabling compiler optimizations
improves performance of text shaping (therefore should help layout).

Initial tests show an improvement of 10.4% in hindi-line-layout
and 12.1% in latin-ebook performance layout tests.

Binary-Size: compiler optimized library will increase the size of the apk.
Bug: 902782
Change-Id: Iee50a04403ec634efec17be5ef8a72b996711a2f
Reviewed-on: https://chromium-review.googlesource.com/c/1321250
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606240}

TBR=wez@chromium.org

Change-Id: I68e17769dec2d0bdc92c7cad609b243b78aec69b
Reviewed-on: https://chromium-review.googlesource.com/c/1325071Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606239}

Bug: 899602
Change-Id: I58371b62f9e810b25fa05e431db8e17b82ff0d10
Reviewed-on: https://chromium-review.googlesource.com/c/1308908Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606238}

Added UKM and UMA metrics that trigger when a site displays or runs mixed
content.

Bug: 901403
Change-Id: I855682e2c0999a859070e89907838bcc133f8673
Reviewed-on: https://chromium-review.googlesource.com/c/1319189Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606237}

This CL makes HostBrowserUtilsTests easier to understand and modify.
Changes:
- Tests are now parameterized so that they run on both a bound and
  an unbound WebAPK.
- Comments for the tests are shorter and more concise.
- Global constants do not state whether the browser should be
  installed or not.

BUG=None

Change-Id: Ie1ce96892bf99001e07b42e3e4aaa4cdc53dfcb6
Reviewed-on: https://chromium-review.googlesource.com/c/1316364
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606236}

Add code to handle all unhandledPromptBehavior states defined by
W3C spec, and make the behaviors spec compliant in W3C mode.

To help testing the changes, also fixed error reporting code in
ChromeDriver that was corrupting error messages in W3C mode.

Bug: chromedriver:2597
Change-Id: I23e4fb0bff2fbc82213d8e28d79b82f0db220e29
Reviewed-on: https://chromium-review.googlesource.com/c/1321851
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606235}

component is a singular string, not a list.

Bug: chromium:902796
Change-Id: I0efd7f9eec2fb88173225ea4f597e8687fa9ee3a
Reviewed-on: https://chromium-review.googlesource.com/c/1323801Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606234}

This avoids the use of Clone() in a couple of places.  (It also creates
new uses of Clone(), but only in tests.)

Requested in review thread of http://crrev.com/c/1294695.

Change-Id: I0ce5c00f3a4acb25cf8d8e265cea063fac5301e2
Reviewed-on: https://chromium-review.googlesource.com/c/1307054Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606233}

Bug: 546288
Change-Id: I06388c3d208a37f8743d1b116e50ef133d7a0857
Reviewed-on: https://chromium-review.googlesource.com/c/1324050
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606232}

Bug: 902195
Bug: 900072
Change-Id: I97307e754cbdcb8eddd78e05b19b5f6b3bc0b3dd
Reviewed-on: https://chromium-review.googlesource.com/c/1323790Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606231}

We have to check with define() whether the variable is defined instead
looking at its value as it couldn't be defined. It's defined with:

    if (dcheck_is_configurable) {
      defines += [ "DCHECK_IS_CONFIGURABLE=1" ]
    }

And the compilation failure:

In file included from gen/modules/desktop_capture/linux/pipewire_stubs.cc:3:
In file included from gen/modules/desktop_capture/linux/pipewire_stubs.h:11:
../../base/logging.h:846:5: error: 'DCHECK_IS_CONFIGURABLE' is not defined, evaluates to 0 [-Werror,-Wundef]
    ^
\#if DCHECK_IS_CONFIGURABLE

Change-Id: I85137252cb3ebd6965037b747574804a3c837f40
Reviewed-on: https://chromium-review.googlesource.com/c/1312948Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
Cr-Commit-Position: refs/heads/master@{#606230}

This CL has a few side cleanups to crrev.com/c/1321773, taken
out for clarity.
- Renames class
 CanvasResourceProviderRamGpuMemoryBuffer to
 CanvasResourceProviderBitmapGpuMemoryBuffer
- Moves calculation of |gl_format| to where it's used.

Bug: 902585
Change-Id: Ia0f0393425afd60ad98dbdd38f3ef5bc0d5e9e2f
Reviewed-on: https://chromium-review.googlesource.com/c/1321749
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606229}

To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang.

This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure.

This is a part of effort adding EXPORT speicifer to enable the flag.

Master CL is
https://chromium-review.googlesource.com/c/chromium/src/+/1317069

This CL was uploaded by git cl split.

R=ericwilligers@chromium.org

Bug: 901709
Change-Id: Ib1b1c7a0649ce67620a9b25ec77d4c6ace44b546
Reviewed-on: https://chromium-review.googlesource.com/c/1322252Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606228}

Adds mojo_base.mojom.Token to serialize the new base::Token type.

Bug: 895591
Change-Id: I7e982d75a9e5d40b4df7e49645d7bf4791e8d57e
Reviewed-on: https://chromium-review.googlesource.com/c/1321191
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606227}

Besides, as a result of exploring different approaches, this CL additionally
adds FromAdState enum that can be potentially shared between WindowOpen and
other event. Made the testing logic easier to follow by switching
to parameter test and expecting single UMA/UKM entry per test.

Bug: 897256
Change-Id: Ic3f0e3637de77968f15e17f25d340d2456f988ef
Reviewed-on: https://chromium-review.googlesource.com/c/1292369
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606226}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ef4d21b915d8..693e848cded9

$ git log ef4d21b91..693e848cd --date=short --no-merges --format='%ad %ae %s'
2018-10-17 mutexlox vm_tools: Add functionality to update guest time.
2018-11-04 joelhockey vm_tools: seneschal: Add support for MY_FILES, use CamelCase mappings
2018-10-19 matthewmwang shill: Make Fast Transition configurable via dbus

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I37d39cb64378164cabcddfbd3e14dd97b57935c1
Reviewed-on: https://chromium-review.googlesource.com/c/1324509Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606225}

There is an issue with the replacing logic if the forms and fields
have no identifier. This CL does not fix this directly, but greatly
reduces the cases where it will happen (only dynamic forms with more
than one form with no id).

Rogerm@ is working on a better way of identifying fields that
should help resolve this: crbug.com/896689

Bug: 898346
Change-Id: I7e17a6a2009be9e376088640bb14a81549ebbef2
Reviewed-on: https://chromium-review.googlesource.com/c/1319851
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606224}

456476c3f62e Add ReadMinidumpUTF16String
95b177e79398 Flesh out ModuleSnapshotMinidump
2dee96b84114 Remove use of MSVC_SUPPRESS_WARNING
bf327d8ceb6a Introduce "dart" dependencies configuration for embedding
             into Dart VM
411f0ae41d96 Implement MemoryMap for ProcessSnapshotMinidump
df5d1aa3ff29 Implement Stack() for ThreadSnapshotMinidump
8e329d12c791 linux: Use capget syscall instead of its libc wrapper
5dd094381ca3 [sysinfo] Convert sysinfo ioctls to FIDL calls
96391cb80f47 [fuchsia] early return in handler on disable
e00c42e63fad linux: use offset of d_name to get size of dirents
95e97a32eba4 Use a relative address in .note.crashpad.info
8c0d3d2c1e8c [fuchsia] support general registers for arm64
a4754a9ae94b [snapshot][arm64] rename CPU context pstate to spsr
9d4afb05820f [fuchsia][arm64] support vector registers
dc0052bd43eb Fuchsia: Use SDK manifest for CC prebuilt and source
             packages
0b19010fba9f Include windows.h before dbghelp.h
da3c7e7ac508 android: fix the build
236ee1076c81 Roll mini_chromium to d2c271a
9ee48fb1be75 Revert "Use a relative address in .note.crashpad.info"
a008d8a151e2 Make Windows bots non-experimental
1b20b620cfc9 Fix 32-bit Windows downcast build failure
131dd81d4ce4 mac: Fix crashpad_snapshot_test
             ProcessReaderMac.Child*Thread* for 10.14
a9be1b140370 Add ProcessMemoryWin and re-factor tests
7f71c57a29cd [fuchsia] re-introduce pstate temporarily
fdfd782c9bd6 switch to EXPECT_DEATH_CRASH
bf10ed0a693b posix: use threadsafe gtest death test for
             ScopedGuardedPage
3663b7cbbec5 Reland "Use a relative address in .note.crashpad.info"
71c75401c43c Revert "[fuchsia] re-introduce pstate temporarily"
e287a3ab12af win: fix mismatched format macros
651af7583b35 win: use zx format specifier instead of a cast

Change-Id: Ie577589f7e27820954c69122f07241b14845783b
Reviewed-on: https://chromium-review.googlesource.com/c/1315363Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606223}