- 20 Nov, 2020 40 commits
-
-
Daniel Hosseinian authored
With the PDF Viewer update, the plugin's viewport no longer takes the size of the entire frame. Additionally, the toolbar no longer overlays the plugin. Consequently, the plugin has an offset relative to the frame. The plugin's size and offset can change with the toggling of the sidenav. Send the plugin offset to PdfAccessibilityTree so accessibility rects can have the correct transformation. Bug: 1150660 Change-Id: Idef25f31cfbfa459e317b6f003a289fcb8daac19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551465Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#829573}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Icd81a140a5c542148b95e7037cf9c44d9e65ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537278Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a241aa984fd6..511da9af8056 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80341f3ee0432527f7c8c9b558c614088f4b78b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829571}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I59c92c79d224aaf14b3a85c6c56d45222ebcd670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536583 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829570}
-
Bao-Duy Tran authored
This enum is only applicable to obsolete InputMethod.ID histogram that's been deprecated since M46. Therefore it should have been marked obsolete together with the histogram's deprecation 6 years ago (July 2014, see https://crrev.com/254e75d880369bf49bdf0e8ccc400ab71f6f2fee). The enum ID needs to be marked obsolete (and not removed), as per UMA guidelines to avoid inadvertent reuse that causes confusion in future. Enum etries can however be completely cleaned up, because InputMethod.ID was a sparse histogram (not an enum histogram) and these reverse mappings from numerical values to labels aren't exhaustive anyway. These removals are akin to adjusting the labels to 'unknown'. These removals only make interpretation of old data inconvenient. It's however unlikely we'd need to analyse data of deprecated InputMethod.ID metric that's no longer been recorded for the past 6 years. In the highly unlikely event we need to do so, repo history is at our disposal. Bug: 1150183 Change-Id: I3f274c038be1b334a4e49ccbef3bae518ede0019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546345Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#829569}
-
Kenichi Ishibashi authored
Before this CL, the callbacks of the following methods were passed directly to mojo remote calls: * UpdateLastUpdateCheckTime * UpdateNavigationPreloadEnabled * UpdateNavigationPreloadHeader As a preparation to support retry for these calls, this CL introduces ServiceWorkerRegistry::DidUpdateRegistration and passes it as the callbacks of remote calls. DidUpdateRegistration keeps the original callbacks and runs the callbacks when ServiceWorkerRegistry gets responses for them. DidUpdateRegistration also checks the result of remote calls. If it's a disk error, it schedules DeleteAndStartOver as the same as other DidXXX callbacks do. This CL doesn't add the retry mechanism for these methods yet. DidUpdateToActiveState is merged into DidUpdateRegistration because it does the same thing. Bug: 1133143 Change-Id: I50bd2f526c9cef03277ae2c3da81a6eb7aa8b63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550112Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829568}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605808617-3dd590b3717c834812eb8652d51332097d715185.profdata to chrome-win64-master-1605819430-f29c6c0acb8066d29cda4fb937b7ae2e0e828814.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id5a80fb4b5238839eb88ea125e490ba264c9092d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551306Reviewed-by:
-
Mason Freed authored
Per the comment, the allowable values come from the enum in feature_policy_features.h. There is no DisableForAll. TBR=iclelland@chromium.org Change-Id: I1509a66c570dbb0c2b34876019f965446f91093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551958Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#829566}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I8e0b2a9a0f23025110e3446410f43bff32cbfed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546505Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82b7546133db..7ab0cbf6d83f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: I0981d4eb895cb411c075a97608ed2a0471695c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829564}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eeca9c6ee7e1..330b60556789 2020-11-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie376592f49379729b41b1bb153a0df9a47db6e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551500Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ifd6d8ed0302fc7ef8d58cb6c8fcb125895e8c8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546307Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829562}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I5ddea7c61bbe23ee599dfce9356c79a705e701fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550010 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829561}
-
Yoshifumi Inoue authored
This patch adds expected images of wpt/appmanifest/shortcuts-member/* imported on 2020-10-30[1] for linux_layout_tests_layout_ng_disabled bot. [1] http://crrev.com/c/507388 TBR=foolip@google.com Bug: 591099 Change-Id: I3892bc65297576b2efb6912b12aee4255a275508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551879Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829560}
-
Noel Gordon authored
A <script src=strings.js> is used in background page SWA fake to fetch load time data at start-up. The experimental SWA main.js has no script loader that the background page JS can use: create one in-situ. Minor: remove unneeded space from window.chrome.storage get: keys. Tbr: Alex Bug: 1113981 Change-Id: I352456080b85dfa7d75a201b96cd68e4993206e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550107Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829559}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6a331d7926b7..6743d1edbf35 2020-11-20 ntfschr@chromium.org Devil: change test runner to use vpython If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nuskos@google.com Test: Test: ./devil/bin/generate_md_docsTest: Test: ./devil/bin/run_py_devicetestsTest: Test: ./devil/bin/run_py_tests Change-Id: I7cb72f5ce62c1dbaf290f23a99dec83ebfe4ed48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551581Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed289e777cfa..4f660f22d9eb 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 060020166679 to de9e649438ed (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I0921b3647f5fca9335f1b6856a2d9deb598b736a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551332Reviewed-by:
-
Hiroshige Hayashizaki authored
Before this CL, for ModuleScript::RunScript(), we entered: - v8::HandleScope in ModuleScript::RunScript(), - v8::Context in ModuleScript::RunScript(), - v8::EscapableHandleScope in V8ScriptRunner::EvaluateModule(), and - v8::Context in V8ScriptRunner::EvaluateModule(). After this CL, we enter: - v8::HandleScope in ModuleScript::RunScript(), and - v8::Context in V8ScriptRunner::EvaluateModule(). This is to remove duplicated scopes and thus simplify the semantics: callers of V8ScriptRunner::EvaluateModule() should enter v8::HandleScope while EvaluateModule() enters v8::Context. Bug: 1111134, 1151165 Change-Id: I84be5b89038fa5fb9f20a36ac9e4996c0e3c7510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476693 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#829556}
-
Noel Gordon authored
chrome_file_manager_private_test_impl.js is also being used to provide file manager private fakes to the file manager SWA app. The SWA has no MockVolumeManager, so move MockVolumeManager.resolveLocalFileSystemURL code into the normal (non-swa) if block at the top. Bug: 1113981 Change-Id: I2f7ba86fd8b28860e9319f6f3561b28d9d6fa8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551860Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#829555}
-
Amr Aboelkher authored
The PSM helper function GetPrivateSetMembershipCachedDecision is returning the actual base::Value*, not its boolean content. When it's being assigned to a boolean variable directly, that indicates whether that base::Value* exists or not. This CL is getting the actual PSM cached boolean decision to be compared against Hash dance decision. It also makes the signature of GetPrivateSetMembershipCachedDecision function to be Optional<bool>. BUG=chromium:1150373 Change-Id: Id9340183f1c1e72d951a2476c591d25b45b9c088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545308 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829554}
-
Zain Afzal authored
getFile can throw a NotFoundError when called on a handle which has been moved or deleted, this cl adds explicit handling for the cases when this happens. BUG: b/172628918, b/172628918 Change-Id: Ie4dea3e667c821a0ac2d2b2c7e90a958eb4f0271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522802 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#829553}
-
Alan Cutter authored
This CL updates the Google Drive bundled manifest start_url to match what's served by the site: https://drive.google.com/_/AppsNotifyUi/manifest.json (Note that "/?lfhs\u003d2" is the same as "/?lfhs=2".) This maintains the "usp=installed_webapp" query param via launch_query_params. This needed to be fixed up to work properly for bundled manifests. Bug: 1058265 Change-Id: I39a2a5442d56153948c4c2ea1f6a75d1b58e7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#829552}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b472168267a0..eeca9c6ee7e1 2020-11-20 ehmaldonado@google.com [owners][git-cl] Use owners client to show all owners for a file. 2020-11-19 ehmaldonado@google.com [owners] Implement GetFilesApprovalStatus for OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5ff5e3fdb080e392504dcd1d61230881b9329dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551722Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46107d3ece07..8930f18245df 2020-11-20 cclao@google.com Vulkan: Add feature flag to fallback rotation to use driver uniform 2020-11-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 4fe17f3425ee to 3f73b676d6e8 (9 revisions) 2020-11-19 geofflang@google.com roll_aosp: Pass more forceful args to gclient sync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I1878c98fd78e90c31c59b00ad71c1652894cfc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551835Reviewed-by:
-
Mason Freed authored
The allow_shadow_root parameters were recently added [1] to the declarative Shadow DOM fragment parser APIs to provide an opt-in to avoid an XSS sanitizer bypass. However, to make these new changes more parallel to the existing getInnerHTML() API, which uses the plural "include_shadow_roots", the opt-in parameters will be renamed here. This CL also deletes some dead code from document_fragment.h. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530222 Bug: 1042130 Change-Id: Ic553316b799f1b1bfe64c8aa457b2d77b97951a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548181Reviewed-by:
-
Alan Cutter authored
This CL moves the app ID constants in default_web_app_ids.h out of the chromeos directory as chrome/browser/web_applications/components/web_app_id_constants.h. This is in preparation for Chrome Windows/Mac/Linux depending on these app IDs as they migrate their preinstalled Chrome apps over to web apps. See: https://chromium-review.googlesource.com/c/chromium/src/+/2531085 Bug: 809304 Change-Id: Iafcab362380a6cc5853dcfb1a57272f51b18a88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546674 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#829548}
-
Yao Xiao authored
This change propagates signals for sticky ad and overlay-popup ad detection from the renderer to the ads intervention manager through the subresource filter component. As the ads intervention manager is running in dry run mode and does not block ads, this allows us to record intervention behavior when triggered by one of these two interventions. Understanding the intervention behavior is a precursor to the ads intervention manager intervening to actively intervening on sites with better ads standard violations. Add base::Feature flags to allow disabling the frequency capping from either web_tests and browsertests. Move relevant tests into a virtual test suite that has the flag disabled. Bug: 1099741 Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#829547}
-
Robbie McElrath authored
This is a reland of d3f64670 Reason for reland: fixed junit test failures Original change's description: > [WebLayer] Update Fragment.getActivity() implementation. > > This CL updates the bytecode modifications we perform on > Fragment.getActivity() to have it call ContextUtils.activityFromContext( > getContext()), and modifies compile_java.py to detect compilation errors > related to this change and print a message pointing you to documentation > about the bytecode modifications. > > A compilation error will now print: > ../...../PasswordEntryEditor.java:144: error: cannot find symbol > getActivity().getSupportFragmentManager(), > ^ > symbol: method getSupportFragmentManager() > location: class Activity > Expecting a FragmentActivity? See docs/.......md > > Bug: 1123216 > Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828643} Bug: 1123216 Change-Id: Id03753fce7da29b914aa02217186b2bb8da5c83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547626 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829546}
-
Xianzhu Wang authored
This fixes performance regression caused by crrev.com/c/2547435 by avoiding z-order list refresh when there will be no overlay scroll controls. The invalidation is not necessary because we'll invalidate z-order list when the ScrollableArea actually creates an overlay scroll control. TEST=Existing tests Bug: 1149793, 1150795 Change-Id: Ifc380b891b9c9155b706c0d5c24c02685bf18a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550586Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829545}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic709538aa5638abf3b1f37dd0a0b619eed54b726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549243 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#829544}
-
David Van Cleve authored
We've rolled out the new default referrer policy of strict-origin-when-cross-origin to 100% and, in the parent CL, removed the enterprise policy that emulates the prior default policy. This CL removes the remaining piping that was used to propagate the enterprise policy's effect to Blink. Bug: 1150018 Change-Id: Ie2ef9a2137201a065f54325e5ad518efe5645ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545063 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829543}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ed6fc040fdc..6a331d7926b7 2020-11-19 ntfschr@chromium.org Devil: relax WebView fallback logic requirement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1150898 Tbr: nuskos@google.com Test: Test: ./devil/bin/run_py_testsTest: Test: out/Default/bin/system_webview_apk set-webview-provider Change-Id: I2a6c33533fa9e35816b3e191e50ffec081845cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550607Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0b25f6e314a..a241aa984fd6 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I41e83fd2f4988688a7dd36109a9ef7108d3d09bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551996Reviewed-by:
-
Trent Begin authored
Enough routines have been added that the list of routines needs to be scrollable to fit inside of the app window. Bug: chromium:1142857 Change-Id: Ia38e61b707fc093bc131a4cb2c7f56d9411bc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550178 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829540}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d9c32d374ba..82b7546133db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1102812 Tbr: shimazu@google.com Change-Id: I81e950ad04a07ebf4a53e7f9b02c297106edcf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551612Reviewed-by:
-
Jinsuk Kim authored
Factors out the self-contained tab-obscuring logic in LBFS. This is injected as a new callback via ctor. Bug: 1127732 Change-Id: Icd7369391ee6b8463fd86eb68d5781d697ff3b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503534 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#829538}
-
Will Harris authored
No behavior change in this CL. BUG=584575 Change-Id: Id2cb83087966964f3817efe5037c070a6dbbca1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551796Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#829537}
-
Bao-Duy Tran authored
Prior to this patch, these tests relied on global input method configs meant for prod. This made the tests unnecessarily non-hermetic. Not to mention such configs come from legacy input_methods.txt [1], remnant from before the migration to extension-based input methods circa 2011 (via the use of GetSupportedInputMethods() [2] which uses kInputMethods autogen'd from input_methods.txt by gen_input_methods.py [3]). Nowadays the canonical source-of-truth configs for 1P input methods on Chrome OS is google_xkb_manifest.json [4]. This refactoring helps further reduce usage of input_methods.txt, towards its full deprecation and removal. Related tests now use test-only config data that's hermetic and minimal for their needs. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=5ab33d25bc676b63e4afbcfade6f9265a5f5a3ea [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/ime/chromeos/input_method_allowlist.cc;l=24;drc=0c6b25ab44b47df2e954ad588f5b518a53ac4c20 [3] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/gen_input_methods.py;drc=0303b222088853ce1c0af2bbc7f47937746eda97 [4] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707 Bug: 1134526 Change-Id: I524f1146a2d1ea09548c2b8f62446db601dc1158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546667 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#829536}
-
Shubham Aggarwal authored
Should have no behavioural effect. Change-Id: Ibf58e36fc56307af001b66e9a874485f5c3a022f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548689 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829535}
-
Rebekah Potter authored
This reverts commit 0c1232a0. Reason for revert: More complaints with this new behavior than the previous one. Seems to make more sense to revert back. Original change's description: > Print Preview: Restore media size setting if height and width match > > In an attempt to not match the setting too easily and restore a size > the printer didn't support (see https://crbug.com/924488), Print Preview > required two media sizes from different printers to match exactly, or > the size would be reset to the printer default when the destination was > changed. > > This CL allows any media sizes reporting the exact same dimensions to > match, which will allow the user's selected paper size to be persisted > across different destinations more often. > > Note that in certain cases, different destinations have similarly > named paper sizes that may correspond to the same standardized size, but > report slightly different dimensions for these sizes to Print Preview. > This CL does not change the behavior for those cases, as it may be > infeasible to distinguish such cases from printers with very similar > reported sizes that correspond to different physical paper sizes, > particularly given that custom user paper sizes are supported by a > large number of printers. > > Bug: 1108661 > Change-Id: I42794fd1b80f34bcd277c111a66aeeb49239e71d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321965 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792536} TBR=rbpotter@chromium.org,dhoss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108661 Change-Id: If21084d8f2034ab4695882ead7a74da92d8090b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551817Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#829534}
-
