- 25 Jul, 2018 40 commits
-
-
Nigel Tao authored
Upcoming changes will refer to these types without being associated with "policy" per se. Change-Id: I1d3e98592686ee640fb5a22f24b180f267d43381 Reviewed-on: https://chromium-review.googlesource.com/1149422 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#577802}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36b2059cae7f..70ddc1ca22ad git log 36b2059cae7f..70ddc1ca22ad --date=short --no-merges --format='%ad %ae %s' 2018-07-25 art-snake@yandex-team.ru Use document size instead of file size while parsing. Created with: gclient setdep -r src/third_party/pdfium@70ddc1ca22ad The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I528ab175def896454e1680319e4b2a9dfaab7a4a Reviewed-on: https://chromium-review.googlesource.com/1149540Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577801}
-
Daniel Bratell authored
MakeFunctionUnique and MockInvalidFunction are functions that are generated twice by ui/gl/generate_bindings.py. With that double generation the code can't be jumbo compiled because of the resulting symbol clash when the code ends up in a single translation unit. This patch gives the functions unique names by adding the "set_name" (gl, egl) to their names. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia08d42a86b99bddc808d1ac7c921f6801eb07782 Reviewed-on: https://chromium-review.googlesource.com/1148453Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#577800}
-
Daniel Bratell authored
gl_enums used Khronos to get a definition of GL_NONE but that broke jumbo build experiments because you cannot have khronos headers and ui/gl headers in the same translation unit. This patch switches gl_enums.cc to use ui/gl/gl_bindings.h like the rest of the code. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id239ca4aa55278ac012c066d6a6f8e243b3ec319 Reviewed-on: https://chromium-review.googlesource.com/1148442Reviewed-by:
-
Javier Ernesto Flores Robles authored
Also creates a protocol with the move. This changes are needed so it can be reused for manual fill. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54bc740454dbc58ba8c1997daa05fc4dff99dccd Reviewed-on: https://chromium-review.googlesource.com/1147675 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577798}
-
Ria Jiang authored
Currently in Shell::CreateShell, we create platform window in PlatformCreateWindow and then set its contents in PlatformSetContents. However, we can be setting two different bounds ([1] and [2]); if we are trying to get the window bounds and it happens to be between these two set-bounds requests (e.g. to x11), we are getting the wrong bounds, which is why the test in the bug report failed. This CL moves window-> show to be after PlatformSetContents so we only set the correct bounds once. [1] https://cs.chromium.org/chromium/src/content/shell/browser/shell_views.cc?type=cs&sq=package:chromium&g=0&l=420 [2] https://cs.chromium.org/chromium/src/content/shell/browser/shell_views.cc?type=cs&sq=package:chromium&g=0&l=91 Bug: 865919 Change-Id: I936148a6236804ff0b01c0a9ec5ad5143cfbd071 Reviewed-on: https://chromium-review.googlesource.com/1149440 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#577797}
-
Eliot Courtney authored
Bug: b/109716842 Test: Able to free resize PIP windows with Android side patch. Change-Id: If27051f3edc27cebc5f2e27f78daf8ea2f60f60e Reviewed-on: https://chromium-review.googlesource.com/1134810Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#577796}
-
Chris Lu authored
Move offset calculation away from -viewDidLayoutSubviews and into -viewDidAppear and -viewWillTransitionIntoSize so that the logic lies in places where the newly rotated frame has been defined. -viewDidAppear covers first-time calculations and -viewWillTransitionIntoSize handles rotations. Video: https://drive.google.com/open?id=1ziE4y_N4FYZuR5cR10i-wuJ1Zkmqzdyv Bug: 862544 Change-Id: Ib493e7395041d498abb5b77d6c8732dc443b01e3 Reviewed-on: https://chromium-review.googlesource.com/1141287Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/2f72894d302e..d62662686b22 $ git log 2f72894d3..d62662686 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dor1s [libFuzzer] Handle unstable edges by disregarding unstable edges 2018-07-24 phosek [sanitizer][fuzzer] Temporarily transition to ZX_TIME_INFINITE_OLD 2018-07-24 phosek Revert "[Fuzzer] Update path to libc++ headers" 2018-07-23 phosek [Fuzzer] Update path to libc++ headers 2018-07-23 dor1s [libFuzzer] Handle unstable edges by using minimum hit counts 2018-07-19 kcc [libFuzzer] when -print_coverage=1 is given, print more stats (the number of seeds that hit every given function) 2018-07-19 kcc [libFuzzer] fix the bot (the no-assert build) 2018-07-19 kcc [libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow-trace) 2018-07-18 phosek [Fuzzer] Improve crash unwinding on Fuchsia 2018-07-18 dor1s [libFuzzer] Create single template for visiting Inline8bitCounters Created with: roll-dep src/third_party/libFuzzer/src Bug: 539572,854276 Change-Id: Iadeb2d7c4c5cbd6ba51e257bc2b0fa662a44050e Reviewed-on: https://chromium-review.googlesource.com/1149444Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577794}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1032259c..dbe25137 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e52443991ff95ac83bcaef7af98edf39e132d93 Reviewed-on: https://chromium-review.googlesource.com/1149445Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577793}
-
Yue Li authored
Also: - update logic for Assistant settings. - update timeout for loading the flow. Bug: 866141, b/111704810, b/111796422 Test: Manual Test Change-Id: Ibb3ba413992ee92b2e334dddeaf7d714d500ffcb Reviewed-on: https://chromium-review.googlesource.com/1148768 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577792}
-
Peter Kasting authored
IMO he's done enough work on the tabstrip during the Refresh cycle to be able to review changes here. TBR=sky Bug: none Change-Id: I1522042e5244e225a7ce2c86d87397729a2086fe Reviewed-on: https://chromium-review.googlesource.com/1147661 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577791}
-
Giovanni Ortuño Urquidi authored
Introduces the BookmarkAppInstallationTask. This class purpose is to perform the necessary steps to install an BookmarkApp from a WebContents or a WebApplicationInfo. This class will have two subclasses BookmarkAppShortcutInstallation task and BookmarkAppWebAppInstallationTask. The former is included in this CL and installs BookmarkApp-based Shortcuts. The latter will install BookmarkApp-based Web Apps. Bug: 864904 Change-Id: I5b5b9f44ff0984b0138663cb7c84abcba1062c77 Reviewed-on: https://chromium-review.googlesource.com/1131024 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This allows NGLineInfo to return a Width which isn't clamped to zero for negative values. This allows alignment of text to work correctly for these values. Additionally, when adjusting the inline static position of abs-pos children, we use the resulting fragment inline size, instead of the line width, as this may be different. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0876f148d285147c3b5cec658ebd7831e97b11aa Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1147875Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577789}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6cf86b3c343e..f79ab3845a7e git log 6cf86b3c343e..f79ab3845a7e --date=short --no-merges --format='%ad %ae %s' 2018-07-25 nednguyen@google.com Make sure Telemetry browser attempts to log symbolizaztion of all unsymbolized dumps upon test failures Created with: gclient setdep -r src/third_party/catapult@f79ab3845a7e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895 TBR=sullivan@chromium.org Change-Id: I0632a93297b85b3e5ca364eb908176c39acf9466 Reviewed-on: https://chromium-review.googlesource.com/1149541Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577788}
-
Matt Falkenhagen authored
This comment seems outdated. S13nSW without NetworkService is supported. The TODO is a bit vague about what was planned to be done. I assume it was to merge the S13nSW without NetworkService code with the non-S13nSW without NetworkService code, but there is not a viable path for that, and as the code will be removed after S13nSW it's not worth it. Change-Id: I85097d207af340173508004249e6eebe317a2cfa Reviewed-on: https://chromium-review.googlesource.com/1149424Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577787}
-
Koji Ishii authored
This patch enables ComputePositionData() for RTL, and enables using the data in CachedOffsetForPosition and CachedPositionForOffset. Because we use binary search, CharacterPositionData stores ShapeResultCharacterData in the visual order, so that its |x_position| is in ascending order. This patch also adds DCHECKs to ensure Cached and non-Cached versions return the same data. Cases they don't were discovered, in LTR and RTL. DCHECKs are limited to when it passes, and failing cases are to be investigated. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifaf3f9f73c7b098e68932e8dc0181a79c1d7778d Reviewed-on: https://chromium-review.googlesource.com/1148025Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577786}
-
Luciano Pacheco authored
Move zip, MTP, removable and archive volumes after Drive and 3rd-party FSPs, as requested on the linked bug. Bug: 867198 Change-Id: I69a61b621e190ade9dd6d16d5655c57ea722cdff Reviewed-on: https://chromium-review.googlesource.com/1149421Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577785}
-
tzik authored
This moves task management logic of base::internal::TimerBase to its subclasses, so that subclasses can hold user tasks as different types for each. Specifically, OneShotTimer's task type is converted to OnceClosure after this CL, and it gets supporting OnceCallback. Bug: 850247 Change-Id: Ie017c2ed6e0fb1fe44937a497576d16e5c3dab68 Reviewed-on: https://chromium-review.googlesource.com/1127215Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577784}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I97f86a8372ea408243baddf8999f3d8f3f4ba785 Reviewed-on: https://chromium-review.googlesource.com/1149117Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577783}
-
David Black authored
Provides more instruction to users until actual endpoints are available. Bug: b:111752710 Change-Id: I250269c0848a02ae89480fb6dff20021f8866895 Reviewed-on: https://chromium-review.googlesource.com/1147425 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#577782}
-
Mounir Lamouri authored
Picture-in-Picture requires submission even if the video may appear as not visible to the frame submitter. This is adding a flag that is turned on when a video enters Picture-in-Picture. Bug: 865940 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98ece11c4ad91ba2c34cafad711c50068fc91384 Reviewed-on: https://chromium-review.googlesource.com/1147542 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577781}
-
Peter Kasting authored
This computes the background tab image Y offset based on the refresh height of the frame top, and simplifies the code by doing this unconditionally instead of only when there's a tab background image. This will not fix cases where a theme uses a custom toolbar image based on assuming that there are 16 DIP above the top of tabs. Added a TODO about that. Bug: 866671 Change-Id: I9c9b5dacaba31f825d8392f5538ebd4cc8140367 Reviewed-on: https://chromium-review.googlesource.com/1147618 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#577780}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e66fe1f7. With Chromium commits locally applied on WPT: 9f17ab2f "Refactoring XR mojo interfaces" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21670 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding TBR=foolip No-Export: true Change-Id: I4d3b08e23956bf55e55ae8cb4aabfde7d11c3005 Reviewed-on: https://chromium-review.googlesource.com/1149441 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577779}
-
Yoichi Osato authored
This is a quick fix for the issue that DocumentMarkerContoller often returns over offset for a text node. That causes DCHECK hit in creating NGOffsetMapping. This patch rounds such offset before offsetmapping creation. Generally, we should sanitize DMC offset management. Bug: 865267 TEST: By hand with the example in the crbug. We might find a root issue by DCHECKing inside DMC. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0c90f14d08df4eee4de0e23d37b4a2be86308f1e Reviewed-on: https://chromium-review.googlesource.com/1148160Reviewed-by:
-
Scott Chen authored
Bug: 867005 Change-Id: Ie56bf0c098bd625a506395cb3ea77eb3f38f18ef Reviewed-on: https://chromium-review.googlesource.com/1148764Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577777}
-
David Black authored
To accomplish this, this CL: - Adds some utility methods to deep_link_utils for parsing params. - Moves parameter keys to a unified place within deep_link_utils. - Uses API to unescape parameters. - Adds support for query via deep link. Bug: b:111654253 Change-Id: Ic09ded6c76393fdc56006594ff01e64e8753ed0f Reviewed-on: https://chromium-review.googlesource.com/1145829 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Chris Dalton authored
The Skia interface validator requires these bindings to be present. Bug: skia:8159 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib79d16ac063bdd5ddace9fbf6bba063e190186d3 Reviewed-on: https://chromium-review.googlesource.com/1147878Reviewed-by:
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74ff6430d6c4..eade4f0eac2e Created with: gclient setdep -r src-internal@eade4f0eac2e The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0acdfffefa6c6a787d900030a1ac34ac094de3b3 Reviewed-on: https://chromium-review.googlesource.com/1149341Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577774}
-
Khushal authored
Plumb through the URL used with a worker context to the GPU so it can be used to currently report the URL for the current page. This change only adds support for work sent from raster tasks and when raster decoder is enabled. R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib5b20c0cc54df3ecbfb1ef3e13a14f0fcc65e3cb Reviewed-on: https://chromium-review.googlesource.com/1145685 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577773}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/04e984409ab0..6cf86b3c343e git log 04e984409ab0..6cf86b3c343e --date=short --no-merges --format='%ad %ae %s' 2018-07-25 benjhayden@chromium.org Fix internal test suite descriptors. Created with: gclient setdep -r src/third_party/catapult@6cf86b3c343e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5f6ddf4f4e5b931d1aa49ab12f688b9b8d1116f0 Reviewed-on: https://chromium-review.googlesource.com/1149342Reviewed-by:
-
Yiming Zhou authored
1. Fixed an edge case where the Recorder UI is truncated by the parent page's stylesheet. Added an explicit padding style to the Recorder UI. 2. Record page load events on the main frame. I can later use the page load events to truncate test recipes. 3. Add a typePassword action. Bug: 855284 Change-Id: Ieac830addbc7dff303ab456438328ffd64e12953 Reviewed-on: https://chromium-review.googlesource.com/1145624 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#577771}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/21edf3db5e33..0359b6977caf git log 21edf3db5e33..0359b6977caf --date=short --no-merges --format='%ad %ae %s' 2018-07-24 theoking@google.com Vulkan: Check mInFlightCommands doesn't grow too fast 2018-07-24 geofflang@chromium.org EGL: Validate that EGL_GL_TEXTURE_ZOFFSET is used only for 3D sources. Created with: gclient setdep -r src/third_party/angle@0359b6977caf The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I287658785a2a2513399497260ea64ae3afd985c3 Reviewed-on: https://chromium-review.googlesource.com/1149340Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577770}
-
Qiyu Hu authored
Bug: b:78650442 Test: Build Change-Id: Ic0a9e07fa68d22faf11549b992c2c885f07d2c00 Reviewed-on: https://chromium-review.googlesource.com/1144193Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#577769}
-
Scott Chen authored
Bug: 846210 Change-Id: I0c20f572ad294050ec78187cfbcc6f4cdd47141f Reviewed-on: https://chromium-review.googlesource.com/1148760Reviewed-by:
-
tzik authored
AddressSorterWin::Job's reference count is zero at the beginning of its constructor, and used to be incremented at base::Bind there implicitly. However, if PostTaskAndReply there failed, the reference is gone and the reference count gets to 0 again. And as the result, `new Job` may return a stale pointer. This CL adds a static constructor to , and moves the ref count manipulation part out from the constructor, in order to avoid the unexpected destruction. Bug: 866456 Change-Id: I1e735d6d0bf427988ba7380569628d4264c755f5 Reviewed-on: https://chromium-review.googlesource.com/1147898Reviewed-by:
-
tzik authored
ExtendedAuthenticatorImpl is a ref counted object. Its first reference is taken by base::Bind in its constructor, and the reference is passed to GetSystemSalt to do an asynchronous task. However, if GetSystemSalt impl drops the passed callback soon, (e.g. by PostTask failure), the reference to ExtendedAuthenticatorImpl is gone and the instance is destroyed, even before the construction has completed. That is, `new ExtendedAuthenticatorImpl` might return a stale pointer on the previous code. This CL adds a static constructor to ExtendedAuthenticatorImpl, and moves the problematic part out of the constructor. Bug: 866456 Change-Id: I377acc8a753c01a79a4cf09617bfa3b0f6aa923f Reviewed-on: https://chromium-review.googlesource.com/1148164Reviewed-by:
-
David Black authored
Still missing tweens. Need to discuss with UX about potentially revising specs to use pre-defined tweens. See bug for demo. Bug: b:111573788 Change-Id: I7d94416afa834d83aafa7e1e5f8eb9d6efe44333 Reviewed-on: https://chromium-review.googlesource.com/1144197 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Ryan Sleevi authored
As previously communicated, and as documented at at https://g.co/chrome/symantecpkicerts, certificates issued by the Symantec Legacy PKI Infrastructure between 2016-06-01 and 2017-12-01 will no longer be trusted. This changes the default state to remove trust in these certificates. Certificates issued under the DigiCert Managed PKI, or those from previously-identified, independent third-party CAs, are not affected. Bug: 796230, 805460 Change-Id: I74bdecc9dfdd66dec1a111f9eddb830babfa8222 Reviewed-on: https://chromium-review.googlesource.com/1134209 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#577764}
-
Xing Liu authored
This CL changes the download progress bar background color to 26% G blue 600. Bug: 864867 Change-Id: If7490c628c623556d1d01a267a391a070a3945f8 Reviewed-on: https://chromium-review.googlesource.com/1148941 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#577763}
-
