GitLab

Attempted fixes for fuzzer bugs.

Bug: 985995,986029,986007,987476
Change-Id: I3da85945fd722224da9c027f71944c97c823e8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718993
Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683250}

Disable TabHoverCardBubbleViewBrowserTest.InvokeUi_tab_hover_card on all
Windows platforms.

Bug: 932402
Change-Id: I5c07f588309907b87b8f5097307ed81fd70aa072
Tbr: kylixrd@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730922Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683249}

This CL adds two metrics recording the time that the peak windowed CPU
usage occurred in an ad frame/page. This is a useful metric to help understand
in what cases these frames are under high CPU usage, either during initial
load of the page or later in the page lifetime.

Bug: 989672
Change-Id: Idf100d3aed04a9ed43e9bb19b23cd97e669a21b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729474Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683248}

Historically, RenderView and RenderWidget were 1:1, and their lifetimes were
entwined.
1) RenderViewHost would create the RenderView.
2) RenderView would create a RenderWidget and pass ownership of itself to the
RenderWidget.
3) RenderViewHost's destructor would destroy the RenderWidget, thus destroying
the RenderView

We want the lifetime of RenderView and RenderWidget to be decoupled. The first
step of this is making RenderView explicitly owned by the browser. This means
that instead of (3), RenderViewHost's destructor will destroy the RenderView,
which will in turn destroy the RenderWidget.

One subtlety is that prior to this CL, RenderWidget was always destroyed
asynchronously. The original reason for supporting this -- dealing with
re-entrancy from nested message loops -- is no longer applicable. The IPC that
destroys RenderWidget is asynchronous, which means it can never be called from a
re-entrant context. However, it is possible for a RenderWidget associated with a
child-frame to be synchronously destroyed by JS. This can be re-entrant. This CL
updates destruction of RenderWidget to be synchronous when called from IPC.

Bug: 987731
Change-Id: If4b319fab19d02c5495ba14e5cc929f441ca4d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717456
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683247}

This CL includes:
1. Make OverlayWindowAndroid an WindowAndroid observer so that it
can observe compositor state.
2. Add a Tab observer to PictureInPictureActivity so that when the
tab that initiate PiP is destroyed or Chrome instance is closed,
PictureInPictureActivity is notified and close properly.

Bug: 964378
Change-Id: Iaab2ee5b1be3acf14d7380588aae63b0d666ec6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717237Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683246}

MANUAL_ prefix handling moved from content test launcher delegate
to gtest SetUp in browser tests.

Bug: 936248
Change-Id: Ice0bdf1fa6cf19cb150de7ec03abbe8aacc36198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679166Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#683245}

When a readback cannot be returned because the tab is no longer attached
to the view, all the subsequent readback would be abandoned, causing
blank or stale thumbnails in Grid Tab Switcher. When this happens, the
symptom persists until the tab is reattached to the view or a restart.

This symptom caused StartSurfaceLayoutTest to be flaky. This CL tries to
reduce the flakiness by reattaching the Tab to the view by switching to
it.

Bug: 989348
Change-Id: Ia714ac8f674b5194e91a56cf19b2b9e4ece8b55f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727520Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683244}

Change-Id: I5756149824d6cbdc2a91a7768607ef806fb52c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730908Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Florian Mayer <fmayer@google.com>
Auto-Submit: Florian Mayer <fmayer@google.com>
Cr-Commit-Position: refs/heads/master@{#683243}

- No device with telephony capability
- Device available but sync turned off

Bug: 982229
Change-Id: I7eb6fe5226cbac9295faf47c8c20d487677a5273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726053
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683242}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f275010c435a..5dd6b1e0a5ef

git log f275010c435a..5dd6b1e0a5ef --date=short --no-merges --format='%ad %ae %s'
2019-08-01 saklein@chromium.org PackagesService: Fix uprev output.

Created with:
  gclient setdep -r src/third_party/chromite@5dd6b1e0a5ef

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9b954e13ffa25159e53e66c3f80fa89c1194336f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730796Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683241}

This CL adds MockBackgroundTaskCoordinator and create an interface for
BackgroundTaskCoordinator, also move implementation code to cc file.

Bug: 963304
Change-Id: I5308ca58d87d1e0c7e56b4b780955d132cc98c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728346Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683240}

This branch is suddenly getting hit, which should never happen, but
misbehaving js is better than a browser crash

Test: None
Bug: 138416788
Change-Id: I3f81ac019b2d0b361bf390f0a1dfce1555a0e392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730794
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683239}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=blundell@chromium.org

Bug: 968047
Change-Id: Ie7157527c1c36286c321800db5ecac024e8124c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728557
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683238}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ae4b7f3..69c9ca09

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I19e2313e425bc7efaa2f4f128ccd6ccc7b4e4313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731331Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683237}

... so it does not collide with blink's conamed class, when
these files get Onion soup'ed.

BUG=704136
R=guidou@chromium.org

Change-Id: I93961b646cb79ff29d54a10f5114bb4866e029f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731450
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683236}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Bug: 968047
Change-Id: I2082e38973c90b49627bea4f27f7e00550f1a5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729221
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683235}

This change adds a `url` parameter intended to be used later in the life
of a file handle.

One of the uses is to implement two steps in our security model:
The SafeBrowsing check and the Quarantine Service process.

Both of these steps require the source URL of the originator of the file
data.

Bug: 986588
Change-Id: I367e48a2654ac9aa0dc09979efabc9e31e261609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729291
Commit-Queue: Olivier Yiptong <oyiptong@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683234}

If daily refresh is enabled refresh the custom background image if it's
been more than 24 hours since the last update.

Bug: 850317
Change-Id: Ic3b5611bb9ce975998bce75936e19cfc3dd2ef66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721682Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683233}

TBR: vitaliii@chromium.org
Bug: 972871
Change-Id: I5196841239ddf2ba8294457ecc7542e6843374a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730953Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683232}

Modifies the build to produce system image tarballs.

Adds logic to unpack the tarballs and restructure their contents to
mirror the layout of the image repository uploaded to CIPD.

Bug: 977018
Change-Id: Ib4ccff8a514d72cd426232c6e1a548f593e38082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722287
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683231}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=falken@chromium.org

Bug: 968047
Change-Id: Iffe135d54c238ed7be67fe9bc1bdade9d050ee2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728666
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683230}

https://webrtc.googlesource.com/src.git/+log/84de3d95cf0e..bd3f30535c33

git log 84de3d95cf0e..bd3f30535c33 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 kron@webrtc.org Request a new key frame if packet buffer is cleared
2019-08-01 nisse@webrtc.org Simplify ReportBlockStats

Created with:
  gclient setdep -r src/third_party/webrtc@bd3f30535c33

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I072ff3b2708e82bbe304b918011d59316a857727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730742Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683229}

setting logic.

This updates a unit test and adds another to verify that we're setting
num_attempts as expected for Periodic Background Sync registrations.

Bug: 989444
Change-Id: Ic4aa69f772ce388025ad4344f346464813f679a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729086
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683228}

Prevents the CastRunner from clobbering the Agent's
setTouchSupportEnabled() platform API if it's already been installed.

Bug: 953796,953958
Change-Id: Ia1044a96209f04d792a8c671a8ac18eb98b2d9ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728445Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683227}

This cl adds SupervisedUserCrosSettingsProvider to be able to
control cros settings.

Bug: 945934
Change-Id: Ifd8d5660c6520754543666ce82f189901b1ae7e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724495
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683226}

On Intel the instruction used is CRC-32C (Castagnoli), which uses a
different polynomial than 'traditional' crc32 deployed in zlib.

Fortunately ARM has instructions for both polynomials, so this patch
will ensure that compressed content using Chromium's zlib will match
i.e. checksums should be the same.

Bug: https://issuetracker.google.com/115695768
Change-Id: Ia22bc150e89afa345a6d3149c30332a6c1e7934d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726551
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683225}

Ozone/X11 window "mobility" has been broken by crrev.com/c/1698263. Which
has been observed in apps such as content_shell, ozone_demo. The issue
is caused |ui::XWindow::activatable_| being set to false in those builds.

This fixes it, defaulting PlatformWindowInitProperties::activatable to
true and just forwarding it to ui::XWindow::Configuration at
X11WindowOzone initialization code.

Bug: 988913
Change-Id: I65cd8ab8a5763ae0f0cbfb748f146662f80846d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726597
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683224}

https://skia.googlesource.com/skia.git/+log/a00318f1ad00..69e1462010af

git log a00318f1ad00..69e1462010af --date=short --no-merges --format='%ad %ae %s'
2019-08-01 michaelludwig@google.com Remove SkDEBUGFAIL in SkDisplacementMapEffector ctor
2019-08-01 robertphillips@google.com Add GrCaps::getTestingCombinations

Created with:
  gclient setdep -r src/third_party/skia@69e1462010af

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@google.com

Bug: chromium:988237
Change-Id: Ib923c3c1a51a855ec3430f81c3d81333605d60ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730792Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683223}

Disable the test as it's flaky.

Bug: 982564
Change-Id: I81f4f87ccd6b2b20f497d42debcbba7741da2090
Tbr: khmel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731610Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683222}

Specifically porting:
 - cr-button
 - cr-checkbox
 - cr-toast
 - cr-toggle
 - cr-view-manager
 - md-select, shared-style, hidden-style styles
 - shared icons

Repro:
 - Add optimize_webui=false flag.
 - Go to chrome://print/polymer3/demo.html.
 - See working cr-* elements, styles, icons.
 - Open Devtools console.
 - No HTML imports warnings should exist.

Bug: 965770
Change-Id: I1eec3c588a155ce32477cbd74cbd0a4864fb3ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626665
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683221}

This reverts commit be8f1163.

Reason for revert: crbug.com/977942

Original change's description:
> Replace base::queue with WTF::Deque in mediarecorder
>
> This is a part of moving media recorder implementation to blink.
> This CL replaces base::queue with WTF::Deque in mediarecorder.
>
> Bug: 960665
> Change-Id: If3b1a795b5e21cfd54b83c46481bf6591efaa74a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669255
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#671211}

TBR=mcasas@chromium.org,haraken@chromium.org,guidou@chromium.org,myid.shin@igalia.com

Bug: 960665
Change-Id: I33d40175cfe2cc357fbd876408579c7c07ab4a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730063Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683220}

Before this change, from debug console, you can see:
 - <AppMeasurement>[I-ACS036002] Analytics screen reporting is enabled...
This boolean option in Info.plist turns this off.

Bug: 989857
Change-Id: I83d1a22b9f546e2efb1278aaad7d66edb722fffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729248
Auto-Submit: Peter Lee <pkl@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683219}

The validation to check that the texture is non-null was inverted which
allowed invalid or null textures to pass validation and crash when being
accessed.

BUG=986057

Change-Id: Icc3e297d16e0c80019b49f6b80b1972911f2f338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724694
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683218}

https://swiftshader.googlesource.com/SwiftShader.git/+log/204a410c8c40..f63c4e51101a

git log 204a410c8c40..f63c4e51101a --date=short --no-merges --format='%ad %ae %s'
2019-08-01 bclayton@google.com Reactor: Don't auto-initialize Pointer<T> variables with null.
2019-08-01 bclayton@google.com Reactor: Add nullptr_t copy / assignment operators to Pointer<T>

Created with:
  gclient setdep -r src/third_party/swiftshader@f63c4e51101a

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I51f77af807365c89ba77b30b32ac2e0428610af7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683217}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=boliu@chromium.org, ntfschr@chromium.org

Bug: 968047
Change-Id: Ia18ba834e8e7182f4d7224645e05e894f1991173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728661
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683216}

Currently when only federated credentials are saved on the site,
the key icon isn't showing up when we refresh the site.

Bug: 677111
Change-Id: I0188d001b59f2af081688acb89adf0928898ead5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717301
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683215}

https://chromium.googlesource.com/angle/angle.git/+log/e995d7fb23c5..868f5fa02353

git log e995d7fb23c5..868f5fa02353 --date=short --no-merges --format='%ad %ae %s'
2019-08-01 jmadill@chromium.org Refactor return values from entry points.

Created with:
  gclient setdep -r src/third_party/angle@868f5fa02353

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: I9d212cf8906e5e84c2c9dd419bd7059af8d1ff24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730736Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#683214}

All policy-based extensions' files should be checked in some way. It
already works for Chrome Web Store extension, but not yet for
self-hosted ones. This commit adds a way of telling to ContentVerifier
that extension should be checked.

The commit only adds a new delegate method, which is not yet used.

Bug: 958794
Change-Id: I67898ce61c47d9ecc53c0398bfa5e9bdb65373b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710327Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@google.com>
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683213}

This CL removed a for-test function since it's no longer used.

Bug: NONE
Change-Id: I998b98f68e9bba9f8366747c4bc7854dfbc97ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728180Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683212}

This is a reland of 107a4e3e

Original change's description:
> Integration tests for click to call
> 
> Bug: 982229
> Change-Id: I3d0f19b55dc6dc07c6ad427d670aaa2db0a9af2d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718410
> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#682242}

Bug: 982229
Change-Id: Id20a918d405d7f56fa1a362666b2da510ee4b3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728552Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683211}