- 30 Jul, 2019 40 commits
-
-
Michael Lippautz authored
- Minor ThreadHeapStatsCollector fixes - Refactor sweeping finalization to reflect the two-step approach (Notify -> PostSweep) that already happened in practice. Initially landed see https://crrev.com/c/1713626 Bug: 982754 Change-Id: I358e0cb43129fd631c31b626e64157e3ba57ce07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724675 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682274}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e5d9dba..45872947 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd183941f838f40387005c7c8961b89efba96042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724644Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682273}
-
Kevin Ellis authored
This patch makes several of the internal methods in animation.cc private. Specifically, the now private methods are: SetCurrentTimeInternal CurrentTimeInternal PlayStateInternal This CL is part of a series of patches aimed at transitioning to the use of methods that are well documented in web specifications. In particular, PlayStateInternal is not spec compliant as it introduces an extra play state (pending). Bug: 960944 Change-Id: I22d59fc37a9f48863e7b52ab32b9d74e164bcfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716964Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#682272}
-
Jordan Demeulenaere authored
Change-Id: I69a14a6e77e53e6eea77aa1c5e4e905b59ae6720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724761Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#682271}
-
Colin Blundell authored
Similar to the code usage snippet that was added for AccessTokenFetcher. Bug: 970295 Change-Id: I80b261978ff475e39a01d03b5756ec81cb7b45d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724078Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682270}
-
Stephane Zermatten authored
Before this change, both unexpected taps and cancels were recorded as SHEET_CLOSED. This was wrong, as unexpected taps should be recorded as OVERLAY_STOP. Change-Id: I6f368611ecaf541fe70bc7a81195c91ada6da116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726089 Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#682269}
-
Mugdha Lakhani authored
For Periodic Background Sync, we decide the next event time for a registration based on other existing periodicsync registrations for this origin. Skip this check for one-shot Background Sync registrations. Currently, if we have both a one-shot and a periodic Background Sync registration for a given origin, this check will be applied to the one-shot sync registration as well. This is unnecessary. This CL removes it and adds a unit test. Bug: 989003 Change-Id: Iff2b1d0444878444c6c1743f6ae0882caca86dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725638Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#682268}
-
manuk authored
Followup to making the feature default enabled. Bug: 966462 Change-Id: Ic7924049df1e14373c0a695878d51d32d0d77ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724118Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682267}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b24e912d9bae..e90f86832eff Created with: gclient setdep -r src-internal@e90f86832eff The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I1b259f2b193c928ed06bfef1219c304fb5f8bf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682266}
-
Ian Kilpatrick authored
There was special logic added for zero width inlines in: https://chromium-review.googlesource.com/c/chromium/src/+/870950/ This logic allowed for zero-width layout opportunities beside floats for inline-level content. This also added a TODO saying this was probably wrong for floats. .... it turned out this was wrong for floats. :) This adds a flag to switch between these two behaviours. Bug: 988505 Change-Id: I2db5e0b9cb6f90cb131821ad205728289d9098ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725309Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682265}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e671a6937e36..4c2c8d173f38 git log e671a6937e36..4c2c8d173f38 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 capn@google.com Compile GLSL in a critical section Created with: gclient setdep -r src/third_party/swiftshader@4c2c8d173f38 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137828018 Change-Id: Ie560611019e1ac27e51437da53a401316ff305cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682264}
-
Adam Langley authored
I think this comment is out of date. (At least I can't find DefaultPolicy.) Therefore update it to reference FeatureDefault, which I think is correct. Change-Id: Iab8fbd9eb71f269d159c8eab5c9de86a2b884a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724468 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#682263}
-
Juan Antonio Navarro Perez authored
We're making stricter requirements on how clients can interact with result objects; in particular they should call DidRunPage before attempting to read (iterate over) the stored results. This is needed to allow the following catapult CL to land: https://chromium-review.googlesource.com/c/catapult/+/1725950 Bug: 973837 Change-Id: I51b1f757344607a497bdca99b86d71583fffaf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725912Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/753002daef60..7deaf37e9442 $ git log 753002dae..7deaf37e9 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 bnc Make QuicSpdyStreamBodyBuffer manage consuming HEADERS frame header and payload. 2019-07-25 renjietang Create HTTP/3 unidirectional stream only when stream limit allows. 2019-07-25 fayang gfe-relnote: In QUIC, replaces QuicStream::priority_ with QuicStream::precedence_ and pluming it to write_blocked_list. No functional change expected. Not protected. 2019-07-25 bnc Rewrite QuicSpdyStreamBodyBuffer's consumed byte tracking algorithm. 2019-07-25 bnc Add QpackHeaderTable::draining_index(). 2019-07-25 bnc Use QpackEncodeRequiredInsertCount(0) instead of 0 in QpackEncoder. 2019-07-24 dschinazi Internal QUICHE change 2019-07-24 renjietang gfe-relnote: n/a - Remove unused member variable in QuicSpdySession 2019-07-24 nharper Add tool for testing quic interop Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src update flags R=rch@chromium.org Change-Id: Ic6c9b0ae4f4d4dadd928d771eb6b64ded55f497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721459Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682261}
-
Kush Sinha authored
If Chrome OS Account Manager - Has been fully initialized, and - Receives an initialization request with a callback, that callback is never invoked. Fix this by calling initialization callbacks instead of just early exiting in the case of duplicate initialization requests. Bug: 967602 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I2d072c50df158c81adc1be497c9891603ac52038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722532 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#682260}
-
Boris Sazonov authored
This CL fixes the button highlight when toolbar buttons are focused using a keyboard. There are two unrelated fixes: 1. ToggleTabStackButton now inherits ChromeImageButton instead of generic ImageButton. 2. ToolbarMenuButtonPhone style no longer forces the background to be null, keeping selectableItemBackground set by ToolbarButton style. Bug: 955037 Change-Id: Idc20378c9660dc0d95189af5efc417dd861512da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725909 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682259}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/105c9d507045..9dc0b9e2f86a git log 105c9d507045..9dc0b9e2f86a --date=short --no-merges --format='%ad %ae %s' 2019-07-30 reed@google.com remove code now that loopers are dead (w.r.t. canvas and paint) Created with: gclient setdep -r src/third_party/skia@9dc0b9e2f86a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I0bb7d7c0042a680ab413a97835b0a266767eb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726010Reviewed-by:
-
Askar Aitzhan authored
There is a policy "DeviceOffHours" which defines some time intervals when some policies gets deleted from policy blob. Among them there is a policy "DeviceGuestModeEnabled". If it's set to false after removing it from policy blob it should default to "true", thus allowing browsing as a guest. Before: There is a button on login screen "Browser as Guest", because policy "DeviceGuestModeEnabled" defaulted to "true" after deleting it from policy blob. But when pressing it Chrome restarts and tries to initialize profile synchronously. But "DeviceOffHours" doesn't get applied because it's a policy that relies on time, and makes async DBus call. So DeviceOffHoursController assumes that time is not reliable and logs out the user. After: Assume that time is reliable until the response from DBus call arrived, thus allowing synchronous profile initialization to finish. After finishing, response from DBus call arrives and corresponding actions are taken (log user out if time is not synchronized). User log out flow: * DeviceOffHoursController::UpdateOffHoursMode => * DeviceOffHoursController::SetOffHoursMode => * DeviceOffHoursController::OffHoursModeIsChanged => * DeviceSettingsService::Load => * DeviceSettingsService::HandleCompletedOperation => * DeviceSettingsService::NotifyDeviceSettingsUpdated => * DeviceSettingsProvider::DeviceSettingsUpdated => * DeviceSettingsProvider::UpdateAndProceedStoring => * DeviceSettingsProvider::UpdateFromService => * DeviceSettingsProvider::UpdateValuesCache => * DeviceSettingsProvider::DecodePolicies => * DecodeLoginPolicies (in device_settings_provider.cc) => * DecodeLoginPolicies changes CrosSettings => * CrosSettings change gets observed by ChromeUserManagerImpl => * UserManagerBase::NotifyUsersSignInConstraintsChanged => * UserSessionManager::OnUsersSignInConstraintsChanged => * AttemptUserExit Test: Set DeviceGuestModeEnabled to "false", Configure "DeviceOffHours" policy to have an interval from Monday 12:00am till Sunday 11:30pm. During an Off Hours interval sign in to the device, disable all the network connections. Exptectation: user will be kicked out as soon network connections are gone. Bug: 930567 Change-Id: I4f7fd429ba7cb64cf99a943e1f5e8686801279d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699667 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#682257}
-
Vasiliy Telezhnikov authored
When disable_es3_gl_context_for_testing is used we force GLVersionInfo to believe that ES3 is not supported by current hardware/driver. Previously it was forcing desktop GL version to 3.0 which doesn't seem to work with Skia. Forcing it to 3.2 achieves the same for test but don't cause any other problems in graphics stack. Bug: 984110 Change-Id: I06d8074eb3e564d2007d9bc8395d53e70dd04c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723801Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#682256}
-
W. James MacLean authored
Since the DCHECK failure in the associated bug is hard to reproduce locally, add output to the DCHECK to determine what type(s) of event(s) are causing it to fail. Hopefully this will get recorded in the crash output should the issue reproduce. Bug: 985944 Change-Id: I3fa8032fb3130d366248a5b134887f54d36070f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724585Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#682255}
-
Carlos Caballero authored
It is currently just an alias to MessagePump::Type. This patch changes a bunch of references to use MessagePump::Type as MessageLoop will eventually disappear. Also rename base::Thread::Options::message_loop_type to message_pump_type It is weird to see things like message_loop_type = MessagePump::Type::UI Also change some other instances that I happened to see in the form loop_type = MessagePump::Type::UI to pump_type = MessagePump::Type::UI This is a mechanical change that will be reviewed according to https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes BUG=891670 TBR=gab@chromium.org Change-Id: Ib41ccc6547b8c9fa0bdba5d23c4767ae03f2a97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718331 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#682254}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9559cdbdf011..ac3d131054ac git log 9559cdbdf011..ac3d131054ac --date=short --no-merges --format='%ad %ae %s' 2019-07-30 dneto@google.com Element type is const for analysis::Vector,Matrix,RuntimeArray (#2765) 2019-07-29 dnovillo@google.com Protect against out-of-bounds references when folding OpCompositeExtract (#2774) 2019-07-29 alanbaker@google.com Don't move debug or decorations when folding (#2772) 2019-07-29 zoddicus@users.noreply.github.com Update OpControlBarriers rules for WebGPU (#2769) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ac3d131054ac The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I23aa3289677f410d3801e888119acfaa5e8db761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725353Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f39e22b4. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iff82de029c41bda6bf62c912b2040cb46a925b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724564Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682252}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c54fa2d4559..afb67c64981e git log 7c54fa2d4559..afb67c64981e --date=short --no-merges --format='%ad %ae %s' 2019-07-30 perezju@chromium.org Revert "[Telemetry] Do not allow iterating over results while running stories" 2019-07-30 perezju@chromium.org [Telemetry] Merge command line help from Telemetry and external parsers 2019-07-30 perezju@chromium.org [Telemetry] Do not allow iterating over results while running stories Created with: gclient setdep -r src/third_party/catapult@afb67c64981e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:973837,chromium:981349,chromium:973837 Change-Id: I12bbddace34a5f376d77473c46aff7f53f3db3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725406Reviewed-by:
-
Kush Sinha authored
Move the update / insertion of the Primary Account's refresh token on Chrome OS to occur before the Primary Account is set in Identity Manager. Design Doc: http://bit.ly/2wkDLLN Summary of changes: - Move the update/insertion of the Primary Account in |AccountManager| from |OAuth2LoginManager| to |UserSessionManager|. This is required so that the Primary Account can be known to |IdentityManager| before it tries to set it in |UserSessionManager::InitProfilePreferences|. - Remove dead code: |OAuth2LoginManager::Observer::OnNewRefreshTokenAvaiable|. - Add UMA stats to track the usage of the legacy API. Manual Test Cases: - OOBE and Login with Account Manager disabled via flag. - Migration to Account Manager. - OOBE and Login with Account Manager enabled. Bug: 967602 Change-Id: I9b734894464d21a72ee5c48531513e730769b7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640057 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682250}
-
Jordan Demeulenaere authored
Bug: 968150 Bug: b/123917157 Change-Id: Ieac89e71474d5e618387873a278ad46f15d5c121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722963 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
-
Adam Rice authored
Previously flow control was not exposed to clients of blink::WebSocketChannel. Expose it by adding ApplyBackpressure() and RemoveBackpressure() methods. These are called by clients to start and stop the additional of new receiving flow control quota. Because there may still be outstanding receive quota, DidReceive*Message() can be called again even after ApplyBackpressure() is called. Once available receive quota is exhausted the messages will stop until RemoveBackpressure() is called. This feature will be used by the WebSocketStream implementation. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit#heading=h.7nki9mck5t64 Also move some initialisers for simple member variables to the header in WebSocketChannelImpl. BUG=983030 Change-Id: If3423f43adf7b7225d0d89eda2a94ce2cef4cb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718966 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#682248}
-
Robbie Gibson authored
Bug: 986804, 987907 Change-Id: Ibf4b7664100f9d318c2110017ea631dc28d66866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713536 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682247}
-
Takuto Ikuta authored
Test from this builder consumes around the following machine hour * p99 CI: 67.32944444444445 * p90 CI: 38.772222222222226 * p50 CI: 36.01555555555556 * p99 CQ: 61.65472222222222 * p90 CQ: 51.79527777777778 * p50 CQ: 33.22638888888889 in chrome pool in recent 30 days. I took the stats from http://shortn/_MnHq3A4dxc some test failure is not xenial specific (crbug.com/988997). I will submit this with https://chrome-internal-review.googlesource.com/c/infradata/config/+/1543036 Bug: 954450 Change-Id: I4c69fe4c9451958a519685d0f5209c75699e3b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710897Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#682246}
-
Yutaka Hirano authored
Otherwise, the throttled request will just be discarded when the frame is detached. Bug: 988102 Change-Id: I1104d7eed6e563cdfdf37b1af6a1205b4adb852c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724526 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682245}
-
Andrew Grieve authored
Bug: 988500 Change-Id: I3fc313404d84a089fbb2650ec588ad5cb58ed2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723799Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#682244}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenInvalidated in O2ATMtest to test that InvalidateAccessToken triggers OnAccessTokenInvalidated from |delegate_|. Bug: 967598 Change-Id: I8c1433646b1e765b072baf20f69ab5f2374e3b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724152Reviewed-by:
-
Himanshu Jaju authored
Bug: 982229 Change-Id: I3d0f19b55dc6dc07c6ad427d670aaa2db0a9af2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718410 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682242}
-
Tomasz Śniatowski authored
https://chromium-review.googlesource.com/c/chromium/src/+/1647268 moved the "current downloaded clang" stamp file, which causes inconsistencies to appear when switching between branches or bisecting across the stamp file move and any clang update. As a partial workaround, remove the old stamp file if it's on disk so in case the user switches back to before the stamp file move, the script always downloads the correct version of clang. Otherwise the script might see an old stamp file and incorrectly assume it doesn't need to download, leaving the user with a broken state (wrong clang). There is no need to handle the opposite case (when the old script downloads clang and notes it in the old stamp file) because the new stamp file location is inside the directory that's clobbered by the download process in either case. Bug: 988933 Change-Id: I9d37996a9b1b3e9375b269eea36e6884a1edfb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724679Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#682241}
-
Nico Weber authored
Moving these constants out-of-line means that the dep on build:branding_buildflags doesn't have to be in public_deps. No behavior change. Bug: 961769 Change-Id: I070afcb39d23eee6a1cf0c40e49c064ddc01b353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724665Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682240}
-
Eero Häkkinen authored
This mojo method is not needed any more because the remove operation was removed from the spec. Bug: 968553 Change-Id: I44591c9a3f198390f5ff69b928c2f70d35fdecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722547Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#682239}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e78b7c05..6e5d9dba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb4dd8b97e9dc493b1d03153ce972d029c6484d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724608Reviewed-by:
-
Colin Blundell authored
This CL adds documentation of how the various core internal classes support the public IdentityManager API surface. The target audience is engineers looking to maintain/change/enhance the implementation of IdentityManager (e.g., members of the signin team). Bug: 970295 Change-Id: I73c13120ec38c791b8b2f973c026c8fca47148d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722935Reviewed-by:
-
Lutz Justen authored
This reverts commit b223de22. Reason for revert: Breaks branded Chrome OS build: ../../chromeos/services/assistant/media_session/assistant_media_session.cc:144:28: error: no member named 'encountered_error' in 'mojo::Remote<media_session::mojom::AudioFocusManager>' ../../chromeos/services/assistant/media_session/assistant_media_session.cc:149:44: error: no member named 'BindNewPipeAndPassReceiver' in 'media_session::mojom::AudioFocusManagerProxy' because of assistant_media_session.cc. Note that this file only compiles with gn arg is_chrome_branded = true. I think audio_focus_remote_->BindNewPipeAndPassReceiver() has to be audio_focus_remote_.BindNewPipeAndPassReceiver(), but I couldn't figure out how to fix encountered_error(). See also https://chromium-review.googlesource.com/c/chromium/src/+/1725553 Original change's description: > Convert services/media_session services to new Mojo types (6/n) > > The primary goal of this CL is to convert usage of |functions| of > interface AudioFocusManager and port dependent files to adopt new > implementation. > > Bug: 955171 > Change-Id: I2c8f269b2b36034b9ebc5beb1aef56ee3db691b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715367 > Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682154} TBR=oshima@chromium.org,kinuko@chromium.org,rockot@google.com,abhijeet@igalia.com Change-Id: Ie5a8b1652ddf623b21a903334713944122013e15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 988971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725890 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
Carlos Caballero authored
MessagePumpType is used in other places (eg base/thread.h). Moving it to its own file will simplify include dependencies. Bug: 891670 Change-Id: I214342da0d6833e0ad324cd4d58c08a0233f7c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718806 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
