GitLab

Moves the feature logic to a check-everything paradigm instead of doing
early returns, for the sake of easy to understand metrics.

privacy doc: http://shortn/_99lQLYJfL1

Bug: 1115259
Change-Id: I036a412104d9ccce885789637461314d50f1e967
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388270Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806701}

The issue below is mostly timeouts.
The relevant diff was to DrainWorklist which used to return true for
empty worklists, but now might return false.
The change to DrainWorklist was made to guarantee no draining is done
when we should yield (due to deadline or job scheduling). Before the
change we would also drain at least one item, which could take some
time. This CL adds a check for emptiness before the yielding check.
This restores previous behavior for empty worklists and avoid
draining an object if we should already yield.

Bug: 1127888
Change-Id: I726d205516bc23b7a2345e5e68e35e08d866f722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409944Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806700}

We no longer merge APKs - the build time saving it provided stopped
working some time ago due to additional dependencies between the ABIs,
and we just archive the symbols from 64-bit bots' 32-bit binaries
separately so there's no real need for the libs to be identical.

Remove the script to make it clear we don't support this any more.

Fixes: 1039881
Change-Id: I5f6f5e102b69518b737664011b7abeb78a40ba65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409924
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806699}

Pass in a SettingsLauncher when constructing ShareSheetCoordinator that
will eventually be passed to SendTabToSelfShareActivity.

Bug: 1090917
Change-Id: I0690a2b552503e95873b9aec1b993f1a18405476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250699Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806698}

Add implementation to chrome://.

Add implementation to chrome-untrusted://.

Add tests.

Bug: b:162051831
Change-Id: I3749503e240a14b1d4ff76cfd3c477470ae704c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396089
Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#806697}

The NPE occurs with the following sequence:
1. show tab-modal dialog.
2. some portion of the containing view hierarchy is removed from a window.
3. dialog dismissed.
4. animation started in 1 finishes, triggering trying to use an object
   that was set to null.

Step 3 needs to cancel the start animation.

BUG=1127254
TEST=covered by test

Change-Id: I58c80c0a1e8330c0b87b2a56e228d67bc61b2cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406933
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806696}

Added builders to luci.chromium.try, waiting for that to land.

Bug: 990885,1125612
Change-Id: If4031cc35a54c987fcaa4b4e494645dd73c77e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402762Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#806695}

Bug: 1046463
Change-Id: I19836bb8315c62d50510d19673a7f4baff3df51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399002
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806694}

IT seems that canvas_fuzzer is yielding lots of false positives, this CL
disables the fuzzer temporarily in order to improve it to reduce false
positives.

Bug: 1124824, 1124812
Change-Id: I293de80684f7878c1b2c8da43a816bf8572840e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402970
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806693}

The code was added in crrev.com/769833 to catch the cases that some
DisplayItemClients were deleted before PaintController::FinishCycle().
We haven't seen any crash reports caught by the code.

Remove the code to ease refactoring of PaintController.

Bug: 1021766, 917911
Change-Id: I06b2bff15207739c1b64779ff20876cd86205511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409212
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806692}

This CL improves AccountPickerBottomSheetRenderTest's account list
expanding action to reduce the flakiness.

Bug: 1127676
Change-Id: Id0849d4c388151b2752a3678a722cac05eb7e9cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407255Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806691}

Adds user actions in the Discover feed metrics recorder alongside the
existing histograms. Mostly reuses existing actions, but added a few
to be in sync with the currently logged histograms.

Bug: 1127457, 1085419
Change-Id: I54db65f31122787942601e6c421b713c8a440022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405858Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/master@{#806690}

The iOS testing templates are not generating .runtime_deps files at
'gn gen' time and this is a pre-requisite to be able to switch WebRTC
tests from the old isolate procedure the the one based on GN/MB.

Bug: webrtc:11930
Change-Id: I2cfde6a9f47526c9e5f0c6a2dbfc470bf4d3284f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407898Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806689}

This change modifies the WellKnownChangePasswordNavigationThrottle to
only be instantiated for main frame navigations.

Fixed: 1127520
Change-Id: Ia63ecaa4a2411a578956049797cb722012339ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410382Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806688}

Crash stack traces are pointing to very occasional errors with AXPosition.
They all seem to be cases where a DCHECK would have failed. I think the
best approach is to not only DCHECK but also gracefully handle the failure
case if it does occur. Not setting the selection doesn't have to be a
fatal error.

Bug: 1116340
Change-Id: I038dc793118214905aa46daf587b9c7a2f9018e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404386
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806687}

This reverts commit 3481a5a7.

Reason for revert: Broke TranslateBrowserTest on android-pie-x86-rel
https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2212
Test output
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869167939689927152/+/steps/weblayer_browsertests/0/logs/Deterministic_failure:_TranslateBrowserTest.TranslateInfoBarNeverTranslateSite__status_FAILURE_/0

It is possible that that specific test needs an adjustment to go in
together with this.

Original change's description:
> [WebLayer] Add ability to override translate target language
> 
> This CL adds the ability to override the target language used by the
> translate feature on a per-Tab basis. This is analogous to the
> functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the
> override is set, all translate infobars in the given Tab will appear
> with the specified language as the target language. Calling
> Tab#setTranslateTargetLanguage() with an empty string clears the
> override and causes behavior to revert to normal.
> 
> Note that even with the override set the translate infobar will not
> appear for pages that are in the user's locale. This is internal
> behavior of Chromium's translate component and is common to CCT and
> WebLayer.
> 
> I marked the added method as since 86 as this CL will be targeted for
> cherrypicking to 86.
> 
> Bug: 1116394
> Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806633}

TBR=jam@chromium.org,blundell@chromium.org,cduvall@chromium.org

Change-Id: Idbb50b93aea9a4037e2956ba63a570047e50944b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410610Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806686}

Since getDefaultPaymentInformation is PaymentRequest UI logic,
move it into PaymentUIsManager.

Bug: 1102522, 1114791
Change-Id: If2f958f38bd81677d734621150ad944b19945212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406693
Commit-Queue: Zarah Tesfai <ztesfai@google.com>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806685}

Refactors NamedMessagePortConnector into a platform-agnostic component,
which can be reused across FIDL, in-process, and testing contexts.
It uses Blink messages and message ports as a common basis for
message and port transport.

* Implements some missing portions of the Blink/FIDL MessagePort
  conversion layer.
* Adds a Fuchsia implementation of NMPC.

Bug: 1104369
Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806684}

If the IVirtualDestkopManager COM method IsWindowOnCurrentVirtualDesktop
fails on a window, treat the window as non-occluding, because that's
safer than treating it as occluding - it might be on an another virtual
desktop, and thus should be non-occluding.

Previously, IsWindowOnCurrentVirtualDesktop was incorrectly returning
base::Optional nullopt on Windows 7 and 8.1 (i.e., unknown). This CL
makes it return true, because there are no virtual desktops on Win 7/8,
so every window is on the current desktop. This allows us to require
that IsWindowOnCurrentVirtualDesktop return true to say that a window
is occluding - previously we checked for != false, to handle Win7.

Bug: 813093
Change-Id: Iee49eff9333a8530314720702b1815256acdbfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410420Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806683}

DownloadManagerService#getProfileKey used getLastUsedRegularProfile to
get profile, which could cause exceptions if the function was called
before regular profile was created.

This is now changed to use ProfileKey#getLastUsedRegularProfile which
handles this case and returns the ProfileKeyStartupAccessor in that case.

Bug: 1106324, 1099577
Change-Id: I1deb3c1484abfcdf871dde1fb8a81853ee1bb371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409272Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806682}

It moved to //components in ff2cc1b1

Bug: 1057100,1127697
Change-Id: Ie1a88bb576d73b04fd73dc5d1214250ddbc82266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410437
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806681}

Remove a DCHECK introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/2385929

It is triggered on Android Webview on the test:
org.chromium.android_webview.test.AwContentsTest#testCreateLoadDestroyManyAtOnce

This will make the 'test-o-phone' tester green again, while sadrul@
investigate this bug.

TBR=sadrul@chromium.org

BUG=1127872

Change-Id: I50a712522636b53462622993c2c2b83038a29f98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410477Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806680}

1. add checks for hide crash button to be displayed in every
showingCrashTest
2. testHideCrashButton: checks if hide crash button removes the crash
from the view

Bug: 1059944
Test: run_webview_instrumentation_test_apk -f *CrashesListFragmentTest*
Change-Id: Iec4d623802468d4d7269384e0ad722a224b1b8e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405573Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Commit-Queue: Azhara Assanova <azharaa@google.com>
Auto-Submit: Azhara Assanova <azharaa@google.com>
Cr-Commit-Position: refs/heads/master@{#806679}

The previous behaviour had those events reported with whatever verdict
Chrome received afterwards, which is inaccurate as the upload was
allowed.

Bug: 1120952
Change-Id: Ie503eac951a835aacbb977cd014e8ca31db4f4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406536Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806678}

This adds a feature that limits the number of entries in
each Safe Browsing list to 2^{18}, which can be used to
measure the impact of limiting the size of the Safe
Browsing database.

Change-Id: Ieef0697ca60e6cd2c65e13b32b425a6ce08c0844
Bug: 1127429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402112
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806677}

BUG=1096303

Change-Id: Ib8ab6c447f11da6ddb37275fed67ec8e2946d141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405937Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mike Pinkerton <pinkerton@chromium.org>
Auto-Submit: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806676}

This is a reland of 3480cbb1

I had to revert the original due to small time regressions in time to
navigation commit time and a larger regression in memory.

I've deferred the initialization of the warm compositor to after we know
we likely have something to show to avoid this regression as much as
possible. This improves things by O(10 ms) still, but is not as
significant of an improvement as before.

Original change's description:
> [Paint Preview] Pre-warm compositor
>
> This CL adds the ability to pre-warm a compositor process for use by
> paint preview show-on-startup.
>
> 1. The compositor is started when native is initialized if the
>    experiment is enabled.
> 2. Depending on the situation the compositor is then used or killed.
>    a. Compositor is used: disconnect handler is updated and it is used
>       as if there was a compositor already.
>    b. Compositor is not used: the process is killed immediately.
>
> This moves initialization of the compositor service up to O(100 ms)
> earlier (in local tests).
>
> Bug: 1126180
> Change-Id: I1e6f627403e8c020b6551c510ad908bba0fc24a2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398562
> Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805317}

Bug: 1126180
Change-Id: I7f7764bb080622b990dfadb7a99957cc9d992668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403580Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806675}

This prompts the user to select an area.
It will be implemented in a follow-up CL.

Bug: b/165356952
Tests: manually deployed
Change-Id: I33c1cc49c4cea542b87256cb00ac3370ef8a4427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376026
Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806674}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I1d381903ba67fb0ab666976478f909212bf8ba5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409939Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806673}

Bug: 1113715
Change-Id: Ia927f27bba18eedf56447fa05afd3bddde679331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273128
Commit-Queue: Clovis PJ <clovispj@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806672}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I4b8e797d5bf9415efa7d05163fb961887093a697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806671}

This CL makes sure that the NTP is correctly layout with MultiWindow.
With MultiWindow, the NTP view is created with a frame of CGRectZero.
Without MultiWindow, the frame is the one of the app.
Forcing the layout after setting the frame, ensures that the elements
are correctly positioned and sized.

Fixed: 1121993
Change-Id: I1c8ae1c468934a36eedd7687348547bf5885e1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410379
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806670}

This CL updates the subtitle string for the web sign-in bottom sheet
according to the latest UI mock.

Screenshot: https://crbug.com/1119718#c2
Bug: 1119718
Change-Id: I0babfaece628a469944f170bcbe920aa559cbd01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367681Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806669}

This reverts commit b1f4b048.

Reason for revert:
Loses test coverage on hundreds of tests from only a single
DCHECK failure. This did not appear to affect cq so should
not affect developer productivity. Re-enabling and going to
resolve the DCHECK failure instead

Original change's description:
> Disable AwSettingsTest.
> 
> Bug: 1126917
> TBR: boliu@chromium.org
> Change-Id: I77d7c6e12f975cb2cb17f5a9ee015d714f3a559b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405702
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806206}

TBR=hanxi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1126917
Change-Id: Idf6793a92576518c0898e736d64912925c6a3196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410340Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806668}

flat_set is simply a sorted vector without duplicates. Previously we
were relying on runtime debug-only checks that our vectors were sorted,
despite needing sorted vectors for the code to be correct. Now sorting
is assured by the data structure.

Bug: 1102701
Change-Id: I6a10dda01e6ef9e2ae8bea38e207afe10137c3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398449
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806667}

R=dpapad@chromium.org
BUG=none

Change-Id: Ifb796b08338cfd17e0c99a06aaad6f2a934e7748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020864
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806666}

render_frame_host->is_mhtml_document() became false after a
same-document navigation, which is wrong.

This is fixed by here.

R=acolwell@chromium.org,nasko@chromium.org
TBR=nasko@chromium.org

Bug: 1126391
Change-Id: Ie473c396ea9769356c39d8eee1d1915c0a136807
Fixed: 1126391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404340Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806665}

Revert "Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu"

This reverts commit 24c91f76.

Reason for revert: Resulting browser process crashes

Original change's description:
> Consolidate translation check and execution logic between TranslateManager and RenderViewContextMenu
> 
> Consolidated logic by having RenderViewContextMenu::ExecTranslate call
> TranslateManager::InitiateManualTranslation, and RenderViewContextMenu::AppendPageItems call
> TranslateManager:CanManuallyTranslate.
> 
> Bug: 898168
> Change-Id: If91cf98626f73d0c357522f8fdca840695185bc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385636
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Megan Jablonski <megjablon@chromium.org>
> Commit-Queue: Anthony Cui <cuianthony@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806161}

TBR=avi@chromium.org,sclittle@chromium.org,megjablon@chromium.org,cuianthony@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 898168
Change-Id: I23e202b72625365eedcd124af000c972ced3f816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409140Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806664}

Bug: 1123202
Change-Id: I0c766d95e62059f815cbec907d8703c522963150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409218
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806663}

Remove an used dep of the tests of DefaultBrowserPromo.

Bug: 1090103
Change-Id: I49c9cdc88bd773cd47a48b877227c307354c39a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408875
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Auto-Submit: Lijin Shen <lazzzis@google.com>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806662}