GitLab

This change adds the captive portal routine and group to the
connectivity diagnostics application.

Bug: chromium:1142857
Change-Id: I64759b54a34ee2291ebdfac273da85f9157740fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583030Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836363}

This requires adding support to context menus to close without animation,
otherwise it will still be visible as the default close has a fade out
animation, and the screenshot will capture a near-opaque version of the
menu.

Accelerators by default will also close menus with fade out, so add the
desk activation acclerator to the exception list and let the desk
animation code handle the closing.

Fixed: 991939
Test: manual
Change-Id: I273042a216c651022215929594a2cedd1efecc82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586013
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836362}

Change-Id: Iafa6c4057fde064553ece03b3c90009184fbf868
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578008Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#836361}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bf3f26cf343..8093cb08ef89

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC alexmos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1056387
Tbr: alexmos@google.com
Change-Id: Iccce963d4f19d0ed7feee154320c1a901e1eafbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587752Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836360}

Roll Chrome Win64 PGO profile from chrome-win64-master-1607687924-42a73eb0331784066b7e53d64e9d9a239913c74b.profdata to chrome-win64-master-1607698715-e13d73f1fde8c8ea06b6de4bb97b90c11d1836bd.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I87f542471a2da868c78368896d73155384b72d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587390Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836359}

Moves the splitting of expectations based on staleness out of the
output code and uses it to automatically remove stale expectations from
the expectation file if specified by the user.

Bug: 998329
Change-Id: I317ded44447203b8fddc2c6277ed3f5f5b66a0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585846Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836358}

Dev and debug versions throw DCHECK in OnDecodeDone due to wrong syntax of logging statement:
```
FUNCTION_DVLOG(status.is_ok() ? 3 : 1) << ": " << status.code();
```
The FUNCTION_DVLOG is defined as follows:
```
  DVLOG(level) << __func__ << "<" << GetStreamTypeString() << ">"
```

The issue is that the condition "status.is_ok() ? 3 : 1" should become "level", but in reality, since there are no braces around it, it gets parsed incorrectly and the number "3" becomes a severity level (see base/logging.h), which corresponds to "FATAL" severity level, which ends up which crash / assert.

Here is the code after preprocessor for that line 524 BEFORE the fix:

  !(((status.is_ok() ? 3 : 1) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code();

and this is the fixed version:

  !((((status.is_ok() ? 3 : 1)) <= ::logging::GetVlogLevel("../../media/filters/decoder_stream.cc")) && (true)) ? (void) 0 : ::logging::LogMessageVoidify() & (::logging::LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream()) << __func__ << "<" << GetStreamTypeString() << ">" << ": " << status.code();

Pay attention to this part:

LogMessage("../../media/filters/decoder_stream.cc", 524, -status.is_ok() ? 3 : 1).stream())

and

LogMessage("../../media/filters/decoder_stream.cc", 524, -(status.is_ok() ? 3 : 1)).stream())

So, basically, before the fix the negative sign is applied to the wrong statement, therefore the LogMessage will get +3 instead of -3. +3 means FATAL, while -3 means verbosity level 3, as far as I understand.

Fixed: 1157701, 1156942
Change-Id: I3132dde1dbd7d18460b74715016b74228e52ad7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586656Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Artem Bolgar <artyom@fb.com>
Cr-Commit-Position: refs/heads/master@{#836357}

Bug: 1157263
Change-Id: I0a02c2db8ec6a68f0fe2dec26269d72db9d9653e
Tbr: mlamouri@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587208Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836356}

This CL updates DCHECK for checking the child count of the text
field on GetTextContainerForPlainTextField(). The text field
could have a sibling of the static text when it has a
placeholder break element. So, this change increases the child
count.

AX-Relnotes: n/a

Bug: 1137292
Change-Id: Ib6d6826ce23156e8d5562d9561ad8061d46b6946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578718
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836355}

https://dawn.googlesource.com/tint.git/+log/ccc67252ffa4..4226b6a1d8bf

2020-12-11 dsinclair@chromium.org Add Symbol to alias.
2020-12-11 dsinclair@chromium.org Add a symbol to the Identifier AST node
2020-12-11 dneto@google.com spirv-reader: refactor, add ToI32 helper
2020-12-11 dsinclair@chromium.org Add a demangler
2020-12-11 dsinclair@chromium.org Add a symbol to the Function AST node.
2020-12-11 dneto@google.com spirv-reader: Support multisampled textures
2020-12-11 bclayton@google.com ast: Merge DecoratedVariable into Variable

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: I9d45cf7cfdfb89b15e9d4df07b3ac40a8c818f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587223Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836354}

It was very surprising to me, in a NavigationRequest for a subframe,
that these are not the previous URL of the subframe that is navigating.


Bug: 1068965
Change-Id: I9765f176fc7dacffa522a80d520ec5660ea175b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230428
Auto-Submit: Fergal Daly <fergal@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836353}

Updates to the insets in response to rotations are necessary for iphones
with notches so that they match the new intrinsic safe area insets.

Bug: 1151932
Change-Id: I2405550da8e9d75899d422ea58a63d54b6780b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568543
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836352}

This reverts commit 32c3c769.

Reason for revert:

ReadingListTestCase/testSwipeDownDismiss is failing again. 
Oct 21 2020 https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-sdk-simulator/510/overview
Dec 11 2020 https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-sdk-simulator/712/overview


Original change's description:
> [iOS] Reenable disabled test
>
> It seems to pass now.
>
> Fixed: 1129589
> Change-Id: Id2fd68a6e3f860f593871c4a223bc0a8f034cefd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460825
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#815142}

TBR=olivierrobin@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Id32622132efa0535dff419886cf859b18594b074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587697Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836351}

Move ChromeStartupDelegate instantiation to after the native FeatureList
is initialized.

Bug: 1158020
Change-Id: I782eb5750078e7f56aa4f1d540c88b03231c0503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587621Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836350}

There were currently two issues with the lighting estimation page: the
ambient light was brighter than expected and the reflection map wasn't
being rendered onto the sphere.

The first issue was likely a result of the sphere's texture having 0
"metalness" and thus being more "stone" like. This caused the light to
get applied to a broader area, and thus made it seem more washed out. In
addition, we now also set the intensity of the light probe to 1 each
frame. While this likely doesn't impact the ambient light intensity, it
is a better pattern having it mirror what happens with the directional
light.

The second was partially due to the metalness value (nothing reflects
with a metalness of 0); however, the environment map wasn't actually
getting set up in Three's renderer.

There's also two additional issues that are fixed here. The first is
that the reflectionchange event was incorrectly subscribed (both the
name and to the wrong object). However, even with that fixed there is
some form of known issue with the event, that means we instead need to
rely on a simple interval timer.

Finally, this change also ensures that the appropriate GL extensions are
enabled for the two possible texture types that we support.

Fixed: 1151501,1151491
Change-Id: Id6ff4f5e4cc237a5e9c4a8aefb82a96827a48205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587554
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836349}

Change-Id: I4ae5949e13899a09f2d1471902d8ea2112476469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587557
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836348}

There are 2 issues being fixed here:
1. base::ReplaceFile is used to move the downloaded file from the temp location to the desired file location. base::ReplaceFile fails if the temp file and the destination file are on different volumes. Using base::Move instead, as it doesn't have that limitation.
2. Getting the size of the downloaded file directly from the NSURLSessionTask instead of from the file system.

Bug: 1153304
Change-Id: I6d38a34a9893e2dfb59d605f657b42d381ec9e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583338
Commit-Queue: Mila Green <milagreen@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836347}

Bug: 1154531
Change-Id: I28fae7f200063d3f6abf29f8bca0ec143e33f520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586292
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836346}

Bug: 1158048
Change-Id: I68b7a7ecacd407bde2a331681ad36a53f74f159c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572676
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836345}

Context -
This CL is specific to Impulse-based-scrolling [1]. Design doc summary
is that if the flag is turned on, scroll animations will use a
different curve. (i.e the new curve is also Bezier based but with
different control points). The CL that added this new curve is
crrev.com/c/1901628.

Problem -
The new curve causes minor jerks for flings on non-PTP touchpads that
send WM_MOUSEWHEEL(s). The reason this happens is because the steep
initial slope of the curve.

Fix -
Start off as an impulse based curve but when subsequent GSU(s) come in,
update the curve to the old ease in/out style curve. That way,
individual mousewheel ticks, keyboard presses, scrollbar clicks will
still feel impulse based and the fling will be smooth.

Misc -
Why can’t we just fix this by changing the control points on the new
Bezier curve?
If we do this, we’d be changing the personality of the Impulse curve
itself which defeats the purpose of adding this new curve in the first
place.

[1] https://docs.google.com/document/d/1A3VmlY3ZR6UtJt3QQ5uuqaCOgPjV6vCMxvkpvPBe0g0/edit#heading=h.ji0n9h8v0xez

Bug: 1157698
Change-Id: I91b90080f6eac4c268f443daf2345716374a1927
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553869
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836344}

This adds support for Widevine L1 HW decryption support on Chrome OS to
the key systems. It also adds explicit support for encrypted HEVC
to the supported type checker used by the key systems if the
corresponding buildflag is on.

BUG=b:153111783
TEST=Widevine UAT site plays for HEVC and other codecs w/ HW_SECURE_ALL

Change-Id: I35c6ae35b6aafa9704524d6be05201e74e3a2748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580321Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#836343}

These instructions should let folks manually symbolize any Chrome
crash dumps generated during Tast tests on bots, which will make
test debugging a bit easier.

Bug: 1155738
Change-Id: I5cd9f11d53721b82fd23003d1f89c6e921a0a122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587583Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836342}

The current comment is slightly misleading, causing extra code review
round-trips.

Change-Id: I899147eab2bc3afdb2717955ad0f2cc4d31524ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582817
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836341}

Adjust IDS_UPDATE_REQUIRED_NO_NETWORK_MESSAGE,
IDS_UPDATE_REQUIRED_METERED_NETWORK_MESSAGE and
IDS_UPDATE_REQUIRED_EOL_MESSAGE to support FlexOrgs by adjusting the
domain placeholder names and descriptions to make it easier for the
translators to understand the usage of the texts.

Additionally refactor all references to domain_name to be called manager
instead.

Finally replace a call to
BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call
to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager.

Bug: b:172685543
Test: Manual
Change-Id: I2272fc6d53dbd641554a2523309da8b461aa009f
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585090Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Jana Grill <janagrill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836340}

Add "Can't receive", "Please try again", and "The device sharing with
you cancelled the transfer" strings. Display them on the receive
confirmation page when the corresponding error statuses are received.
Also use the "Not enough disk space" string that already existed.

Fixed: 1157284
Change-Id: I085573fb7943c9e38899a6b038bb068386e33c35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587398Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#836339}

Before this patch, the touch target for the checkbox in the credit card
editor was 32dp, which is smaller than the 48dp required for
accessibility.

This patch sets the minimum height of 48dp for the checkbox in the
credit card editor.

After this patch, the touch target for the checkbox in the credit card
editor is exactly 48dp in height.

Bug: 977272
Change-Id: I25b5de2145fdadef6b2c411fcbbc4b781500e18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584462Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836338}

https://android.googlesource.com/platform/external/perfetto.git/+log/e94526b4043b..74ccf7b62fc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I0b29e5506c18e334721bcb5890d5255efd759187
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587497Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836337}

Add the following keyboard shortcuts to a capture session.

Space: Creates a default region 1/12th the size of the root.
Tab: Cycles through and highlights the region and affordance circles.
  Also handles events as these were affecting the top window.
Arrow keys: Shifts the region if it is focused, resizes the region if
  a affordance circle is focused.

Not in this CL:
  - moving focus to capture bar/capture button, requires those widgets
    to be focusable
  - leave focus on mouse click and start tabbing from the last mouse
    click

Bug: 1154778
Test: manual, added test
Change-Id: Ib4adf61e93bc7ad759fb33bac3185d069de0da65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575325
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836336}

Update nearby_contact_visibility visibility explanation strings.

Screenshots:
https://screenshot.googleplex.com/7Htyi2qu6qqvtkp.png
https://screenshot.googleplex.com/BgxPKkMQ4tFywjt.png
https://screenshot.googleplex.com/7sboMbzfBXK5Wc3.png

Fixed: 1157633
Change-Id: I9ed1a85f24b35823d3e7487d2923bc4801f2ab5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586770
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#836335}

This test not only fails on simulator.
It also fails on:
https://ci.chromium.org/ui/p/chrome/builders/ci/ios-beta-device/2066/overview
https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-beta-device/710/overview

TBR=eugenebut@chromium.org

Bug: 1147654
Change-Id: I8a7c0927d00b33a62cb3806e13d502f1484bede7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587651Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836334}

Now that there's no longer a WKBasedNavigationManagerImpl, this
CL merges WKBasedNavigationManagerTests into NavigationManagerTests.

Bug: 738020
Change-Id: I0ca38967d64ef8ebade2d808413b478b04c1bf56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581461Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836333}

https://crrev.com/c/2059752 introduced a dependency on
//services/network/public/mojom/cross_origin_embedder_policy.mojom
in
//components/services/storage/public/mojom/service_worker_database.mojom

This means the Storage Service's mojo interface now depends on the
Network Service. This CL makes the dependency explicit.

Bug: 994911
Change-Id: I1b9806d8f50183c3f551f071f01ed9a60625d591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587653
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836332}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/84a26597..da7e8b6d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ifd7f7dfdb165ff673cd3f7552d3e2085571cfec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587490Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836331}

This reverts commit 3da5569e.

Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots:

https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584

Sample failure output:

[ RUN      ] OutOfProcessPPAPITest.Instance_ExecuteScript
[18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode.

DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca
[18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid
[18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid
[18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1)
[18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1)
[18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176)
Received signal 11 <unknown> 000000000000
#0 0x7f89c0dca89f base::debug::CollectStackTrace()
#1 0x7f89c0b5409a base::debug::StackTrace::StackTrace()
#2 0x7f89c0b54055 base::debug::StackTrace::StackTrace()
#3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f)
#5 0x7f89b142c419 std::__Cr::default_delete<>::operator()()
#6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset()
#7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr()
#8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState()
#9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote()
#10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance()
#11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl()
#12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl()
#13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>()
#14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct()
#15 0x7f89b25350a3 base::RefCounted<>::Release()
#16 0x7f89b2535069 scoped_refptr<>::Release()
#17 0x7f89b253020a scoped_refptr<>::~scoped_refptr()
#18 0x7f89b25ce3f3 scoped_refptr<>::reset()
#19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn
#20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy()
#21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose()
#22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose()
#23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope()
#24 0x7f89a4f58862 blink::ContainerNode::RemoveChild()
#25 0x7f89a5111cbb blink::Node::removeChild()
#26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback()
#27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call()
#28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall()
#30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall()
#31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit
  r8: 00000f84ee181f88  r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690
 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10
  di: 00007f89b3e98918  si: 00007f89b3e98918  bp: 00007ffc8c8ee710  bx: 00007f89c0f52440
  dx: 00000f84ee181f90  ax: 00007f89b2587db0  cx: 0000000000000000  sp: 00007ffc8c8ee6f0
  ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000
 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure
Failed
Unexpected termination of a renderer process; status: 1, exit_code: 256
Stack trace:
#0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe()
#1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify()
#2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied()
#3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError()
#4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError()
#5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>()
#6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>()
#7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE
#8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce()
#9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv
#10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask()
#11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl()
#12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
#14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch()
#15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch()
#16 0x7f3d2f683197 g_main_context_dispatch
#17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef)
#18 0x7f3d2f68349c g_main_context_iteration
#19 0x7f3d5caf6b00 base::MessagePumpGlib::Run()
#20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run()
#21 0x7f3d5cb95d75 base::RunLoop::Run()
#22 0x55ec187b836a content::RunThisRunLoop()
#23 0x55ec187b831f content::RunMessageLoop()
#24 0x55ec18760320 content::JavascriptTestObserver::Run()
#25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL()
#26 0x55ec16a8b48e content::PPAPITestBase::RunTest()
#27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread()
#28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>()
#30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>()
#31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#32 0x55ec1871cddc base::internal::Invoker<>::RunOnce()
#33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv
#34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun()
#35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun()
#36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>()
#37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>()
#38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE
#39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce()
#40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv
#41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow()
#42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks()
#43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize()
#44 0x7f3d4c5f0d64 content::BrowserMain()
#45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain()
#46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser()
#47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run()
#48 0x7f3d4e7bae05 content::RunContentProcess()
#49 0x7f3d4e7bb79d content::ContentMain()
#50 0x55ec18718d5a content::BrowserTestBase::SetUp()
#51 0x55ec1865a9ac content::ContentBrowserTest::SetUp()
#52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp()
#53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>()

Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL.  This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=)

Original change's description:
> Add mojo interfaces for pepper plugins.
>
> This adds some base plumbing for pepper plugin instance handling. The
> pepper renderer code allocates and manages the PepperPluginInstanceImpl,
> this creates the correct encapsulation moving code out of RenderFrameImpl.
>
> On the browser side a PepperPluginInstance is created to handle the
> messages and relay them to the WebContentsImpl which use to handle
> the processing of Pepper messages.
>
> BUG=1157519
>
> Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836239}

TBR=dcheng@chromium.org,bbudge@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1157519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836330}

https://chromium.googlesource.com/angle/angle.git/+log/d9318acc24b0..8326b26a790f

2020-12-11 syoussefi@chromium.org Fix link validation with ambiguous instanceless interface blocks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Change-Id: Iff599dccf2401f0a39ec5cca175207a873fac061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587392Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836329}

This target comprises 1.95% of our total Chrome samples, but isn't
optimized for speed except on ARM. It may be worthwhile to optimize it
in this way.

This includes a miscellaneous `git cl format`.

Bug: 1143481
Change-Id: Ifa6a25a4f1954289a5f54fc3785e2e83de431c4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507572Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Felicia Lim <flim@chromium.org>
Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836328}

This reverts commit 7e5912e8.

Reason for revert: we're planning to launch this to M88+ using Finch instead. See https://docs.google.com/document/d/1bXwJwJAGP-2msI9IU6kbrZH9zBvQkTVNpjiKIxKZFhg/edit?ts=5fd309ef# for more details.

Original change's description:
> Reland "Origin isolation: enable by default"
>
> This reverts commit 0ea7d517.
>
> Reason for revert: A fix for the problem that lead to this revert has been landed in r831153 and we need to re-enable this change to test it.
>
> Original change's description:
> > Revert "Origin isolation: enable by default"
> >
> > This reverts commit 824b062d.
> >
> > Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721.
> >
> > Original change's description:
> > > Origin isolation: enable by default
> > >
> > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI
> > >
> > > Further work on removing origin trial code and the flags is tracked in
> > > https://crbug.com/1148056 and https://crbug.com/1148057.
> > >
> > > Bug: 1042415
> > > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145
> > > Commit-Queue: Domenic Denicola <domenic@chromium.org>
> > > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#826910}
> >
> > TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1042415, 1141721
> > Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209
> > Reviewed-by: Domenic Denicola <domenic@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: Charlie Reis <creis@chromium.org>
> > Commit-Queue: Charlie Reis <creis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#829937}
>
> TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1042415
> Bug: 1141721
> Change-Id: I6cf3211dc675bd2351c8dc6831e8d3e2495d8c2e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560907
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#831175}

TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org,wjmaclean@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1042415
Bug: 1141721
Change-Id: I14fc536d9389f6706b15f241182e4a65b09f1a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587453Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836327}

https://swiftshader.googlesource.com/SwiftShader.git/+log/31cc1f148e42..4f90750776f8

2020-12-11 capn@google.com Implement VK_EXT_scalar_block_layout support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I67a47f0ad8b1dd308b85a77db0539797b6250d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587221Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836326}

Fixing a bug where dragging text from one input element to another, and
then trying to undo this change, makes first input element's value
inaccessible. In order to fix this, the root editable element
associated with a `SelectionForUndoStep` is calculated at construction
time. It is important to do so at construction time as the base
position of the selection might be disconnected from the document, thus
we might not be able to compute the root editable element.

Bug: 864941
Test: Drag text from one input element to another, and then undo this
change. After undoing, try to use the first input element's `value`
property, and verify it has the correct value.

Change-Id: Ie0016f7459bad462e67e508b64e2686c39a66fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574954
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836325}

Generate DIR_METADATA files and remove metadata from OWNERS
files for directories under //ui.

Bug: 1113033
Change-Id: Id5922f2b2a0a870048107d653cb78c2f05e942d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583126Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Cr-Commit-Position: refs/heads/master@{#836324}