- 13 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0864a7ac638c..f9143725470b git log 0864a7ac638c..f9143725470b --date=short --no-merges --format='%ad %ae %s' 2018-11-13 geofflang@chromium.org Only use CompositorNativeWindow11 when the window is non-null. 2018-11-13 ynovikov@chromium.org Vulkan: refactor WrappedObject descendants Created with: gclient setdep -r src/third_party/angle@f9143725470b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9237b7e197941a754f000be7c84c71381815c4a1 Reviewed-on: https://chromium-review.googlesource.com/c/1333861Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607688}
-
Lei Zhang authored
In chrome/ and chromeos/. These TearDown() overrides are pointless. Change-Id: I0e9c6d2a346bc40ecf45e30a8bac0914a987e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/1330913Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#607687}
-
Dominic Mazzoni authored
Change-Id: I77e9b4332bd9f67e04e65e2afca895314b278498 Reviewed-on: https://chromium-review.googlesource.com/c/1314140 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607686}
-
Elly Fong-Jones authored
This test uses NSButton as its dummy class for some test cases, but there is now a 10.14-specific behavior in ViewTreeValidator to ignore children of buttons because of the linked bug, which causes this test to fail on 10.14. Bug: 892176 Change-Id: I35bac3065ed1b2ded9466e63b6c27cd804b7180c Reviewed-on: https://chromium-review.googlesource.com/c/1333140 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607685}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: I605b7ff0aee6ec52254af8871efc7308f79d647a Reviewed-on: https://chromium-review.googlesource.com/c/1334098Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#607684}
-
Chris Harrelson authored
The foreground layer paints normal-flow and positive z-index non-composited children in the presence of a composited negative-z-index-child. In these cases, we should not consider the normal-flow or positive z-index non-composited children as contributing to opaqueness of the main graphics layer, since they paint elsewhere. Bug: 892137 Change-Id: I7bd6a4eab615881e4ec3931049f292b046202430 Reviewed-on: https://chromium-review.googlesource.com/c/1332699Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607683}
-
Liquan(Max) Gu authored
This CL refactors the codes of Image Paint Detecor. This will make it easier to support background image for the metric. Specifically, this CL will do the following things: 1. Move GetImageUrl() into an anonymous function. 2. Simplify the logic of IsJustLoaded(). Take out the IsLoad() part from it and move it into an anonymous function. Background image support will be done by extending these two functions. Bug: 869924 Change-Id: Idfe4794612e1d5daa71afb03f8191700ce3d65bb Reviewed-on: https://chromium-review.googlesource.com/c/1333990Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607682}
-
Kurt Horimoto authored
CGRectGetMaxY() changes as the toolbars are translated, causing issues when it is called from |-updateForFullscreenProgress:|. This CL updates the implementation to be based on the heights, rather than the frames. Bug: 903229 Change-Id: Ice018324f426104467f80c21544435c612b3455f Reviewed-on: https://chromium-review.googlesource.com/c/1328143Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#607681}
-
kyle Ju authored
Bug: 738489 Change-Id: I0251f741bee780b3cbb88b13a29b67238b8c0cf5 Reviewed-on: https://chromium-review.googlesource.com/c/1269759 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#607680}
-
Mario Sanchez Prada authored
Migrate uses of SigninManagerBase's GetAuthenticatedAccountInfo() and IsSigninAllowed() to the Identity Manager. Bug: 903894 Change-Id: Idcddc8adffbdb4093df7170551403ae20a14afe7 Reviewed-on: https://chromium-review.googlesource.com/c/1329979Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#607679}
-
Jonathan Metzman authored
Bug: 904877 Change-Id: I76942f10b864f9fab39792ec8d734c1e9cec8468 Reviewed-on: https://chromium-review.googlesource.com/c/1333900 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607678}
-
Sunny Sachanandani authored
GPU.DirectComposition.SwapChainCreationResult is emitted for each overlay format, but it was missing an affected-histogram entry in the histogram_suffixes list. Bug: 869677 Change-Id: I20cd9987ba2ebf42230c3e026e5d33c600cc6713 Reviewed-on: https://chromium-review.googlesource.com/c/1333133Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#607677}
-
Ned Nguyen authored
This also remove check_sys_deps from base.Port's subclasses that are the same as the base class method. Note: this CL removes an unused parameter and is a refactor with no intended behavior change. This clean up is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1229240/ BUG: chromium:773617,chromium:884776 Change-Id: I82edf733a696c4e0e6de20a8bac954e244d51365 Reviewed-on: https://chromium-review.googlesource.com/c/1333893 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607676}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60b6bc3c2950..f47abb48757f git log 60b6bc3c2950..f47abb48757f --date=short --no-merges --format='%ad %ae %s' 2018-11-13 mtklein@google.com remove unused DXDY SSSE3 bitmap opts 2018-11-13 brianosman@google.com Remove obsolete SK_IGNORE_ defines Created with: gclient setdep -r src/third_party/skia@f47abb48757f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I4b9c084dbf4533cba3ea73f2a041c29d16b4b676 Reviewed-on: https://chromium-review.googlesource.com/c/1333854Reviewed-by:
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=torne@chromium.org Bug: 766678 Change-Id: I30e57cb0d9a0b1a449a4227561e97ea330ff6a12 Reviewed-on: https://chromium-review.googlesource.com/c/1325195 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607674}
-
Etienne Pierre-doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowBaseSyncPrimitives in non-test files * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. This CL required special attention: * ScopedAllowWaitForAndroidLayoutTests was deleted in favor of ScopedAllowBaseSyncPrimitivesForTesting. * |reduced_restrictions_| was removed because the related WaitableEvent is now declared as idle, which does not require any allowance. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=peter@chromium.org Bug: 766678 Change-Id: I8065043e9b1b5005fb9ff2894cb2dc30098efd8e Reviewed-on: https://chromium-review.googlesource.com/c/1325205 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#607673}
-
Ted Choc authored
In some instances, the attempted scroll position is beyond the length of the URL. This crashes some versions of Android and hangs others. This caps the scroll position to the text length and adds some logging to attempt to catch this locally. BUG=859219 Change-Id: I7859d37ede741c5ce81d85df400cbe4bea2ccdeb Reviewed-on: https://chromium-review.googlesource.com/c/1332209Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607672}
-
Friedrich Horschig authored
Before this CL, components like the infobar would query the state of the keyboard as soon as the activity is resized. That means, the accessory might not have updated the state of filling components (and immediate updates might cause relayouts) and an old keyboard state is reported. Now, the accessory reports the state of keyboard replacements before the actual component is updated. This way, replacements can be considered for keyboard visibility, even if the component updates are pending. Bug: 903256 Change-Id: Ie95297b6dbdfc1929aaf0643a805fbb4fd93378b Reviewed-on: https://chromium-review.googlesource.com/c/1329246 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#607671}
-
Elly Fong-Jones authored
This change: 1) Has platform_info not assert that 10.14 is unsupported 2) Has the web_tests baseline code handle 10.14 (right now the same way it handles 10.13) The second change is almost certainly wrong but this gets run_blinkpy_tests green locally. Bug: 892229 Change-Id: Iae1188879f8496aa03fd060ed5590c841515a2c8 Reviewed-on: https://chromium-review.googlesource.com/c/1333567Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607670}
-
Clark DuVall authored
Records two metrics, one to track request time when at least one listener is registered, and another to record request time when the request has been blocked on a listener. Bug: 827582 Change-Id: I938cb971a40a638295b13a27f9c1d77f6e6d2107 Reviewed-on: https://chromium-review.googlesource.com/c/1327149 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607669}
-
Ian Kilpatrick authored
Instead make the NGConstraintSpaceBuilder to directly write into the NGConstraintSpace members. Along with a (very) slight perf win (easier on the stack), it makes it easier for the rare_data_ patch to follow this one. There should be no behaviour change. Bug: 635619 Change-Id: I0f75166df760ed03fb8f0ab3099c5b12760547ed Reviewed-on: https://chromium-review.googlesource.com/c/1321571 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#607668}
-
Tom Tan authored
This change enables "is_clang=true" of Chromium build for Windows ARM64. This change works with current clang-cl.exe in chromium repo mostly, except cannot compiling code with __try/__except. The fix of this compilation issue is under review in LLVM community (see below link). https://reviews.llvm.org/D53540 Bug: 893460 Change-Id: I3fbc943c9fd04e325b3a9686ce80202dc0f27238 Reviewed-on: https://chromium-review.googlesource.com/c/1330355 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607667}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/84f62b6f08e8..78869faa9193 git log 84f62b6f08e8..78869faa9193 --date=short --no-merges --format='%ad %ae %s' 2018-11-13 perezju@chromium.org [telemetry] Treat most exceptions as "possibly handleable" Created with: gclient setdep -r src/third_party/catapult@78869faa9193 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900909 TBR=sullivan@chromium.org Change-Id: I17117fac12c5ef19aab8edfd9080d031dccaa087 Reviewed-on: https://chromium-review.googlesource.com/c/1333858Reviewed-by:
-
Friedrich Horschig authored
Currently the scrolling causes the top divider to disappear. Without a shadow separating the accessory bar from the scrollable list, this looks wrong. Therefore, this CL adds such a shadow. Also, some bottom spacing related to the scrolling is fixed. Bug: 903824 Change-Id: I31cd318cb96fa77db3ba55d8a9a61488e9d6da0b Reviewed-on: https://chromium-review.googlesource.com/c/1331400 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Skip the blacklist check in resource loading hints browsertest. This has been a cause of flakiness in previews browser tests previously. Bug: 904014,904500 Change-Id: Ia8386c7e010d0976830ec0a84b7e1441acd87f00 Reviewed-on: https://chromium-review.googlesource.com/c/1333994Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#607664}
-
Emircan Uysaler authored
We should not use title in any of notification or request texts because it can easily be injected. We should use URL instead and follow the guidelines to simplify. Bug: 326740 Change-Id: Ib9d6ea0c996883a206a2cb016c505b8280ad6cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1324911Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607663}
-
Yi Gu authored
Previously worklet-animation-style-update.html used runChecksWithRAF to test the output because it was the only way to check getComputedStyle. Now that getComputedStyle is supported via peeking via main thread and the behavior has been tested in animator-animate.html, we no longer need this test. Bug: 900356 Change-Id: I104f271c562c6718c664dc1de264018f928eb546 Reviewed-on: https://chromium-review.googlesource.com/c/1319511Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#607662}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e317c5c..c1a5d275 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I201789a098ffd817ab3da891875a4d78b7a5c1c8 Reviewed-on: https://chromium-review.googlesource.com/c/1333993Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607661}
-
Ian Clelland authored
This CL moves the IsFeatureAllowed checks for image policies from the old location on Frame to the new methods on Document. Bug: 888668 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3d44ce3f0263e2b9f3dec3f33f2a9c89f57f76ab Reviewed-on: https://chromium-review.googlesource.com/c/1243168Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
-
Eric Stevenson authored
https://chromium-review.googlesource.com/c/chromium/src/+/1319335 caused some tests to be moved to secondary dex files which are ignored by TestRequestBuilder KitKat. This CL adds support by manually listing tests the same way incremental install does. Bug: 903820 Change-Id: I1cb874c4bf570d482bc28668978234538629e261 Reviewed-on: https://chromium-review.googlesource.com/c/1332607Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#607659}
-
François Beaufort authored
This CL fixes a tab crash that occurs when calling document.exitPictureInPicture() if a video in a shadow DOM is already in Picture-in-Picture. Bug: 904828 Change-Id: I6aed0fa43dd0af1406d4349509101d423f622d96 Reviewed-on: https://chromium-review.googlesource.com/c/1333769Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#607658}
-
Steve Kobes authored
This histogram has 100 buckets (per go/uma-histogram-guidelines), corresponding to jank scores 0 - 10. Bug: 581518 Change-Id: If3376139e60feafc671fe7e6e64391cb1a70f609 Reviewed-on: https://chromium-review.googlesource.com/c/1332389Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Migrate away from SigninManagerBase::GetAuthenticatedAccountInfo and use the IdentityManager's API instead. Bug: 903867 Change-Id: Ic8ce02d342bcd277385f766132b163d969422584 Reviewed-on: https://chromium-review.googlesource.com/c/1331475Reviewed-by:
-
Javier Ernesto Flores Robles authored
Shows the manual fallback icons to the right on iPads. Changes include: -Updates FormInputAccessoryView to support a custom view to the right. -Stops instantiation of ManualFillAccessoryViewController when manual fallback is disabled. Bug: 845472 Change-Id: I82b3772bf60af33f3102b520ce3cc647b16310b9 Reviewed-on: https://chromium-review.googlesource.com/c/1329176 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607655}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc5cd59f. With Chromium commits locally applied on WPT: 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I6f3bd1847e71117d55d174880d86b5be0e26166d Reviewed-on: https://chromium-review.googlesource.com/c/1333891 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607654}
-
Daniel Bratell authored
third_party/mesa is no longer part of Chromium, and having it listed here enforces gn checks for any product that still checks out mesa in third_party (i.e. Google Chrome) which is a problem. Bug: 873321 Change-Id: If1c28fb2c393f04c9b0fe0703204fd7225a1a483 Reviewed-on: https://chromium-review.googlesource.com/c/1333812 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607653}
-
John Abd-El-Malek authored
The functionality worked, as part of converting DICE, however the test code didn't work since it depended on accessing the net objects directly. Switch the tests to use the EmbeddedTestServer, to better match production, which removes the dependency on net/. Also: -make GetFilePathWithReplacements replace strings in the mock headers if they're present -add a global to google_util to ignore ports; that way other tests can be converted without having to modify each callsite to google_util Bug: 881976 Change-Id: Ic52023495c1c98c1248025c11cdf37f433fef058 Reviewed-on: https://chromium-review.googlesource.com/c/1328142 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#607652}
-
David Bokan authored
Root scroller shouldn't consider plugins. However, the current method of getting the scrollable area would check for a local frame and try to convert its view to a LocalFrameView. In the case of a plugin, the ContentFrame()->IsLocalFrame may return true but the EmbededContentView is a PluginView rather than a LocalFrameView. This CL cleans up these checks by looking exclusively at the EmbeddedContentView since that's all we care about. Bug: 903440 Change-Id: I7f172559321ecb4777e1fd85ed63f105798df257 Reviewed-on: https://chromium-review.googlesource.com/c/1330330Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607651}
-
Marc Treib authored
The PrefService isn't required anymore. Bug: 884159 Change-Id: I6fabe54fe69e56602d8bbbd6134b8cc8acec9e80 Reviewed-on: https://chromium-review.googlesource.com/c/1333773Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607650}
-
Wei Li authored
These tests were flaky before, but have been stable recently. We should enable them to capture problems. BUG=146006 Change-Id: I909a5e09ad5107a97ba18aef0ffb572928bfdc7c Reviewed-on: https://chromium-review.googlesource.com/c/1332927Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#607649}
-
