GitLab

Existing BreadcrumbManagers are associated with BrowserStates via
BreadcrumbManagerKeyedService instances. This CL adds an application
wide BreadcrumbManager for logging global events not tied to a specific
BrowserState.

Logged events currently come from listening to UserActions and memory
pressure events.

Bug: 1003922
Change-Id: If0e1db381755043d85487e0a85fbb9037abae263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987368
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733823}

In the case where the previous state of the finch trials was
unknown (when the previous status was not saved previously
due to this feature not being in the code), we had been
defaulting to resetting the cache.  This CL changes that
behavior and only resets when there is a known change to the
cache.  It also improves the testing to use PRE_ tests to
more accurately model reloading behavior rather than relying
on explicitly setting variables.

Also fixes flaky behavior introduced due to cross-process
testing.  Note the TODO regarding the bug to clean up the manner
in which we resolve the race condition.

Bug: 1041542,1041810
Change-Id: I9c40c9be9682b5372e1f3fb2851ef6531802f1bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003249
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733822}

Move ComputedHashes's underlying data into its own class ComputedHashes::Data,
that wraps the canonicalization logic in it.

Adding items to Data would canonicalize paths, obviating the need for
  a) the linear search in case-insensitive OS.
  b) additional dot-space trimming treatment on windows.

Bug: 796395
Change-Id: I1517f6daa8253562b731cf62a5c54fb95f2bd10e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003261
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733821}

https://dawn.googlesource.com/dawn.git/+log/3003aa622b2f..80880ee99854

git log 3003aa622b2f..80880ee99854 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 natlee@microsoft.com Device Loss handle GetBindGroupLayout and test

Created with:
  gclient setdep -r src/third_party/dawn@80880ee99854

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ie641d7d9d4709bf41043db33fb46819a049a4697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013900Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733820}

When copying in an image document, in most cases, there's no selection,
and we just want to copy the image itself. So we have a fast path for
that.

However, Javascript may insert other contents into an image document,
which can be selected and should be copyable. This patch detects this
case, and if so, uses the normal code path instead of the fast path.

Bug: 1042468
Change-Id: I45f5f296dc93040fd770f017b6220c51048b954b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007657Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733819}

This reverts commit cb210848.

The original CL and
https://chromium-review.googlesource.com/c/chromium/src/+/2003909
interacted, causing a build breakage. This has been fixed between
patchsets 1 and 2.

Original CL description:
> Add code to generate PROMPT_FOR_SCANNING verdicts
>
> This CL adds the code needed to generate PROMPT_FOR_SCANNING danger
> types. This danger type is used when an Advanced Protection user
> downloads a file that is marked as UNCOMMON. It causes the user to be
> prompted to send this file to Google for deep scanning. The generation
> of these verdicts is guarded by a Finch flag as well as the user's
> Advanced Protection enrollment status.
>
> It also removes the old Finch flag related to Safe Browsing performing
> additional download scanning for Advanced Protection users, to
> minimize confusion.

Bug: 1020418
Change-Id: Iea42aa1ad8ca8aa0750449969e265e783ab6f85d
TBR: mek@chromium.org, tedchoc@chromium.org, xingliu@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013800
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733818}

Deletes the convenience public methods in TabImpl class. The callsites
use a new util method defined in Preview or SecurityStateModel.
Tests that relied on TabImpl.getSecurityModel for mocking out the method
now has a new one in the class being tested.

Bug: 995903

Change-Id: I00d52617a10999be8dc36f629dbc64b5aa0d8bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000411
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733817}

The previous CL added support for midword matching for HistoryQuick
suggestions. This CL adds corresponding tests.

Bug: 591981
Change-Id: I07371c6473592f6852b3223064e6cff3d13213e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013215
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733816}

Showing user adding UI might change target app list visibility (even if the app
list is shown behind the lock screen), so last_target_visible_ (which is
relied upon to determine the visibility state on session change) might
have wrong value if user adding is canceled (and no other windows are
shown over the home screen).

BUG=1043915

Change-Id: I52a56d486ed5ba06621670f91d68a46fc78f2f83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013627Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733815}

Add another launchSettingsPage method for launching the top-level
Settings page, rather than relying on caller to pass null.

Change-Id: I144549cb237ef15073146d4881f711971aba6a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013343Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733814}

Bug: 1042063
Change-Id: Ib2c17548d8df20d8061d448b788a193199129faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012901Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733813}

https://pdfium.googlesource.com/pdfium.git/+log/fcb6cd6d22a2..c3e55aa23f88

git log fcb6cd6d22a2..c3e55aa23f88 --date=short --first-parent --format='%ad %ae %s'
2020-01-21 thestig@chromium.org Rearrange CPDF_LinkExtract::ExtractLinks().
2020-01-21 thestig@chromium.org Remove |CPDF_LinkExtract::m_strPageText|.
2020-01-21 thestig@chromium.org Do some clean up in CXFA_FFDocView.
2020-01-21 thestig@chromium.org Make FSMatrixFromCFXMatrix() consistent with FSRectFFromCFXFloatRect().
2020-01-21 nigi@chromium.org [SkiaPaths] Make MatrixChanged() indicate changes of all its elements.
2020-01-18 tsepez@chromium.org Remove CXFA_NodeOwner::FreeOwnedNode().

Created with:
  gclient setdep -r src/third_party/pdfium@c3e55aa23f88

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1042956
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I02ddf3838e21d9c838dfb1adeec7484c890abf21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013509Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733812}

Users should now land on the Help app rather than the welcome tour post
OOBE. Use the same triggering logic as was present before, including
prefs to ensure that users who saw the welcome tour are not subsequently
shown the Help app.

Use AppServiceProxy so that we can track usage through
Apps.DefaultAppLaunch.FromChromeInternal::Get Help

Bug: 1001460, b/145710734
Change-Id: I5aaece65b9a858a913a533209dc33652008021aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003155
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733811}

Bug: 1041932,1034876
Change-Id: I82d2919b2c35e93384443cd8cfe0677d3a50cb48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007481Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733810}

There are some special extensions, e.g. hangouts, pen-as-Popup and
Speakeasy, opening windows when launch. But extensions are not managed
in AppService, so extensions icons are not added to Shelf when launch
those extensions.

Add ChromeAppIconLoader back to Load icons for extensions in Shelf.
Add LauncherExtensionAppUpdater to handle the extensions life-cycle
events.

BUG=1041493
BUG=b:147424621

Change-Id: Ia30440568c0920060aac479ad92ee54f81fceb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006847
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733809}

Note this changes to "real" metrics that includes borders.
The code only checks one dimension already to workaround this.
And this should work with multi-window case as well.

Bug: 1042063
Change-Id: Id6614a7cc7c56a05281f551a7e8874b1239347ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012890Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733808}

This switch was added in case of unexpected failures in stable. Since
it's now been running without any reported crashes since M78, remove it.

TBR=hnakashima@chromium.org

Fixed: 998990
Change-Id: I3bd5a55d7860d0a4a1374c33e5f0bd620019615b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013624
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733807}

Bug: 973627
Change-Id: Iee9a68b4e69a8bc51dc83a891618fa02574dd648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013044Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733806}

This CL also removes myself as an OWNER, though I am still an OWNER of
the parent directory.

Change-Id: I0ec994ab5be2afca356ff0120f45f64a8a489067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013521
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733805}

Allow compiling PFFFT for OSX.  This is mostly for testing and
debugging.  Unless PFFFT performance improves, the OSX FFT routines
are much faster so we should not default to using PFFFT.

Bug: 1042503
Change-Id: I217686e264eb290a8344afab1ac4da5073e1fe26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004067Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733804}

HistoryNavigationCoordinator can keep a reference to a Tab already
destroyed. This CL observes TabObserver.onDestroyed to null out the
reference to such tab. This ensures the clean up task against an
already-destroyed object like SwipeRefreshHandler avoids an exception.

Bug: 1043584
Change-Id: I37e0e0a78cd227a1f1413576eeba3801cd147e8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010753Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733803}

TBR=rsleevi@chromium.org

Change-Id: I2ade07f18471a494a3600bb477000b84ecdaf18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011161Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733802}

The current logic avoids calls to MaybeStartDragWindowFromShelf until
the first shelf drag update, so it can detect the scroll direction
before starting window drag, and then use the scroll value to detect the
initial scroll position. Simpler approach would be to pass the
scroll start gesture's scroll hint in StartGestureDrag.

Additionally, this cl further restricts when window drag can start with
extended hotseat. The window drag will only be allowed if the gesture
started on the shelf (e.g. gesture that starts on hotseat, goes down,
and then up again should not start window drag).

BUG=1043243

Change-Id: I9c70ab4670646e1be27970f37b0e7bcc3f2fc224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008618Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733801}

This flag is really useful for debugging and used by UX and QA as part
of testing.

Bug: None
Change-Id: Ia11e76df8bc06321d58e1721c8f10ca4d16e643f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008431
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733800}

Various fixes for the migration CL at:
https://chromium-review.googlesource.com/c/chromium/src/+/2004184

Bug: 1042558
Change-Id: I5204114771f738a4bbe67524c598ba3652e522ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012889Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733799}

This CL adds functionality to allow adding kEnableFeatures and
kDisableFeatures via config. Earlier there was a bug as adding
multiple feature sections to command line didn't work, so this CL
makes sure we serialize them in one switch.

Bug: 1026011
Change-Id: I6ba08023be8520119cc724300c306558e12e26e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006073
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733798}

Implement a bridge to communicate the status and number of blocked
cookies on a page between C++ and Java. Add related tests.

Bug: 1040091

Change-Id: I8fa22728fd51e58a57844d98205dc0b9e61ee216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964411
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733797}

This CL changes the resolution of the following histograms to microseconds:
  - Extensions.DeclarativeNetRequest.EvaluateRequestTime.AllExtensions2
  - Extensions.DeclarativeNetRequest.EvaluateBeforeRequestTime.SingleExtension

Generally these will take sub-millisecond times, hence recording time in
microseconds is more appropriate.

BUG=696822

Change-Id: I6559ea8e6e498a82c0189246f36cf474a2152707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003195
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733796}

Bug: 1036876, 1036877
Change-Id: I04649454c87fe91874e146809c2e0bc6768d8d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013347Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733795}

AssistantState might be freed when QuickAnswersClient destructor is
called (for example, in unit tests).

Bug: b/144314551
Test: Unit tests
Change-Id: Ib088e3eb2f1e1d3797a698bd10bbef16b1f3bd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012910Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733794}

Adds the central class for managing project secrets and hashing values.

There two TODOs left for KeyData:
 1. UMA metrics for failure states.
 2. allow overriding of key rotation period per-event.

I'll add these in follow-up CLs, as they both require edits to other
files.

Bug: 1016655
Change-Id: I7a294fd9be606aa6fc510f4f25058e54ab3d327d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928451
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733793}

Previously, the saved passwords with domains
experiment was enabled by default but the sampled
pings experiment was the one that should have enabled
instead.

Bug: 953106
Change-Id: Ie8bae8851f23bdfa09e736cf4a1602c7fd15eaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012886
Commit-Queue: Bettina Dea <bdea@chromium.org>
Auto-Submit: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733792}

This test (probably - could be the one before it) is flakily crashing,
and due to an infra issue is causing all of the tests after it in the
shard to fail as well.

TBR: kbr@chromium.org
Bug: 1043953
Change-Id: Ie1b72eda1895a2214dc0a3d1c7639c841d6fd532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013647Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733791}

This is a reland of 4184bbb0

Original change's description:
> Convert browser side's legacy IPCs of BlinkTest message to Mojo
>
> As a step to convert legacy IPCs to the Mojo, this CL
> converts browser side's BlinkTest IPCs to Mojo. This
> CL introduces WebTestClient interface to replace the
> IPC messages to Mojo methods in web_test.mojom file.
> The interface starts to support the original messages
> as below,
>
>  - InitiateLayoutDump()
>  - PrintMessageToStderr()
>  - SetPopupBlockingEnabled()
>  - NavigateSecondaryWindow()
>  - GoToOffset
>  - Reload()
>  - LoadURLForFrame()
>  - CloseRemainingWindows()
>  - ResetDone()
>  - SendBluetoothManualChooserEvent()
>  - GetBluetoothManualChooserEvents()
>  - SetBluetoothManualChooser()
>
> This CL should not change any behavior.
>
> Bug: 1039247
> Change-Id: Ic30f8cc0cb19ec8a306b577f3c10567d91bdccf1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002047
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#732388}

Bug: 1039247
Change-Id: I16f452ba3c78f69f31d04cb3c92c5b76a3814c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007311
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733790}

This was done in-person with UX. Reducing this spacing makes it more
clear that the header belongs to the below items.

Bug: chromium:943702
Change-Id: I08e8af77574873a45b1548bdee5ebb3a9cefcc8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013646
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733789}

Change-Id: Ieb0668d2f451acaa9a3072570cecf84556bdc8c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012090
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733788}

Using wpt-import in Chromium 7f7c7020.
With Chromium commits locally applied on WPT:
0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests"
e29a6ac8 "[FlexNG] Fix devtools DCHECK."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I40d40bf3557f0bd6bb4680ff64c5b9205f1d3c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013362Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#733787}

Use SharedPreferencesManager consistently instead of SharedPreferences
directly. Move the usages to methods in SigninPreferencesManager.

Bug: 1022108
Change-Id: Ic71a4986ecba4c33c7b7661b018533fa75f18e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011286
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733786}

Screenshots here:
https://drive.google.com/drive/folders/1ya-W3P0fFftqwD8MVoc1FaGcOJucjawm?usp=sharing

Video record:
1, single start surface
https://drive.google.com/a/google.com/file/d/1TsAyE5lzz5OyaluVWFsjOnoY7RFMit7d/view?usp=sharing
2, tasks only start surface
https://drive.google.com/a/google.com/file/d/1Jij-EpFKZOFWhf5BV79yP97JSWgF4QxA/view?usp=sharing
3, start surface disabled
https://drive.google.com/a/google.com/file/d/15AlCELYCu_FgdifcO9NyGp5eCVQzNzBG/view?usp=sharing

Bug: 982018
Change-Id: I3b3bb7daa9eb58ab9cd804d58c376f0c9be9edfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992272
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733785}

This CL updates PasswordInfobarModalInteractionHandler to take Browser
upon construction so that it can use the command dispatcher to open the
passwords settings when selected in the password infobar modal view.

Additionally, this CL adds default behavior to the show settings command
for use when there is not a base view controller to send with the
command.  OverlayRequestCoordinators' base view controllers are their
corresponding OverlayContainerViewController, which only should be used
to present things from within that OverlayPresenter's modality.  The
default behavior is to instead use the current BVC as the base controller
if one is not provided.

Bug: 1030357
Change-Id: I9a3d18cad6425aed47c005ce52ec7119b4a9059c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001727
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733784}