- 05 Jun, 2019 40 commits
-
-
Devon O'Brien authored
Add newly Qualified CT Logs and remove 2018 CT Log shards. Bug: 962537, 859093, 888130, 796333, 801624 Change-Id: I4b0e5b772c1726af2cb7c633de038b0827453b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644898 Commit-Queue: Devon O'Brien <asymmetric@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#666475}
-
Chris Palmer authored
jcivelli is no longer working on Chromium, and we need more OWNERS for this security-relevant service. Bug: None TBR: jcivelli, rsesek Change-Id: I77f0ee0eafb4eb3b4709d18dd4ab09d9ecb7a037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645240 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#666474}
-
Matt Mueller authored
Bug: 749276 Change-Id: If49f4fb0d5e550da54e9aa6c66c1ba5d893a8a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645982Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#666473}
-
Kristi Park authored
The tile's restricted ID is referenced in multiple places as "rid" and "tid". Standardize naming by changing all references of "tid" to "rid". Change-Id: I285d7b21abb404adb0c97cdecad38c38ae3a39d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642235Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#666472}
-
Henrique Nakashima authored
Testing Offline Prefetch in reduced mode manually requires a bit more time. Bug: 933358 Change-Id: Iea9e52fda62bbf7fc2251fe3ca8eef2d110f4889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626495 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#666471}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2f4a8dfd3a59..d3692c701b12 git log 2f4a8dfd3a59..d3692c701b12 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 johnkslang@users.noreply.github.com Merge pull request #1791 from dj2/unused Created with: gclient setdep -r src/third_party/glslang/src@d3692c701b12 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I09a91e60063dc1083e76aac7782a64a80d04ac85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#666470}
-
Carlos Knippschild authored
Bug: 960069 Change-Id: I1870678c0fe42311a2c7ea3e30f272d6de89d372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644301 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#666469}
-
Daniel Murphy authored
This change removes the kWipeCorruptV2IDBDatabases feature to now mark databases that have missing blobs (so permantently corrupt databases) as corrupt, so they are cleared appropriately. Since Docs has error handling here, and we are in active communications with them, disable this corruption handling only for Docs. The reporting will stay in place to monitor how small of a problem this is. The numbers on this are pretty small, there are less than 0.005% of users that have these non-docs corrupt databases. R=pwnall@chromium.org Bug: 857159 Change-Id: Icf8feac9ad6b626108e00213447a706bbe264e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633334Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#666468}
-
Robert Ma authored
To include a fix that would suppress some noisy logging from pywebsocket: https://github.com/web-platform-tests/wpt/pull/17124 Fixups made in this roll: * chromium.patch is updated so that it can apply cleanly. There is no substantial change. * A new file is included: tools/lint/rules.py * The fake test file in PRESUBMIT_test.py is changed to accommodate a stricter regex (https://github.com/web-platform-tests/wpt/pull/16605). * wpt_manifest.py no longer uses the removed `--work` flag. Bug: 968904 Change-Id: Id49c50ba4d5da6dda906a21e06a5c24f24dd5a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642112 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#666467}
-
Cammie Smith Barnes authored
We add a method to extract the resource URL from the cache key, so that HttpCacheDataRemover can perform its URL matching to determine which cache entries to remove. This is in accordance with the spec at https://w3c.github.io/webappsec-clear-site-data/ In future, it may be desirable to change the spec so that when there is a clear-site-data request for a given site, all resources keyed with that site as the resource URL, the domain, or the initiator, inclusively, would be removed from the cache. Test 1: net_unittests --gtest_filter=*HttpSplitCacheKeyTest* Test 2: services_unittests --gtest_filter=*HttpCacheDataRemoverSplitCacheTest* Bug: 951812 Change-Id: Id1afd9fff5f766e46d596ce8be340d09e6296bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590406Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#666466}
-
John Abd-El-Malek authored
The tests that used to be on this bot are now on the CQ as network service is on by default. Bug: 598073 Change-Id: If1a941917910a8543aab4c2b2a0d893d516aecc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645993 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#666465}
-
Xiyuan Xia authored
- Replace mojo interface MediaController/Client in cpp; - Current MediaController/Client -> Media{Controller/Client}Impl; Bug: 958207 Change-Id: Ia3b9253a45d431e9d0532adc434e38fb0a97adf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646532 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#666464}
-
Jacob DeWitt authored
- Remove TODOs that reference closed crbugs. - Create crbugs and update comments for TODOs that didn't already link to a crbug. Change-Id: Id25cca7ca4ffa6ee8f9a5ac7f7af4ee817e17ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639204Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#666463}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/928b2997b301..e0d90c84e42f git log 928b2997b301..e0d90c84e42f --date=short --no-merges --format='%ad %ae %s' 2019-06-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-05 csmartdalton@google.com ccpr: Preserve fill rules for cached paths Created with: gclient setdep -r src/third_party/skia@e0d90c84e42f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ia5abd88548b6d0b3d8af4f521e622148af60820c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644926Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e77dbf600358..01927c1c5000 git log e77dbf600358..01927c1c5000 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 manojgupta@google.com cros_sdk: Allow using a Frozen SDK for bootstrapping. 2019-06-05 manojgupta@google.com cros_sdk: Format with yapf. 2019-06-05 saklein@chromium.org Build API: Recursive Path Handling 2019-06-05 dburger@chromium.org Fix config updater. Created with: gclient setdep -r src/third_party/chromite@01927c1c5000 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Idb0a76aea82296816ae761361861da50a612f8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645986Reviewed-by:
-
Dana Fried authored
Button listener was not scoped and is not owned by the button in question, so was never deleted. Since button listeners are optional and this one was never used, the choice was made to remove it entirely. Bug: 961075 Change-Id: If9600ba17cb2e30a4a10c9bdf4d0449f056b583f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646753 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#666460}
-
Charlie Reis authored
This also fixes some owner lines with typos which caused issues in processing the file. Bug: None Change-Id: I17a6ec571846da6a7018bd2cfef5d40e61a4c530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645981Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#666459}
-
Mei Liang authored
Change-Id: If3d333382233c155e4882e04fb3e9acbc14ea109 Bug: 970982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644525 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666458}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: If4403c877bc53c97b35a0b36f7cb0de142cdfb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646373 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#666457}
-
Yuchen Liu authored
Temporary grants permisson of PROTECTED_MEDIA_IDENTIFIER, to unblock EME dev. Bug: 922833 Bug: 966191 Test: Build and pages with EME Change-Id: I853719d74ee04a1bbc0e7d4768d17aa208147ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646632 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#666456}
-
Nick Burris authored
Per discussion, it makes sense for TextFragmentAnchor matching to be case sensitive to reduce ambiguity. Case insensitivity is likely not useful since the targetText would be generated by a copy of the text (either by a machine or a human copy-paste). Change-Id: I7b52d2adc4f9474fbf77bbfb45814f5ab91036c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644835Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#666455}
-
Harry Cutts authored
See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the feature. The flag should never expire as these are debugging and development tools, so we'd never want to enable them for everybody, but nor would we want to disable them. Bug: 952054 Test: build, then check chrome://flags/#gesture-properties-dbus-service. Change-Id: Ic876d3f9f2fffff084b7c280b4561e013cd31a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589446 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#666454}
-
Joe Mason authored
Make sure the navigation observer is watching the WebContents returned by AddSelectedTabWithURL. GetActiveWebContents can return null when there is no page open. Change-Id: I9de58135e3559df0bfedc673241e44f345cf3cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636598Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b632bc58ed37..9cd21f1bf945 git log b632bc58ed37..9cd21f1bf945 --date=short --no-merges --format='%ad %ae %s' 2019-06-05 enga@chromium.org Implement CreateBufferMapped for non-mappable buffers 2019-06-05 enga@chromium.org Add Create/ReleaseStagingBuffer to DynamicUploader Created with: gclient setdep -r src/third_party/dawn@9cd21f1bf945 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I8078513f9b6e70dd17d21bd64c44766169f097c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645242Reviewed-by:
-
Matthew Mourgos authored
- Fixes the padding and spacing within the folder view. - Fixes the AppListItemView title width to be the same both outside and inside of a folder. Bug: 911745 Change-Id: I1d2d168631312ca9a17da2b4adf317079af9319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639720Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#666451}
-
Yue Zhang authored
This CL enables dropping a tab on another tab to form a group. It is behind the TabGroupsAndroidUiImprovements flag. Bug: 963692 Change-Id: I1cb49a20459972af3c02bdc7c9ebb9480209de29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615606Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#666450}
-
Etienne Bergeron authored
This CL is basically removign dead code. There is an old bug still going on to remove the NATIVE typesetter on MAC. CC=benck@google.com R=tapted@chromium.org Bug: 889152, 454835 Change-Id: If1e2814a22aced9030b914b6c1ab60b2f4bf39eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645143 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#666449}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 960984 Change-Id: I37833956b7c9fd6b82a04a264dcaac096aebdd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638779Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#666448}
-
Jack Lynch authored
Currently, the settings modal does not set aria-hidden on the main devtools content when it is opened. As a result, screen reader users who use the "Form fields" list in NVDA or similar functionality in other tools will be presented with a list of form controls that are visually hidden. This change adds a field to UI.Dialog that determines whether the dialog should mark all of its siblings with aria-hidden when it is shown. Before: https://i.imgur.com/7kV9dgE.jpg After: https://i.imgur.com/AyNJQCQ.jpg Change-Id: I131144a6e551cb2387f7db2fd5a67c5526051f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620777 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#666447}
-
Erik Luo authored
"grid" shorthand and "grid-template-areas" CSS properties may accept an ascii-like structure as a value, representing the grid. This CL wraps the value onto a newline once a new row begins. Screenshot: https://imgur.com/a/c7y3ILm Bug: 943858 Change-Id: I0268a9df2a2582aea60efcbd88f661780d4b0e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531685 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Jason Majors authored
This service will expose a parser for BLE advertising packets so we can safely parse them. The bluez device needs this parser so it can expose the navigator.bluetooth.requestLEScan(options) API. Bug: 962699 Change-Id: Ic205b2c427a703379b5fc619daff998585654aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610873 Commit-Queue: Jason Majors <jmajors@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#666445}
-
Tommy Steimel authored
This CL adds a new ScopedSetIdleState class for testing that sets an overriding idle state in ui/base/idle so that classes depending on ui/base/idle can be more easily tested. Bug: 951560 Change-Id: I4234af0783c7fc053620803b74f0ef6b0fc0ce4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643414Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#666444}
-
Dave Tapuska authored
Due to lifecycle issues with the presentation API it is easier to ensure that the objects it creates are garbage collected and we can copy the lists before iterating on them. BUG=960785 Change-Id: I06fe61d0465fa36e16a3defa7b06a32b220b05c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645813 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#666443}
-
Vladislav Kuzkokov authored
|base::OnceCallback::Run| can only be called on rvalue reference. Bug: None Change-Id: I209de9b09c4b37ed97f592f6a077b9c4d8152821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646013 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Becky Zhou authored
Bug: 940650 Change-Id: Ief5041b3aba808b861901fde6d0696fbc12f53e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637843 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#666441}
-
Hwanseung Lee authored
Currently, device::Gamepad's mapping is character array. it can be more simplify using an enum instead of a character array. Bug: 955809 Change-Id: I90fa1b40a33e01942ebdfda9535ae0ca000210e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600922Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
Mike Dougherty authored
With SlimNavigationManager enabled, the resent post request dialog is presented while the load is still ongoing. On iPad, this displays a loading spinner on the tab UI which interferes with EarlGrey synchronization. Disable synchronization while the dialog is shown if SlimNavigationManager is enabled. Bug: 968296 Change-Id: Ib67693a451dd8170746b4f2329ca4eed82fc254e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645434Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#666439}
-
Ilia Samsonov authored
If disabled tests run, test launcher was flagged to run them explicitly. Since we will remove the MANUAL_ flag, we should track the results. Instead of testing test result tracker procedurally, We use test launcher unit tests for functional testing. Bug: 936248 Change-Id: Iafb2d40a9c650964097cd3f1136d6a5012afda3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641805 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#666438}
-
Erik Chen authored
The method is a duplicate of GetVmSwapBytes Change-Id: I1bfc11484035c8c3452831bee0553a98e07a8cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637746Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
XSetWindowAttributes initialization of attributes in GLSurfaceGLX is not in the same order of the declaration. GCC fails because of that. Bug: 819294 Change-Id: I8a97da980d5961a35a47ae4d0d8d558b85291f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646253Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#666436}
-
