- 01 Oct, 2020 1 commit
-
-
Ben Joyce authored
Reduces time from 14123ms to 4339ms Bug: 989569 Change-Id: I12318738a72d6c17b0cc41de360a550e860392df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438633Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#812456}
-
- 30 Sep, 2020 39 commits
-
-
Ahmed Fakhry authored
This reverts commit af996d67. Reason for revert: Issue 1133923: Many NTP tests fail on linux-chromeos-chrome BUG=1133923 Original change's description: > Reland "Use JS modules for the NTP module" > > This is a reland of 7927c8a6 > > TBR=calamity@chromium.org,steimel@chromium.org > > Original change's description: > > Use JS modules for the NTP module > > > > Uses JS modules for the NTP module and updates > > closure so it can resolve chrome://kaleidoscope. > > > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > > Reviewed-by: calamity <calamity@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811807} > > Change-Id: I348d2116dc851394804866642a24da48d25e3edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812268} TBR=calamity@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I303b81834a65df123e1abe797b02e4b0c4ccb0ec No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442169Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812455}
-
Brian Malcolm authored
This is the UI name of the entity that manages the user's domain, which can either be a domain name (foo.com), or the admin's email address (user@foo.com). This function will be used in future cl's. BUG=chromium:1081272 Change-Id: If0526718a1ae593543711b5a65bff78671123bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432090 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812454}
-
Peter Kasting authored
Bug: 772945 Change-Id: I6ec2c460f5254736c48b35a15638f05320e00c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440909 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#812453}
-
Daniel Hosseinian authored
Bug: 652400 Change-Id: I44b3f9561c3186f9c40d52201ad4ec30b3f9c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439433Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812452}
-
Robert Ogden authored
Uses the PolicyTest browser test base, with minimal Isolated Prerender enabling on top. Bug: 1133815 Change-Id: I63c60a07aea25050cc750f575aa1841686c16a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440224Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#812451}
-
Fabrice de Gans-Riberi authored
Bug: 1073821 Change-Id: Ib1659d8bde4d020d768ecbe6eb11bab81b5db662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429610Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812450}
-
Scott Little authored
This histogram is still in use, so this CL extends its expiration. Fixed: 1089164 Change-Id: I23a0a4ec11941360dbb2948415106b15b7ba9fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439426 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812449}
-
Willie Koomson authored
This change adds support for SetVmId() call to ConciergeClient, which is used by ArcVmClientAdapter to set the correct owner id for a mini-ARCVM instance. BUG=b:144542975 TEST=Use function from ArcVmClientAdapter, and check that vm_concierge receives the call and responds successfully. Cq-Depend: chromium:2354353 Change-Id: I098b3fa2c1e829b693906a234aae635fa0b3ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354493Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#812448}
-
Ian Kilpatrick authored
Previously when we had a specified main-size, and we were a table, we considered this to be the min-size instead. This was incorrect. Instead we should have been applying the min content-size as the floor for tables, and leaving the main size alone. Bug: 1128941 Change-Id: I7310b5d31990ff77a028837f742b3a0eba697318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438775 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812447}
-
Mike Wasserman authored
Notify the renderer of user activation when the permission is granted: Override UserMadePermissionDecision to call NotifyUserActivation. Add RenderFrameHost[Impl] plumbing for the LocalFrame signal. Add UserActivationNotificationType plumbing for LocalFrame interface. Add a basic browser test. Bug: 1083357 Test: Scripts can requestFullscreen({screen: (await getScreens()[0])}) Change-Id: Ia72b7f003b7807ed13de6e76612d107f8050fc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426884 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812446}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3773c401fe1a..f38f54f2f1a3 2020-09-30 kimstephanie@google.com Add optional enforce_fetch kwarg to fetch and refresh git cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I4a41c9fc8a96538834c52553e675c5c405a14413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812445}
-
Joel Fernandes authored
Currently, if board does not pass a minimum boost over command line, then it is set to 0. This can lead to poor performance for boards that do not configure a boost. Set it to 20%. On Android, it is generally set to this value. TEST=power_VideoCall.fast Change-Id: I65d3682caff38f87d4153f180ae4deb7db5cd339 Signed-off-by:
Joel Fernandes <joelaf@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439029Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#812444}
-
Kartik Hegde authored
Introduce the fake network context class, used by unit tests, to avoid duplication across multiple routines. BUG=chromium:956783 TEST=none Change-Id: I536a208c32a6454c832847325eb3d933d357b40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434092Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1d1b8b30e95..b3859a3cba60 2020-09-30 cclao@google.com Vulkan: disable glFlush deferral optimization for QualComm GPUs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: If57e83a8c381ecffb87bfae6c33ebda1ec128dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441235Reviewed-by:
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None. Change-Id: I9c1145a4589aa7bbf761c51585055cdb363313d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380931Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#812441}
-
tby authored
This adds two metrics: - a status/error metric we can use to track query QPS and errors - a query latency metric Bug: 1034842 Change-Id: I4c426873a8685ce605df17b6a31d6ad17ef5c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436970Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#812440}
-
Bettina Dea authored
Create experiment and feature flags for Enhanced Protection promo on NTP on Android. Second part of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2430263 Bug: 1130739 Change-Id: I4a01699c7a70b2fe99f69e7df950cdd9d0b66046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423165Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
-
Matthew Denton authored
Msan doesn't seem to hook syscall(__NR_process_vm_readv, ...) to unpoison the newly read bytes, so just unpoison it manually. Bug: 1117351 Change-Id: I0b1d5258402c2deb5d148e4f41fcdff1f4f05bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436753Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812438}
-
Clark DuVall authored
Due to b/169196314, Android won't use the split's class loader to load services even if the service is defined in the split's manifest. This check makes sure all services are defined in the base module's dex if isolatedSplits is true. Bug: 1126301 Change-Id: I108e67ba48ec95ee03c514bf028980845c3c6ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436421 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#812437}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ib11f9a77c8118b7afba482bf9b80cab8d1b1fb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438945 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812436}
-
Fabrice de Gans-Riberi authored
Bug: 1104411 Change-Id: I3752f13c65f326a56ae40fc4823aca0bc7fa1537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425119 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812435}
-
Sky Malice authored
Processor class has not been public since https://crrev.com/2723003010, and callers should not need to strongly type it. Updating documentation to match what most existing callers are already doing. Using the variable name mProcessor because it currently the most popular. grep -r "Features.JUnitProcessor();" chrome/* | cut -d: -f2 | \ cut -d= -f1 | sort | uniq -c "mFeaturesProcessor" at 10 uses "mFeaturesProcessorRule" at 25 uses "mProcessor" at 46 uses Change-Id: Ic2b1c4a44898f9366cff7a0072659c8e2f70d653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441660Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#812434}
-
Thomas Lukaszewicz authored
Adds test cases for Tab Search bubble. Updates ShowUI test to anchor to the Tab Search button. Bug: 1099917 Change-Id: Id1440d383e73ed3bb6e983fa0b62db1fa8c933da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436689 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#812433}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I904540644c257307be39c965f1d775646df30b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438805 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812432}
-
Josiah K authored
Change-Id: Ie6b5eadc25d2ddda95140d6c2730e663a33e34c3 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439699 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This is a reland of cb2f5900 Original change's description: > [Instant Start] Avoid pre-native GURL usage > > Remove native dependency of > ReturnToChromeExperimentsUtil.shouldShowStartSurfaceAsTheHomePage() > and PseudoTab.readAllPseudoTabsFromStateFile() so that they can be > called without leading to native initialization. > > Benchmarking results using http://crrev.com/c/2373287: > > 100 samples on Nexus 5X > Median Diff with control p-value > FirstDrawCompletedTime 414.0ms -29.0ms (-7.00%) 0.000000 > SingleTabTitleAvailableTime 287.0ms -31.5ms (-10.98%) 0.000000 > FeedStreamCreatedTime 836.5ms -39.5ms (-4.72%) 0.000030 > FeedContentFirstLoadedTime 1898.5ms -0.5ms (-0.03%) 0.534189 > FeedsLoadingPlaceholderShown 234.0ms -2.0ms (-0.85%) 0.629761 > > 100 samples on Pixel 2 XL > Median Diff with control p-value > FirstDrawCompletedTime 176.0ms -18.0ms (-10.23%) 0.000000 > SingleTabTitleAvailableTime 131.0ms -14.0ms (-10.69%) 0.000000 > FeedStreamCreatedTime 424.0ms -31.0ms (-7.31%) 0.000180 > FeedContentFirstLoadedTime 1137.0ms -18.5ms (-1.63%) 0.075061 > FeedsLoadingPlaceholderShown 107.0ms -1.0ms (-0.93%) 0.718766 > > 100 samples on Pixel 3 XL > Median Diff with control p-value > FirstDrawCompletedTime 155.0ms -13.5ms (-8.71%) 0.000000 > SingleTabTitleAvailableTime 117.0ms -13.0ms (-11.11%) 0.000000 > FeedStreamCreatedTime 356.0ms -35.5ms (-9.97%) 0.000001 > FeedsLoadingPlaceholderShown 94.5ms -2.0ms (-2.12%) 0.007312 > FeedContentFirstLoadedTime 924.0ms -6.5ms (-0.70%) 0.034100 > > Bug: 1041865 > Change-Id: I640aaeb6f2dae64b9152fd94d0cd354a487f5bf5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372900 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809226} Bug: 1041865, 1131139 Change-Id: Ia56003e714389baed68c2af9df37f22b3cef32e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427874Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95c77a92cd84..af8e9f1e8115 2020-09-30 jalyn@microsoft.com Settings: Don't allow shortcut headers to overlap content 2020-09-30 vidorteg@microsoft.com Changing 'request blocking' to 'network request blocking' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130946 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic369df5f0806df5d713f142ac31339c3acdf89a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441232Reviewed-by:
-
Brandon Wylie authored
This reverts commit 44803ec9. Reason for revert: Fixed already Original change's description: > Revert "Migrate remaining usages of ChromeActivityTestRule" > > This reverts commit fd165f29. > > Reason for revert: Failing build on ToT: > new ChromeActivityTestRule<>(ChromeActivity.class); > ^ > reason: cannot infer type-variable(s) T > > Original change's description: > > Migrate remaining usages of ChromeActivityTestRule > > > > Bug: 989569 > > Change-Id: If9f2bf207142253262bca092ca7dad6975893322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811949} > > TBR=mthiesse@chromium.org,agrieve@chromium.org > > Change-Id: I5970dcbad4685e2ae423b0bf5bdcd8beb7b00396 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 989569 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441672 > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812334} TBR=mthiesse@chromium.org,agrieve@chromium.org,wylieb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 989569 Change-Id: Ifc9054d915cacdef40394661472aff4653b123a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441673Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Bluetooth operations are invoked on different threads from the ones which bound the SharedRemotes, so passing raw pointers could potentially cause deadlocks. This CL converts to using SharedRemotes directly to fix this issue. Bug: 1130069 Change-Id: I8a17b10f74c3d406138895c31ab5ff74dc12b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440981Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812427}
-
Elly Fong-Jones authored
This change: 1) Makes the behavior change described in this CL's title 2) Adds unit tests to cover that behavior 3) Makes RenderViewContextMenuMac constructable for testing purposes Bug: 853814 Change-Id: I0426f73a9dd828a96905bea8873010ad6e5025ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441657Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812426}
-
Joon Ahn authored
https://screenshot.googleplex.com/APf7nYKZJynGLbr Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifde623fa4bc35c934b2d053629abcfde722eb4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439435 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#812425}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Start with a mojo definition for the printing::PrinterSemanticCapsAndDefaults::Paper structure, which is required for the larger query. Bug: 809738 Change-Id: Id7d52f131f8587b9edc50c8e1c4f8b6718998965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387409Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Brian Cui authored
This CL disables some tests in order to land the following DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2436646 The test failures are caused by a string change in the Console counter title property. Example: "2 errors, 1 warning" will change to "Open Console to view 2 errors, 1 warning" Bug: 1133060 Change-Id: I9a08caca60dc3283ccf50e4669cf83803ee4ab0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441677Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brian Cui <brcui@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812423}
-
Esmael El-Moslimany authored
Bug: 1131871 Change-Id: Ic88e6fba9226ed273aa028ef8a489c0f6e8e583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441008 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812422}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Id8b7299aa6fa0226ec16fc43d545ceb1e150a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437173Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812421}
-
Xi Han authored
The original CL got reverted because crbug.com/1132734: all the open tab heads are missing on tablet. The issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2392403. Original change's description: In this CL, we remove the check of stack tab switcher in TabUiFeatureUtilities#supportInstantStart(). Thus instant start can be enabled in MVP++. These changes can be verified by: - StartSurfaceTest#testShow_SingleAsHomepage_V2__Instant*. The following changes are made to support stack tab switcher in instant start: 1) Defer the creation of TabList in StackLayoutBase. It allows the StackLayoutBase/StartSurfaceStackLayout to be created pre-native. 2) Add pending observer list in TabModelFilterProvider. Any observer which is added before the TabModelFilterProvider is initialized, will be cached and notified when the initialization is completed. 3) StartSurfaceLayout and StackLayoutBase will create its SceneLayer if hasn't yet before calling updateSceneLayer(). Bug: 1116449, 1076449 Change-Id: Id8bc9153629a575ac6ef3728733d7945cc43b54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436618Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812420}
-
Russell Davis authored
Bug: 1131780 Change-Id: I3556016852284a7c7c2c64c22787747dfb420ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438634Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812419}
-
Ahmed Mehfooz authored
This CL changes the holding space bubble to use an AnchorRect instead of an AnchorView. This is to position it in the corner of the screen in a similar way to the system and media tray. Bug: 1131254 Change-Id: Idde8ff8071b1c01fcb0ba282957ece19c1a50c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439025 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#812418}
-
Mike Wittman authored
Updates the ThreadProfiler configuration to consider a build to be a Chrome release if it's official and Chrome branded. The existing code only considered the Chrome branded state which is overly lenient. For what its worth breakpad uses the same conditions for whether it should be enabled. This changes behavior of edge cases as follows: Unofficial Chrome branded builds are now considered to be development/CQ builds and as such the profiler is always enabled for them. Official Chrome branded builds with unknown channel are no longer treated as development/CQ builds, so the profiler is disabled for them rather than always enabled. Bug: 1129939 Change-Id: I52b2120ef98734278ffd211809463c2ded3d3bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432386 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812417}
-
